81881 2012-03-22 01:19:57 -0700 Use stereo AudioBuffer instead of RealtimeAnalyserNode in the layout test of stereo2mono-down-mixing 2012-03-22 10:42:15 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 xingnan.wang webkit-unassigned crogers webkit.review.bot oldest_to_newest 585056 0 xingnan.wang 2012-03-22 01:19:57 -0700 It`s better to use stereo AudioBuffer instead of RealtimeAnalyserNode in the layout test of stereo2mono-down-mixing. 585074 1 133207 xingnan.wang 2012-03-22 02:04:59 -0700 Created attachment 133207 Patch 585075 2 xingnan.wang 2012-03-22 02:05:35 -0700 (In reply to comment #1) > Created an attachment (id=133207) [details] > Patch Upload the patch. 585453 3 crogers 2012-03-22 10:35:44 -0700 Thanks for cleaning this up! 585460 4 133207 webkit.review.bot 2012-03-22 10:42:11 -0700 Comment on attachment 133207 Patch Clearing flags on attachment: 133207 Committed r111728: <http://trac.webkit.org/changeset/111728> 585461 5 webkit.review.bot 2012-03-22 10:42:15 -0700 All reviewed patches have been landed. Closing bug. 133207 2012-03-22 02:04:59 -0700 2012-03-22 10:42:11 -0700 Patch bug-81881-20120322170815.patch text/plain 2656 xingnan.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjZmM2IwOTljMzcwOWQyNDU4Mjgw Y2Q3YWIyNDE3OWEwM2RiNzI3NS4uODNiY2ExNDExNTE4NDQ0ZmUyMGI0ODUyYTA0MTc4MTZkYzJj YjdmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAzLTIyICBYaW5nbmFuIFdhbmcgIDx4 aW5nbmFuLndhbmdAaW50ZWwuY29tPgorCisgICAgICAgIFVzZSBzdGVyZW8gQXVkaW9CdWZmZXIg aW5zdGVhZCBvZiBSZWFsdGltZUFuYWx5c2VyTm9kZSBpbiB0aGUgbGF5b3V0IHRlc3Qgb2Ygc3Rl cmVvMm1vbm8tZG93bi1taXhpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgxODgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3ZWJhdWRpby9zdGVyZW8ybW9uby1kb3duLW1peGluZy5odG1sOgorCiAy MDEyLTAzLTIxICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29ARnJlZUJTRC5vcmc+CiAK ICAgICAgICAgW0VGTF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy93ZWJhdWRpby9zdGVyZW8ybW9uby1kb3duLW1peGluZy5odG1sIGIvTGF5b3V0VGVzdHMv d2ViYXVkaW8vc3RlcmVvMm1vbm8tZG93bi1taXhpbmcuaHRtbAppbmRleCA1NmIyMmQwMDU5MmY2 ODI0MGY3YTRkZjcwYzY0MDFjNWEyNmEwNjFiLi4zYzcyNWU3Nzc3MThlMTMwMTQwMWUzYzA5ZjBl OWQwMTUyMjgwNzY0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9zdGVyZW8ybW9u by1kb3duLW1peGluZy5odG1sCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL3N0ZXJlbzJtb25v LWRvd24tbWl4aW5nLmh0bWwKQEAgLTE1LDIxICsxNSwyMSBAQCBkZXNjcmlwdGlvbigiVGhpcyB0 ZXN0IHZlcmlmaWVzIHdoZXRoZXIgZG93biBtaXhpbmcgZnJvbSBzdGVyZW8gdG8gbW9ubyB3aWxs IGNhdQogCiB2YXIgc2FtcGxlUmF0ZSA9IDQ0MTAwLjA7CiB2YXIgcmVuZGVyTGVuZ3RoU2Vjb25k cyA9IDAuMTsKLXZhciBmZnRTaXplID0gMzI7CiAKIHZhciBjb250ZXh0OwogdmFyIHRvbmVCdWZm ZXI7CiB2YXIgYnVmZmVyU291cmNlOwotdmFyIGFuYWx5c2VyOwogCiBmdW5jdGlvbiBjcmVhdGVE YXRhQnVmZmVyKGNvbnRleHQsIGxlbmd0aEluU2Vjb25kcykgewotICAgIHZhciBhdWRpb0J1ZmZl ciA9IGNvbnRleHQuY3JlYXRlQnVmZmVyKDEsIGxlbmd0aEluU2Vjb25kcyAqIHNhbXBsZVJhdGUs IHNhbXBsZVJhdGUpOworICAgIHZhciBhdWRpb0J1ZmZlciA9IGNvbnRleHQuY3JlYXRlQnVmZmVy KDIsIGxlbmd0aEluU2Vjb25kcyAqIHNhbXBsZVJhdGUsIHNhbXBsZVJhdGUpOwogCiAgICAgdmFy IG4gPSBhdWRpb0J1ZmZlci5sZW5ndGg7Ci0gICAgdmFyIGRhdGEgPSBhdWRpb0J1ZmZlci5nZXRD aGFubmVsRGF0YSgwKTsKKyAgICB2YXIgZGF0YTAgPSBhdWRpb0J1ZmZlci5nZXRDaGFubmVsRGF0 YSgwKTsKKyAgICB2YXIgZGF0YTEgPSBhdWRpb0J1ZmZlci5nZXRDaGFubmVsRGF0YSgxKTsKIAog ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbjsgKytpKSB7Ci0gICAgICAgIGRhdGFbaV0gPSAxLjA7 CisgICAgICAgIGRhdGEwW2ldID0gMS4wOworICAgICAgICBkYXRhMVtpXSA9IDEuMDsKICAgICB9 CiAKICAgICByZXR1cm4gYXVkaW9CdWZmZXI7CkBAIC00OSwyMCArNDksMTUgQEAgZnVuY3Rpb24g cnVuVGVzdCgpIHsKIAogICAgIHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIAotICAgIC8v IENyZWF0ZSBvZmZsaW5lIGF1ZGlvIGNvbnRleHQuCisgICAgLy8gQ3JlYXRlIG9mZmxpbmUgYXVk aW8gY29udGV4dCwgdGhlIGRlc3RpbmF0aW9uIGlzIG1vbm8uCiAgICAgY29udGV4dCA9IG5ldyB3 ZWJraXRBdWRpb0NvbnRleHQoMSwgc2FtcGxlUmF0ZSAqIHJlbmRlckxlbmd0aFNlY29uZHMsIHNh bXBsZVJhdGUpOwotICAgIC8vIEV4cGxpY2l0bHkgY3JlYXRlIGEgbW9ubyBBdWRpb0NvbnRleHQg c28gdGhhdCB0aGUgZGVzdGluYXRpb24gaXMgbW9uby4KKyAgICAvLyBDcmVhdGUgYSBzdGVyZW8g QXVkaW9CdWZmZXIuCiAgICAgdG9uZUJ1ZmZlciA9IGNyZWF0ZURhdGFCdWZmZXIoY29udGV4dCwg cmVuZGVyTGVuZ3RoU2Vjb25kcyk7CiAKICAgICBidWZmZXJTb3VyY2UgPSBjb250ZXh0LmNyZWF0 ZUJ1ZmZlclNvdXJjZSgpOwogICAgIGJ1ZmZlclNvdXJjZS5idWZmZXIgPSB0b25lQnVmZmVyOwog Ci0gICAgLy8gV2UgY3JlYXRlIGFuIGFuYWx5c2VyIGhlcmUsIGJlY2F1c2UgaXQgaGFzIGEgaGFy ZC1jb2RlZCBzdGVyZW8gb3V0cHV0LgotICAgIGFuYWx5c2VyID0gY29udGV4dC5jcmVhdGVBbmFs eXNlcigpOwotICAgIGFuYWx5c2VyLmZmdFNpemUgPSBmZnRTaXplOwotCi0gICAgYnVmZmVyU291 cmNlLmNvbm5lY3QoYW5hbHlzZXIpOwotICAgIGFuYWx5c2VyLmNvbm5lY3QoY29udGV4dC5kZXN0 aW5hdGlvbik7CisgICAgYnVmZmVyU291cmNlLmNvbm5lY3QoY29udGV4dC5kZXN0aW5hdGlvbik7 CiAKICAgICBidWZmZXJTb3VyY2Uubm90ZU9uKDApOwogCg==