81866 2012-03-21 20:35:31 -0700 Expand RenderTextControlSingleLine::controlClipRect() to contain contentRect(). 2012-03-22 01:06:58 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80479 1 tkent tkent morrita shinyak webkit.review.bot oldest_to_newest 584926 0 tkent 2012-03-21 20:35:31 -0700 Clip by contentRect() instead of container's frameRect() in RenderTextControlSingleLine 584981 1 133189 tkent 2012-03-21 22:20:55 -0700 Created attachment 133189 Patch 584984 2 133189 tkent 2012-03-21 22:24:17 -0700 Comment on attachment 133189 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133189&action=review > Source/WebCore/ChangeLog:28 > + ┗ ShadowRoot > + ┗ container element > + ┌─────────────┐<input> box > + │ ┌──────────┐ │ > + │ │container box │ │ > + │ └──────────┘ │ > + └─────────────┘ Broken by Bug 75394. Please look at https://bugs.webkit.org/attachment.cgi?id=133189 instead. 585010 3 133189 morrita 2012-03-21 23:52:13 -0700 Comment on attachment 133189 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133189&action=review Do we really need to handle searchbox specially? can be just compute union of content element and clip? > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:375 > + RenderBox* containerBox = containerElement()->renderBox(); It looks we can expect containerbox being not null according to the original code? 585013 4 tkent 2012-03-21 23:56:00 -0700 (In reply to comment #3) > Do we really need to handle searchbox specially? > can be just compute union of content element and clip? Oh, union is a good idea. 585016 5 133197 tkent 2012-03-22 00:13:57 -0700 Created attachment 133197 Patch 2 585050 6 133197 webkit.review.bot 2012-03-22 01:06:54 -0700 Comment on attachment 133197 Patch 2 Clearing flags on attachment: 133197 Committed r111660: <http://trac.webkit.org/changeset/111660> 585051 7 webkit.review.bot 2012-03-22 01:06:58 -0700 All reviewed patches have been landed. Closing bug. 133189 2012-03-21 22:20:55 -0700 2012-03-22 00:13:52 -0700 Patch bug-81866-20120322142054.patch text/plain 3664 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IxN2U4ZjMzMWJkNDI4 ZGRmZjE5ZjUxM2ZkOTEyMzQ3NDI1ZGEwYy4uOTM5YTY2NzQ4NGY0M2Q5NTk2NTI3MjgwY2I2ZDlm OWQ5OTQ1MzFiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDUyIEBACisyMDEyLTAzLTIxICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBDbGlwIGJ5IGNvbnRlbnRS ZWN0KCkgaW5zdGVhZCBvZiBjb250YWluZXIncyBmcmFtZVJlY3QoKSBpbiBSZW5kZXJUZXh0Q29u dHJvbFNpbmdsZUxpbmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MTg2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENsaXAgY2hpbGQgcmVuZGVyaW5nIHdpdGggUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVM aW5lOjpjb250ZW50UmVjdCgpCisgICAgICAgIGluc3RlYWQgb2YgdGhlIGNvbnRhaW5lcidzIGZy YW1lUmVjdCgpLiBUaGVzZSByZWN0YW5nbGVzIGFyZSB1c3VhbGx5CisgICAgICAgIGVxdWl2YWxl bnQgYXQgdGhpcyBtb21lbnQgYmVjYXVzZSB0aGUgY29udGFpbmVyIGVsZW1lbnQgb2NjdXBpZXMg dGhlCisgICAgICAgIHdob2xlIGNvbnRlbnQgYm94IG9mIHRoZSBSZW5kZXJUZXh0Q29udHJvbFNp bmdsZUxpbmUuCisgICAgICAgIEFuIGV4Y2VwdGlvbiBpcyBhIHNlYXJjaCBmaWVsZC4gdGhlIGNv bnRhaW5lciBoZWlnaHQgY2FuIGJlIGxhcmdlciB0aGFuCisgICAgICAgIHRoZSBjb250ZW50IGhl aWdodC4gV2UgdXNlIGEgcmVjdGFuZ2xlIG9mIHdoaWNoIHRoZSBoZWlnaHQgaXMgdGhlCisgICAg ICAgIGNvbnRhaW5lciBoZWlnaHQgYW5kIHRoZSB3aWR0aCBpcyB0aGUgY29udGVudCB3aWR0aCBp biB0aGlzIGNhc2UuCisKKyAgICAgICAgV2UgbmVlZCB0aGlzIGNoYW5nZSBiZWNhdXNlIHRoZSBj dXJyZW50IHNoYWRvdyBlbGVtZW50cyBvZiBhIHRleHQgZmllbGQKKyAgICAgICAgY2FuIGJlIHdy YXBwZWQgYnkgYW5vdGhlciBzaGFkb3cgdHJlZS4gZS5nLgorCisgICAgICAgIEEgY3VycmVudCBz aXR1YXRpb246CisKKyAgICAgICAgPGlucHV0PgorICAgICAgICAgIOKUlyBTaGFkb3dSb290Cisg ICAgICAgICAgICAg4pSXIGNvbnRhaW5lciBlbGVtZW50CisgICAgICAgIOKUjOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUkDxpbnB1dD4gYm94CisgICAgICAgIOKUgiDi lIzilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilJAg4pSCCisgICAgICAgIOKUgiDilIJj b250YWluZXIgYm94ICAgICAgIOKUgiDilIIKKyAgICAgICAg4pSCIOKUlOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUmCDilIIKKyAgICAgICAg4pSU4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSYCisKKyAgICAgICAgV3JhcHBlZCBieSBhbm90aGVyIFNoYWRv d1Jvb3Q6CisKKyAgICAgICAgPGlucHV0PgorICAgICAgICAgIOKUlyBOZXcgU2hhZG93Um9vdAor ICAgICAgICAgICAgIOKUoyA8c2hhZG93PiByZXByZXNlbnRzIHRoZSBleGlzdGluZyBzaGFkb3cg dHJlZQorICAgICAgICAgICAgIOKUgyAg4pSXIGNvbnRhaW5lciBlbGVtZW50CisgICAgICAgICAg ICAg4pSXIEQ6IGFuIGFkZGl0aW9uYWwgZGVjb3JhdGlvbiBlbGVtZW50CisgICAgICAgIOKUjOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUkDxpbnB1dD4gYm94CisgICAg ICAgIOKUgiDilIzilIDilIDilIDilIDilIDilIDilIDilKzilIDilIDilJAg4pSCCisgICAgICAg IOKUgiDilIJjb250YWluZXIgYm94IOKUgiBEICDilIIg4pSCCisgICAgICAgIOKUgiDilJTilIDi lIDilIDilIDilIDilIDilIDilLTilIDilIDilJgg4pSCCisgICAgICAgIOKUlOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUmAorICAgICAgICBJbiB0aGlzIGNhc2UsIGlm IHdlIGNsaXAgY2hpbGQgcmVuZGVyZXJzIGJ5IGNvbnRhaW5lciBib3gsIEQgaXMgbm90CisgICAg ICAgIGRyYXduLiBXZSBzaG91bGQgYXBwbHkgY29udGVudCBib3ggb2YgdGhlIDxpbnB1dD4uCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHdvbid0IG1ha2UgYW55IGJlaGF2aW9yIGNoYW5n ZSBmb3Igbm93LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xl TGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6 OmNvbnRyb2xDbGlwUmVjdCk6CisKIDIwMTItMDMtMjEgIERhbmEgSmFuc2VucyAgPGRhbmFrakBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBFYXJseSBvdXQgaW4gYSBuZXcgcHJl cGFyZVRvRHJhdygpIHN0ZXAgaWYgY2hlY2tlcmJvYXJkaW5nIGFuIGFjY2VsZXJhdGVkIGFuaW1h dGlvbiBpbiBvcmRlciB0byBza2lwIHRoZSBmcmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcAppbmRleCBlN2Vj ZWRmYTY0MjRmMjAwNjQ1MWQ3MGY5NzMyMWE3NDkwZDc4OTgyLi41NjMyNzM3MTExZjBlMTMxMGQ0 NDU1ODdhNDhlMGViOTA2YzljMGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcApAQCAtMzcwLDcgKzM3MCwx NCBAQCBib29sIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6aGFzQ29udHJvbENsaXAoKSBj b25zdAogTGF5b3V0UmVjdCBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6OmNvbnRyb2xDbGlw UmVjdChjb25zdCBMYXlvdXRQb2ludCYgYWRkaXRpb25hbE9mZnNldCkgY29uc3QKIHsKICAgICBB U1NFUlQoaGFzQ29udHJvbENsaXAoKSk7Ci0gICAgTGF5b3V0UmVjdCBjbGlwUmVjdCA9IExheW91 dFJlY3QoY29udGFpbmVyRWxlbWVudCgpLT5yZW5kZXJCb3goKS0+ZnJhbWVSZWN0KCkpOworICAg IExheW91dFJlY3QgY2xpcFJlY3QgPSBjb250ZW50Qm94UmVjdCgpOworICAgIGlmIChpbnB1dEVs ZW1lbnQoKS0+aXNTZWFyY2hGaWVsZCgpKSB7CisgICAgICAgIFJlbmRlckJveCogY29udGFpbmVy Qm94ID0gY29udGFpbmVyRWxlbWVudCgpLT5yZW5kZXJCb3goKTsKKyAgICAgICAgaWYgKGNvbnRh aW5lckJveCAmJiBjbGlwUmVjdC5oZWlnaHQoKSA8IGNvbnRhaW5lckJveC0+aGVpZ2h0KCkpIHsK KyAgICAgICAgICAgIGNsaXBSZWN0LnNldFkoY29udGFpbmVyQm94LT55KCkpOworICAgICAgICAg ICAgY2xpcFJlY3Quc2V0SGVpZ2h0KGNvbnRhaW5lckJveC0+aGVpZ2h0KCkpOworICAgICAgICB9 CisgICAgfQogICAgIGNsaXBSZWN0Lm1vdmVCeShhZGRpdGlvbmFsT2Zmc2V0KTsKICAgICByZXR1 cm4gY2xpcFJlY3Q7CiB9Cg== 133197 2012-03-22 00:13:57 -0700 2012-03-22 01:06:54 -0700 Patch 2 bug-81866-20120322161355.patch text/plain 3258 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IxN2U4ZjMzMWJkNDI4 ZGRmZjE5ZjUxM2ZkOTEyMzQ3NDI1ZGEwYy4uZDQyMTNhYjBiODllMDZhYjM1YTA1NTg1ZWRjMGI1 YTM5MjRmYmVmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDUwIEBACisyMDEyLTAzLTIxICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBFeHBhbmQgUmVuZGVyVGV4 dENvbnRyb2xTaW5nbGVMaW5lOjpjb250cm9sQ2xpcFJlY3QoKSB0byBjb250YWluIGNvbnRlbnRS ZWN0KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MTg2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IG5lZWQgdG8gZXhwYW5kIHRoZSBjb250cm9sQ2xpcFJlY3QgYmVjYXVzZSB0aGUgZXhpc3Rpbmcg c2hhZG93CisgICAgICAgIHRyZWUgb2YgYSB0ZXh0IGZpZWxkIGNhbiBiZSB3cmFwcGVkIGJ5IGFu b3RoZXIgc2hhZG93IHRyZWUuIGUuZy4KKworICAgICAgICBBIGN1cnJlbnQgc2l0dWF0aW9uOgor CisgICAgICAgIDxpbnB1dD4KKyAgICAgICAgICDilJcgU2hhZG93Um9vdAorICAgICAgICAgICAg IOKUlyBjb250YWluZXIgZWxlbWVudAorICAgICAgICDilIzilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilJA8aW5wdXQ+J3MgYm9yZGVyIGJveAorICAgICAgICDilILilIzilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilJDilIIKKyAgICAgICAg4pSC4pSCY29udGFpbmVy IGJveCAgICAgICDilILilIIKKyAgICAgICAg4pSC4pSU4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSY4pSCCisgICAgICAgIOKUlOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUmAorCisgICAgICAgIFdyYXBwZWQgYnkgYW5vdGhlciBTaGFkb3dSb290OgorCisgICAg ICAgIDxpbnB1dD4KKyAgICAgICAgICDilJcgTmV3IFNoYWRvd1Jvb3QKKyAgICAgICAgICAgICDi lKMgPHNoYWRvdz4gcmVwcmVzZW50cyB0aGUgZXhpc3Rpbmcgc2hhZG93IHRyZWUKKyAgICAgICAg ICAgICDilIMgIOKUlyBjb250YWluZXIgZWxlbWVudAorICAgICAgICAgICAgIOKUlyBEOiBhbiBh ZGRpdGlvbmFsIGRlY29yYXRpb24gZWxlbWVudAorICAgICAgICDilIzilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilJA8aW5wdXQ+J3MgYm9yZGVyIGJveAorICAgICAgICDilILi lIzilIDilIDilIDilIDilIDilIDilIDilKzilIDilIDilJDilIIKKyAgICAgICAg4pSC4pSCY29u dGFpbmVyIGJveCDilIIgRCAg4pSC4pSCCisgICAgICAgIOKUguKUlOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUtOKUgOKUgOKUmOKUggorICAgICAgICDilJTilIDilIDilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilJgKKyAgICAgICAgSW4gdGhpcyBjYXNlLCBpZiB3ZSBjbGlwIGNoaWxkIHJl bmRlcmVycyBieSBjb250YWluZXIgYm94LCBEIGlzIG5vdAorICAgICAgICBkcmF3bi4gV2Ugc2hv dWxkIGNsaXAgYnkgdGhlIGNvbnRlbnQgYm94IG9mIHRoZSA8aW5wdXQ+LgorCisgICAgICAgIEEg c2VhcmNoIGZpZWxkIGhhcyBhbiBleGNlcHRpb25hbCBiZWhhdmlvci4gSXQgY2FuIGhhdmUgdGhl IGNvbnRhaW5lcgorICAgICAgICBib3ggb2Ygd2hpY2ggaGVpZ2h0IGlzIHRhbGxlciB0aGFuIHRo ZSBjb250ZW50IGJveCBoZWlnaHQuIFRoZQorICAgICAgICBjb250cm9sQ2xpcFJlY3Qgc2hvdWxk IGNvbnRhaW4gYm90aCBvZiB0aGUgY29udGFpbmVyIGJveCBhbmQgdGhlIGNvbnRlbnQKKyAgICAg ICAgYm94IGluIHRoaXMgY2FzZS4gSW4gb3RoZXIgY2FzZXMsIHRoZSBjb250YWluZXIgYm94IGlz IGVxdWl2YWxlbnQgdG8gdGhlCisgICAgICAgIGNvbnRlbnQgYm94LiBTbyB0aGUgY29kZSBhbHdh eXMgdW5pdGVzIHRoZW0uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHdvbid0IG1ha2Ug YW55IGJlaGF2aW9yIGNoYW5nZSBmb3Igbm93LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clRleHRDb250cm9sU2luZ2xlTGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0 Q29udHJvbFNpbmdsZUxpbmU6OmNvbnRyb2xDbGlwUmVjdCk6CisKIDIwMTItMDMtMjEgIERhbmEg SmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBFYXJs eSBvdXQgaW4gYSBuZXcgcHJlcGFyZVRvRHJhdygpIHN0ZXAgaWYgY2hlY2tlcmJvYXJkaW5nIGFu IGFjY2VsZXJhdGVkIGFuaW1hdGlvbiBpbiBvcmRlciB0byBza2lwIHRoZSBmcmFtZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGlu ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVM aW5lLmNwcAppbmRleCBlN2VjZWRmYTY0MjRmMjAwNjQ1MWQ3MGY5NzMyMWE3NDkwZDc4OTgyLi4z ZmVjZWRhZDIzMzliZDI5ZWE1MDBjMDQxNTFmZDFlZDY2NWI4ZDBkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNw cApAQCAtMzcwLDcgKzM3MCw3IEBAIGJvb2wgUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpo YXNDb250cm9sQ2xpcCgpIGNvbnN0CiBMYXlvdXRSZWN0IFJlbmRlclRleHRDb250cm9sU2luZ2xl TGluZTo6Y29udHJvbENsaXBSZWN0KGNvbnN0IExheW91dFBvaW50JiBhZGRpdGlvbmFsT2Zmc2V0 KSBjb25zdAogewogICAgIEFTU0VSVChoYXNDb250cm9sQ2xpcCgpKTsKLSAgICBMYXlvdXRSZWN0 IGNsaXBSZWN0ID0gTGF5b3V0UmVjdChjb250YWluZXJFbGVtZW50KCktPnJlbmRlckJveCgpLT5m cmFtZVJlY3QoKSk7CisgICAgTGF5b3V0UmVjdCBjbGlwUmVjdCA9IHVuaW9uUmVjdChjb250ZW50 Qm94UmVjdCgpLCBjb250YWluZXJFbGVtZW50KCktPnJlbmRlckJveCgpLT5mcmFtZVJlY3QoKSk7 CiAgICAgY2xpcFJlY3QubW92ZUJ5KGFkZGl0aW9uYWxPZmZzZXQpOwogICAgIHJldHVybiBjbGlw UmVjdDsKIH0K