81860 2012-03-21 18:21:44 -0700 [Chromium] Should check m_socket in SocketStreamHandleInternal::close() 2012-03-22 00:26:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi tkent toyoshim webkit.review.bot yutak oldest_to_newest 584858 0 bashi 2012-03-21 18:21:44 -0700 See the chromium bug report: http://crbug.com/118846 This problem not always occurs (maybe depends on server implementation). 584863 1 133161 bashi 2012-03-21 18:26:10 -0700 Created attachment 133161 Patch 584871 2 bashi 2012-03-21 18:29:44 -0700 (In reply to comment #1) > Created an attachment (id=133161) [details] > Patch This patch doesn't include test because user interaction (closing alert popup) is needed to reproduce the problem. 584914 3 tkent 2012-03-21 20:06:41 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=133161) [details] [details] > > Patch > > This patch doesn't include test because user interaction (closing alert popup) is needed to reproduce the problem. Would you add reasons why m_socket can be 0 and why alert() affects to ChangeLog? 584995 4 133192 bashi 2012-03-21 23:14:49 -0700 Created attachment 133192 Patch 584996 5 bashi 2012-03-21 23:15:52 -0700 > Would you add reasons why m_socket can be 0 and why alert() affects to ChangeLog? Thank you for review. Added explanations to ChangeLog. 585003 6 133192 tkent 2012-03-21 23:26:11 -0700 Comment on attachment 133192 Patch ok 585024 7 133192 webkit.review.bot 2012-03-22 00:26:02 -0700 Comment on attachment 133192 Patch Clearing flags on attachment: 133192 Committed r111656: <http://trac.webkit.org/changeset/111656> 585025 8 webkit.review.bot 2012-03-22 00:26:06 -0700 All reviewed patches have been landed. Closing bug. 133161 2012-03-21 18:26:10 -0700 2012-03-21 23:14:44 -0700 Patch bug-81860-20120322102609.patch text/plain 1521 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhjYjRlYmM0OGNjNDk2NTMyNTU5Yjg5OTMyOWRjOTdlN2I0MWY1ZDcuLmQ3YWE5MjA1YzQ3N2Q3 NWYyMjY3YjdmNjlmNmRiMDlmOTk2M2RhODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDMtMjEgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gU2hvdWxkIGNoZWNrIG1fc29ja2V0IGlu IFNvY2tldFN0cmVhbUhhbmRsZUludGVybmFsOjpjbG9zZSgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTg2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3VyZXMgbV9zb2NrZXQgaXMgbm90IE5VTEwu CisKKyAgICAgICAgKiBzcmMvU29ja2V0U3RyZWFtSGFuZGxlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNvY2tldFN0cmVhbUhhbmRsZUludGVybmFsOjpjbG9zZSk6CisKIDIwMTItMDMtMjEgIERh bmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBF YXJseSBvdXQgaW4gYSBuZXcgcHJlcGFyZVRvRHJhdygpIHN0ZXAgaWYgY2hlY2tlcmJvYXJkaW5n IGFuIGFjY2VsZXJhdGVkIGFuaW1hdGlvbiBpbiBvcmRlciB0byBza2lwIHRoZSBmcmFtZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU29ja2V0U3RyZWFtSGFuZGxlLmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NvY2tldFN0cmVhbUhhbmRsZS5jcHAKaW5k ZXggNmEzMjI5OWFmZWZlZWQ4MTdjODNkZTIxNTdjNjZiYTczNTA4NmFkMy4uZmYxMmNjMjRmNDlh NTAwYjMwZTE5NmY0ZWFiMWYyNWVhMDQwZDA5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvU29ja2V0U3RyZWFtSGFuZGxlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9Tb2NrZXRTdHJlYW1IYW5kbGUuY3BwCkBAIC05Miw3ICs5Miw4IEBAIGludCBT b2NrZXRTdHJlYW1IYW5kbGVJbnRlcm5hbDo6c2VuZChjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVu KQogdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGVJbnRlcm5hbDo6Y2xvc2UoKQogewogICAgIExPRyhO ZXR3b3JrLCAiY2xvc2UiKTsKLSAgICBtX3NvY2tldC0+Y2xvc2UoKTsKKyAgICBpZiAobV9zb2Nr ZXQpCisgICAgICAgIG1fc29ja2V0LT5jbG9zZSgpOwogfQogICAgIAogdm9pZCBTb2NrZXRTdHJl YW1IYW5kbGVJbnRlcm5hbDo6ZGlkT3BlblN0cmVhbShXZWJTb2NrZXRTdHJlYW1IYW5kbGUqIHNv Y2tldEhhbmRsZSwgaW50IG1heFBlbmRpbmdTZW5kQWxsb3dlZCkK 133192 2012-03-21 23:14:49 -0700 2012-03-22 00:26:02 -0700 Patch bug-81860-20120322151448.patch text/plain 1753 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhjYjRlYmM0OGNjNDk2NTMyNTU5Yjg5OTMyOWRjOTdlN2I0MWY1ZDcuLmUyZDc0NDc3ODQ2NmFk NGI3OGMwMmNiODdjNTRjMDlmMTM4MmI5NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMjEgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gU2hvdWxkIGNoZWNrIG1fc29ja2V0IGlu IFNvY2tldFN0cmVhbUhhbmRsZUludGVybmFsOjpjbG9zZSgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTg2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1fc29ja2V0IGNvdWxkIGJlIE5VTEwgaWYgV2Vi U29ja2V0OjpyZXN1bWUoKSBpcyBjYWxsZWQgYWZ0ZXIgU29ja2V0U3RyZWFtSGFuZGxlOjpkaWRD bG9zZSgpIGlzIGNhbGxlZC4KKyAgICAgICAgVGhpcyBjb3VsZCBoYXBwZW4gd2hlbiB0aGUgcGFn ZSBzaG93cyBhIHBvcHVwIGRpYWxvZyAoYnkgdXNpbmcgYWxlcnQoKSkgaW1tZWRpYXRlbHkgYWZ0 ZXIgY2xvc2luZyBhbiBXZWJTb2NrZXQgb2JqZWN0LgorCisgICAgICAgICogc3JjL1NvY2tldFN0 cmVhbUhhbmRsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGVJbnRl cm5hbDo6Y2xvc2UpOiBFbnN1cmVzIG1fc29ja2V0IGlzIG5vdCBOVUxMLgorCiAyMDEyLTAzLTIx ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1 bV0gRWFybHkgb3V0IGluIGEgbmV3IHByZXBhcmVUb0RyYXcoKSBzdGVwIGlmIGNoZWNrZXJib2Fy ZGluZyBhbiBhY2NlbGVyYXRlZCBhbmltYXRpb24gaW4gb3JkZXIgdG8gc2tpcCB0aGUgZnJhbWUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NvY2tldFN0cmVhbUhhbmRs ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Tb2NrZXRTdHJlYW1IYW5kbGUuY3Bw CmluZGV4IDZhMzIyOTlhZmVmZWVkODE3YzgzZGUyMTU3YzY2YmE3MzUwODZhZDMuLmZmMTJjYzI0 ZjQ5YTUwMGIzMGUxOTZmNGVhYjFmMjVlYTA0MGQwOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1NvY2tldFN0cmVhbUhhbmRsZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvU29ja2V0U3RyZWFtSGFuZGxlLmNwcApAQCAtOTIsNyArOTIsOCBAQCBp bnQgU29ja2V0U3RyZWFtSGFuZGxlSW50ZXJuYWw6OnNlbmQoY29uc3QgY2hhciogZGF0YSwgaW50 IGxlbikKIHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlSW50ZXJuYWw6OmNsb3NlKCkKIHsKICAgICBM T0coTmV0d29yaywgImNsb3NlIik7Ci0gICAgbV9zb2NrZXQtPmNsb3NlKCk7CisgICAgaWYgKG1f c29ja2V0KQorICAgICAgICBtX3NvY2tldC0+Y2xvc2UoKTsKIH0KICAgICAKIHZvaWQgU29ja2V0 U3RyZWFtSGFuZGxlSW50ZXJuYWw6OmRpZE9wZW5TdHJlYW0oV2ViU29ja2V0U3RyZWFtSGFuZGxl KiBzb2NrZXRIYW5kbGUsIGludCBtYXhQZW5kaW5nU2VuZEFsbG93ZWQpCg==