8184 2006-04-04 15:12:19 -0700 REGRESSION (r13655): Layer outline not clipped where it should be 2006-04-07 12:20:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED http://build.webkit.org/results/post-commit-pixel-powerpc-mac-os-x/169/fast/clip/outline-overflowClip-diffs.html P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 38553 0 mitz 2006-04-04 15:12:19 -0700 My fix for bug 7943 caused a pixel regression in fast/clip/outline-overflowClip.html . Sorry! 38583 1 7518 mitz 2006-04-05 00:11:28 -0700 Created attachment 7518 Patch Tested patch 38584 2 7518 mjs 2006-04-05 00:18:31 -0700 Comment on attachment 7518 Patch r=me 38612 3 darin 2006-04-05 10:36:23 -0700 Damn, my fault. I reviewed that patch and should have noticed! 38754 4 mitz 2006-04-07 12:20:21 -0700 (In reply to comment #3) > Damn, my fault. I reviewed that patch and should have noticed! > Nope, entirely my fault. I should have run the tests with the final version of the patch. Fix verified in r13271 nightly. 7518 2006-04-05 00:11:28 -0700 2006-04-05 00:18:31 -0700 Patch 8184_r1.patch text/plain 3350 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzNjk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDQtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgLSB1cGRhdGVkIHRlc3QgcmVzdWx0IGZvciBodHRwOi8vYnVn emlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTgxODQKKyAgICAgICAgICBSRUdS RVNTSU9OIChyMTM2NTUpOiBMYXllciBvdXRsaW5lIG5vdCBjbGlwcGVkIHdoZXJlIGl0IHNob3Vs ZCBiZQorCisgICAgICAgICogZmFzdC9jbGlwL291dGxpbmUtb3ZlcmZsb3dDbGlwLWV4cGVjdGVk LnR4dDogUmV2ZXJ0ZWQgdG8gdGhlIGNvcnJlY3QKKyAgICAgICAgZXhwZWN0ZWQgcmVzdWx0Lgor CiAyMDA2LTA0LTA0ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBKdXN0aW4gYW5kIEFkZWxlLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jbGlw L291dGxpbmUtb3ZlcmZsb3dDbGlwLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2NsaXAvb3V0bGluZS1vdmVyZmxvd0NsaXAtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAxMzY5OSkKKysrIExheW91dFRlc3RzL2Zhc3QvY2xpcC9vdXRsaW5lLW92ZXJmbG93Q2xpcC1l eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTE1LDcgKzE1LDcgQEAgbGF5ZXIgYXQgKDgs NDQpIHNpemUgMzA0eDIwNCBiYWNrZ3JvdW5kQwogICAgIFJlbmRlclRleHQge1RFWFR9IGF0ICgy LDIpIHNpemUgMTAzeDE4CiAgICAgICB0ZXh0IHJ1biBhdCAoMiwyKSB3aWR0aCAxMDM6ICJ0ZXh0 IGluIG91dGVyIGRpdiAiCiAgICAgUmVuZGVyVGV4dCB7VEVYVH0gYXQgKDAsMCkgc2l6ZSAweDAK LWxheWVyIGF0ICg2MCw2NCkgc2l6ZSAxMDV4MjQgYmFja2dyb3VuZENsaXAgYXQgKDgzLDY0KSBz aXplIDgyeDI0IGNsaXAgYXQgKDgzLDY3KSBzaXplIDc5eDE4IG91dGxpbmVDbGlwIGF0ICg4MCw0 MSkgc2l6ZSAyMzV4MjEwIHNjcm9sbFdpZHRoIDEwMAorbGF5ZXIgYXQgKDYwLDY0KSBzaXplIDEw NXgyNCBiYWNrZ3JvdW5kQ2xpcCBhdCAoODMsNjQpIHNpemUgODJ4MjQgY2xpcCBhdCAoODMsNjcp IHNpemUgNzl4MTggb3V0bGluZUNsaXAgYXQgKDgzLDQ0KSBzaXplIDIyOXgyMDQgc2Nyb2xsV2lk dGggMTAwCiAgIFJlbmRlckJsb2NrIChwb3NpdGlvbmVkKSB7RElWfSBhdCAoNTIsMjApIHNpemUg MTA1eDI0IFtiZ2NvbG9yPSNFRUVFRUVdIFtib3JkZXI6ICgzcHggc29saWQgI0ZGMDAwMCldCiAg ICAgUmVuZGVyVGV4dCB7VEVYVH0gYXQgKDMsMykgc2l6ZSA5OXgxOAogICAgICAgdGV4dCBydW4g YXQgKDMsMykgd2lkdGggOTk6ICJ0ZXh0IGluIGlubmVyIGRpdiAiCkluZGV4OiBXZWJDb3JlL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM2OTkp CisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisy MDA2LTA0LSMjICBNaXR6IFBldHRlbCAgPG9wZW5kYXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0 dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE4NAorICAgICAg ICAgIFJFR1JFU1NJT04gKHIxMzY1NSk6IExheWVyIG91dGxpbmUgbm90IGNsaXBwZWQgd2hlcmUg aXQgc2hvdWxkIGJlCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZVJlY3RzKTogUmV2ZXJ0ZWQgdGhp cyBwYXJ0IG9mIHRoZSBmaXggZm9yIGJ1ZyA3OTQzLgorICAgICAgICBUaGUgb3V0bGluZVJlY3Qg c2hvdWxkIG5vdCBiZSBpbmZsYXRlZC4KKwogMjAwNi0wNC0wNCAgRGFyaW4gQWRsZXIgIDxkYXJp bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSnVzdGluIChlZGl0aW5nIHBhcnRz KSBhbmQgQWRlbGUgKHRoZSByZXN0KS4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJ KHJldmlzaW9uIDEzNjk5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMzc3LDggKzEzNzcsNiBAQCB2b2lkIFJlbmRlckxheWVyOjpjYWxj dWxhdGVSZWN0cyhjb25zdCBSCiAgICAgY29udmVydFRvTGF5ZXJDb29yZHMocm9vdExheWVyLCB4 LCB5KTsKICAgICBsYXllckJvdW5kcyA9IEludFJlY3QoeCx5LHdpZHRoKCksaGVpZ2h0KCkpOwog ICAgIAotICAgIGludCBvdXRsaW5lU2l6ZSA9IHJlbmRlcmVyKCktPnN0eWxlKCktPm91dGxpbmVT aXplKCk7Ci0gICAgb3V0bGluZVJlY3QuaW5mbGF0ZShvdXRsaW5lU2l6ZSk7CiAgICAgLy8gVXBk YXRlIHRoZSBjbGlwIHJlY3RzIHRoYXQgd2lsbCBiZSBwYXNzZWQgdG8gY2hpbGQgbGF5ZXJzLgog ICAgIGlmIChtX29iamVjdC0+aGFzT3ZlcmZsb3dDbGlwKCkgfHwgbV9vYmplY3QtPmhhc0NsaXAo KSkgewogICAgICAgICAvLyBUaGlzIGxheWVyIGVzdGFibGlzaGVzIGEgY2xpcCBvZiBzb21lIGtp bmQuCkBAIC0xMzk2LDcgKzEzOTQsNiBAQCB2b2lkIFJlbmRlckxheWVyOjpjYWxjdWxhdGVSZWN0 cyhjb25zdCBSCiAgICAgICAgIC8vIHJlY3QgaXMgaW50ZXJzZWN0ZWQgd2l0aCBvdXIgbGF5ZXIn cyBib3VuZHMuCiAgICAgICAgIGJhY2tncm91bmRSZWN0LmludGVyc2VjdChsYXllckJvdW5kcyk7 CiAgICAgfQotICAgIG91dGxpbmVSZWN0LmludGVyc2VjdChwYWludERpcnR5UmVjdCk7CiB9CiAK IGJvb2wgUmVuZGVyTGF5ZXI6OmludGVyc2VjdHNEYW1hZ2VSZWN0KGNvbnN0IEludFJlY3QmIGxh eWVyQm91bmRzLCBjb25zdCBJbnRSZWN0JiBkYW1hZ2VSZWN0KSBjb25zdAo=