81822 2012-03-21 12:14:51 -0700 [MutationObservers] attributeFilter should be case sensitive at all times 2012-03-23 17:58:29 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68729 1 rafaelw rafaelw adamk ojan rniwa sam webkit.review.bot oldest_to_newest 584473 0 rafaelw 2012-03-21 12:14:51 -0700 The current behavior is that it is case insensitive for HTML elements in an HTML document. This should be removed as it is inconsistent with the spec. 584478 1 133092 rafaelw 2012-03-21 12:18:32 -0700 Created attachment 133092 Patch 584484 2 133092 adamk 2012-03-21 12:23:47 -0700 Comment on attachment 133092 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133092&action=review thanks > Source/WebCore/dom/MutationObserverRegistration.cpp:117 > + return (m_attributeFilter.contains(attributeName)); Nit: no need for parens here. 584489 3 133092 ojan 2012-03-21 12:26:26 -0700 Comment on attachment 133092 Patch Was this discussed on a mailing list? Can you point to the relevant part of the spec? 584500 4 133092 ojan 2012-03-21 12:34:31 -0700 Comment on attachment 133092 Patch Discussed this in person with Rafael. The discussion happened on #whatwg. The summary sounds like the following to me: -Attribute names in HTML are actually all lowercase. -Legacy APIs like setAttribute, querySelector and the HTML Parser lowercase attribute names for you. -New APIs should just only accept lowercase attributes. I don't buy that argument and will bring this up again on whatwg@. 584501 5 133092 rniwa 2012-03-21 12:34:33 -0700 Comment on attachment 133092 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133092&action=review >> Source/WebCore/dom/MutationObserverRegistration.cpp:117 >> + return (m_attributeFilter.contains(attributeName)); > > Nit: no need for parens here. Yup, please fix this nit before landing it. 586689 6 133550 rafaelw 2012-03-23 13:47:33 -0700 Created attachment 133550 Patch for landing 586788 7 133550 webkit.review.bot 2012-03-23 15:09:07 -0700 Comment on attachment 133550 Patch for landing Rejecting attachment 133550 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11102 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 11102. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12116869 586928 8 133550 webkit.review.bot 2012-03-23 17:58:24 -0700 Comment on attachment 133550 Patch for landing Clearing flags on attachment: 133550 Committed r111950: <http://trac.webkit.org/changeset/111950> 586929 9 webkit.review.bot 2012-03-23 17:58:29 -0700 All reviewed patches have been landed. Closing bug. 133092 2012-03-21 12:18:32 -0700 2012-03-23 13:23:05 -0700 Patch bug-81822-20120321121831.patch text/plain 7210 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjhmNDg1OWJlNDU4OTI5 ZDNmMmRkYmJkNDUxNDE5Y2QzNWViODhlMS4uNDIzOTZhZGUxZmIxMDU3ZDdkYjk2ZWRiNjcyYmE2 NjJkYWFiZmQ0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTIxICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9u T2JzZXJ2ZXJzXSBhdHRyaWJ1dGVGaWx0ZXIgc2hvdWxkIGJlIGNhc2Ugc2Vuc2l0aXZlIGF0IGFs bCB0aW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODE4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHJlbW92ZXMgdGhlIGJlaGF2aW9yIGluIE11dGF0aW9uT2JzZXJ2ZXJSZWdpc3RyYXRpb24g d2hpY2ggdHJlYXRzCisgICAgICAgIGF0dHJpYnV0ZUZpbHRlciBhcyBjYXNlIGluc2Vuc2l0aXZl IGZvciBIVE1MIGVsZW1lbnRzIGluIEhUTUwgZG9jdW1lbnRzLgorCisgICAgICAgIFJlbGV2YW50 IHRlc3RzIGhhdmUgYmVlbiB1cGRhdGVkLgorCisgICAgICAgICogZG9tL011dGF0aW9uT2JzZXJ2 ZXJSZWdpc3RyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TXV0YXRpb25PYnNlcnZlclJl Z2lzdHJhdGlvbjo6cmVzZXRPYnNlcnZhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpNdXRhdGlv bk9ic2VydmVyUmVnaXN0cmF0aW9uOjpzaG91bGRSZWNlaXZlTXV0YXRpb25Gcm9tKToKKyAgICAg ICAgKiBkb20vTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbi5oOgorICAgICAgICAoTXV0YXRp b25PYnNlcnZlclJlZ2lzdHJhdGlvbik6CisKIDIwMTItMDMtMjEgIFplbm8gQWxiaXNzZXIgIDx6 ZW5vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtNYWNdIHJhbmxpYiBzZWdmYXVsdHMgd2hl biBjcmVhdGluZyBzeW1ib2wgdGFibGVzIGZvciBsaWJXZWJDb3JlLmEuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbi5jcHAKaW5kZXggYjhl YjU5NDg3NDcwYWE4OWNhZTk0ZjVjNjliYjBkMmE3NWEyOTQxNC4uM2I3YTU3NjJmODYyYzJhZmIz Mjc0NjZlOWRkZmQwODYxYmY3ZjBmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL011 dGF0aW9uT2JzZXJ2ZXJSZWdpc3RyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9N dXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0aW9uLmNwcApAQCAtNjMsNyArNjMsNiBAQCB2b2lkIE11 dGF0aW9uT2JzZXJ2ZXJSZWdpc3RyYXRpb246OnJlc2V0T2JzZXJ2YXRpb24oTXV0YXRpb25PYnNl cnZlck9wdGlvbnMgb3B0aQogICAgIGNsZWFyVHJhbnNpZW50UmVnaXN0cmF0aW9ucygpOwogICAg IG1fb3B0aW9ucyA9IG9wdGlvbnM7CiAgICAgbV9hdHRyaWJ1dGVGaWx0ZXIgPSBhdHRyaWJ1dGVG aWx0ZXI7Ci0gICAgbV9jYXNlSW5zZW5zaXRpdmVBdHRyaWJ1dGVGaWx0ZXIuY2xlYXIoKTsKIH0K IAogdm9pZCBNdXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0aW9uOjpvYnNlcnZlZFN1YnRyZWVOb2Rl V2lsbERldGFjaChQYXNzUmVmUHRyPE5vZGU+IG5vZGUpCkBAIC0xMTUsMjggKzExNCw3IEBAIGJv b2wgTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbjo6c2hvdWxkUmVjZWl2ZU11dGF0aW9uRnJv bShOb2RlKiBub2RlLCBXZWJLaXRNCiAgICAgaWYgKHR5cGUgIT0gV2ViS2l0TXV0YXRpb25PYnNl cnZlcjo6QXR0cmlidXRlcyB8fCAhKG1fb3B0aW9ucyAmIFdlYktpdE11dGF0aW9uT2JzZXJ2ZXI6 OkF0dHJpYnV0ZUZpbHRlcikpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgaWYgKG1fYXR0 cmlidXRlRmlsdGVyLmNvbnRhaW5zKGF0dHJpYnV0ZU5hbWUpKQotICAgICAgICByZXR1cm4gdHJ1 ZTsKLQotICAgIGlmIChub2RlLT5kb2N1bWVudCgpLT5pc0hUTUxEb2N1bWVudCgpICYmIG5vZGUt PmlzSFRNTEVsZW1lbnQoKSkKLSAgICAgICAgcmV0dXJuIGNhc2VJbnNlbnNpdGl2ZUF0dHJpYnV0 ZUZpbHRlcigpLmNvbnRhaW5zKGF0dHJpYnV0ZU5hbWUpOwotCi0gICAgcmV0dXJuIGZhbHNlOwot fQotCi1jb25zdCBIYXNoU2V0PEF0b21pY1N0cmluZz4mIE11dGF0aW9uT2JzZXJ2ZXJSZWdpc3Ry YXRpb246OmNhc2VJbnNlbnNpdGl2ZUF0dHJpYnV0ZUZpbHRlcigpCi17Ci0gICAgaWYgKG1fY2Fz ZUluc2Vuc2l0aXZlQXR0cmlidXRlRmlsdGVyKQotICAgICAgICByZXR1cm4gKm1fY2FzZUluc2Vu c2l0aXZlQXR0cmlidXRlRmlsdGVyOwotCi0gICAgbV9jYXNlSW5zZW5zaXRpdmVBdHRyaWJ1dGVG aWx0ZXIgPSBhZG9wdFB0cihuZXcgSGFzaFNldDxBdG9taWNTdHJpbmc+KCkpOwotICAgIGZvciAo SGFzaFNldDxBdG9taWNTdHJpbmc+Ojpjb25zdF9pdGVyYXRvciBpdGVyID0gbV9hdHRyaWJ1dGVG aWx0ZXIuYmVnaW4oKTsgaXRlciAhPSBtX2F0dHJpYnV0ZUZpbHRlci5lbmQoKTsgKytpdGVyKSB7 Ci0gICAgICAgIEF0b21pY1N0cmluZyBhdHRyaWJ1dGVOYW1lTG93ZXIgPSBpdGVyLT5sb3dlcigp OwotICAgICAgICBpZiAoKCppdGVyKSAhPSBhdHRyaWJ1dGVOYW1lTG93ZXIpCi0gICAgICAgICAg ICAgbV9jYXNlSW5zZW5zaXRpdmVBdHRyaWJ1dGVGaWx0ZXItPmFkZChhdHRyaWJ1dGVOYW1lTG93 ZXIpOwotICAgIH0KLQotICAgIHJldHVybiAqbV9jYXNlSW5zZW5zaXRpdmVBdHRyaWJ1dGVGaWx0 ZXI7CisgICAgcmV0dXJuIChtX2F0dHJpYnV0ZUZpbHRlci5jb250YWlucyhhdHRyaWJ1dGVOYW1l KSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9NdXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9k b20vTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbi5oCmluZGV4IDYzNjJlNmFhZmVhZjY0Nzg3 NjY5NjRiNDgzYTYxNWNkZWU2NzI0NjkuLmJjMzIzNmQ4ZDY0NGQ1OTg2ODE3YzA4OGZkNGNhMjZj ZWY3YmZjZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbk9ic2VydmVy UmVnaXN0cmF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uT2JzZXJ2ZXJS ZWdpc3RyYXRpb24uaApAQCAtNzIsNyArNzIsNiBAQCBwcml2YXRlOgogCiAgICAgTXV0YXRpb25P YnNlcnZlck9wdGlvbnMgbV9vcHRpb25zOwogICAgIEhhc2hTZXQ8QXRvbWljU3RyaW5nPiBtX2F0 dHJpYnV0ZUZpbHRlcjsKLSAgICBPd25QdHI8SGFzaFNldDxBdG9taWNTdHJpbmc+ID4gbV9jYXNl SW5zZW5zaXRpdmVBdHRyaWJ1dGVGaWx0ZXI7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggM2Y2Mzg2ZDY5ODYzOGUwNWQ2OGRiYzFmMWVjYjA2MjI0Mzg2YTQxZC4uM2JkMjk2 NTY2NTZkYThkODEzYzU3OTI5OWNmYjM4MTA1NTNiNWI3MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTAzLTIxICBSYWZhZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW011dGF0aW9uT2JzZXJ2ZXJzXSBhdHRyaWJ1dGVGaWx0ZXIgc2hvdWxkIGJlIGNh c2Ugc2Vuc2l0aXZlIGF0IGFsbCB0aW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODE4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGZhc3QvbXV0YXRpb24vb2JzZXJ2ZS1hdHRyaWJ1dGVzLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L211dGF0aW9uL29ic2VydmUtYXR0cmlidXRlcy5odG1s OgorCiAyMDEyLTAzLTIxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgQ2hlY2tpbmcgaW4gdXBkYXRlZCB0ZXN0IGV4cGVjdGF0aW9ucwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9vYnNlcnZlLWF0dHJpYnV0ZXMtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9vYnNlcnZlLWF0dHJpYnV0ZXMtZXhw ZWN0ZWQudHh0CmluZGV4IDgzZWI3YmFlMmQzMjBhODIzZGJmNTBmYjMyMWU4ZjRlNDBhN2QxYTMu LjE3MzZkMjIxNzgxYmNkNzA1YzNkZDAwMjU4Mjg1MTMzNmExNmJkNjYgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvbXV0YXRpb24vb2JzZXJ2ZS1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L211dGF0aW9uL29ic2VydmUtYXR0cmlidXRlcy1leHBlY3Rl ZC50eHQKQEAgLTEwMSwxOCArMTAxLDE1IEBAIFBBU1MgbXV0YXRpb25zWzJdLnR5cGUgaXMgImF0 dHJpYnV0ZXMiCiBQQVNTIG11dGF0aW9uc1syXS5hdHRyaWJ1dGVOYW1lIGlzICJpZCIKIFBBU1Mg bXV0YXRpb25zWzJdLm9sZFZhbHVlIGlzICJiYXIiCiAKLVRlc3RpbmcgdGhhdCBhdHRyaWJ1dGVG aWx0ZXIgd29ya3MgYXMgZXhwZWN0ZWQgYW5kIGlnbm9yZXMgY2FzZSB3aXRoIEhUTUwgZWxlbWVu dHMuCi0uLi5vbmx5IGZvbywgYmFyICYgYm9vbSBzaG91bGQgYmUgcmVjZWl2ZWQuCi1QQVNTIG11 dGF0aW9ucy5sZW5ndGggaXMgMworVGVzdGluZyB0aGF0IGF0dHJpYnV0ZUZpbHRlciB3b3JrcyBh cyBleHBlY3RlZCBhbmQgb2JzZXJ2ZXMgY2FzZSB3aXRoIEhUTUwgZWxlbWVudHMuCisuLi5vbmx5 IGZvbyBhbmQgYmFyIHNob3VsZCBiZSByZWNlaXZlZC4KK1BBU1MgbXV0YXRpb25zLmxlbmd0aCBp cyAyCiBQQVNTIG11dGF0aW9uc1swXS50eXBlIGlzICJhdHRyaWJ1dGVzIgogUEFTUyBtdXRhdGlv bnNbMF0uYXR0cmlidXRlTmFtZSBpcyAiZm9vIgogUEFTUyBtdXRhdGlvbnNbMF0uYXR0cmlidXRl TmFtZXNwYWNlIGlzIG51bGwKIFBBU1MgbXV0YXRpb25zWzFdLnR5cGUgaXMgImF0dHJpYnV0ZXMi CiBQQVNTIG11dGF0aW9uc1sxXS5hdHRyaWJ1dGVOYW1lIGlzICJiYXIiCiBQQVNTIG11dGF0aW9u c1sxXS5hdHRyaWJ1dGVOYW1lc3BhY2UgaXMgbnVsbAotUEFTUyBtdXRhdGlvbnNbMl0udHlwZSBp cyAiYXR0cmlidXRlcyIKLVBBU1MgbXV0YXRpb25zWzJdLmF0dHJpYnV0ZU5hbWUgaXMgImJvb20i Ci1QQVNTIG11dGF0aW9uc1syXS5hdHRyaWJ1dGVOYW1lc3BhY2UgaXMgbnVsbAogCiBUZXN0aW5n IHRoZSBiZWhhdmlvciBvZiBhdHRyaWJ1dGVGaWx0ZXIgd2hlbiB0aGUgc2FtZSBvYnNlcnZlciBv YnNlcnZlcyBhdCBtdWx0aXBsZSBub2RlcyBpbiBhIHN1YnRyZWUgd2l0aCBkaWZmZXJlbnQgZmls dGVyIG9wdGlvbnMuCiAuLi5vbmx5IGZvbywgYmFyICYgYmF0IHNob3VsZCBiZSByZWNlaXZlZC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbXV0YXRpb24vb2JzZXJ2ZS1hdHRyaWJ1dGVz Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L211dGF0aW9uL29ic2VydmUtYXR0cmlidXRlcy5odG1s CmluZGV4IDg2N2M0YjM1YWM4MDM3MDQyNzg5ZDk3ZjJlYzVmYzgwZmQ1NmI1YmMuLmY4ZDMyYzY0 NzNkNWViNGExNDg0MDJiOTU1NTZlNTVmNzFiZDllOWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvbXV0YXRpb24vb2JzZXJ2ZS1hdHRyaWJ1dGVzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9tdXRhdGlvbi9vYnNlcnZlLWF0dHJpYnV0ZXMuaHRtbApAQCAtNDUxLDcgKzQ1MSw3IEBA IGZ1bmN0aW9uIHRlc3RBdHRyaWJ1dGVGaWx0ZXIoKSB7CiAgICAgdmFyIG9ic2VydmVyOwogCiAg ICAgZnVuY3Rpb24gc3RhcnQoKSB7Ci0gICAgICAgIGRlYnVnKCdUZXN0aW5nIHRoYXQgYXR0cmli dXRlRmlsdGVyIHdvcmtzIGFzIGV4cGVjdGVkIGFuZCBpZ25vcmVzIGNhc2Ugd2l0aCBIVE1MIGVs ZW1lbnRzLicpOworICAgICAgICBkZWJ1ZygnVGVzdGluZyB0aGF0IGF0dHJpYnV0ZUZpbHRlciB3 b3JrcyBhcyBleHBlY3RlZCBhbmQgb2JzZXJ2ZXMgY2FzZSB3aXRoIEhUTUwgZWxlbWVudHMuJyk7 CiAKICAgICAgICAgbXV0YXRpb25zID0gbnVsbDsKICAgICAgICAgb2JzZXJ2ZXIgPSBuZXcgV2Vi S2l0TXV0YXRpb25PYnNlcnZlcihmdW5jdGlvbihtKSB7CkBAIC00NjksMTggKzQ2OSwxNSBAQCBm dW5jdGlvbiB0ZXN0QXR0cmlidXRlRmlsdGVyKCkgewogICAgIH0KIAogICAgIGZ1bmN0aW9uIGZp bmlzaCgpIHsKLSAgICAgICAgZGVidWcoJy4uLm9ubHkgZm9vLCBiYXIgJiBib29tIHNob3VsZCBi ZSByZWNlaXZlZC4nKTsKKyAgICAgICAgZGVidWcoJy4uLm9ubHkgZm9vIGFuZCBiYXIgc2hvdWxk IGJlIHJlY2VpdmVkLicpOwogCi0gICAgICAgIHNob3VsZEJlKCdtdXRhdGlvbnMubGVuZ3RoJywg JzMnKTsKKyAgICAgICAgc2hvdWxkQmUoJ211dGF0aW9ucy5sZW5ndGgnLCAnMicpOwogICAgICAg ICBzaG91bGRCZSgnbXV0YXRpb25zWzBdLnR5cGUnLCAnImF0dHJpYnV0ZXMiJyk7CiAgICAgICAg IHNob3VsZEJlKCdtdXRhdGlvbnNbMF0uYXR0cmlidXRlTmFtZScsICciZm9vIicpOwogICAgICAg ICBzaG91bGRCZSgnbXV0YXRpb25zWzBdLmF0dHJpYnV0ZU5hbWVzcGFjZScsICdudWxsJyk7CiAg ICAgICAgIHNob3VsZEJlKCdtdXRhdGlvbnNbMV0udHlwZScsICciYXR0cmlidXRlcyInKTsKICAg ICAgICAgc2hvdWxkQmUoJ211dGF0aW9uc1sxXS5hdHRyaWJ1dGVOYW1lJywgJyJiYXIiJyk7CiAg ICAgICAgIHNob3VsZEJlKCdtdXRhdGlvbnNbMV0uYXR0cmlidXRlTmFtZXNwYWNlJywgJ251bGwn KTsKLSAgICAgICAgc2hvdWxkQmUoJ211dGF0aW9uc1syXS50eXBlJywgJyJhdHRyaWJ1dGVzIicp OwotICAgICAgICBzaG91bGRCZSgnbXV0YXRpb25zWzJdLmF0dHJpYnV0ZU5hbWUnLCAnImJvb20i Jyk7Ci0gICAgICAgIHNob3VsZEJlKCdtdXRhdGlvbnNbMl0uYXR0cmlidXRlTmFtZXNwYWNlJywg J251bGwnKTsKICAgICAgICAgb2JzZXJ2ZXIuZGlzY29ubmVjdCgpOwogICAgICAgICBkZWJ1Zygn Jyk7CiAgICAgICAgIHJ1bk5leHRUZXN0KCk7Cg== 133550 2012-03-23 13:47:33 -0700 2012-03-23 17:58:24 -0700 Patch for landing bug-81822-20120323134732.patch text/plain 7195 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGFmZmRkNzMyYzM1ZmE3 M2Q2MzliMDdiNzMyYWI3MTdjYTBmMmRmNS4uYmVmMzBkMmMwODY1Yzk5MTY1NjFmOWI4MDU3YTk4 YjhjMjg1YTdkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTIxICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9u T2JzZXJ2ZXJzXSBhdHRyaWJ1dGVGaWx0ZXIgc2hvdWxkIGJlIGNhc2Ugc2Vuc2l0aXZlIGF0IGFs bCB0aW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODE4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgVGhp cyByZW1vdmVzIHRoZSBiZWhhdmlvciBpbiBNdXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0aW9uIHdo aWNoIHRyZWF0cworICAgICAgICBhdHRyaWJ1dGVGaWx0ZXIgYXMgY2FzZSBpbnNlbnNpdGl2ZSBm b3IgSFRNTCBlbGVtZW50cyBpbiBIVE1MIGRvY3VtZW50cy4KKworICAgICAgICBSZWxldmFudCB0 ZXN0cyBoYXZlIGJlZW4gdXBkYXRlZC4KKworICAgICAgICAqIGRvbS9NdXRhdGlvbk9ic2VydmVy UmVnaXN0cmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok11dGF0aW9uT2JzZXJ2ZXJSZWdp c3RyYXRpb246OnJlc2V0T2JzZXJ2YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TXV0YXRpb25P YnNlcnZlclJlZ2lzdHJhdGlvbjo6c2hvdWxkUmVjZWl2ZU11dGF0aW9uRnJvbSk6CisgICAgICAg ICogZG9tL011dGF0aW9uT2JzZXJ2ZXJSZWdpc3RyYXRpb24uaDoKKyAgICAgICAgKE11dGF0aW9u T2JzZXJ2ZXJSZWdpc3RyYXRpb24pOgorCiAyMDEyLTAzLTIzICBCZXRoIERha2luICA8YmRha2lu QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODIwODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbk9ic2Vy dmVyUmVnaXN0cmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbk9ic2VydmVy UmVnaXN0cmF0aW9uLmNwcAppbmRleCBiOGViNTk0ODc0NzBhYTg5Y2FlOTRmNWM2OWJiMGQyYTc1 YTI5NDE0Li45YmQ2MWM5OTcxMGRiODU2ZjgzOTkyZmRlZTY2MWVmOWQwNzI3M2FkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uT2JzZXJ2ZXJSZWdpc3RyYXRpb24uY3Bw CkBAIC02Myw3ICs2Myw2IEBAIHZvaWQgTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbjo6cmVz ZXRPYnNlcnZhdGlvbihNdXRhdGlvbk9ic2VydmVyT3B0aW9ucyBvcHRpCiAgICAgY2xlYXJUcmFu c2llbnRSZWdpc3RyYXRpb25zKCk7CiAgICAgbV9vcHRpb25zID0gb3B0aW9uczsKICAgICBtX2F0 dHJpYnV0ZUZpbHRlciA9IGF0dHJpYnV0ZUZpbHRlcjsKLSAgICBtX2Nhc2VJbnNlbnNpdGl2ZUF0 dHJpYnV0ZUZpbHRlci5jbGVhcigpOwogfQogCiB2b2lkIE11dGF0aW9uT2JzZXJ2ZXJSZWdpc3Ry YXRpb246Om9ic2VydmVkU3VidHJlZU5vZGVXaWxsRGV0YWNoKFBhc3NSZWZQdHI8Tm9kZT4gbm9k ZSkKQEAgLTExNSwyOCArMTE0LDcgQEAgYm9vbCBNdXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0aW9u OjpzaG91bGRSZWNlaXZlTXV0YXRpb25Gcm9tKE5vZGUqIG5vZGUsIFdlYktpdE0KICAgICBpZiAo dHlwZSAhPSBXZWJLaXRNdXRhdGlvbk9ic2VydmVyOjpBdHRyaWJ1dGVzIHx8ICEobV9vcHRpb25z ICYgV2ViS2l0TXV0YXRpb25PYnNlcnZlcjo6QXR0cmlidXRlRmlsdGVyKSkKICAgICAgICAgcmV0 dXJuIHRydWU7CiAKLSAgICBpZiAobV9hdHRyaWJ1dGVGaWx0ZXIuY29udGFpbnMoYXR0cmlidXRl TmFtZSkpCi0gICAgICAgIHJldHVybiB0cnVlOwotCi0gICAgaWYgKG5vZGUtPmRvY3VtZW50KCkt PmlzSFRNTERvY3VtZW50KCkgJiYgbm9kZS0+aXNIVE1MRWxlbWVudCgpKQotICAgICAgICByZXR1 cm4gY2FzZUluc2Vuc2l0aXZlQXR0cmlidXRlRmlsdGVyKCkuY29udGFpbnMoYXR0cmlidXRlTmFt ZSk7Ci0KLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KLWNvbnN0IEhhc2hTZXQ8QXRvbWljU3RyaW5n PiYgTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbjo6Y2FzZUluc2Vuc2l0aXZlQXR0cmlidXRl RmlsdGVyKCkKLXsKLSAgICBpZiAobV9jYXNlSW5zZW5zaXRpdmVBdHRyaWJ1dGVGaWx0ZXIpCi0g ICAgICAgIHJldHVybiAqbV9jYXNlSW5zZW5zaXRpdmVBdHRyaWJ1dGVGaWx0ZXI7Ci0KLSAgICBt X2Nhc2VJbnNlbnNpdGl2ZUF0dHJpYnV0ZUZpbHRlciA9IGFkb3B0UHRyKG5ldyBIYXNoU2V0PEF0 b21pY1N0cmluZz4oKSk7Ci0gICAgZm9yIChIYXNoU2V0PEF0b21pY1N0cmluZz46OmNvbnN0X2l0 ZXJhdG9yIGl0ZXIgPSBtX2F0dHJpYnV0ZUZpbHRlci5iZWdpbigpOyBpdGVyICE9IG1fYXR0cmli dXRlRmlsdGVyLmVuZCgpOyArK2l0ZXIpIHsKLSAgICAgICAgQXRvbWljU3RyaW5nIGF0dHJpYnV0 ZU5hbWVMb3dlciA9IGl0ZXItPmxvd2VyKCk7Ci0gICAgICAgIGlmICgoKml0ZXIpICE9IGF0dHJp YnV0ZU5hbWVMb3dlcikKLSAgICAgICAgICAgICBtX2Nhc2VJbnNlbnNpdGl2ZUF0dHJpYnV0ZUZp bHRlci0+YWRkKGF0dHJpYnV0ZU5hbWVMb3dlcik7Ci0gICAgfQotCi0gICAgcmV0dXJuICptX2Nh c2VJbnNlbnNpdGl2ZUF0dHJpYnV0ZUZpbHRlcjsKKyAgICByZXR1cm4gbV9hdHRyaWJ1dGVGaWx0 ZXIuY29udGFpbnMoYXR0cmlidXRlTmFtZSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0 aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbi5o CmluZGV4IDYzNjJlNmFhZmVhZjY0Nzg3NjY5NjRiNDgzYTYxNWNkZWU2NzI0NjkuLmJjMzIzNmQ4 ZDY0NGQ1OTg2ODE3YzA4OGZkNGNhMjZjZWY3YmZjZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9NdXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL011dGF0aW9uT2JzZXJ2ZXJSZWdpc3RyYXRpb24uaApAQCAtNzIsNyArNzIsNiBAQCBw cml2YXRlOgogCiAgICAgTXV0YXRpb25PYnNlcnZlck9wdGlvbnMgbV9vcHRpb25zOwogICAgIEhh c2hTZXQ8QXRvbWljU3RyaW5nPiBtX2F0dHJpYnV0ZUZpbHRlcjsKLSAgICBPd25QdHI8SGFzaFNl dDxBdG9taWNTdHJpbmc+ID4gbV9jYXNlSW5zZW5zaXRpdmVBdHRyaWJ1dGVGaWx0ZXI7CiB9Owog CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTkxY2I0MDc0ZmQ1NzU0OTAyZDdkOWNh MDJlMGVhY2VhYzFiNGRlYy4uMzUzNmQyMTc1ZjU5M2ZlNWY0MDkxOGE4ODgxMzM5OTQ2NjA0MjBi NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTIxICBSYWZhZWwgV2VpbnN0ZWluICA8 cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9uT2JzZXJ2ZXJzXSBhdHRy aWJ1dGVGaWx0ZXIgc2hvdWxkIGJlIGNhc2Ugc2Vuc2l0aXZlIGF0IGFsbCB0aW1lcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE4MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgKiBmYXN0L211dGF0aW9uL29i c2VydmUtYXR0cmlidXRlcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9tdXRhdGlvbi9v YnNlcnZlLWF0dHJpYnV0ZXMuaHRtbDoKKwogMjAxMi0wMy0yMiAgT2phbiBWYWZhaSAgPG9qYW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluaXRpYWwgdHJpYWdlIHBhc3Mgb2YgY3NzMy9zZWxl Y3RvcnMzL3htbCBmb3IgdGhlIENocm9taXVtIHBvcnRzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9tdXRhdGlvbi9vYnNlcnZlLWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmFzdC9tdXRhdGlvbi9vYnNlcnZlLWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0CmluZGV4 IDgzZWI3YmFlMmQzMjBhODIzZGJmNTBmYjMyMWU4ZjRlNDBhN2QxYTMuLjE3MzZkMjIxNzgxYmNk NzA1YzNkZDAwMjU4Mjg1MTMzNmExNmJkNjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv bXV0YXRpb24vb2JzZXJ2ZS1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L211dGF0aW9uL29ic2VydmUtYXR0cmlidXRlcy1leHBlY3RlZC50eHQKQEAgLTEwMSwx OCArMTAxLDE1IEBAIFBBU1MgbXV0YXRpb25zWzJdLnR5cGUgaXMgImF0dHJpYnV0ZXMiCiBQQVNT IG11dGF0aW9uc1syXS5hdHRyaWJ1dGVOYW1lIGlzICJpZCIKIFBBU1MgbXV0YXRpb25zWzJdLm9s ZFZhbHVlIGlzICJiYXIiCiAKLVRlc3RpbmcgdGhhdCBhdHRyaWJ1dGVGaWx0ZXIgd29ya3MgYXMg ZXhwZWN0ZWQgYW5kIGlnbm9yZXMgY2FzZSB3aXRoIEhUTUwgZWxlbWVudHMuCi0uLi5vbmx5IGZv bywgYmFyICYgYm9vbSBzaG91bGQgYmUgcmVjZWl2ZWQuCi1QQVNTIG11dGF0aW9ucy5sZW5ndGgg aXMgMworVGVzdGluZyB0aGF0IGF0dHJpYnV0ZUZpbHRlciB3b3JrcyBhcyBleHBlY3RlZCBhbmQg b2JzZXJ2ZXMgY2FzZSB3aXRoIEhUTUwgZWxlbWVudHMuCisuLi5vbmx5IGZvbyBhbmQgYmFyIHNo b3VsZCBiZSByZWNlaXZlZC4KK1BBU1MgbXV0YXRpb25zLmxlbmd0aCBpcyAyCiBQQVNTIG11dGF0 aW9uc1swXS50eXBlIGlzICJhdHRyaWJ1dGVzIgogUEFTUyBtdXRhdGlvbnNbMF0uYXR0cmlidXRl TmFtZSBpcyAiZm9vIgogUEFTUyBtdXRhdGlvbnNbMF0uYXR0cmlidXRlTmFtZXNwYWNlIGlzIG51 bGwKIFBBU1MgbXV0YXRpb25zWzFdLnR5cGUgaXMgImF0dHJpYnV0ZXMiCiBQQVNTIG11dGF0aW9u c1sxXS5hdHRyaWJ1dGVOYW1lIGlzICJiYXIiCiBQQVNTIG11dGF0aW9uc1sxXS5hdHRyaWJ1dGVO YW1lc3BhY2UgaXMgbnVsbAotUEFTUyBtdXRhdGlvbnNbMl0udHlwZSBpcyAiYXR0cmlidXRlcyIK LVBBU1MgbXV0YXRpb25zWzJdLmF0dHJpYnV0ZU5hbWUgaXMgImJvb20iCi1QQVNTIG11dGF0aW9u c1syXS5hdHRyaWJ1dGVOYW1lc3BhY2UgaXMgbnVsbAogCiBUZXN0aW5nIHRoZSBiZWhhdmlvciBv ZiBhdHRyaWJ1dGVGaWx0ZXIgd2hlbiB0aGUgc2FtZSBvYnNlcnZlciBvYnNlcnZlcyBhdCBtdWx0 aXBsZSBub2RlcyBpbiBhIHN1YnRyZWUgd2l0aCBkaWZmZXJlbnQgZmlsdGVyIG9wdGlvbnMuCiAu Li5vbmx5IGZvbywgYmFyICYgYmF0IHNob3VsZCBiZSByZWNlaXZlZC4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvbXV0YXRpb24vb2JzZXJ2ZS1hdHRyaWJ1dGVzLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L211dGF0aW9uL29ic2VydmUtYXR0cmlidXRlcy5odG1sCmluZGV4IDg2N2M0YjM1 YWM4MDM3MDQyNzg5ZDk3ZjJlYzVmYzgwZmQ1NmI1YmMuLmY4ZDMyYzY0NzNkNWViNGExNDg0MDJi OTU1NTZlNTVmNzFiZDllOWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbXV0YXRpb24v b2JzZXJ2ZS1hdHRyaWJ1dGVzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9v YnNlcnZlLWF0dHJpYnV0ZXMuaHRtbApAQCAtNDUxLDcgKzQ1MSw3IEBAIGZ1bmN0aW9uIHRlc3RB dHRyaWJ1dGVGaWx0ZXIoKSB7CiAgICAgdmFyIG9ic2VydmVyOwogCiAgICAgZnVuY3Rpb24gc3Rh cnQoKSB7Ci0gICAgICAgIGRlYnVnKCdUZXN0aW5nIHRoYXQgYXR0cmlidXRlRmlsdGVyIHdvcmtz IGFzIGV4cGVjdGVkIGFuZCBpZ25vcmVzIGNhc2Ugd2l0aCBIVE1MIGVsZW1lbnRzLicpOworICAg ICAgICBkZWJ1ZygnVGVzdGluZyB0aGF0IGF0dHJpYnV0ZUZpbHRlciB3b3JrcyBhcyBleHBlY3Rl ZCBhbmQgb2JzZXJ2ZXMgY2FzZSB3aXRoIEhUTUwgZWxlbWVudHMuJyk7CiAKICAgICAgICAgbXV0 YXRpb25zID0gbnVsbDsKICAgICAgICAgb2JzZXJ2ZXIgPSBuZXcgV2ViS2l0TXV0YXRpb25PYnNl cnZlcihmdW5jdGlvbihtKSB7CkBAIC00NjksMTggKzQ2OSwxNSBAQCBmdW5jdGlvbiB0ZXN0QXR0 cmlidXRlRmlsdGVyKCkgewogICAgIH0KIAogICAgIGZ1bmN0aW9uIGZpbmlzaCgpIHsKLSAgICAg ICAgZGVidWcoJy4uLm9ubHkgZm9vLCBiYXIgJiBib29tIHNob3VsZCBiZSByZWNlaXZlZC4nKTsK KyAgICAgICAgZGVidWcoJy4uLm9ubHkgZm9vIGFuZCBiYXIgc2hvdWxkIGJlIHJlY2VpdmVkLicp OwogCi0gICAgICAgIHNob3VsZEJlKCdtdXRhdGlvbnMubGVuZ3RoJywgJzMnKTsKKyAgICAgICAg c2hvdWxkQmUoJ211dGF0aW9ucy5sZW5ndGgnLCAnMicpOwogICAgICAgICBzaG91bGRCZSgnbXV0 YXRpb25zWzBdLnR5cGUnLCAnImF0dHJpYnV0ZXMiJyk7CiAgICAgICAgIHNob3VsZEJlKCdtdXRh dGlvbnNbMF0uYXR0cmlidXRlTmFtZScsICciZm9vIicpOwogICAgICAgICBzaG91bGRCZSgnbXV0 YXRpb25zWzBdLmF0dHJpYnV0ZU5hbWVzcGFjZScsICdudWxsJyk7CiAgICAgICAgIHNob3VsZEJl KCdtdXRhdGlvbnNbMV0udHlwZScsICciYXR0cmlidXRlcyInKTsKICAgICAgICAgc2hvdWxkQmUo J211dGF0aW9uc1sxXS5hdHRyaWJ1dGVOYW1lJywgJyJiYXIiJyk7CiAgICAgICAgIHNob3VsZEJl KCdtdXRhdGlvbnNbMV0uYXR0cmlidXRlTmFtZXNwYWNlJywgJ251bGwnKTsKLSAgICAgICAgc2hv dWxkQmUoJ211dGF0aW9uc1syXS50eXBlJywgJyJhdHRyaWJ1dGVzIicpOwotICAgICAgICBzaG91 bGRCZSgnbXV0YXRpb25zWzJdLmF0dHJpYnV0ZU5hbWUnLCAnImJvb20iJyk7Ci0gICAgICAgIHNo b3VsZEJlKCdtdXRhdGlvbnNbMl0uYXR0cmlidXRlTmFtZXNwYWNlJywgJ251bGwnKTsKICAgICAg ICAgb2JzZXJ2ZXIuZGlzY29ubmVjdCgpOwogICAgICAgICBkZWJ1ZygnJyk7CiAgICAgICAgIHJ1 bk5leHRUZXN0KCk7Cg==