81788 2012-03-21 08:43:16 -0700 Web Inspector: Speed up heap snapshot loading 2012-03-21 09:37:30 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 alph webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 584162 0 alph 2012-03-21 08:43:16 -0700 Heap snapshot loading takes ~ 4.5 sec for gmail.com 584166 1 133050 alph 2012-03-21 08:46:13 -0700 Created attachment 133050 Patch 584168 2 alph 2012-03-21 08:47:33 -0700 With the fix parsing takes 1200 ms instead of 3000 ms. 584170 3 webkit.review.bot 2012-03-21 08:49:19 -0700 Attachment 133050 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 584179 4 133051 alph 2012-03-21 08:57:13 -0700 Created attachment 133051 Patch 584230 5 133051 webkit.review.bot 2012-03-21 09:37:26 -0700 Comment on attachment 133051 Patch Clearing flags on attachment: 133051 Committed r111553: <http://trac.webkit.org/changeset/111553> 584231 6 webkit.review.bot 2012-03-21 09:37:30 -0700 All reviewed patches have been landed. Closing bug. 133050 2012-03-21 08:46:13 -0700 2012-03-21 08:56:56 -0700 Patch bug-81788-20120321164612.patch text/plain 1877 alph U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWY2YmRkZjE1YzFkNDIz MzY0MTVjMmMzOWI1NzczZTU1OGEyMmU5Ni4uOTVkZGVhODYzODRjMThkMjY0Mzk5ZDc3YmU5NTYx OTdkNmJjNjQ4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTIxICBBbGV4 ZWkgRmlsaXBwb3YgIDxhbGV4ZWlmQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBTcGVlZHVwIGhlYXAgc25hcHNob3QgbG9hZGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNzg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5IZWFwU25hcHNob3RMb2FkZXIucHJvdG90eXBlLl9wYXJzZU5vZGVzKToKKwogMjAx Mi0wMy0yMSAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0aGFuLmRvbmdAdG9yY2htb2JpbGUuY29tLmNu PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbWluZyBibGFja2JlcnJ5IHNwZWNpZmlj IGNzcyBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0hlYXBTbmFwc2hvdC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVh cFNuYXBzaG90LmpzCmluZGV4IDA1Yjc4OGRiYzQ5NGU1MWUyMDQ3NzU2MTQ3MTQ3YmYzMmYwMTM5 N2IuLjE5MWIyYjkxM2YxOWU3NzZkZjg2M2VhNzMwZDZjYWYzYTdlNGRjNTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCkBAIC0x MTAsMTggKzExMCwyMSBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90TG9hZGVyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgICAgICB0aGlzLl9qc29uID0gIiI7CiAgICAgICAgICAgICAgICAg cmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9CisgICAgICAgICAgICB2YXIgbmV4dE51bWJlciA9 IDA7CiAgICAgICAgICAgICB2YXIgc3RhcnRJbmRleCA9IGluZGV4OwogICAgICAgICAgICAgd2hp bGUgKGluZGV4IDwgbGVuZ3RoKSB7CiAgICAgICAgICAgICAgICAgdmFyIGNvZGUgPSB0aGlzLl9q c29uLmNoYXJDb2RlQXQoaW5kZXgpOwogICAgICAgICAgICAgICAgIGlmIChjaGFyMCA+IGNvZGUg fHwgY29kZSA+IGNoYXI5KQogICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAg ICAgICBuZXh0TnVtYmVyICo9IDEwOworICAgICAgICAgICAgICAgIG5leHROdW1iZXIgKz0gKGNv ZGUgLSBjaGFyMCk7CiAgICAgICAgICAgICAgICAgKytpbmRleDsKICAgICAgICAgICAgIH0KICAg ICAgICAgICAgIGlmIChpbmRleCA9PT0gbGVuZ3RoKSB7CiAgICAgICAgICAgICAgICAgdGhpcy5f anNvbiA9IHRoaXMuX2pzb24uc2xpY2Uoc3RhcnRJbmRleCk7CiAgICAgICAgICAgICAgICAgcmV0 dXJuIHRydWU7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB0aGlzLl9ub2Rlcy5wdXNoKHBh cnNlSW50KHRoaXMuX2pzb24uc2xpY2Uoc3RhcnRJbmRleCwgaW5kZXgpKSk7CisgICAgICAgICAg ICB0aGlzLl9ub2Rlcy5wdXNoKG5leHROdW1iZXIpOwogICAgICAgICB9CiAgICAgfSwKIAo= 133051 2012-03-21 08:57:13 -0700 2012-03-21 09:37:26 -0700 Patch bug-81788-20120321165711.patch text/plain 1844 alph U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWY2YmRkZjE1YzFkNDIz MzY0MTVjMmMzOWI1NzczZTU1OGEyMmU5Ni4uY2FiMjc2NzlkODFiNDIwZmJhN2NhYzhhYjk3MWRm MjlkNGQyNDE2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTIxICBBbGV4 ZWkgRmlsaXBwb3YgIDxhbGV4ZWlmQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBTcGVlZHVwIGhlYXAgc25hcHNob3QgbG9hZGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNzg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFw c2hvdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RMb2FkZXIucHJvdG90 eXBlLl9wYXJzZU5vZGVzKToKKwogMjAxMi0wMy0yMSAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0aGFu LmRvbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVh bWluZyBibGFja2JlcnJ5IHNwZWNpZmljIGNzcyBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCmluZGV4IDA1Yjc4OGRiYzQ5NGU1 MWUyMDQ3NzU2MTQ3MTQ3YmYzMmYwMTM5N2IuLjE5MWIyYjkxM2YxOWU3NzZkZjg2M2VhNzMwZDZj YWYzYTdlNGRjNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvSGVhcFNuYXBzaG90LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvSGVhcFNuYXBzaG90LmpzCkBAIC0xMTAsMTggKzExMCwyMSBAQCBXZWJJbnNwZWN0b3IuSGVh cFNuYXBzaG90TG9hZGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICB0aGlzLl9qc29u ID0gIiI7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9CisgICAg ICAgICAgICB2YXIgbmV4dE51bWJlciA9IDA7CiAgICAgICAgICAgICB2YXIgc3RhcnRJbmRleCA9 IGluZGV4OwogICAgICAgICAgICAgd2hpbGUgKGluZGV4IDwgbGVuZ3RoKSB7CiAgICAgICAgICAg ICAgICAgdmFyIGNvZGUgPSB0aGlzLl9qc29uLmNoYXJDb2RlQXQoaW5kZXgpOwogICAgICAgICAg ICAgICAgIGlmIChjaGFyMCA+IGNvZGUgfHwgY29kZSA+IGNoYXI5KQogICAgICAgICAgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgICAgICAgICBuZXh0TnVtYmVyICo9IDEwOworICAgICAgICAg ICAgICAgIG5leHROdW1iZXIgKz0gKGNvZGUgLSBjaGFyMCk7CiAgICAgICAgICAgICAgICAgKytp bmRleDsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmIChpbmRleCA9PT0gbGVuZ3RoKSB7 CiAgICAgICAgICAgICAgICAgdGhpcy5fanNvbiA9IHRoaXMuX2pzb24uc2xpY2Uoc3RhcnRJbmRl eCk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9Ci0gICAgICAg ICAgICB0aGlzLl9ub2Rlcy5wdXNoKHBhcnNlSW50KHRoaXMuX2pzb24uc2xpY2Uoc3RhcnRJbmRl eCwgaW5kZXgpKSk7CisgICAgICAgICAgICB0aGlzLl9ub2Rlcy5wdXNoKG5leHROdW1iZXIpOwog ICAgICAgICB9CiAgICAgfSwKIAo=