<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>81784</bug_id>
          
          <creation_ts>2012-03-21 08:16:00 -0700</creation_ts>
          <short_desc>Web Inspector: HeapSnapshot: move all builders and calculation calls to HeapSnapshot._init function.</short_desc>
          <delta_ts>2012-03-21 08:49:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>78411</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Ilya Tikhonovsky">loislo</reporter>
          <assigned_to name="Ilya Tikhonovsky">loislo</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>timothy</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>584142</commentid>
    <comment_count>0</comment_count>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2012-03-21 08:16:00 -0700</bug_when>
    <thetext>We are doing almost all the calculations for Summary view.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>584146</commentid>
    <comment_count>1</comment_count>
      <attachid>133045</attachid>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2012-03-21 08:19:04 -0700</bug_when>
    <thetext>Created attachment 133045
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>584169</commentid>
    <comment_count>2</comment_count>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2012-03-21 08:49:18 -0700</bug_when>
    <thetext>Committed r111548: &lt;http://trac.webkit.org/changeset/111548&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>133045</attachid>
            <date>2012-03-21 08:19:04 -0700</date>
            <delta_ts>2012-03-21 08:34:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-81784-20120321161902.patch</filename>
            <type>text/plain</type>
            <size>4559</size>
            <attacher name="Ilya Tikhonovsky">loislo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjgxMDk0Nzc1ODRhYTZm
NjQxM2FlNTIzNjAxNWJiOTlkNmY1NDgzOS4uN2FkMjZkZDU2MDRjMGFjOWU1YmYxOTY4YzU3NjQ1
ZTdhNzQ0YzRmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTAzLTIxICBJbHlh
IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5zcGVj
dG9yOiBIZWFwU25hcHNob3Q6IG1vdmUgYWxsIGJ1aWxkZXJzIGFuZCBjYWxjdWxhdGlvbiBjYWxs
cyB0byBIZWFwU25hcHNob3QuX2luaXQgZnVuY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTc4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo
b3QuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZS5faW5p
dCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZS5kaXNwb3Nl
KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlLl9yZXRhaW5l
cnNGb3JOb2RlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBl
Ll9kb21pbmF0ZWROb2Rlc09mTm9kZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBz
aG90LnByb3RvdHlwZS5fZmxhZ3NPZk5vZGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBT
bmFwc2hvdC5wcm90b3R5cGUuYWdncmVnYXRlcyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVh
cFNuYXBzaG90LnByb3RvdHlwZS5fYnVpbGRSZXRhaW5lcnMpOgorICAgICAgICAoV2ViSW5zcGVj
dG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUuZ2V0IG5vZGVJbmRleGVzKToKKworMjAxMi0wMy0y
MSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2Vi
IEluc3BlY3RvcjogSGVhcFByb2ZpbGVyOiBET00gbm9kZSBpZCBjYW4gb3ZlcmZsb3cgSW50MzIu
CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTc3Ngog
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFw
c2hvdC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90
LmpzCmluZGV4IDg2ZTI2YTk1NDU5MmM4OTJjMmMwOTRiMGMwNWU4MmI0Y2EyMzc5MTUuLmM0MzAw
MzkzYTZmY2FiM2FiNzcyYzk2ZjlmZDJmNTc0OTAyN2RkYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCkBAIC03OTIsOCArNzky
LDEyIEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlID0gewogICAgICAgICAg
ICAgZGV0YWNoZWRET01UcmVlTm9kZTogMiwKICAgICAgICAgfTsKIAotICAgICAgICB0aGlzLl9k
aXN0YW5jZXNUb1dpbmRvdyA9IFtdOwogICAgICAgICB0aGlzLl9tYXJrSW52aXNpYmxlRWRnZXMo
KTsKKyAgICAgICAgdGhpcy5fYnVpbGROb2RlSW5kZXgoKTsKKyAgICAgICAgdGhpcy5fYnVpbGRS
ZXRhaW5lcnMoKTsKKyAgICAgICAgdGhpcy5fYnVpbGREb21pbmF0ZWROb2RlcygpOworICAgICAg
ICB0aGlzLl9jYWxjdWxhdGVGbGFncygpOworICAgICAgICB0aGlzLl9jYWxjdWxhdGVPYmplY3RU
b1dpbmRvd0Rpc3RhbmNlKCk7CiAgICAgfSwKIAogICAgIGRpc3Bvc2U6IGZ1bmN0aW9uKCkKQEAg
LTgxMSw2ICs4MTUsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsK
ICAgICAgICAgZGVsZXRlIHRoaXMuX2RvbWluYXRlZE5vZGVzOwogICAgICAgICBkZWxldGUgdGhp
cy5fZG9taW5hdGVkSW5kZXg7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9mbGFnczsKKyAgICAgICAg
ZGVsZXRlIHRoaXMuX2Rpc3RhbmNlc1RvV2luZG93OwogICAgIH0sCiAKICAgICBnZXQgX2FsbE5v
ZGVzKCkKQEAgLTg2Niw5ICs4NzEsNiBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3Rv
dHlwZSA9IHsKIAogICAgIF9yZXRhaW5lcnNGb3JOb2RlOiBmdW5jdGlvbihub2RlKQogICAgIHsK
LSAgICAgICAgaWYgKCF0aGlzLl9yZXRhaW5lcnMpCi0gICAgICAgICAgICB0aGlzLl9idWlsZFJl
dGFpbmVycygpOwotCiAgICAgICAgIHZhciByZXRJbmRleEZyb20gPSB0aGlzLl9nZXRSZXRhaW5l
ckluZGV4KG5vZGUubm9kZUluZGV4KTsKICAgICAgICAgdmFyIHJldEluZGV4VG8gPSB0aGlzLl9n
ZXRSZXRhaW5lckluZGV4KG5vZGUuX25leHROb2RlSW5kZXgpOwogICAgICAgICByZXR1cm4gbmV3
IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RBcnJheVNsaWNlKHRoaXMsICJfcmV0YWluZXJzIiwg
cmV0SW5kZXhGcm9tLCByZXRJbmRleFRvKTsKQEAgLTg3Niw5ICs4NzgsNiBAQCBXZWJJbnNwZWN0
b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsKIAogICAgIF9kb21pbmF0ZWROb2Rlc09mTm9k
ZTogZnVuY3Rpb24obm9kZSkKICAgICB7Ci0gICAgICAgIGlmICghdGhpcy5fZG9taW5hdGVkTm9k
ZXMpCi0gICAgICAgICAgICB0aGlzLl9idWlsZERvbWluYXRlZE5vZGVzKCk7Ci0KICAgICAgICAg
dmFyIGRvbWluYXRlZEluZGV4RnJvbSA9IHRoaXMuX2dldERvbWluYXRlZEluZGV4KG5vZGUubm9k
ZUluZGV4KTsKICAgICAgICAgdmFyIGRvbWluYXRlZEluZGV4VG8gPSB0aGlzLl9nZXREb21pbmF0
ZWRJbmRleChub2RlLl9uZXh0Tm9kZUluZGV4KTsKICAgICAgICAgcmV0dXJuIG5ldyBXZWJJbnNw
ZWN0b3IuSGVhcFNuYXBzaG90QXJyYXlTbGljZSh0aGlzLCAiX2RvbWluYXRlZE5vZGVzIiwgZG9t
aW5hdGVkSW5kZXhGcm9tLCBkb21pbmF0ZWRJbmRleFRvKTsKQEAgLTg4NiwxNiArODg1LDExIEBA
IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlID0gewogCiAgICAgX2ZsYWdzT2ZO
b2RlOiBmdW5jdGlvbihub2RlKQogICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLl9mbGFncykKLSAg
ICAgICAgICAgIHRoaXMuX2NhbGN1bGF0ZUZsYWdzKCk7CiAgICAgICAgIHJldHVybiB0aGlzLl9m
bGFnc1tub2RlLm5vZGVJbmRleF07CiAgICAgfSwKIAogICAgIGFnZ3JlZ2F0ZXM6IGZ1bmN0aW9u
KHNvcnRlZEluZGV4ZXMsIGtleSwgZmlsdGVyU3RyaW5nKQogICAgIHsKLSAgICAgICAgaWYgKCF0
aGlzLl9yZXRhaW5lcnMpCi0gICAgICAgICAgICB0aGlzLl9idWlsZFJldGFpbmVycygpOwotCiAg
ICAgICAgIGlmICghdGhpcy5fYWdncmVnYXRlcykgewogICAgICAgICAgICAgdGhpcy5fYWdncmVn
YXRlcyA9IHt9OwogICAgICAgICAgICAgdGhpcy5fYWdncmVnYXRlc1NvcnRlZEZsYWdzID0ge307
CkBAIC05MjcsOSArOTIxLDYgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUg
PSB7CiAKICAgICBfYnVpbGRSZXZlcnNlSW5kZXg6IGZ1bmN0aW9uKGluZGV4QXJyYXlOYW1lLCBi
YWNrUmVmc0FycmF5TmFtZSwgaW5kZXhDYWxsYmFjaywgZGF0YUNhbGxiYWNrKQogICAgIHsKLSAg
ICAgICAgaWYgKCF0aGlzLl9ub2RlSW5kZXgpCi0gICAgICAgICAgICB0aGlzLl9idWlsZE5vZGVJ
bmRleCgpOwotCiAgICAgICAgIC8vIEJ1aWxkcyB1cCB0d28gYXJyYXlzOgogICAgICAgICAvLyAg
LSAiYmFja1JlZnNBcnJheSIgaXMgYSBjb250aW51b3VzIGFycmF5LCB3aGVyZSBlYWNoIG5vZGUg
b3ducyBhbgogICAgICAgICAvLyAgICBpbnRlcnZhbCAoY2FuIGJlIGVtcHR5KSB3aXRoIGNvcnJl
c3BvbmRpbmcgYmFjayByZWZlcmVuY2VzLgpAQCAtOTgxLDcgKzk3Miw2IEBAIFdlYkluc3BlY3Rv
ci5IZWFwU25hcHNob3QucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICAgZGF0YUNh
bGxiYWNrKGluZGV4Q2FsbGJhY2socmV0SW5kZXgpLCBub2RlLm5vZGVJbmRleCArIHRoaXMuX2Zp
cnN0RWRnZU9mZnNldCArIGVkZ2UuZWRnZUluZGV4KTsKICAgICAgICAgICAgICAgICAgfQogICAg
ICAgICAgICAgIH0pLmJpbmQodGhpcykpOwotICAgICAgICB0aGlzLl9jYWxjdWxhdGVPYmplY3RU
b1dpbmRvd0Rpc3RhbmNlKCk7CiAgICAgfSwKIAogICAgIF9jYWxjdWxhdGVPYmplY3RUb1dpbmRv
d0Rpc3RhbmNlOiBmdW5jdGlvbigpCkBAIC0xMTEyLDggKzExMDIsNiBAQCBXZWJJbnNwZWN0b3Iu
SGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsKIAogICAgIGdldCBub2RlSW5kZXhlcygpCiAgICAg
ewotICAgICAgICBpZiAoIXRoaXMuX25vZGVJbmRleCkKLSAgICAgICAgICAgIHRoaXMuX2J1aWxk
Tm9kZUluZGV4KCk7CiAgICAgICAgIHJldHVybiB0aGlzLl9ub2RlSW5kZXg7CiAgICAgfSwKIAo=
</data>
<flag name="review"
          id="136900"
          type_id="1"
          status="+"
          setter="yurys"
    />
          </attachment>
      

    </bug>

</bugzilla>