81761 2012-03-21 04:38:58 -0700 Fix Gobject binding for sequence<T> for function return type. 2012-03-21 06:53:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80269 0 arko webkit-unassigned abarth code.vineet haraken japhet webkit.review.bot oldest_to_newest 583994 0 arko 2012-03-21 04:38:58 -0700 After r111416 <http://trac.webkit.org/changeset/111416> revision I was trying to remove the custom binding for [Custom] Array getValues() and using sequence<MicroDataItemValue> getValues(). It works for JS bindings but for Gobject bindings it is trying to include #include "sequence<MicroDataItemValue>.h" in WebKitDOMPropertyNodeList.cpp. We should fix the same. 584001 1 code.vineet 2012-03-21 04:56:40 -0700 Should we skip the function in the GObject Bindings? 584019 2 133017 code.vineet 2012-03-21 05:18:04 -0700 Created attachment 133017 quick_fix Providing quick fix. This should solve your current build issue, but not sure if want these bindings in GObject. I can see some changes in binding like below not related to this change, someone might have forgot to run bindings tests. -#import <wtf/Float32Array.h> -#import <wtf/Float64Array.h> -#import <wtf/Int32Array.h> +#import "Float32Array.h" +#import "Float64Array.h" +#import "Int32Array.h" 584028 3 webkit.review.bot 2012-03-21 05:23:25 -0700 Attachment 133017 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 584039 4 133017 haraken 2012-03-21 05:47:20 -0700 Comment on attachment 133017 quick_fix View in context: https://bugs.webkit.org/attachment.cgi?id=133017&action=review The change looks OK. If you want, please change r to r?. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:214 > + if ($codeGenerator->GetArrayType($functionReturnType)) { Maybe we can just write $codeGenerator->GetArrayType($function->signature->type). $function->signature->type for setters would be empty. 584042 5 haraken 2012-03-21 05:54:11 -0700 (In reply to comment #2) > Created an attachment (id=133017) [details] > quick_fix > > Providing quick fix. This should solve your current build issue, but not sure if want these bindings in GObject. > I can see some changes in binding like below not related to this change, someone might have forgot to run bindings tests. > > -#import <wtf/Float32Array.h> > -#import <wtf/Float64Array.h> > -#import <wtf/Int32Array.h> > +#import "Float32Array.h" > +#import "Float64Array.h" > +#import "Int32Array.h" I rebaselined the run-bindings-tests results. Would you please rebase your patch with the latest WebKit trunk and re-upload it? 584044 6 haraken 2012-03-21 05:55:15 -0700 (In reply to comment #4) > > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:214 > > + if ($codeGenerator->GetArrayType($functionReturnType)) { > > Maybe we can just write $codeGenerator->GetArrayType($function->signature->type). $function->signature->type for setters would be empty. Sorry, your change is correct. Please ignore the above comment. 584048 7 133028 code.vineet 2012-03-21 06:04:44 -0700 Created attachment 133028 Patch patch as per review comments. 584064 8 133028 haraken 2012-03-21 06:19:59 -0700 Comment on attachment 133028 Patch OK. Thanks for the fix! 584093 9 133028 webkit.review.bot 2012-03-21 06:53:00 -0700 Comment on attachment 133028 Patch Clearing flags on attachment: 133028 Committed r111535: <http://trac.webkit.org/changeset/111535> 584094 10 webkit.review.bot 2012-03-21 06:53:05 -0700 All reviewed patches have been landed. Closing bug. 133017 2012-03-21 05:18:04 -0700 2012-03-21 06:04:44 -0700 quick_fix quick_fix.diff text/plain 7370 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTUyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTIxICBWaW5lZXQg Q2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE3NjEKKyAgICAgICAgRml4IEdvYmplY3QgYmlu ZGluZyBmb3Igc2VxdWVuY2U8VD4gZm9yIGZ1bmN0aW9uIHJldHVybiB0eXBlLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisgICAg ICAgIChTa2lwRnVuY3Rpb24pOiBTa2lwIGZ1bmN0aW9uIHdpdGggc2VxdWVuY2U8VD4gcmV0dXJu IHR5cGUuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01GbG9hdDY0 QXJyYXkuY3BwOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktp dERPTUZsb2F0NjRBcnJheS5jcHA6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dP YmplY3QvV2ViS2l0RE9NRmxvYXQ2NEFycmF5UHJpdmF0ZS5oOgorICAgICAgICAqIGJpbmRpbmdz L3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmouY3BwOgorICAgICAgICAod2Vi a2l0X2RvbV90ZXN0X29ial9tZXRob2Rfd2l0aF9zZXF1ZW5jZV9hcmcpOgorICAgICAgICAqIGJp bmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmouaDoKKyAgICAgICAg KiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvT2JqQy9ET01GbG9hdDY0QXJyYXkubW06CisKIDIwMTIt MDMtMjEgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtX SzJdW01hY10gTWluaUJyb3dzZXIgYXNzZXJ0cyBhdCBIYXNoVGFibGUuaDo0ODAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y R09iamVjdC5wbQkocmV2aXNpb24gMTExNTE4KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQkod29ya2luZyBjb3B5KQpAQCAtMTkyLDYg KzE5Miw3IEBAIHN1YiBTa2lwRnVuY3Rpb24gewogICAgIG15ICRwcmVmaXggPSBzaGlmdDsKIAog ICAgIG15ICRmdW5jdGlvbk5hbWUgPSAid2Via2l0X2RvbV8iIC4gJGRlY2FtZWxpemUgLiAiXyIg LiAkcHJlZml4IC4gZGVjYW1lbGl6ZSgkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZSk7CisgICAg bXkgJGZ1bmN0aW9uUmV0dXJuVHlwZSA9ICRwcmVmaXggZXEgInNldF8iID8gInZvaWQiIDogJGZ1 bmN0aW9uLT5zaWduYXR1cmUtPnR5cGU7CiAgICAgbXkgJGlzQ3VzdG9tRnVuY3Rpb24gPSAkZnVu Y3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbSJ9OwogICAgIG15 ICRjYWxsV2l0aCA9ICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsi Q2FsbFdpdGgifTsKICAgICBteSAkaXNVbnN1cHBvcnRlZENhbGxXaXRoID0gJGNvZGVHZW5lcmF0 b3ItPkV4dGVuZGVkQXR0cmlidXRlQ29udGFpbnMoJGNhbGxXaXRoLCAiU2NyaXB0QXJndW1lbnRz IikgfHwgJGNvZGVHZW5lcmF0b3ItPkV4dGVuZGVkQXR0cmlidXRlQ29udGFpbnMoJGNhbGxXaXRo LCAiQ2FsbFN0YWNrIik7CkBAIC0yMTAsNiArMjExLDEwIEBAIHN1YiBTa2lwRnVuY3Rpb24gewog ICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKKyAgICBpZiAoJGNvZGVHZW5lcmF0b3ItPkdldEFy cmF5VHlwZSgkZnVuY3Rpb25SZXR1cm5UeXBlKSkgeworICAgICAgICByZXR1cm4gMTsKKyAgICB9 CisKICAgICBpZiAoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWUgZXEgImdldENTU0NhbnZhc0Nv bnRleHQiKSB7CiAgICAgICAgIHJldHVybiAxOwogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NRmxvYXQ2NEFycmF5LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTUZs b2F0NjRBcnJheS5jcHAJKHJldmlzaW9uIDExMTUxOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NRmxvYXQ2NEFycmF5LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjEsOSArMjEsOSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYkRP TUZsb2F0NjRBcnJheS5oIgogCi0jaW5jbHVkZSA8d3RmL0Zsb2F0MzJBcnJheS5oPgotI2luY2x1 ZGUgPHd0Zi9GbG9hdDY0QXJyYXkuaD4KLSNpbmNsdWRlIDx3dGYvSW50MzJBcnJheS5oPgorI2lu Y2x1ZGUgIkZsb2F0MzJBcnJheS5oIgorI2luY2x1ZGUgIkZsb2F0NjRBcnJheS5oIgorI2luY2x1 ZGUgIkludDMyQXJyYXkuaCIKICNpbmNsdWRlICJXZWJET01GbG9hdDMyQXJyYXkuaCIKICNpbmNs dWRlICJXZWJET01JbnQzMkFycmF5LmgiCiAjaW5jbHVkZSAiV2ViRXhjZXB0aW9uSGFuZGxlci5o IgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2Vi S2l0RE9NRmxvYXQ2NEFycmF5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01GbG9hdDY0QXJyYXkuY3BwCShyZXZp c2lvbiAxMTE1MTgpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09i amVjdC9XZWJLaXRET01GbG9hdDY0QXJyYXkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw4ICsy NSw4IEBACiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogI2luY2x1ZGUgIkRPTU9iamVjdENhY2hl LmgiCiAjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgotI2luY2x1ZGUgPHd0Zi9GbG9hdDY0QXJy YXkuaD4KLSNpbmNsdWRlIDx3dGYvSW50MzJBcnJheS5oPgorI2luY2x1ZGUgIkZsb2F0NjRBcnJh eS5oIgorI2luY2x1ZGUgIkludDMyQXJyYXkuaCIKICNpbmNsdWRlICJKU01haW5UaHJlYWRFeGVj U3RhdGUuaCIKICNpbmNsdWRlICJXZWJLaXRET01CaW5kaW5nLmgiCiAjaW5jbHVkZSAiZ29iamVj dC9Db252ZXJ0VG9VVEY4U3RyaW5nLmgiCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01GbG9hdDY0QXJyYXlQcml2YXRlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2Vi S2l0RE9NRmxvYXQ2NEFycmF5UHJpdmF0ZS5oCShyZXZpc2lvbiAxMTE1MTgpCisrKyBTb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvR09iamVjdC9XZWJLaXRET01GbG9hdDY0QXJy YXlQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzLDcgKzIzLDcgQEAKIAogI2luY2x1ZGUg PGdsaWItb2JqZWN0Lmg+CiAjaW5jbHVkZSA8d2Via2l0L1dlYktpdERPTUFycmF5QnVmZmVyVmll dy5oPgotI2luY2x1ZGUgPHd0Zi9GbG9hdDY0QXJyYXkuaD4KKyNpbmNsdWRlICJGbG9hdDY0QXJy YXkuaCIKIG5hbWVzcGFjZSBXZWJLaXQgewogICAgIFdlYktpdERPTUZsb2F0NjRBcnJheSAqCiAg ICAgd3JhcEZsb2F0NjRBcnJheShXZWJDb3JlOjpGbG9hdDY0QXJyYXkgKmNvcmVPYmplY3QpOwpJ bmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0 RE9NVGVzdE9iai5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5jcHAJKHJldmlzaW9uIDExMTUxOCkK KysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERP TVRlc3RPYmouY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw2IEBACiAjaW5jbHVkZSAi V2ViS2l0RE9NQmluZGluZy5oIgogI2luY2x1ZGUgImJvb2wuaCIKICNpbmNsdWRlICJnb2JqZWN0 L0NvbnZlcnRUb1VURjhTdHJpbmcuaCIKLSNpbmNsdWRlICJzZXF1ZW5jZTxTY3JpcHRQcm9maWxl Pi5oIgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01EaWN0aW9uYXJ5LmgiCiAjaW5jbHVkZSAi d2Via2l0L1dlYktpdERPTURpY3Rpb25hcnlQcml2YXRlLmgiCiAjaW5jbHVkZSAid2Via2l0L1dl YktpdERPTURvY3VtZW50LmgiCkBAIC01OSw4ICs1OCw2IEBACiAjaW5jbHVkZSAid2Via2l0L1dl YktpdERPTWUuaCIKICNpbmNsdWRlICJ3ZWJraXQvV2ViS2l0RE9NZVByaXZhdGUuaCIKICNpbmNs dWRlICJ3ZWJraXQvV2ViS2l0RE9Nc2VxdWVuY2UuaCIKLSNpbmNsdWRlICJ3ZWJraXQvV2ViS2l0 RE9Nc2VxdWVuY2U8U2NyaXB0UHJvZmlsZT4uaCIKLSNpbmNsdWRlICJ3ZWJraXQvV2ViS2l0RE9N c2VxdWVuY2U8U2NyaXB0UHJvZmlsZT5Qcml2YXRlLmgiCiAjaW5jbHVkZSAid2Via2l0L1dlYktp dERPTXNlcXVlbmNlUHJpdmF0ZS5oIgogI2luY2x1ZGUgIndlYmtpdGRlZmluZXMuaCIKICNpbmNs dWRlICJ3ZWJraXRnbG9iYWxzcHJpdmF0ZS5oIgpAQCAtMTc5LDE3ICsxNzYsNiBAQCB3ZWJraXRf ZG9tX3Rlc3Rfb2JqX21ldGhvZF93aXRoX3NlcXVlbmNlCiAgICAgaXRlbS0+bWV0aG9kV2l0aFNl cXVlbmNlQXJnKGNvbnZlcnRlZF8pOwogfQogCi1XZWJLaXRET01zZXF1ZW5jZTxTY3JpcHRQcm9m aWxlPioKLXdlYmtpdF9kb21fdGVzdF9vYmpfbWV0aG9kX3JldHVybmluZ19zZXF1ZW5jZShXZWJL aXRET01UZXN0T2JqKiBzZWxmLCBnbG9uZyBpbnRfYXJnKQotewotICAgIGdfcmV0dXJuX3ZhbF9p Zl9mYWlsKHNlbGYsIDApOwotICAgIFdlYkNvcmU6OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0 ZTsKLSAgICBXZWJDb3JlOjpUZXN0T2JqICogaXRlbSA9IFdlYktpdDo6Y29yZShzZWxmKTsKLSAg ICBQYXNzUmVmUHRyPFdlYkNvcmU6OnNlcXVlbmNlPFNjcmlwdFByb2ZpbGU+PiBnX3JlcyA9IFdU Rjo6Z2V0UHRyKGl0ZW0tPm1ldGhvZFJldHVybmluZ1NlcXVlbmNlKGludF9hcmcpKTsKLSAgICBX ZWJLaXRET01zZXF1ZW5jZTxTY3JpcHRQcm9maWxlPiogcmVzID0gV2ViS2l0OjpraXQoZ19yZXMu Z2V0KCkpOwotICAgIHJldHVybiByZXM7Ci19Ci0KIFdlYktpdERPTVRlc3RPYmoqCiB3ZWJraXRf ZG9tX3Rlc3Rfb2JqX21ldGhvZF90aGF0X3JlcXVpcmVzX2FsbF9hcmdzX2FuZF90aHJvd3MoV2Vi S2l0RE9NVGVzdE9iaiogc2VsZiwgY29uc3QgZ2NoYXIqIHN0cl9hcmcsIFdlYktpdERPTVRlc3RP YmoqIG9ial9hcmcsIEdFcnJvciAqKmVycm9yKQogewpJbmRleDogU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERP TVRlc3RPYmouaAkocmV2aXNpb24gMTExNTE4KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9NVGVzdE9iai5oCSh3b3JraW5nIGNvcHkpCkBA IC0xMjcsMTcgKzEyNyw2IEBAIFdFQktJVF9BUEkgdm9pZAogd2Via2l0X2RvbV90ZXN0X29ial9t ZXRob2Rfd2l0aF9zZXF1ZW5jZV9hcmcoV2ViS2l0RE9NVGVzdE9iaiogc2VsZiwgV2ViS2l0RE9N c2VxdWVuY2UqICk7CiAKIC8qKgotICogd2Via2l0X2RvbV90ZXN0X29ial9tZXRob2RfcmV0dXJu aW5nX3NlcXVlbmNlOgotICogQHNlbGY6IEEgI1dlYktpdERPTVRlc3RPYmoKLSAqIEBpbnRfYXJn OiBBICNnbG9uZwotICoKLSAqIFJldHVybnM6ICh0cmFuc2ZlciBub25lKToKLSAqCi0qKi8KLVdF QktJVF9BUEkgV2ViS2l0RE9Nc2VxdWVuY2U8U2NyaXB0UHJvZmlsZT4qCi13ZWJraXRfZG9tX3Rl c3Rfb2JqX21ldGhvZF9yZXR1cm5pbmdfc2VxdWVuY2UoV2ViS2l0RE9NVGVzdE9iaiogc2VsZiwg Z2xvbmcgaW50X2FyZyk7Ci0KLS8qKgogICogd2Via2l0X2RvbV90ZXN0X29ial9tZXRob2RfdGhh dF9yZXF1aXJlc19hbGxfYXJnc19hbmRfdGhyb3dzOgogICogQHNlbGY6IEEgI1dlYktpdERPTVRl c3RPYmoKICAqIEBzdHJfYXJnOiBBICNnY2hhcgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L09iakMvRE9NRmxvYXQ2NEFycmF5Lm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9PYmpDL0RPTUZsb2F0NjRBcnJheS5t bQkocmV2aXNpb24gMTExNTE4KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L09iakMvRE9NRmxvYXQ2NEFycmF5Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw5ICszOSw5 IEBACiAjaW1wb3J0ICJET01Ob2RlSW50ZXJuYWwuaCIKICNpbXBvcnQgIkRPTVN0eWxlU2hlZXRJ bnRlcm5hbC5oIgogI2ltcG9ydCAiRXhjZXB0aW9uSGFuZGxlcnMuaCIKLSNpbXBvcnQgPHd0Zi9G bG9hdDMyQXJyYXkuaD4KLSNpbXBvcnQgPHd0Zi9GbG9hdDY0QXJyYXkuaD4KLSNpbXBvcnQgPHd0 Zi9JbnQzMkFycmF5Lmg+CisjaW1wb3J0ICJGbG9hdDMyQXJyYXkuaCIKKyNpbXBvcnQgIkZsb2F0 NjRBcnJheS5oIgorI2ltcG9ydCAiSW50MzJBcnJheS5oIgogI2ltcG9ydCAiSlNNYWluVGhyZWFk RXhlY1N0YXRlLmgiCiAjaW1wb3J0ICJUaHJlYWRDaGVjay5oIgogI2ltcG9ydCAiV2ViU2NyaXB0 T2JqZWN0UHJpdmF0ZS5oIgo= 133028 2012-03-21 06:04:44 -0700 2012-03-21 06:53:00 -0700 Patch q_fix.diff text/plain 4668 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTUyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIxICBWaW5lZXQg Q2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE3NjEKKyAgICAgICAgRml4IEdvYmplY3QgYmlu ZGluZyBmb3Igc2VxdWVuY2U8VD4gZm9yIGZ1bmN0aW9uIHJldHVybiB0eXBlLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06CisgICAg ICAgIChTa2lwRnVuY3Rpb24pOiBTa2lwIGZ1bmN0aW9uIHdpdGggc2VxdWVuY2U8VD4gcmV0dXJu IHR5cGUuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2ViS2l0RE9N VGVzdE9iai5jcHA6CisgICAgICAgICh3ZWJraXRfZG9tX3Rlc3Rfb2JqX21ldGhvZF93aXRoX3Nl cXVlbmNlX2FyZyk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0dPYmplY3QvV2Vi S2l0RE9NVGVzdE9iai5oOgorCiAyMDEyLTAzLTIxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByZWJhc2VsaW5lZCBydW4tYmluZGlu Z3MtdGVzdHMgcmVzdWx0cy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckdPYmplY3QucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQkocmV2aXNpb24gMTExNTI4KQor KysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5w bQkod29ya2luZyBjb3B5KQpAQCAtMTkyLDYgKzE5Miw3IEBAIHN1YiBTa2lwRnVuY3Rpb24gewog ICAgIG15ICRwcmVmaXggPSBzaGlmdDsKIAogICAgIG15ICRmdW5jdGlvbk5hbWUgPSAid2Via2l0 X2RvbV8iIC4gJGRlY2FtZWxpemUgLiAiXyIgLiAkcHJlZml4IC4gZGVjYW1lbGl6ZSgkZnVuY3Rp b24tPnNpZ25hdHVyZS0+bmFtZSk7CisgICAgbXkgJGZ1bmN0aW9uUmV0dXJuVHlwZSA9ICRwcmVm aXggZXEgInNldF8iID8gInZvaWQiIDogJGZ1bmN0aW9uLT5zaWduYXR1cmUtPnR5cGU7CiAgICAg bXkgJGlzQ3VzdG9tRnVuY3Rpb24gPSAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRy aWJ1dGVzLT57IkN1c3RvbSJ9OwogICAgIG15ICRjYWxsV2l0aCA9ICRmdW5jdGlvbi0+c2lnbmF0 dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ2FsbFdpdGgifTsKICAgICBteSAkaXNVbnN1cHBv cnRlZENhbGxXaXRoID0gJGNvZGVHZW5lcmF0b3ItPkV4dGVuZGVkQXR0cmlidXRlQ29udGFpbnMo JGNhbGxXaXRoLCAiU2NyaXB0QXJndW1lbnRzIikgfHwgJGNvZGVHZW5lcmF0b3ItPkV4dGVuZGVk QXR0cmlidXRlQ29udGFpbnMoJGNhbGxXaXRoLCAiQ2FsbFN0YWNrIik7CkBAIC0yMTQsNiArMjE1 LDEwIEBAIHN1YiBTa2lwRnVuY3Rpb24gewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKKyAg ICBpZiAoJGNvZGVHZW5lcmF0b3ItPkdldEFycmF5VHlwZSgkZnVuY3Rpb25SZXR1cm5UeXBlKSkg eworICAgICAgICByZXR1cm4gMTsKKyAgICB9CisKICAgICAjIFNraXAgZnVuY3Rpb25zIHRoYXQg aGF2ZSBbIkNhbGxiYWNrIl0gcGFyYW1ldGVycywgYmVjYXVzZSB0aGlzCiAgICAgIyBjb2RlIGdl bmVyYXRvciBkb2Vzbid0IGtub3cgaG93IHRvIGF1dG8tZ2VuZXJhdGUgY2FsbGJhY2tzLgogICAg ICMgU2tpcCBmdW5jdGlvbnMgdGhhdCBoYXZlICJNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyIiBwYXJh bWV0ZXJzLCBiZWNhdXNlIHRoaXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmouY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RPYmou Y3BwCShyZXZpc2lvbiAxMTE1MjgpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMs NyArMzMsNiBAQAogI2luY2x1ZGUgIldlYktpdERPTUJpbmRpbmcuaCIKICNpbmNsdWRlICJib29s LmgiCiAjaW5jbHVkZSAiZ29iamVjdC9Db252ZXJ0VG9VVEY4U3RyaW5nLmgiCi0jaW5jbHVkZSAi c2VxdWVuY2U8U2NyaXB0UHJvZmlsZT4uaCIKICNpbmNsdWRlICJ3ZWJraXQvV2ViS2l0RE9NRGlj dGlvbmFyeS5oIgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01EaWN0aW9uYXJ5UHJpdmF0ZS5o IgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01Eb2N1bWVudC5oIgpAQCAtNTksOCArNTgsNiBA QAogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01lLmgiCiAjaW5jbHVkZSAid2Via2l0L1dlYktp dERPTWVQcml2YXRlLmgiCiAjaW5jbHVkZSAid2Via2l0L1dlYktpdERPTXNlcXVlbmNlLmgiCi0j aW5jbHVkZSAid2Via2l0L1dlYktpdERPTXNlcXVlbmNlPFNjcmlwdFByb2ZpbGU+LmgiCi0jaW5j bHVkZSAid2Via2l0L1dlYktpdERPTXNlcXVlbmNlPFNjcmlwdFByb2ZpbGU+UHJpdmF0ZS5oIgog I2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01zZXF1ZW5jZVByaXZhdGUuaCIKICNpbmNsdWRlICJ3 ZWJraXRkZWZpbmVzLmgiCiAjaW5jbHVkZSAid2Via2l0Z2xvYmFsc3ByaXZhdGUuaCIKQEAgLTE3 OSwxNyArMTc2LDYgQEAgd2Via2l0X2RvbV90ZXN0X29ial9tZXRob2Rfd2l0aF9zZXF1ZW5jZQog ICAgIGl0ZW0tPm1ldGhvZFdpdGhTZXF1ZW5jZUFyZyhjb252ZXJ0ZWRfKTsKIH0KIAotV2ViS2l0 RE9Nc2VxdWVuY2U8U2NyaXB0UHJvZmlsZT4qCi13ZWJraXRfZG9tX3Rlc3Rfb2JqX21ldGhvZF9y ZXR1cm5pbmdfc2VxdWVuY2UoV2ViS2l0RE9NVGVzdE9iaiogc2VsZiwgZ2xvbmcgaW50X2FyZykK LXsKLSAgICBnX3JldHVybl92YWxfaWZfZmFpbChzZWxmLCAwKTsKLSAgICBXZWJDb3JlOjpKU01h aW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7Ci0gICAgV2ViQ29yZTo6VGVzdE9iaiAqIGl0ZW0gPSBX ZWJLaXQ6OmNvcmUoc2VsZik7Ci0gICAgUGFzc1JlZlB0cjxXZWJDb3JlOjpzZXF1ZW5jZTxTY3Jp cHRQcm9maWxlPj4gZ19yZXMgPSBXVEY6OmdldFB0cihpdGVtLT5tZXRob2RSZXR1cm5pbmdTZXF1 ZW5jZShpbnRfYXJnKSk7Ci0gICAgV2ViS2l0RE9Nc2VxdWVuY2U8U2NyaXB0UHJvZmlsZT4qIHJl cyA9IFdlYktpdDo6a2l0KGdfcmVzLmdldCgpKTsKLSAgICByZXR1cm4gcmVzOwotfQotCiBXZWJL aXRET01UZXN0T2JqKgogd2Via2l0X2RvbV90ZXN0X29ial9tZXRob2RfdGhhdF9yZXF1aXJlc19h bGxfYXJnc19hbmRfdGhyb3dzKFdlYktpdERPTVRlc3RPYmoqIHNlbGYsIGNvbnN0IGdjaGFyKiBz dHJfYXJnLCBXZWJLaXRET01UZXN0T2JqKiBvYmpfYXJnLCBHRXJyb3IgKiplcnJvcikKIHsKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERP TVRlc3RPYmouaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvR09iamVjdC9XZWJLaXRET01UZXN0T2JqLmgJKHJldmlzaW9uIDExMTUyOCkKKysrIFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9HT2JqZWN0L1dlYktpdERPTVRlc3RP YmouaAkod29ya2luZyBjb3B5KQpAQCAtMTI3LDE3ICsxMjcsNiBAQCBXRUJLSVRfQVBJIHZvaWQK IHdlYmtpdF9kb21fdGVzdF9vYmpfbWV0aG9kX3dpdGhfc2VxdWVuY2VfYXJnKFdlYktpdERPTVRl c3RPYmoqIHNlbGYsIFdlYktpdERPTXNlcXVlbmNlKiApOwogCiAvKioKLSAqIHdlYmtpdF9kb21f dGVzdF9vYmpfbWV0aG9kX3JldHVybmluZ19zZXF1ZW5jZToKLSAqIEBzZWxmOiBBICNXZWJLaXRE T01UZXN0T2JqCi0gKiBAaW50X2FyZzogQSAjZ2xvbmcKLSAqCi0gKiBSZXR1cm5zOiAodHJhbnNm ZXIgbm9uZSk6Ci0gKgotKiovCi1XRUJLSVRfQVBJIFdlYktpdERPTXNlcXVlbmNlPFNjcmlwdFBy b2ZpbGU+Kgotd2Via2l0X2RvbV90ZXN0X29ial9tZXRob2RfcmV0dXJuaW5nX3NlcXVlbmNlKFdl YktpdERPTVRlc3RPYmoqIHNlbGYsIGdsb25nIGludF9hcmcpOwotCi0vKioKICAqIHdlYmtpdF9k b21fdGVzdF9vYmpfbWV0aG9kX3RoYXRfcmVxdWlyZXNfYWxsX2FyZ3NfYW5kX3Rocm93czoKICAq IEBzZWxmOiBBICNXZWJLaXRET01UZXN0T2JqCiAgKiBAc3RyX2FyZzogQSAjZ2NoYXIK