81756 2012-03-21 03:58:50 -0700 Web Inspector: HeapSnapshot: make _bfs twice as fast as the old version. 2012-03-21 06:40:53 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 78411 0 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 583966 0 loislo 2012-03-21 03:58:50 -0700 %subj% patch to follow 583968 1 133005 loislo 2012-03-21 04:03:00 -0700 Created attachment 133005 Patch 583971 2 133005 yurys 2012-03-21 04:09:02 -0700 Comment on attachment 133005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133005&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:1023 > + if (typeof this._distancesToWindow[childNodeIndex] !== "undefined") if (childNodeIndex in this._distanceToWindow) ? 583989 3 loislo 2012-03-21 04:29:58 -0700 Committed r111522: <http://trac.webkit.org/changeset/111522> 133005 2012-03-21 04:03:00 -0700 2012-03-21 04:09:02 -0700 Patch bug-81756-20120321120259.patch text/plain 3346 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBiMjY2YzEyYzU5MzE0 OGIyMWIwNzc0MzdlZTBkYWVmZGZmOGY5Yy4uZDhkMjRiYzhmNWUyNTI4OTc4MWI4OWQ5NGJlMTNh NzMyY2M3MjcwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEyLTAzLTIxICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5zcGVj dG9yOiBIZWFwU25hcHNob3Q6IG1ha2UgX2JmcyB0d2ljZSBhcyBmYXN0IGFzIHRoZSBvbGQgdmVy c2lvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgx NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5IZWFwU25hcHNob3QucHJvdG90eXBlLl9jYWxjdWxhdGVPYmplY3RUb1dpbmRvd0Rpc3RhbmNl KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlLl9iZnMpOgor CisyMDEyLTAzLTIxICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBIZWFwUHJvZmlsZXI6IHN1cHBvcnQgZGlzdGFuY2UgY29s dW1uIGluIFN1bW1hcnkgVmlldy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgxNjc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9IZWFwU25hcHNob3QuanMKaW5kZXggMDViNzg4ZGJjNDk0ZTUxZTIwNDc3NTYxNDcx NDdiZjMyZjAxMzk3Yi4uOTVmMWVjNmJiZmJmYjhhZWE2NjM2OWYwMjY5NDdkNmIxOGZmZTAwYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo b3QuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo b3QuanMKQEAgLTk5MSwxNiArOTkxLDE3IEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJv dG90eXBlID0gewogICAgICAgICAvLyBiZnMgZm9yIFdpbmRvdyByb290cwogICAgICAgICB2YXIg bGlzdCA9IFtdOwogICAgICAgICBmb3IgKHZhciBpdGVyID0gdGhpcy5yb290Tm9kZS5lZGdlczsg aXRlci5oYXNOZXh0KCk7IGl0ZXIubmV4dCgpKSB7Ci0gICAgICAgICAgICBpZiAoaXRlci5lZGdl Lm5vZGUuaXNXaW5kb3cpIHsKLSAgICAgICAgICAgICAgICBsaXN0LnB1c2goaXRlci5lZGdlLm5v ZGUpOwotICAgICAgICAgICAgICAgIHRoaXMuX2Rpc3RhbmNlc1RvV2luZG93W2l0ZXIuZWRnZS5u b2RlLm5vZGVJbmRleF0gPSAwOworICAgICAgICAgICAgdmFyIG5vZGUgPSBpdGVyLmVkZ2Uubm9k ZTsKKyAgICAgICAgICAgIGlmIChub2RlLmlzV2luZG93KSB7CisgICAgICAgICAgICAgICAgbGlz dC5wdXNoKG5vZGUubm9kZUluZGV4KTsKKyAgICAgICAgICAgICAgICB0aGlzLl9kaXN0YW5jZXNU b1dpbmRvd1tub2RlLm5vZGVJbmRleF0gPSAwOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAg ICAgICAgIHRoaXMuX2JmcyhsaXN0KTsKIAogICAgICAgICAvLyBiZnMgZm9yIHJvb3QKICAgICAg ICAgbGlzdCA9IFtdOwotICAgICAgICBsaXN0LnB1c2godGhpcy5yb290Tm9kZSk7CisgICAgICAg IGxpc3QucHVzaCh0aGlzLl9yb290Tm9kZUluZGV4KTsKICAgICAgICAgdGhpcy5fZGlzdGFuY2Vz VG9XaW5kb3dbdGhpcy5yb290Tm9kZS5ub2RlSW5kZXhdID0gMDsKICAgICAgICAgdGhpcy5fYmZz KGxpc3QpOwogICAgIH0sCkBAIC0xMDA4LDIwICsxMDA5LDIxIEBAIFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3QucHJvdG90eXBlID0gewogICAgIF9iZnM6IGZ1bmN0aW9uKGxpc3QpCiAgICAgewog ICAgICAgICB2YXIgaW5kZXggPSAwOworICAgICAgICB2YXIgbm9kZSA9IHRoaXMucm9vdE5vZGU7 CiAgICAgICAgIHdoaWxlIChpbmRleCA8IGxpc3QubGVuZ3RoKSB7Ci0gICAgICAgICAgICB2YXIg bm9kZSA9IGxpc3RbaW5kZXgrK107IC8vIHNoaWZ0IGdlbmVyYXRlcyB0b28gbXVjaCBnYXJiYWdl LgorICAgICAgICAgICAgdmFyIG5vZGVJbmRleCA9IGxpc3RbaW5kZXgrK107IC8vIHNoaWZ0IGdl bmVyYXRlcyB0b28gbXVjaCBnYXJiYWdlLgogICAgICAgICAgICAgaWYgKGluZGV4ID4gMTAwMDAw KSB7CiAgICAgICAgICAgICAgICAgbGlzdCA9IGxpc3Quc2xpY2UoaW5kZXgpOwogICAgICAgICAg ICAgICAgIGluZGV4ID0gMDsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHZhciBkaXN0YW5j ZSA9IHRoaXMuX2Rpc3RhbmNlc1RvV2luZG93W25vZGUubm9kZUluZGV4XSArIDE7CisgICAgICAg ICAgICB2YXIgZGlzdGFuY2UgPSB0aGlzLl9kaXN0YW5jZXNUb1dpbmRvd1tub2RlSW5kZXhdICsg MTsKKyAgICAgICAgICAgIG5vZGUubm9kZUluZGV4ID0gbm9kZUluZGV4OwogICAgICAgICAgICAg Zm9yICh2YXIgaXRlciA9IG5vZGUuZWRnZXM7IGl0ZXIuaGFzTmV4dCgpOyBpdGVyLm5leHQoKSkg ewotICAgICAgICAgICAgICAgIHZhciBlZGdlID0gaXRlci5lZGdlOwotICAgICAgICAgICAgICAg IHZhciBjaGlsZE5vZGUgPSBlZGdlLm5vZGU7Ci0gICAgICAgICAgICAgICAgaWYgKHR5cGVvZiB0 aGlzLl9kaXN0YW5jZXNUb1dpbmRvd1tjaGlsZE5vZGUubm9kZUluZGV4XSAhPT0gInVuZGVmaW5l ZCIpCisgICAgICAgICAgICAgICAgdmFyIGNoaWxkTm9kZUluZGV4ID0gaXRlci5lZGdlLm5vZGVJ bmRleDsKKyAgICAgICAgICAgICAgICBpZiAodHlwZW9mIHRoaXMuX2Rpc3RhbmNlc1RvV2luZG93 W2NoaWxkTm9kZUluZGV4XSAhPT0gInVuZGVmaW5lZCIpCiAgICAgICAgICAgICAgICAgICAgIGNv bnRpbnVlOwotICAgICAgICAgICAgICAgIHRoaXMuX2Rpc3RhbmNlc1RvV2luZG93W2NoaWxkTm9k ZS5ub2RlSW5kZXhdID0gZGlzdGFuY2U7Ci0gICAgICAgICAgICAgICAgbGlzdC5wdXNoKGNoaWxk Tm9kZSk7CisgICAgICAgICAgICAgICAgdGhpcy5fZGlzdGFuY2VzVG9XaW5kb3dbY2hpbGROb2Rl SW5kZXhdID0gZGlzdGFuY2U7CisgICAgICAgICAgICAgICAgbGlzdC5wdXNoKGNoaWxkTm9kZUlu ZGV4KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0sCg==