81726 2012-03-20 19:46:48 -0700 [BlackBerry] Remove redundant code in SocketStreamHandler 2012-03-21 00:30:21 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei jonathan.dong.webkit leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 583717 0 charles.wei 2012-03-20 19:46:48 -0700 platform/network/blackberry/SocketStreamHandle.h void didReceiveAuthenticationChallenge(const AuthenticationChallenge&); void receivedCredential(const AuthenticationChallenge&, const Credential&); void receivedRequestToContinueWithoutCredential(const AuthenticationChallenge&); void receivedCancellation(const AuthenticationChallenge&); are not needed and not called from anywhere, with empty implementation. Need to remove them since that's what MAC and CURL network porting uses, we use different mechanism for authentication. 583722 1 132951 charles.wei 2012-03-20 19:56:54 -0700 Created attachment 132951 Patch to remove redundant code in SocketStreamHandle 583725 2 charles.wei 2012-03-20 20:03:49 -0700 Internal: 145049 583872 3 132951 webkit.review.bot 2012-03-21 00:30:16 -0700 Comment on attachment 132951 Patch to remove redundant code in SocketStreamHandle Clearing flags on attachment: 132951 Committed r111507: <http://trac.webkit.org/changeset/111507> 583873 4 webkit.review.bot 2012-03-21 00:30:21 -0700 All reviewed patches have been landed. Closing bug. 132951 2012-03-20 19:56:54 -0700 2012-03-21 00:30:16 -0700 Patch to remove redundant code in SocketStreamHandle 0001-BlackBerry-Remove-redundant-code-in-SocketStreamHand.patch text/plain 3757 charles.wei RnJvbSBiMDkwZmVlMTI5MmVhMzkzMWJjYjIzYTUxZTFkNzZhMDE5N2QxZDkyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBXZWQsIDIxIE1hciAyMDEyIDEwOjU4OjE3ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIFJlbW92ZSByZWR1bmRhbnQgY29kZSBpbiBTb2NrZXRTdHJlYW1I YW5kbGVyCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE3MjYKClJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKTm8gbmV3IHRlc3RzIG5lZWRlZC4gSnVzdCByZW1v dmUgcmVkdW5kYW50IGNvZGUuCgoqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9Tb2NrZXRT dHJlYW1IYW5kbGUuaDoKKFNvY2tldFN0cmVhbUhhbmRsZSk6CiogcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L1NvY2tldFN0cmVhbUhhbmRsZUJsYWNrQmVycnkuY3BwOgotLS0KIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysr KysrKysKIC4uLi9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlLmggICAgICAg IHwgICAgNiAtLS0tLQogLi4uL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlQmxhY2tCZXJy eS5jcHAgICAgfCAgIDIxIC0tLS0tLS0tLS0tLS0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDEz IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ZWQ0YjEzLi5l OWZiYjEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMjAgIENoYXJsZXMg V2VpICA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBSZW1vdmUgcmVkdW5kYW50IGNvZGUgaW4gU29ja2V0U3RyZWFtSGFuZGxlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE3MjYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVl ZGVkLiBKdXN0IHJlbW92ZSByZWR1bmRhbnQgY29kZS4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9Tb2NrZXRTdHJlYW1IYW5kbGUuaDoKKyAgICAgICAgKFNvY2tldFN0 cmVhbUhhbmRsZSk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1NvY2tl dFN0cmVhbUhhbmRsZUJsYWNrQmVycnkuY3BwOgorCiAyMDEyLTAzLTIwICBXLiBKYW1lcyBNYWNM ZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIENvbnZl cnQgVG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlIHRvIGEgMi1EIEJlemllciBmb3IgYmV0 dGVyIGNvbnRyb2wgb2YgY3VydmUgc2hhcGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlLmgK aW5kZXggY2MzZWQ3Yi4uNzNiMTE4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9ibGFja2JlcnJ5L1NvY2tldFN0cmVhbUhhbmRsZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9Tb2NrZXRTdHJlYW1IYW5kbGUuaApA QCAtNjUsMTIgKzY1LDYgQEAgcHJvdGVjdGVkOgogcHJpdmF0ZToKICAgICBTb2NrZXRTdHJlYW1I YW5kbGUoY29uc3QgU3RyaW5nJiBncm91cE5hbWUsIGNvbnN0IEtVUkwmLCBTb2NrZXRTdHJlYW1I YW5kbGVDbGllbnQqKTsKIAotICAgIC8vIE5vIGF1dGhlbnRpY2F0aW9uIGZvciBzdHJlYW1zIHBl ciBzZSwgYnV0IHByb3h5IG1heSBhc2sgZm9yIGNyZWRlbnRpYWxzLgotICAgIHZvaWQgZGlkUmVj ZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdl Jik7Ci0gICAgdm9pZCByZWNlaXZlZENyZWRlbnRpYWwoY29uc3QgQXV0aGVudGljYXRpb25DaGFs bGVuZ2UmLCBjb25zdCBDcmVkZW50aWFsJik7Ci0gICAgdm9pZCByZWNlaXZlZFJlcXVlc3RUb0Nv bnRpbnVlV2l0aG91dENyZWRlbnRpYWwoY29uc3QgQXV0aGVudGljYXRpb25DaGFsbGVuZ2UmKTsK LSAgICB2b2lkIHJlY2VpdmVkQ2FuY2VsbGF0aW9uKGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxl bmdlJik7Ci0KICAgICBPd25QdHI8QmxhY2tCZXJyeTo6UGxhdGZvcm06OkZpbHRlclN0cmVhbT4g bV9zb2NrZXRTdHJlYW07CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlQmxhY2tCZXJyeS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFu ZGxlQmxhY2tCZXJyeS5jcHAKaW5kZXggN2UyMGUxNy4uMGZkMGU2OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1NvY2tldFN0cmVhbUhhbmRs ZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxh Y2tiZXJyeS9Tb2NrZXRTdHJlYW1IYW5kbGVCbGFja0JlcnJ5LmNwcApAQCAtMzYsNyArMzYsNiBA QAogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5oIgogI2luY2x1ZGUgIktV UkwuaCIKICNpbmNsdWRlICJMb2dnaW5nLmgiCi0jaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIK ICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiUGFnZUNsaWVudEJsYWNrQmVycnkuaCIKICNp bmNsdWRlICJQYWdlR3JvdXAuaCIKQEAgLTk4LDI2ICs5Nyw2IEBAIHZvaWQgU29ja2V0U3RyZWFt SGFuZGxlOjpwbGF0Zm9ybUNsb3NlKCkKICAgICBtX3NvY2tldFN0cmVhbS0+c3RyZWFtQ2xvc2Uo KTsKIH0KIAotdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGU6OmRpZFJlY2VpdmVBdXRoZW50aWNhdGlv bkNoYWxsZW5nZShjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYpCi17Ci0gICAgbm90SW1w bGVtZW50ZWQoKTsKLX0KLQotdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGU6OnJlY2VpdmVkQ3JlZGVu dGlhbChjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYsIGNvbnN0IENyZWRlbnRpYWwmKQot ewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci19Ci0KLXZvaWQgU29ja2V0U3RyZWFtSGFuZGxlOjpy ZWNlaXZlZFJlcXVlc3RUb0NvbnRpbnVlV2l0aG91dENyZWRlbnRpYWwoY29uc3QgQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UmKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci19Ci0KLXZvaWQgU29j a2V0U3RyZWFtSGFuZGxlOjpyZWNlaXZlZENhbmNlbGxhdGlvbihjb25zdCBBdXRoZW50aWNhdGlv bkNoYWxsZW5nZSYpCi17Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLX0KLQogLy8gRmlsdGVyU3Ry ZWFtIGludGVyZmFjZQogCiB2b2lkIFNvY2tldFN0cmVhbUhhbmRsZTo6bm90aWZ5U3RhdHVzUmVj ZWl2ZWQoaW50IHN0YXR1cywgY29uc3QgY2hhciogbWVzc2FnZSkKLS0gCjEuNy45LjEKCg==