81713 2012-03-20 16:14:48 -0700 [chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape. 2012-03-20 19:06:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wjmaclean wjmaclean davemoore enne jamesr rjkroege webkit.review.bot oldest_to_newest 583567 0 wjmaclean 2012-03-20 16:14:48 -0700 [chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape. 583582 1 132924 wjmaclean 2012-03-20 16:23:22 -0700 Created attachment 132924 Patch 583587 2 wjmaclean 2012-03-20 16:24:20 -0700 (In reply to comment #1) > Created an attachment (id=132924) [details] > Patch The patch to rename this class will follow (maybe tomorrow morning at this point). 583676 3 132924 nduca 2012-03-20 18:18:13 -0700 Comment on attachment 132924 Patch Unofficially LGTM. Does @davemoore <3 this? 583679 4 132924 dpranke 2012-03-20 18:20:29 -0700 Comment on attachment 132924 Patch stylistically the patch looks fine; normally I wouldn't touch a patch in this area with a ten foot pole, but nduca says it looks good ... 583680 5 wjmaclean 2012-03-20 18:23:45 -0700 (In reply to comment #3) > (From update of attachment 132924 [details]) > Unofficially LGTM. Does @davemoore <3 this? Yes, Dave has seen and thought it was good (not to speak for him of course!). Rob and Alex and I are happier with it than any of the other candidates - it feels pretty good. 583699 6 132924 webkit.review.bot 2012-03-20 19:06:28 -0700 Comment on attachment 132924 Patch Clearing flags on attachment: 132924 Committed r111483: <http://trac.webkit.org/changeset/111483> 583700 7 webkit.review.bot 2012-03-20 19:06:32 -0700 All reviewed patches have been landed. Closing bug. 132924 2012-03-20 16:23:22 -0700 2012-03-20 19:06:28 -0700 Patch bug-81713-20120320192321.patch text/plain 5763 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU2NDg5NTNlM2Y1NjZh MmRlYjE4MDE0NWQxYjg4OGFiNjVjMDc2Mi4uYTgwYzU3YWEzYWUxY2I3NTBlNzYxMTFhNzJmZmQw NmUwNTkzZDc5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAzLTIwICBXLiBK YW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21p dW1dIENvbnZlcnQgVG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlIHRvIGEgMi1EIEJlemll ciBmb3IgYmV0dGVyIGNvbnRyb2wgb2YgY3VydmUgc2hhcGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTcxMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4aXNpdGluZyB1bml0IHRlc3QgcmV2aXNlZCB0 byBjb3ZlciB0aGlzIGNoYW5nZS4KKworICAgICAgICBDaGFuZ2UgdGhlIGZsaW5nIGdlc3R1cmUg YW5pbWF0aW9uIGN1cnZlIHRvIHVzZSBhIDItRCBCZXppZXIgdG8gb2J0YWluIGdyZWF0ZXIgY29u dHJvbAorICAgICAgICBvdmVyIHRoZSBzaGFwZSBvZiB0aGUgY3VydmUuIEFsc28sIGNoYW5nZSB0 aW1lIHNjYWxpbmcgY29kZSB0byBiZSBsb2dhcml0aG1pYyBmb3IgbW9yZQorICAgICAgICBuYXR1 cmFsIGZlZWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Ub3VjaEZsaW5nUGxhdGZvcm1HZXN0dXJl Q3VydmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1 cnZlOjpUb3VjaEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUpOgorICAgICAgICAoV2ViQ29yZTo6 VG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjphcHBseSk6CisKIDIwMTItMDMtMjAgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IGJlNGViYmE0Mzc4NDM4ZmQ2MGE4MjJjMjU1ZjE4ODVh NWU0ODdhNTAuLjdkZWFlMzU3OTgyMDcwMDEwZWEzMzk4M2RmNjY3NjFmMGM1MTNlNzMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTItMDMtMjAgIFcuIEph bWVzIE1hY0xlYW4gIDx3am1hY2xlYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFtjaHJvbWl1 bV0gQ29udmVydCBUb3VjaEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUgdG8gYSAyLUQgQmV6aWVy IGZvciBiZXR0ZXIgY29udHJvbCBvZiBjdXJ2ZSBzaGFwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9QbGF0Zm9ybUdlc3R1cmVDdXJ2ZVRl c3QuY3BwOgorCisyMDEyLTAzLTIwICBXLiBKYW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9t aXVtLm9yZz4KKwogICAgICAgICBbY2hyb21pdW1dIFR1bmUgZmxpbmcgcGh5c2ljcyBjdXJ2ZS4g W05vdCBmb3IgcmV2aWV3IHlldF0KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgxMzk4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1RvdWNoRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9Ub3VjaEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUuY3BwCmluZGV4IDQzZGJmMGFjNmYx ZDk3MTNhNjNhNmZkZjBlYzE2NzYyMTg1NjZhZmUuLjhhODlhMmIyNjFhNDAwYjhhMzRjYzRhYmEz MDA0MjI4NzcyMzliYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RvdWNo RmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vVG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlLmNwcApAQCAtMjcsNiArMjcsNyBAQAog I2luY2x1ZGUgIlRvdWNoRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5oIgogCiAjaW5jbHVkZSAi UGxhdGZvcm1HZXN0dXJlQ3VydmVUYXJnZXQuaCIKKyNpbmNsdWRlICJVbml0QmV6aWVyLmgiCiAj aW5jbHVkZSA8bWF0aC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC00MCw3ICs0MSw3IEBA IFBhc3NPd25QdHI8UGxhdGZvcm1HZXN0dXJlQ3VydmU+IFRvdWNoRmxpbmdQbGF0Zm9ybUdlc3R1 cmVDdXJ2ZTo6Y3JlYXRlKGNvbnN0IEZsCiAKIFRvdWNoRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2 ZTo6VG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlKGNvbnN0IEZsb2F0UG9pbnQmIHZlbG9j aXR5KQogICAgIDogbV92ZWxvY2l0eSh2ZWxvY2l0eSkKLSAgICAsIG1fdGltZVNjYWxlRmFjdG9y KDEwMDAgLyBtYXgoMS5mLCBtYXgoZmFicyh2ZWxvY2l0eS54KCkpLCBmYWJzKHZlbG9jaXR5Lnko KSkpKSkKKyAgICAsIG1fdGltZVNjYWxlRmFjdG9yKDMgLyBsb2cxMChtYXgoMTAuZiwgbWF4KGZh YnModmVsb2NpdHkueCgpKSwgZmFicyh2ZWxvY2l0eS55KCkpKSkpKQogewogICAgIEFTU0VSVCh2 ZWxvY2l0eSAhPSBGbG9hdFBvaW50Ojp6ZXJvKCkpOwogfQpAQCAtNTEsMjYgKzUyLDIxIEBAIFRv dWNoRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6flRvdWNoRmxpbmdQbGF0Zm9ybUdlc3R1cmVD dXJ2ZSgpCiAKIGJvb2wgVG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjphcHBseShkb3Vi bGUgdGltZSwgUGxhdGZvcm1HZXN0dXJlQ3VydmVUYXJnZXQqIHRhcmdldCkKIHsKLSAgICAvLyBI ZXJlIHdlIGltcGxlbWVudCBhIGN1YmljIGJlemllciBjdXJ2ZSB3aXRoIHBhcmFtZXRlcnMgW3Aw IHAxIHAyIHAzXSA9IFsxICgzICsgMS90YXUpIDAgMF0gd2hpY2ggZ2l2ZXMKLSAgICAvLyB2KDAp ID0gMSwgYSgwKSA9IHYoMCkvdGF1LCB2KDEpID0gMCwgYSgxKSA9IDAuIFRoZSBjdXJ2ZSBpcyBz Y2FsZWQgYnkgdGhlIGluaXRpYWwKLSAgICAvLyB2ZWxvY2l0eSwgYW5kIHRoZSB0aW1lIHBhcmFt ZXRlciBpcyByZS1zY2FsZWQgc28gdGhhdCBsYXJnZXIgaW5pdGlhbCB2ZWxvY2l0aWVzCi0gICAg Ly8gbGVhZCB0byBsb25nZXIgaW5pdGlhbCBhbmltYXRpb25zLiBUaGlzIHNob3VsZCBhbGxvdyB0 aGUgYW5pbWF0aW9uIHRvIHNtb290aGx5Ci0gICAgLy8gY29udGludWUgdGhlIHZlbG9jaXR5IGF0 IHRoZSBlbmQgb2YgdGhlIEdlc3R1cmVTY3JvbGwsIGFuZCBzbW9vdGhseSBjb21lIHRvIGEgcmVz dAotICAgIC8vIGF0IHRoZSBlbmQuIEZpbmFsbHksIHdlIGhhdmUgaW50ZWdyYXRlZCB0aGUgY3Vy dmUgc28gd2UgY2FuIGRlYWwgd2l0aCBkaXNwbGFjZW1lbnQKLSAgICAvLyBhcyBhIGZ1bmN0aW9u IG9mIHRpbWUsIGFuZCBub3QgdmVsb2NpdHkuCisgICAgLy8gVXNlIDItRCBCZXppZXIgY3VydmUg d2l0aCBhICJzdHJldGNoZWQtaXRhbGljLXMiIGN1cnZlLgorICAgIC8vIFdlIHNjYWxlIHRpbWUg bG9nYXJpdGhtaWNhbGx5IGFzIHRoaXMgKHN1YmplY3RpdmVseSkgZmVlbHMgYmV0dGVyLgogICAg IHRpbWUgKj0gbV90aW1lU2NhbGVGYWN0b3I7CiAKLSAgICBzdGF0aWMgZG91YmxlIHRhdSA9IDAu MjU7Ci0gICAgc3RhdGljIGRvdWJsZSBwMSA9ICAzLjAgKyAxIC8gdGF1OwotICAgIC8vIE5vdGU6 ICJkaXNwbGFjZW1lbnQiIGJlbG93IGlzIHRoZSBpbnRlZ3JhbCBvZiB0aGUgY3ViaWMgYmV6aWVy IGN1cnZlIGRlZmluZWQgYnkgW3AwIHAxIHAyIHAzXS4KKyAgICBzdGF0aWMgVW5pdEJlemllciBm bGluZ0JlemllcigwLjMzMzMsIDAuNjY2NiwgMC42NjY2LCAxKTsKIAogICAgIGZsb2F0IGRpc3Bs YWNlbWVudDsKICAgICBpZiAodGltZSA8IDApCiAgICAgICAgIGRpc3BsYWNlbWVudCA9IDA7Ci0g ICAgZWxzZSBpZiAodGltZSA8IDEpCi0gICAgICAgIGRpc3BsYWNlbWVudCA9IHRpbWUgKiAodGlt ZSAqICh0aW1lICogKHRpbWUgKiAwLjI1ICogKDMgKiBwMSAtIDEuMCkgKyAoMSAtIDIgKiBwMSkp ICsgMS41ICogKHAxIC0gMSkpICsgMSkgLyBtX3RpbWVTY2FsZUZhY3RvcjsKLSAgICBlbHNlCi0g ICAgICAgIGRpc3BsYWNlbWVudCA9ICgxICsgKHAxIC0gMSkgKiAxLjUgKyAoMSAtIDIgKiBwMSkg KyAoMyAqIHAxIC0gMSkgKiAwLjI1KSAvIG1fdGltZVNjYWxlRmFjdG9yOworICAgIGVsc2UgaWYg KHRpbWUgPCAxKSB7CisgICAgICAgIC8vIEJlbG93LCBzIGlzIHRoZSBjdXJ2ZSBwYXJhbWV0ZXIg Zm9yIHRoZSAyLUQgQmV6aWVyIGN1cnZlICh0aW1lKHMpLCBkaXNwbGFjZW1lbnQocykpLgorICAg ICAgICBkb3VibGUgcyA9IGZsaW5nQmV6aWVyLnNvbHZlQ3VydmVYKHRpbWUsIDEuZS0zKTsKKyAg ICAgICAgZGlzcGxhY2VtZW50ID0gZmxpbmdCZXppZXIuc2FtcGxlQ3VydmVZKHMpOworICAgIH0g ZWxzZQorICAgICAgICBkaXNwbGFjZW1lbnQgPSAxOwogCiAgICAgLy8gS2VlcCB0cmFjayBvZiBp bnRlZ2VyIHBvcnRpb24gb2Ygc2Nyb2xsIHRodXMgZmFyLCBhbmQgcHJlcGFyZSBpbmNyZW1lbnQu CiAgICAgSW50UG9pbnQgc2Nyb2xsKGRpc3BsYWNlbWVudCAqIG1fdmVsb2NpdHkueCgpLCBkaXNw bGFjZW1lbnQgKiBtX3ZlbG9jaXR5LnkoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL1BsYXRmb3JtR2VzdHVyZUN1cnZlVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL1BsYXRmb3JtR2VzdHVyZUN1cnZlVGVzdC5jcHAKaW5kZXggNzE2Zjcw ZTAyNzY2YTEwOWFlODI0ZGUwMmM0ZGM2ZjI1YWViYzEyOS4uMjk4NTc5MWRiNGQ4MzViNTU4OTQ4 MDUxNWI2YWE3NzUzOWJiMWFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9QbGF0Zm9ybUdlc3R1cmVDdXJ2ZVRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vdGVzdHMvUGxhdGZvcm1HZXN0dXJlQ3VydmVUZXN0LmNwcApAQCAtMTAwLDcgKzEwMCw3 IEBAIFRFU1QoUGxhdGZvcm1HZXN0dXJlQ3VydmUsIGZsaW5nQ3VydmUpCiBURVNUKFBsYXRmb3Jt R2VzdHVyZUN1cnZlLCBmbGluZ0N1cnZlVG91Y2gpCiB7CiAgICAgZG91YmxlIGluaXRpYWxWZWxv Y2l0eSA9IDEwMDA7Ci0gICAgY29uc3QgZG91YmxlIHRvdWNoRmxpbmdDdXJ2ZUFyZWFGYWN0b3Ig PSAyOyAvLyBEZXBlbmRzIG9uIHZhbHVlIG9mIHRhdSBpbiBUb3VjaEZsaW5nUGxhdGZvcm1HZXN0 dXJlQ3VydmUuCisgICAgY29uc3QgZG91YmxlIHRvdWNoRmxpbmdDdXJ2ZUFyZWFGYWN0b3IgPSAx OyAvLyBEZXBlbmRzIG9uIHBhcmFtZXRlcml6YXRpb24gaW4gVG91Y2hGbGluZ1BsYXRmb3JtR2Vz dHVyZUN1cnZlLgogICAgIE1vY2tQbGF0Zm9ybUdlc3R1cmVDdXJ2ZVRhcmdldCB0YXJnZXQ7CiAg ICAgT3duUHRyPEFjdGl2ZVBsYXRmb3JtR2VzdHVyZUFuaW1hdGlvbj4gYW5pbWF0aW9uID0gQWN0 aXZlUGxhdGZvcm1HZXN0dXJlQW5pbWF0aW9uOjpjcmVhdGUoVG91Y2hGbGluZ1BsYXRmb3JtR2Vz dHVyZUN1cnZlOjpjcmVhdGUoRmxvYXRQb2ludChpbml0aWFsVmVsb2NpdHksIDApKSwgJnRhcmdl dCk7CiAK