81674 2012-03-20 09:41:08 -0700 [Qt][WK2] Item cannot be selected from select list in touch webview 2012-03-21 04:43:59 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dinu.jacob webkit-unassigned menard webkit.review.bot zoltan oldest_to_newest 583149 0 dinu.jacob 2012-03-20 09:41:08 -0700 Cannot select an item a from a select list. 583154 1 dinu.jacob 2012-03-20 09:43:42 -0700 Touch webview grabs focus in touc event handler as the itemSelector qml component is not handling the touch event. Need to set the flag to ignore touch event in qquickwebview when displaying the select list (the flag was set earler in https://bugs.webkit.org/show_bug.cgi?id=79738 for the other dialogs that uses QtDialogRunner in qquickwebview) 583156 2 132840 dinu.jacob 2012-03-20 09:47:28 -0700 Created attachment 132840 Patch 583996 3 132840 webkit.review.bot 2012-03-21 04:43:55 -0700 Comment on attachment 132840 Patch Clearing flags on attachment: 132840 Committed r111523: <http://trac.webkit.org/changeset/111523> 583997 4 webkit.review.bot 2012-03-21 04:43:59 -0700 All reviewed patches have been landed. Closing bug. 132840 2012-03-20 09:47:28 -0700 2012-03-21 04:43:55 -0700 Patch 81674.patch text/plain 3974 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5YzRhYmMyLi5hNzc1MWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMDMtMjAgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1dLMl0gSXRlbSBjYW5ub3QgYmUgc2VsZWN0ZWQgZnJvbSBzZWxlY3QgbGlzdCBp biB0b3VjaCB3ZWJ2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MTY3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFjdGl2YXRlIGZsYWcgdG8gcHJldmVudCBRUXVpY2tXZWJWaWV3IGZyb20gYWNjZXB0 aW5nIHRvdWNoIGV2ZW50IHdoZW4gc2VsZWN0CisgICAgICAgIGRpYWxvZyBpcyBiZWluZyBkaXNw bGF5ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwOgor ICAgICAgICAoUVF1aWNrV2ViVmlld1ByaXZhdGU6OlFRdWlja1dlYlZpZXdQcml2YXRlKToKKyAg ICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpleGVjRGlhbG9nUnVubmVyKToKKyAgICAgICAg KFFRdWlja1dlYlZpZXc6OnRvdWNoRXZlbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlld19wX3AuaDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpzZXRE aWFsb2dBY3RpdmUpOgorICAgICAgICAoUVF1aWNrV2ViVmlld1ByaXZhdGUpOgorICAgICAgICAq IFVJUHJvY2Vzcy9xdC9XZWJQb3B1cE1lbnVQcm94eVF0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUG9wdXBNZW51UHJveHlRdDo6c2hvd1BvcHVwTWVudSk6CisgICAgICAgIChXZWJLaXQ6Oldl YlBvcHVwTWVudVByb3h5UXQ6OmhpZGVQb3B1cE1lbnUpOgorCiAyMDEyLTAzLTIwICBBbnRhcnlh bWkgUGFuZGlhICA8YW50YXJ5YW1pLnBhbmRpYUBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgW0dU S10gW1dLMl0gQWRkIGphdmFzY3JpcHQgY2xpcGJvYXJkIGZ1bmN0aW9uYWxpdHkgc2V0dGluZ3Mg dG8gV2ViS2l0MiBHVEsrIEFQSS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IGZkYzIwNzMuLjA2ZDA1MmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtODEs NyArODEsNyBAQCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6UVF1aWNrV2ViVmlld1ByaXZhdGUoUVF1 aWNrV2ViVmlldyogdmlld3BvcnQpCiAgICAgLCBtX25hdmlnYXRvclF0T2JqZWN0RW5hYmxlZChm YWxzZSkKICAgICAsIG1fcmVuZGVyVG9PZmZzY3JlZW5CdWZmZXIoZmFsc2UpCiAgICAgLCBtX2xv YWRTdGFydGVkU2lnbmFsU2VudChmYWxzZSkKLSAgICAsIG1fZGlhbG9nUnVubmVyQWN0aXZlKGZh bHNlKQorICAgICwgbV9kaWFsb2dBY3RpdmUoZmFsc2UpCiB7CiAgICAgdmlld3BvcnQtPnNldEZs YWdzKFFRdWlja0l0ZW06Okl0ZW1DbGlwc0NoaWxkcmVuVG9TaGFwZSk7CiAgICAgUU9iamVjdDo6 Y29ubmVjdCh2aWV3cG9ydCwgU0lHTkFMKHZpc2libGVDaGFuZ2VkKCkpLCB2aWV3cG9ydCwgU0xP VChfcV9vblZpc2libGVDaGFuZ2VkKCkpKTsKQEAgLTM2NiwxMCArMzY2LDEwIEBAIHZvaWQgUVF1 aWNrV2ViVmlld1ByaXZhdGU6OmV4ZWNEaWFsb2dSdW5uZXIoUXREaWFsb2dSdW5uZXImIGRpYWxv Z1J1bm5lcikKICAgICBzZXRWaWV3SW5BdHRhY2hlZFByb3BlcnRpZXMoZGlhbG9nUnVubmVyLmRp YWxvZygpKTsKIAogICAgIGRpc2FibGVNb3VzZUV2ZW50cygpOwotICAgIG1fZGlhbG9nUnVubmVy QWN0aXZlID0gdHJ1ZTsKKyAgICBtX2RpYWxvZ0FjdGl2ZSA9IHRydWU7CiAKICAgICBkaWFsb2dS dW5uZXIuZXhlYygpOwotICAgIG1fZGlhbG9nUnVubmVyQWN0aXZlID0gZmFsc2U7CisgICAgbV9k aWFsb2dBY3RpdmUgPSBmYWxzZTsKICAgICBlbmFibGVNb3VzZUV2ZW50cygpOwogfQogCkBAIC0x MzY2LDcgKzEzNjYsNyBAQCB2b2lkIFFRdWlja1dlYlZpZXc6OmZvY3VzT3V0RXZlbnQoUUZvY3Vz RXZlbnQqIGV2ZW50KQogdm9pZCBRUXVpY2tXZWJWaWV3Ojp0b3VjaEV2ZW50KFFUb3VjaEV2ZW50 KiBldmVudCkKIHsKICAgICBRX0QoUVF1aWNrV2ViVmlldyk7Ci0gICAgaWYgKGQtPm1fZGlhbG9n UnVubmVyQWN0aXZlKSB7CisgICAgaWYgKGQtPm1fZGlhbG9nQWN0aXZlKSB7CiAgICAgICAgIGV2 ZW50LT5pZ25vcmUoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAppbmRleCBmNDU2ZDdk Li43NWViNWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnZpZXdfcF9wLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x cXVpY2t3ZWJ2aWV3X3BfcC5oCkBAIC0xMTgsNiArMTE4LDggQEAgcHVibGljOgogCiAgICAgUVJl Y3QgdmlzaWJsZUNvbnRlbnRzUmVjdCgpIGNvbnN0OwogCisgICAgdm9pZCBzZXREaWFsb2dBY3Rp dmUoYm9vbCBhY3RpdmUpIHsgbV9kaWFsb2dBY3RpdmUgPSBhY3RpdmU7IH0KKwogICAgIC8vIFBh Z2VDbGllbnQuCiAgICAgV2ViQ29yZTo6SW50U2l6ZSB2aWV3U2l6ZSgpIGNvbnN0OwogICAgIHZv aWQgZGlkUmVjZWl2ZU1lc3NhZ2VGcm9tTmF2aWdhdG9yUXRPYmplY3QoY29uc3QgU3RyaW5nJiBt ZXNzYWdlKTsKQEAgLTE2Miw3ICsxNjQsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgYm9vbCBtX25hdmln YXRvclF0T2JqZWN0RW5hYmxlZDsKICAgICBib29sIG1fcmVuZGVyVG9PZmZzY3JlZW5CdWZmZXI7 CiAgICAgYm9vbCBtX2xvYWRTdGFydGVkU2lnbmFsU2VudDsKLSAgICBib29sIG1fZGlhbG9nUnVu bmVyQWN0aXZlOworICAgIGJvb2wgbV9kaWFsb2dBY3RpdmU7CiAgICAgUVVybCBtX2ljb25VUkw7 CiAgICAgUVVybCBtX2RlZmVyZWRVcmxUb0xvYWQ7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1dlYlBvcHVwTWVudVByb3h5UXQuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1dlYlBvcHVwTWVudVByb3h5UXQuY3BwCmluZGV4IDRjMGRlYWQuLjI4 YjhhY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9XZWJQb3B1cE1l bnVQcm94eVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvV2ViUG9wdXBN ZW51UHJveHlRdC5jcHAKQEAgLTIzOSwxMSArMjM5LDEzIEBAIHZvaWQgV2ViUG9wdXBNZW51UHJv eHlRdDo6c2hvd1BvcHVwTWVudShjb25zdCBJbnRSZWN0JiByZWN0LCBXZWJDb3JlOjpUZXh0RGly ZWN0CiAgICAgICAgIG5vdGlmeVZhbHVlQ2hhbmdlZCgpOwogICAgICAgICByZXR1cm47CiAgICAg fQorICAgIFFRdWlja1dlYlZpZXdQcml2YXRlOjpnZXQobV93ZWJWaWV3KS0+c2V0RGlhbG9nQWN0 aXZlKHRydWUpOwogfQogCiB2b2lkIFdlYlBvcHVwTWVudVByb3h5UXQ6OmhpZGVQb3B1cE1lbnUo KQogewogICAgIG1faXRlbVNlbGVjdG9yLmNsZWFyKCk7CisgICAgUVF1aWNrV2ViVmlld1ByaXZh dGU6OmdldChtX3dlYlZpZXcpLT5zZXREaWFsb2dBY3RpdmUoZmFsc2UpOwogICAgIG1fY29udGV4 dC5jbGVhcigpOwogICAgIG5vdGlmeVZhbHVlQ2hhbmdlZCgpOwogfQo=