81672 2012-03-20 09:08:33 -0700 [BlackBerry] Allow simulator to use GLES2 acceleration 2013-01-04 02:20:30 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 fspacek webkit-unassigned rwlbuis tonikitoo webkit.review.bot oldest_to_newest 583118 0 fspacek 2012-03-20 09:08:33 -0700 Any hardware acceleration is only enabled on device build. The Simulator now has GLES2 drivers so we should be able to turn it on in simulator too. The patch makes it possible to enable GLES2 support with an environment variable. 583122 1 132837 fspacek 2012-03-20 09:11:52 -0700 Created attachment 132837 proposed patch 583123 2 132837 rwlbuis 2012-03-20 09:15:43 -0700 Comment on attachment 132837 proposed patch LGTM. 583125 3 132837 webkit.review.bot 2012-03-20 09:17:59 -0700 Comment on attachment 132837 proposed patch Rejecting attachment 132837 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ucceeded at 1 with fuzz 3. patching file Source/cmake/OptionsBlackBerry.cmake Hunk #1 FAILED at 19. Hunk #2 succeeded at 121 with fuzz 1. 1 out of 2 hunks FAILED -- saving rejects to file Source/cmake/OptionsBlackBerry.cmake.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12001348 598467 4 136275 mxie 2012-04-09 11:38:21 -0700 Created attachment 136275 Patch 598468 5 136275 rwlbuis 2012-04-09 11:39:30 -0700 Comment on attachment 136275 Patch LGTM. 598680 6 136275 webkit.review.bot 2012-04-09 15:40:19 -0700 Comment on attachment 136275 Patch Clearing flags on attachment: 136275 Committed r113633: <http://trac.webkit.org/changeset/113633> 800113 7 rwlbuis 2013-01-04 02:20:30 -0800 This landed a long time ago, so close. 132837 2012-03-20 09:11:52 -0700 2012-03-20 09:17:59 -0700 proposed patch gles2.diff text/plain 2995 fspacek ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2ZjAwYWQzLi40NjI3MmQ1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTItMDMtMjAgIEZpbGlwIFNwYWNlayAgPGZzcGFjZWtAcmltLmNvbT4KKworICAgICAgICBb QmxhY2tCZXJyeV0gQWxsb3cgR0xFUzIgc3VwcG9ydCB0byBiZSBlbmFibGVkIG9uIHNpbXVsYXRv ciB3aXRoIEVOQUJMRV9HTEVTMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODE2NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZToKKwogMjAx Mi0wMy0xNSAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5 XSBSZW1vdmUgc29tZSBmZWF0dXJlcyB0aGF0IHdlIGRvIG5vdCBoYXZlIGFueW1vcmUKZGlmZiAt LWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZSBiL1NvdXJjZS9jbWFr ZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZQppbmRleCBlNzZkOWNlLi5mZTRhNTQ5IDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21ha2UKKysrIGIvU291cmNlL2Nt YWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCkBAIC0xOSwxMCArMTksMTMgQEAgU0VUKFdURl9V U0VfU0tJQV9URVhUIDEpCiBBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX1NLSUFfVEVYVD0xKQog CiBJRiAoVEFSR0VUSU5HX1BMQVlCT09LKQorICAgIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0Vf QVJFTkFfQUxMT0NfQUxJR05NRU5UX0lOVEVHRVI9MSkKK0VORElGICgpCisKK0lGIChFTkFCTEVf R0xFUzIpCiAgICAgU0VUKFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkcgMSkKICAgICBB RERfREVGSU5JVElPTlMoLURXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HPTEpCiAgICAg QUREX0RFRklOSVRJT05TKC1EQkxBQ0tCRVJSWV9QTEFURk9STV9HUkFQSElDU19FR0w9MSkKLSAg ICBBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX0FSRU5BX0FMTE9DX0FMSUdOTUVOVF9JTlRFR0VS PTEpCiBFTkRJRiAoKQogCiBJRiAoQURESVRJT05BTF9TWVNURU1fSU5DTFVERV9QQVRIKQpAQCAt MTIxLDcgKzEyNCw3IEBAIFNFVChXZWJDb3JlX0xJQlJBUllfTkFNRSB3ZWJjb3JlKQogU0VUKFdl YktpdF9MSUJSQVJZX05BTUUgd2Via2l0KQogU0VUKFdlYktpdF9EUlRfTElCUkFSWV9OQU1FIHdl YmtpdF9EUlQpCiAKLUlGIChUQVJHRVRJTkdfUExBWUJPT0spCitJRiAoRU5BQkxFX0dMRVMyKQog ICAgIFdFQktJVF9GRUFUVVJFKEVOQUJMRV8zRF9SRU5ERVJJTkcgIkVuYWJsZSAzRCBSZW5kZXJp bmciIERFRkFVTFQgT04pCiAgICAgV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1dFQkdMICJFbmFibGUg V2ViR0wiIERFRkFVTFQgT04pCiAgICAgV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0FDQ0VMRVJBVEVE XzJEX0NBTlZBUyAiRW5hYmxlIEFjY2VsZXJhdGVkIDJEIENhbnZhcyAiIERFRkFVTFQgT04pCmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzhkOGJh YS4uMDA1ZTZiMCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTIwICBGaWxpcCBTcGFjZWsgIDxmc3BhY2Vr QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEFsbG93IEdMRVMyIHN1cHBvcnQgdG8g YmUgZW5hYmxlZCBvbiBzaW11bGF0b3Igd2l0aCBFTkFCTEVfR0xFUzIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNjcyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06 CisgICAgICAgIChibGFja2JlcnJ5Q01ha2VBcmd1bWVudHMpOgorCiAyMDEyLTAzLTEyICBNaW5n IFhpZSAgPG14aWVAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gYnVpbGQtd2Via2l0 IGRvZXNuJ3QgcmVjb2duaXplICItLWNtYWtlYXJnIiBmb3IgdGhlIEJsYWNrQmVycnkgcG9ydApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCmluZGV4IDk4M2YyNzkuLjVjM2YyOGMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAg LTkzMCw2ICs5MzAsNyBAQCBzdWIgYmxhY2tiZXJyeUNNYWtlQXJndW1lbnRzKCkKICAgICBpZiAo JGNwdSBlcSAiYTkiKSB7CiAgICAgICAgICRjcHUgPSAkYXJjaCAuICJ2N2xlIjsKICAgICAgICAg cHVzaCBAY21ha2VFeHRyYU9wdGlvbnMsICctRFRBUkdFVElOR19QTEFZQk9PSz0xJzsKKyAgICAg ICAgcHVzaCBAY21ha2VFeHRyYU9wdGlvbnMsICctREVOQUJMRV9HTEVTMj0xJzsKICAgICB9CiAK ICAgICBteSAkc3RhZ2VEaXIgPSAkRU5WeyJTVEFHRV9ESVIifTsKQEAgLTk1Niw2ICs5NTcsNyBA QCBzdWIgYmxhY2tiZXJyeUNNYWtlQXJndW1lbnRzKCkKIAogICAgIHB1c2ggQGNtYWtlRXh0cmFP cHRpb25zLCAiLURDTUFLRV9TS0lQX1JQQVRIPSdPTiciIGlmIGlzRGFyd2luKCk7CiAgICAgcHVz aCBAY21ha2VFeHRyYU9wdGlvbnMsICItREVOQUJMRV9EUlQ9MSIgaWYgJEVOVnsiRU5BQkxFX0RS VCJ9OworICAgIHB1c2ggQGNtYWtlRXh0cmFPcHRpb25zLCAiLURFTkFCTEVfR0xFUzI9MSIgaWYg JEVOVnsiRU5BQkxFX0dMRVMyIn07CiAKICAgICBteSBAaW5jbHVkZVN5c3RlbURpcmVjdG9yaWVz OwogICAgIHB1c2ggQGluY2x1ZGVTeXN0ZW1EaXJlY3RvcmllcywgRmlsZTo6U3BlYy0+Y2F0ZGly KCRzdGFnZUluYywgImdyc2tpYSIsICJza2lhIik7Cg== 136275 2012-04-09 11:38:21 -0700 2012-04-09 15:40:18 -0700 Patch bug-81672-20120409143820.patch text/plain 3017 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0JsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21h a2UKaW5kZXggMGUxMTk0MTU4Mzc2OGE1ZTc4Mzk5MTA3NjFjMzExYzIzN2ViODRhZi4uNTEwODFh YTk4YjhmNzYyMDFmMWVlOTUyODI1ZjZjNjliMDQ2MWQ1NSAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxh Y2tCZXJyeS5jbWFrZQpAQCAtMTgsNyArMTgsNyBAQCBBRERfREVGSU5JVElPTlMoLURXVEZfVVNF X1BUSFJFQURTPTEpCiBTRVQoV1RGX1VTRV9PUEVOVFlQRV9TQU5JVElaRVIgMSkKIEFERF9ERUZJ TklUSU9OUygtRFdURl9VU0VfT1BFTlRZUEVfU0FOSVRJWkVSPTEpCiAKLUlGIChUQVJHRVRJTkdf UExBWUJPT0spCitJRiAoRU5BQkxFX0dMRVMyKQogICAgIFNFVChXVEZfVVNFX0FDQ0VMRVJBVEVE X0NPTVBPU0lUSU5HIDEpCiAgICAgQUREX0RFRklOSVRJT05TKC1EV1RGX1VTRV9BQ0NFTEVSQVRF RF9DT01QT1NJVElORz0xKQogICAgIEFERF9ERUZJTklUSU9OUygtREJMQUNLQkVSUllfUExBVEZP Uk1fR1JBUEhJQ1NfRUdMPTEpCkBAIC0xNTMsNyArMTUzLDcgQEAgV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX1ZJREVPIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX1dFQl9USU1JTkcgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfV09SS0VSUyBPTikKIAotSUYgKFRBUkdFVElOR19QTEFZQk9PSykKK0lG IChFTkFCTEVfR0xFUzIpCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFXzNEX1JFTkRFUklORyBPTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfV0VCR0wgT04pCiBFTFNFICgpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjkzZmY5MmEwMjk2MWJlZDlhYWI0ZjBhMjI4ZWIyYjRj NGI0MTczNC4uMzI4MDM4ZTIyYjlhYTYzMTdhM2M2ZTU3OGI5YzA1YTRlYmEwMjlmMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA0LTA5ICBNaW5nIFhpZSAgPG14aWVAcmltLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gQWxsb3cgc2ltdWxhdG9yIHRvIHVzZSBHTEVTMiBhY2NlbGVyYXRpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNjcyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dGRpcnMucG06CisgICAgICAgIChibGFja2JlcnJ5Q01ha2VBcmd1bWVudHMpOgorCiAyMDEyLTA0 LTA5ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1 aWxkIGZpeCBmb3IgV2luQ0UgYWZ0ZXIgcjExMzU3MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBjMTQ0 ODcwNWNhYjE3NjE3MzE2ZGEzY2Y2MGFkNTZlY2NlNGFiMzgzLi44MTIxMzU3M2Q3MTRjNTU0YjFi ODY3OTMzMDUzMzgyODYxYjkzY2ZmIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC05MzIsNiArOTMyLDcg QEAgc3ViIGJsYWNrYmVycnlDTWFrZUFyZ3VtZW50cygpCiAgICAgaWYgKCRjcHUgZXEgImE5Iikg ewogICAgICAgICAkY3B1ID0gJGFyY2ggLiAidjdsZSI7CiAgICAgICAgIHB1c2ggQGNtYWtlRXh0 cmFPcHRpb25zLCAnLURUQVJHRVRJTkdfUExBWUJPT0s9MSc7CisgICAgICAgIHB1c2ggQGNtYWtl RXh0cmFPcHRpb25zLCAnLURFTkFCTEVfR0xFUzI9MSc7CiAgICAgfQogCiAgICAgbXkgJHN0YWdl RGlyID0gJEVOVnsiU1RBR0VfRElSIn07CkBAIC05NTgsNiArOTU5LDcgQEAgc3ViIGJsYWNrYmVy cnlDTWFrZUFyZ3VtZW50cygpCiAKICAgICBwdXNoIEBjbWFrZUV4dHJhT3B0aW9ucywgIi1EQ01B S0VfU0tJUF9SUEFUSD0nT04nIiBpZiBpc0RhcndpbigpOwogICAgIHB1c2ggQGNtYWtlRXh0cmFP cHRpb25zLCAiLURFTkFCTEVfRFJUPTEiIGlmICRFTlZ7IkVOQUJMRV9EUlQifTsKKyAgICBwdXNo IEBjbWFrZUV4dHJhT3B0aW9ucywgIi1ERU5BQkxFX0dMRVMyPTEiIGlmICRFTlZ7IkVOQUJMRV9H TEVTMiJ9OwogCiAgICAgbXkgQGluY2x1ZGVTeXN0ZW1EaXJlY3RvcmllczsKICAgICBwdXNoIEBp bmNsdWRlU3lzdGVtRGlyZWN0b3JpZXMsIEZpbGU6OlNwZWMtPmNhdGRpcigkc3RhZ2VJbmMsICJn cnNraWEiLCAic2tpYSIpOwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4 IGExZjk1NGZmNDEwMjAwNTgyYThhYzM5MTJjYmU5ZjVkOTUyOWY5MzEuLjY0ZDQ3YTU3MTdmODFi MWRlNmYxMTQ2MGI5ZDUyZGRjYWRiZDdlZWYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wNC0wOSAgTWluZyBYaWUgIDxteGllQHJp bS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEFsbG93IHNpbXVsYXRvciB0byB1c2UgR0xF UzIgYWNjZWxlcmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MTY3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlOgorCiAyMDEyLTA0 LTA5ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtD TWFrZV0gQnVpbGQgZml4IGZvciBVU0VfU1lTVEVNX01BTExPQyBhZnRlciByMTEzNTcwLgo=