81666 2012-03-20 08:19:52 -0700 (r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro 2012-03-20 09:18:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kpiascik webkit-unassigned webkit.review.bot oldest_to_newest 583081 0 kpiascik 2012-03-20 08:19:52 -0700 (r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro 583083 1 132828 kpiascik 2012-03-20 08:21:35 -0700 Created attachment 132828 Patch 583085 2 132828 rwlbuis 2012-03-20 08:23:49 -0700 Comment on attachment 132828 Patch Better do it like this: if (m_mousePressed && m_mouseDownMayStartSelect && #if ENABLE(DRAG_SUPPORT) !m_mouseDownMayStartDrag && #endif m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode) 583094 3 132831 kpiascik 2012-03-20 08:31:38 -0700 Created attachment 132831 Patch 583096 4 132831 rwlbuis 2012-03-20 08:36:34 -0700 Comment on attachment 132831 Patch Better :) 583126 5 132831 webkit.review.bot 2012-03-20 09:18:14 -0700 Comment on attachment 132831 Patch Clearing flags on attachment: 132831 Committed r111400: <http://trac.webkit.org/changeset/111400> 583127 6 webkit.review.bot 2012-03-20 09:18:18 -0700 All reviewed patches have been landed. Closing bug. 132828 2012-03-20 08:21:35 -0700 2012-03-20 08:31:31 -0700 Patch bug-81666-20120320112147.patch text/plain 1861 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE1MDcyMWFiYTczNWJh NTZmNzVhNTBiZWRiNGY2NmU1NGIyMTIyZC4uOGE0YTk3OWFlYWNlNTE2MDhjN2NiYmQ1NDY2M2Rh NGZlNzVmNzhlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTIwICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CisKKyAgICAgICAgKHIxMTAwNjMpIG1fbW91 c2VEb3duTWF5U3RhcnREcmFnIGlzIHVzZWQgd2l0aG91dCBiZWluZyBiZWhpbmQgdGhlIEVOQUJM RShEUkFHX1NVUFBPUlQpIG1hY3JvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MTY2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvbXBpbGVkIHdpdGggZmVhdHVyZSBkaXNhYmxlZCBhbmQgYnVpbHQuCisK KyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVu dEhhbmRsZXI6OnNlbGVjdEN1cnNvcik6CisKIDIwMTItMDMtMDcgIENoYW5nU2VvayBPaCAgPHNo aXZhbWlkb3dAZ21haWwuY29tPgogCiAgICAgICAgIFtFRkxdIFJldmlzZSBQbGF0Zm9ybUtleWJv YXJkRXZlbnRFZmwgYW5kIEVmbEtleWJvYXJkVXRpbGl0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAKaW5kZXggMWMxMTQ3YjczNjZjNjVmZjA4ZDBkZGQ0NWY0N2I5YjIwYWIwNjc0 My4uNDk0MjdlMWZkOTcwMDM4NzE1YzA4OWY1NjM5NzQxYTBjNWMwMmFkNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMTI4Niw5ICsxMjg2LDEzIEBAIE9wdGlvbmFsQ3Vy c29yIEV2ZW50SGFuZGxlcjo6c2VsZWN0Q3Vyc29yKGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVz dFJlc3VsdHMmIGV2CiAKICAgICAvLyBEdXJpbmcgc2VsZWN0aW9uLCB1c2UgYW4gSS1iZWFtIG5v IG1hdHRlciB3aGF0IHdlJ3JlIG92ZXIuCiAgICAgLy8gSWYgYSBkcmFnIG1heSBiZSBzdGFydGlu ZyBvciB3ZSdyZSBjYXB0dXJpbmcgbW91c2UgZXZlbnRzIGZvciBhIHBhcnRpY3VsYXIgbm9kZSwg ZG9uJ3QgdHJlYXQgdGhpcyBhcyBhIHNlbGVjdGlvbi4KKyNpZiBFTkFCTEUoRFJBR19TVVBQT1JU KQogICAgIGlmIChtX21vdXNlUHJlc3NlZCAmJiBtX21vdXNlRG93bk1heVN0YXJ0U2VsZWN0ICYm ICFtX21vdXNlRG93bk1heVN0YXJ0RHJhZyAmJiBtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+aXNDYXJl dE9yUmFuZ2UoKSAmJiAhbV9jYXB0dXJpbmdNb3VzZUV2ZW50c05vZGUpCiAgICAgICAgIHJldHVy biBpQmVhbTsKLQorI2Vsc2UKKyAgICBpZiAobV9tb3VzZVByZXNzZWQgJiYgbV9tb3VzZURvd25N YXlTdGFydFNlbGVjdCAmJiBtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+aXNDYXJldE9yUmFuZ2UoKSAm JiAhbV9jYXB0dXJpbmdNb3VzZUV2ZW50c05vZGUpCisgICAgICAgIHJldHVybiBpQmVhbTsKKyNl bmRpZgogICAgIGlmIChyZW5kZXJlcikgewogICAgICAgICBDdXJzb3Igb3ZlcnJpZGVDdXJzb3I7 CiAgICAgICAgIHN3aXRjaCAocmVuZGVyZXItPmdldEN1cnNvcihyb3VuZGVkSW50UG9pbnQoZXZl bnQubG9jYWxQb2ludCgpKSwgb3ZlcnJpZGVDdXJzb3IpKSB7Cg== 132831 2012-03-20 08:31:38 -0700 2012-03-20 09:18:14 -0700 Patch bug-81666-20120320113150.patch text/plain 1752 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE1MDcyMWFiYTczNWJh NTZmNzVhNTBiZWRiNGY2NmU1NGIyMTIyZC4uOGE0YTk3OWFlYWNlNTE2MDhjN2NiYmQ1NDY2M2Rh NGZlNzVmNzhlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTIwICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CisKKyAgICAgICAgKHIxMTAwNjMpIG1fbW91 c2VEb3duTWF5U3RhcnREcmFnIGlzIHVzZWQgd2l0aG91dCBiZWluZyBiZWhpbmQgdGhlIEVOQUJM RShEUkFHX1NVUFBPUlQpIG1hY3JvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MTY2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvbXBpbGVkIHdpdGggZmVhdHVyZSBkaXNhYmxlZCBhbmQgYnVpbHQuCisK KyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVu dEhhbmRsZXI6OnNlbGVjdEN1cnNvcik6CisKIDIwMTItMDMtMDcgIENoYW5nU2VvayBPaCAgPHNo aXZhbWlkb3dAZ21haWwuY29tPgogCiAgICAgICAgIFtFRkxdIFJldmlzZSBQbGF0Zm9ybUtleWJv YXJkRXZlbnRFZmwgYW5kIEVmbEtleWJvYXJkVXRpbGl0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAKaW5kZXggMWMxMTQ3YjczNjZjNjVmZjA4ZDBkZGQ0NWY0N2I5YjIwYWIwNjc0 My4uY2I4N2UzOTY2ZDFhMTM3ZjBlYjU2MWVmZDE4ZmE5MTA0YjNmN2QyNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMTI4Niw3ICsxMjg2LDExIEBAIE9wdGlvbmFsQ3Vy c29yIEV2ZW50SGFuZGxlcjo6c2VsZWN0Q3Vyc29yKGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVz dFJlc3VsdHMmIGV2CiAKICAgICAvLyBEdXJpbmcgc2VsZWN0aW9uLCB1c2UgYW4gSS1iZWFtIG5v IG1hdHRlciB3aGF0IHdlJ3JlIG92ZXIuCiAgICAgLy8gSWYgYSBkcmFnIG1heSBiZSBzdGFydGlu ZyBvciB3ZSdyZSBjYXB0dXJpbmcgbW91c2UgZXZlbnRzIGZvciBhIHBhcnRpY3VsYXIgbm9kZSwg ZG9uJ3QgdHJlYXQgdGhpcyBhcyBhIHNlbGVjdGlvbi4KLSAgICBpZiAobV9tb3VzZVByZXNzZWQg JiYgbV9tb3VzZURvd25NYXlTdGFydFNlbGVjdCAmJiAhbV9tb3VzZURvd25NYXlTdGFydERyYWcg JiYgbV9mcmFtZS0+c2VsZWN0aW9uKCktPmlzQ2FyZXRPclJhbmdlKCkgJiYgIW1fY2FwdHVyaW5n TW91c2VFdmVudHNOb2RlKQorICAgIGlmIChtX21vdXNlUHJlc3NlZCAmJiBtX21vdXNlRG93bk1h eVN0YXJ0U2VsZWN0CisjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkKKyAgICAgICAgJiYgIW1fbW91 c2VEb3duTWF5U3RhcnREcmFnCisjZW5kaWYKKyAgICAgICAgJiYgbV9mcmFtZS0+c2VsZWN0aW9u KCktPmlzQ2FyZXRPclJhbmdlKCkgJiYgIW1fY2FwdHVyaW5nTW91c2VFdmVudHNOb2RlKQogICAg ICAgICByZXR1cm4gaUJlYW07CiAKICAgICBpZiAocmVuZGVyZXIpIHsK