81665 2012-03-20 08:17:02 -0700 [GTK] icon database requests not dispatched until new data arrives 2012-03-22 08:05:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 csaavedra svillar svillar oldest_to_newest 583080 0 csaavedra 2012-03-20 08:17:02 -0700 Apply this patch http://fpaste.org/I0hD/ to ephy master (rev. 5343bd) and you'll notice the following: 1. Opening ephy's history window (ctrl+ h) will show the list of hosts (in the left window) without any icons. 2. Without closing the history window, load any webpage (hopefully with favicon). 3. The icons will be loaded now. Apparently the favicon requests done with webkit_favicon_database_get_favicon_pixbuf() are not dispatched until new data arrives in the database. 585136 1 133226 svillar 2012-03-22 05:13:29 -0700 Created attachment 133226 Patch 585258 2 133226 mrobinson 2012-03-22 07:37:21 -0700 Comment on attachment 133226 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133226&action=review Okay. Please add this commit id to the 1.8 wiki page. One comment could be slightly cleaned up, I think. > Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp:543 > + // By asking for the icon directly: > + // 1- if we don't get the icon data now, we'll get notified about it later (even if the initial import is not finished yet). > + // 2- if we get the icon data now, then success. Perhaps you could make this slightly more concise: We ask for the icon directly. If we don't get the icon data now, we'll be notified later (even if the database is still importing icons). 585291 3 svillar 2012-03-22 08:05:57 -0700 Committed r111698: <http://trac.webkit.org/changeset/111698> 133226 2012-03-22 05:13:29 -0700 2012-03-22 07:37:21 -0700 Patch bug-81665-20120322131327.patch text/plain 3128 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwOTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggODIzNzJmOTE3 ZjNiOWM2Mjk4MWIyNzJhMWZmZWRkMmVkZDUwOTAzMS4uOTA1Y2IwYzk5ODVhN2RiNzI4OGQ4Mjc1 OTBhZmZlMWQ3Mzc0MmZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTAzLTIyICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIGljb24gZGF0YWJhc2UgcmVxdWVzdHMgbm90IGRpc3BhdGNoZWQgdW50aWwgbmV3 IGRhdGEgYXJyaXZlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODE2NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXYWl0IGZvciB0aGUgaW1wb3J0IHRvIGZpbmlzaCBiZWZvcmUgcmVwb3J0aW5nIHRoYXQg dGhlIGZhdmljb24KKyAgICAgICAgY2FjaGUgZG9lcyBub3QgaGF2ZSBhIHBpeGJ1ZiBmb3IgYW4g VVJMLgorCisgICAgICAgIENoYW5nZXMgYWxyZWFkeSBjb3ZlcmVkIGJ5IHRoZSBmYXZpY29uIGRh dGFiYXNlIHVuaXQgdGVzdHMuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0ZmF2aWNvbmRhdGFi YXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdF9mYXZpY29uX2RhdGFiYXNlX2dldF9mYXZpY29uX3Bp eGJ1Zik6CisKIDIwMTItMDMtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPiBhbmQgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBXZWJLaXRJY29uRGF0YWJhc2UgZG9lc24ndCBrZWVwIGljb25zIGNhY2hl ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGZhdmljb25kYXRh YmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZmF2aWNvbmRhdGFiYXNl LmNwcAppbmRleCAyOWYyNjlkMjA3YmM5Zjc0NDBhNWZlMzZkZDM1Y2RjODJlNDUzZGRjLi43ZWIx NGViZWU2MTMwZGEwMjVlZGUzMDk5M2ZmZTBhYzM3ZmQwNjNmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZmF2aWNvbmRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZmF2aWNvbmRhdGFiYXNlLmNwcApAQCAtNTIxLDggKzUy MSwxMCBAQCB2b2lkIHdlYmtpdF9mYXZpY29uX2RhdGFiYXNlX2dldF9mYXZpY29uX3BpeGJ1ZihX ZWJLaXRGYXZpY29uRGF0YWJhc2UqIGRhdGFiYXNlLAogICAgIEdSZWZQdHI8R1NpbXBsZUFzeW5j UmVzdWx0PiByZXN1bHQgPSBhZG9wdEdSZWYoZ19zaW1wbGVfYXN5bmNfcmVzdWx0X25ldyhHX09C SkVDVChkYXRhYmFzZSksIGNhbGxiYWNrLCB1c2VyRGF0YSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmVpbnRlcnByZXRfY2FzdDxncG9pbnRlcj4od2Via2l0X2Zhdmljb25fZGF0YWJhc2VfZ2V0X2Zh dmljb25fcGl4YnVmKSkpOwogCi0gICAgLy8gSWYgd2UgZG9uJ3QgaGF2ZSBhbiBpY29uIGZvciB0 aGUgZ2l2ZW4gVVJJIHJldHVybiBBU0FQLgotICAgIGlmIChkYXRhYmFzZS0+cHJpdi0+aW1wb3J0 RmluaXNoZWQgJiYgaWNvbkRhdGFiYXNlKCkuc3luY2hyb25vdXNJY29uVVJMRm9yUGFnZVVSTChT dHJpbmc6OmZyb21VVEY4KHBhZ2VVUkkpKS5pc0VtcHR5KCkpIHsKKyAgICAvLyBJZiB3ZSBkb24n dCBoYXZlIGFuIGljb24gZm9yIHRoZSBnaXZlbiBVUkkgb3IgdGhlIGRhdGFiYXNlIGlzIG5vdCBv cGVuZWQgdGhlbiByZXR1cm4gQVNBUC4gV2UgaGF2ZSB0byBjaGVjayB0aGF0CisgICAgLy8gYmVj YXVzZSBpZiB0aGUgZGF0YWJhc2UgaXMgbm90IG9wZW5lZCBpdCB3aWxsIHNraXAgKGFuZCBub3Qg bm90aWZ5IGFib3V0KSBldmVyeSBzaW5nbGUgaWNvbiBsb2FkIHJlcXVlc3QKKyAgICBpZiAoKGRh dGFiYXNlLT5wcml2LT5pbXBvcnRGaW5pc2hlZCAmJiBpY29uRGF0YWJhc2UoKS5zeW5jaHJvbm91 c0ljb25VUkxGb3JQYWdlVVJMKFN0cmluZzo6ZnJvbVVURjgocGFnZVVSSSkpLmlzRW1wdHkoKSkK KyAgICAgICAgfHwgIWljb25EYXRhYmFzZSgpLmlzT3BlbigpKSB7CiAgICAgICAgIGdfc2ltcGxl X2FzeW5jX3Jlc3VsdF9zZXRfb3BfcmVzX2dwb2ludGVyKHJlc3VsdC5nZXQoKSwgMCwgMCk7CiAg ICAgICAgIGdfc2ltcGxlX2FzeW5jX3Jlc3VsdF9jb21wbGV0ZV9pbl9pZGxlKHJlc3VsdC5nZXQo KSk7CiAgICAgICAgIHJldHVybjsKQEAgLTUzNiwxMSArNTM4LDEyIEBAIHZvaWQgd2Via2l0X2Zh dmljb25fZGF0YWJhc2VfZ2V0X2Zhdmljb25fcGl4YnVmKFdlYktpdEZhdmljb25EYXRhYmFzZSog ZGF0YWJhc2UsCiAgICAgQVNTRVJUKGljb25zKTsKICAgICBpY29ucy0+YXBwZW5kKGFkb3B0UHRy KHJlcXVlc3QpKTsKIAorICAgIC8vIEJ5IGFza2luZyBmb3IgdGhlIGljb24gZGlyZWN0bHk6Cisg ICAgLy8gMS0gaWYgd2UgZG9uJ3QgZ2V0IHRoZSBpY29uIGRhdGEgbm93LCB3ZSdsbCBnZXQgbm90 aWZpZWQgYWJvdXQgaXQgbGF0ZXIgKGV2ZW4gaWYgdGhlIGluaXRpYWwgaW1wb3J0IGlzIG5vdCBm aW5pc2hlZCB5ZXQpLgorICAgIC8vIDItIGlmIHdlIGdldCB0aGUgaWNvbiBkYXRhIG5vdywgdGhl biBzdWNjZXNzLgogICAgIEdka1BpeGJ1ZiogcGl4YnVmID0gZ2V0SWNvblBpeGJ1ZlN5bmNocm9u b3VzbHkoZGF0YWJhc2UsIHBhZ2VVUkwsIEludFNpemUod2lkdGgsIGhlaWdodCkpOwotICAgIGlm ICghcGl4YnVmICYmICFkYXRhYmFzZS0+cHJpdi0+aW1wb3J0RmluaXNoZWQpIHsKLSAgICAgICAg Ly8gSW5pdGlhbCBpbXBvcnQgaXMgb25nb2luZywgdGhlIGljb24gZGF0YSB3aWxsIGJlIGF2YWls YWJsZSBsYXRlci4KKyAgICBpZiAoIXBpeGJ1ZikKICAgICAgICAgcmV0dXJuOwotICAgIH0KIAog ICAgIHJlcXVlc3QtPmFzeW5jUmVzdWx0Q29tcGxldGVJbklkbGUocGl4YnVmKTsKIAo=