81664 2012-03-20 07:49:10 -0700 [BlackBerry] Removing doubly defined methods in BackingStore.cpp 2012-03-20 08:31:35 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian rwlbuis tonikitoo webkit.review.bot oldest_to_newest 583065 0 nima.ghanavatian 2012-03-20 07:49:10 -0700 drawLayersOnCommitIfNeeded() and drawAndBlendLayersForDirectRendering(const Platform::IntRect& dirtyRect) were defined twice. Removing erroneous bits. 583075 1 132826 nima.ghanavatian 2012-03-20 08:10:01 -0700 Created attachment 132826 Patch 583076 2 132826 rwlbuis 2012-03-20 08:13:12 -0700 Comment on attachment 132826 Patch Looks good. 583092 3 132826 webkit.review.bot 2012-03-20 08:31:30 -0700 Comment on attachment 132826 Patch Clearing flags on attachment: 132826 Committed r111398: <http://trac.webkit.org/changeset/111398> 583093 4 webkit.review.bot 2012-03-20 08:31:35 -0700 All reviewed patches have been landed. Closing bug. 132826 2012-03-20 08:10:01 -0700 2012-03-20 08:31:29 -0700 Patch bug-81664-20120320110704.patch text/plain 3103 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyMzAyNzY4MjcyOGJjYjRiMmVjYjM4NTJkZWJmMDJmMTgxMGFiMGU2Li5jNjA1NTVjMDg4 NjA3OTg4YzZhNTI0MzdmNTIyYjAwMzIxYzRmNjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMy0yMCAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmluZyBkb3Vi bHkgZGVmaW5lZCBtZXRob2RzIGluIEJhY2tpbmdTdG9yZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNjY0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkvQmFja2luZ1N0b3JlLmNwcDoKKyAg ICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6ZHJhd0FuZEJs ZW5kTGF5ZXJzRm9yRGlyZWN0UmVuZGVyaW5nKToKKwogMjAxMi0wMy0yMCAgTWlrZSBGZW50b24g IDxtaWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBDcmFzaCB3aGVuIGRy YWdnaW5nIHRoZSBGQ0MgY2FyZXQgb3ZlciBhbiBpbnZhbGlkIG5vZGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKaW5kZXggYjRhNGFkZGYxMTQxYjRl YjBlM2JmNjJhNzIyNmM3NTEwZTkxM2RkMC4uZTU4MDZiM2FhNzMwMmQ1NjhkODdjOTBhYTJkMTgw MGEyODFkM2QyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNr aW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0 b3JlLmNwcApAQCAtMjU2OCw0NiArMjU2OCw2IEBAIHZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6 ZHJhd0FuZEJsZW5kTGF5ZXJzRm9yRGlyZWN0UmVuZGVyaW5nKGNvbnN0IFBsYXRmb3JtOjpJCiAg ICAgYmxlbmRDb21wb3NpdGluZ1N1cmZhY2UodmlzaWJsZURpcnR5UmVjdCk7CiAjZW5kaWYKIH0K LQotYm9vbCBCYWNraW5nU3RvcmVQcml2YXRlOjpkcmF3TGF5ZXJzT25Db21taXRJZk5lZWRlZCgp Ci17Ci0gICAgLy8gQ2hlY2sgaWYgcmVuZGVyaW5nIGNhdXNlZCBhIGNvbW1pdCBhbmQgd2UgbmVl ZCB0byByZWRyYXcgdGhlIGxheWVycwotICAgIGlmICghbV9uZWVkc0RyYXdMYXllcnNPbkNvbW1p dCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgbV9uZWVkc0RyYXdMYXllcnNPbkNvbW1p dCA9IGZhbHNlOwotICAgIG1fd2ViUGFnZS0+ZC0+ZHJhd0xheWVyc09uQ29tbWl0KCk7Ci0KLSAg ICByZXR1cm4gdHJ1ZTsKLX0KLQotdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpkcmF3QW5kQmxl bmRMYXllcnNGb3JEaXJlY3RSZW5kZXJpbmcoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIGRpcnR5 UmVjdCkKLXsKLSAgICBBU1NFUlQoQmxhY2tCZXJyeTo6UGxhdGZvcm06OnVzZXJJbnRlcmZhY2VU aHJlYWRNZXNzYWdlQ2xpZW50KCktPmlzQ3VycmVudFRocmVhZCgpKTsKLSAgICBpZiAoIUJsYWNr QmVycnk6OlBsYXRmb3JtOjp1c2VySW50ZXJmYWNlVGhyZWFkTWVzc2FnZUNsaWVudCgpLT5pc0N1 cnJlbnRUaHJlYWQoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgLy8gQmVjYXVzZSB3ZSdyZSBi ZWluZyBjYWxsZWQgc3luYyBmcm9tIHRoZSBXZWJLaXQgdGhyZWFkLCB3ZSBjYW4gdXNlCi0gICAg Ly8gcmVndWxhciBXZWJQYWdlIHNpemUgYW5kIHRyYW5zZm9ybWF0aW9uIGZ1bmN0aW9ucyB3aXRo b3V0IGNvbmNlcm5zLgotICAgIFdlYkNvcmU6OkludFJlY3QgY29udGVudHNSZWN0ID0gdmlzaWJs ZUNvbnRlbnRzUmVjdCgpOwotICAgIFdlYkNvcmU6OkZsb2F0UmVjdCB1bnRyYW5zZm9ybWVkQ29u dGVudHNSZWN0ID0gbV93ZWJQYWdlLT5kLT5tYXBGcm9tVHJhbnNmb3JtZWRGbG9hdFJlY3QoV2Vi Q29yZTo6RmxvYXRSZWN0KGNvbnRlbnRzUmVjdCkpOwotICAgIFdlYkNvcmU6OkludFJlY3QgY29u dGVudHNTY3JlZW5SZWN0ID0gbV9jbGllbnQtPm1hcEZyb21UcmFuc2Zvcm1lZENvbnRlbnRzVG9U cmFuc2Zvcm1lZFZpZXdwb3J0KGNvbnRlbnRzUmVjdCk7Ci0gICAgV2ViQ29yZTo6SW50UmVjdCBk c3RSZWN0ID0gaW50ZXJzZWN0aW9uKGNvbnRlbnRzU2NyZWVuUmVjdCwKLSAgICAgICAgV2ViQ29y ZTo6SW50UmVjdChXZWJDb3JlOjpJbnRQb2ludCgwLCAwKSwgbV93ZWJQYWdlLT5kLT50cmFuc2Zv cm1lZFZpZXdwb3J0U2l6ZSgpKSk7Ci0KLSAgICAvLyBDaGVjayBpZiByZW5kZXJpbmcgY2F1c2Vk IGEgY29tbWl0IGFuZCB3ZSBuZWVkIHRvIHJlZHJhdyB0aGUgbGF5ZXJzLgotICAgIG1fbmVlZHNE cmF3TGF5ZXJzT25Db21taXQgPSBmYWxzZTsKLSAgICBtX3dlYlBhZ2UtPmQtPmRyYXdTdWJMYXll cnMoZHN0UmVjdCwgdW50cmFuc2Zvcm1lZENvbnRlbnRzUmVjdCk7Ci0KLSNpZiBFTkFCTEVfQ09N UE9TSVRJTkdfU1VSRkFDRQotICAgIC8vIFNlZSBhYm92ZSBjb21tZW50IGFib3V0IHN5bmMgY2Fs bGluZywgdmlzaWJsZUNvbnRlbnRzUmVjdCgpIGlzIHNhZmUgaGVyZS4KLSAgICBQbGF0Zm9ybTo6 SW50UmVjdCB2aXNpYmxlRGlydHlSZWN0ID0gZGlydHlSZWN0OwotICAgIHZpc2libGVEaXJ0eVJl Y3QuaW50ZXJzZWN0KHZpc2libGVDb250ZW50c1JlY3QoKSk7Ci0gICAgdmlzaWJsZURpcnR5UmVj dCA9IG1fY2xpZW50LT5tYXBGcm9tVHJhbnNmb3JtZWRDb250ZW50c1RvVHJhbnNmb3JtZWRWaWV3 cG9ydCh2aXNpYmxlRGlydHlSZWN0KTsKLQotICAgIGJsZW5kQ29tcG9zaXRpbmdTdXJmYWNlKHZp c2libGVEaXJ0eVJlY3QpOwotI2VuZGlmCi19CiAjZW5kaWYKIAogYm9vbCBCYWNraW5nU3RvcmVQ cml2YXRlOjppc0FjdGl2ZSgpIGNvbnN0Cg==