81641 2012-03-20 02:22:18 -0700 Web Inspector: provide class name filter for "comparison" view in heap profiler 2012-03-20 05:01:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys alph apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 582875 0 yurys 2012-03-20 02:22:18 -0700 We have it in "summary" view, would be useful in "comparison" view as well. 582877 1 132782 yurys 2012-03-20 02:23:36 -0700 Created attachment 132782 Patch 582899 2 alph 2012-03-20 03:22:45 -0700 lgtm 582962 3 yurys 2012-03-20 05:01:45 -0700 Committed r111383: <http://trac.webkit.org/changeset/111383> 132782 2012-03-20 02:23:36 -0700 2012-03-20 04:32:08 -0700 Patch bug-81641-20120320132334.patch text/plain 6449 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTc5ZWY5ZDhhYTVjY2E3 NzQ3ZTM2NWJjYjlhMWJkZWJhM2FmNmE3NC4uMDNmZmY3ODVkMzQyYTRhZWFhYjQyNDhkOGZkNjli MGUzNmVlNzk5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAzLTIwICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHByb3ZpZGUgY2xhc3MgbmFtZSBmaWx0ZXIgZm9yICJjb21wYXJpc29uIiB2aWV3IGluIGhl YXAgcHJvZmlsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgxNjQxCisKKyAgICAgICAgQ2xhc3MgbmFtZSBmaWx0ZXJpbmcgbm93IHdvcmtzIGZvciBi b3RoIFN1bW1hcnkgYW5kIENvbXBhcmlzb24gdmlld3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVk SGVhcHNob3RWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RW aWV3LnByb3RvdHlwZS5fY3JlYXRlVG9vbGJhcldpdGhDbGFzc05hbWVGaWx0ZXIpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3LnByb3RvdHlwZS5fY2hhbmdlTmFt ZUZpbHRlcik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9oZWFwUHJvZmlsZXIuY3Nz OgorICAgICAgICAoLmRldGFpbGVkLWhlYXBzaG90LXZpZXcgLmNsYXNzLXZpZXctZ3JpZCk6Cisg ICAgICAgICguZGV0YWlsZWQtaGVhcHNob3QtdmlldyAuY2xhc3Mtdmlldy10b29sYmFyKToKKyAg ICAgICAgKC5kZXRhaWxlZC1oZWFwc2hvdC12aWV3IC5jbGFzcy12aWV3LXRvb2xiYXIgaW5wdXQu Y2xhc3MtbmFtZS1maWx0ZXIpOgorCiAyMDEyLTAzLTE5ICBIaXJvbm9yaSBCb25vICA8aGJvbm9A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhIGNvcHkgY29uc3RydWN0b3IgdG8gQ29sbGFw c2VkQm9yZGVyVmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RldGFpbGVkSGVhcHNob3RWaWV3LmpzCmluZGV4IDM3ZDk4NWZkOTdmMDBiZWU2 YmIyNzViZjc2ODQ2NTRlMDUwYWFmNGUuLjNhZTlkMDAyM2M5MGVkNmZhOTM2ZGY4OWE5Y2NjNTM5 ODA0N2Q0OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RGV0YWlsZWRIZWFwc2hvdFZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qcwpAQCAtMjk5LDE1ICsyOTksNiBAQCBXZWJJ bnNwZWN0b3IuSGVhcFNuYXBzaG90Q29uc3RydWN0b3JzRGF0YUdyaWQucHJvdG90eXBlID0gewog ICAgICAgICBsb2FkZXIocHJvZmlsZUluZGV4LCBmaXJzdFNuYXBzaG90TG9hZGVkLmJpbmQodGhp cykpOwogICAgIH0sCiAKLSAgICBfbmFtZUZpbHRlckNoYW5nZWQ6IGZ1bmN0aW9uKGZpbHRlclN0 cmluZykKLSAgICB7Ci0gICAgICAgIHZhciBmaWx0ZXIgPSBmaWx0ZXJTdHJpbmcudG9Mb3dlckNh c2UoKTsKLSAgICAgICAgZm9yICh2YXIgaSA9IDAsIGwgPSB0aGlzLmNoaWxkcmVuLmxlbmd0aDsg aSA8IGw7ICsraSkgewotICAgICAgICAgICAgdmFyIG5vZGUgPSB0aGlzLmNoaWxkcmVuW2ldOwot ICAgICAgICAgICAgaWYgKG5vZGUuZGVwdGggPT09IDApCi0gICAgICAgICAgICAgICAgbm9kZS5y ZXZlYWxlZCA9IG5vZGUuX25hbWUudG9Mb3dlckNhc2UoKS5pbmRleE9mKGZpbHRlcikgIT09IC0x OwotICAgICAgICB9Ci0gICAgfQogfTsKIAogV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdENvbnN0 cnVjdG9yc0RhdGFHcmlkLnByb3RvdHlwZS5fX3Byb3RvX18gPSBXZWJJbnNwZWN0b3IuSGVhcFNu YXBzaG90U29ydGFibGVEYXRhR3JpZC5wcm90b3R5cGU7CkBAIC00NTUsMjUgKzQ0NiwyMCBAQCBX ZWJJbnNwZWN0b3IuRGV0YWlsZWRIZWFwc2hvdFZpZXcgPSBmdW5jdGlvbihwYXJlbnQsIHByb2Zp bGUpCiAKICAgICB0aGlzLmNvbnN0cnVjdG9yc1ZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlZpZXco KTsKICAgICB0aGlzLmNvbnN0cnVjdG9yc1ZpZXcuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJ2aWV3 Iik7Ci0KLSAgICB0aGlzLmNvbnN0cnVjdG9yc1ZpZXdUb29sYmFyID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiZGl2Iik7Ci0gICAgdGhpcy5jb25zdHJ1Y3RvcnNWaWV3VG9vbGJhci5hZGRTdHls ZUNsYXNzKCJjb25zdHJ1Y3RvcnMtdmlldy10b29sYmFyIik7Ci0gICAgdGhpcy5jb25zdHJ1Y3Rv cnNWaWV3RmlsdGVyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaW5wdXQiKTsKLSAgICB0aGlz LmNvbnN0cnVjdG9yc1ZpZXdGaWx0ZXIuYWRkU3R5bGVDbGFzcygiY29uc3RydWN0b3JzLXZpZXct ZmlsdGVyIik7Ci0gICAgdGhpcy5jb25zdHJ1Y3RvcnNWaWV3RmlsdGVyLnNldEF0dHJpYnV0ZSgi cGxhY2Vob2xkZXIiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNsYXNzIGZpbHRlciIpKTsKLSAg ICB0aGlzLmNvbnN0cnVjdG9yc1ZpZXdGaWx0ZXIuYWRkRXZlbnRMaXN0ZW5lcigia2V5dXAiLCB0 aGlzLl9jaGFuZ2VOYW1lRmlsdGVyLmJpbmQodGhpcyksIGZhbHNlKTsKLSAgICB0aGlzLmNvbnN0 cnVjdG9yc1ZpZXdUb29sYmFyLmFwcGVuZENoaWxkKHRoaXMuY29uc3RydWN0b3JzVmlld0ZpbHRl cik7Ci0gICAgdGhpcy5jb25zdHJ1Y3RvcnNWaWV3LmVsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5j b25zdHJ1Y3RvcnNWaWV3VG9vbGJhcik7CisgICAgdGhpcy5jb25zdHJ1Y3RvcnNWaWV3LmVsZW1l bnQuYXBwZW5kQ2hpbGQodGhpcy5fY3JlYXRlVG9vbGJhcldpdGhDbGFzc05hbWVGaWx0ZXIoKSk7 CiAKICAgICB0aGlzLmNvbnN0cnVjdG9yc0RhdGFHcmlkID0gbmV3IFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3RDb25zdHJ1Y3RvcnNEYXRhR3JpZCgpOwotICAgIHRoaXMuY29uc3RydWN0b3JzRGF0 YUdyaWQuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJjb25zdHJ1Y3RvcnMtdmlldy1ncmlkIik7Cisg ICAgdGhpcy5jb25zdHJ1Y3RvcnNEYXRhR3JpZC5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoImNsYXNz LXZpZXctZ3JpZCIpOwogICAgIHRoaXMuY29uc3RydWN0b3JzRGF0YUdyaWQuZWxlbWVudC5hZGRF dmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0aGlzLl9tb3VzZURvd25JbkNvbnRlbnRzR3JpZC5i aW5kKHRoaXMpLCB0cnVlKTsKICAgICB0aGlzLmNvbnN0cnVjdG9yc0RhdGFHcmlkLnNob3codGhp cy5jb25zdHJ1Y3RvcnNWaWV3LmVsZW1lbnQpOwogICAgIHRoaXMuY29uc3RydWN0b3JzRGF0YUdy aWQuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRGF0YUdyaWQuRXZlbnRzLlNlbGVjdGVk Tm9kZSwgdGhpcy5fc2VsZWN0aW9uQ2hhbmdlZCwgdGhpcyk7CiAKICAgICB0aGlzLmRpZmZWaWV3 ID0gbmV3IFdlYkluc3BlY3Rvci5WaWV3KCk7CiAgICAgdGhpcy5kaWZmVmlldy5lbGVtZW50LmFk ZFN0eWxlQ2xhc3MoInZpZXciKTsKKyAgICB0aGlzLmRpZmZWaWV3LmVsZW1lbnQuYXBwZW5kQ2hp bGQodGhpcy5fY3JlYXRlVG9vbGJhcldpdGhDbGFzc05hbWVGaWx0ZXIoKSk7CisKICAgICB0aGlz LmRpZmZEYXRhR3JpZCA9IG5ldyBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90RGlmZkRhdGFHcmlk KCk7CisgICAgdGhpcy5kaWZmRGF0YUdyaWQuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJjbGFzcy12 aWV3LWdyaWQiKTsKICAgICB0aGlzLmRpZmZEYXRhR3JpZC5zaG93KHRoaXMuZGlmZlZpZXcuZWxl bWVudCk7CiAgICAgdGhpcy5kaWZmRGF0YUdyaWQuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0 b3IuRGF0YUdyaWQuRXZlbnRzLlNlbGVjdGVkTm9kZSwgdGhpcy5fc2VsZWN0aW9uQ2hhbmdlZCwg dGhpcyk7CiAKQEAgLTgwMiw5ICs3ODgsMjcgQEAgV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNo b3RWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5wZXJmb3JtU2VhcmNoKHRoaXMuY3Vy cmVudFF1ZXJ5LCB0aGlzLl9zZWFyY2hGaW5pc2hlZENhbGxiYWNrKTsKICAgICB9LAogCi0gICAg X2NoYW5nZU5hbWVGaWx0ZXI6IGZ1bmN0aW9uKCkKKyAgICBfY3JlYXRlVG9vbGJhcldpdGhDbGFz c05hbWVGaWx0ZXI6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHRoaXMuZGF0YUdyaWQuX25h bWVGaWx0ZXJDaGFuZ2VkKHRoaXMuY29uc3RydWN0b3JzVmlld0ZpbHRlci52YWx1ZSk7CisgICAg ICAgIHZhciB0b29sYmFyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgICAg IHRvb2xiYXIuYWRkU3R5bGVDbGFzcygiY2xhc3Mtdmlldy10b29sYmFyIik7CisgICAgICAgIHZh ciBjbGFzc05hbWVGaWx0ZXIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpbnB1dCIpOworICAg ICAgICBjbGFzc05hbWVGaWx0ZXIuYWRkU3R5bGVDbGFzcygiY2xhc3MtbmFtZS1maWx0ZXIiKTsK KyAgICAgICAgY2xhc3NOYW1lRmlsdGVyLnNldEF0dHJpYnV0ZSgicGxhY2Vob2xkZXIiLCBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIkNsYXNzIGZpbHRlciIpKTsKKyAgICAgICAgY2xhc3NOYW1lRmls dGVyLmFkZEV2ZW50TGlzdGVuZXIoImtleXVwIiwgdGhpcy5fY2hhbmdlTmFtZUZpbHRlci5iaW5k KHRoaXMsIGNsYXNzTmFtZUZpbHRlciksIGZhbHNlKTsKKyAgICAgICAgdG9vbGJhci5hcHBlbmRD aGlsZChjbGFzc05hbWVGaWx0ZXIpOworICAgICAgICByZXR1cm4gdG9vbGJhcjsKKyAgICB9LAor CisgICAgX2NoYW5nZU5hbWVGaWx0ZXI6IGZ1bmN0aW9uKGNsYXNzTmFtZUlucHV0RWxlbWVudCkK KyAgICB7CisgICAgICAgIHZhciBmaWx0ZXIgPSBjbGFzc05hbWVJbnB1dEVsZW1lbnQudmFsdWUu dG9Mb3dlckNhc2UoKTsKKyAgICAgICAgdmFyIGNoaWxkcmVuID0gdGhpcy5kYXRhR3JpZC5jaGls ZHJlbjsKKyAgICAgICAgZm9yICh2YXIgaSA9IDAsIGwgPSBjaGlsZHJlbi5sZW5ndGg7IGkgPCBs OyArK2kpIHsKKyAgICAgICAgICAgIHZhciBub2RlID0gY2hpbGRyZW5baV07CisgICAgICAgICAg ICBpZiAobm9kZS5kZXB0aCA9PT0gMCkKKyAgICAgICAgICAgICAgICBub2RlLnJldmVhbGVkID0g bm9kZS5fbmFtZS50b0xvd2VyQ2FzZSgpLmluZGV4T2YoZmlsdGVyKSAhPT0gLTE7CisgICAgICAg IH0KICAgICB9LAogCiAgICAgX3Byb2ZpbGVzOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2hlYXBQcm9maWxlci5jc3MgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2hlYXBQcm9maWxlci5jc3MKaW5kZXggZDk4ZTM4 MjNlOWYwYjlhZmVmYjZhMjk0MWUyODY0MWQwNzQ3ZWYyNy4uYzc1MjdkZDA1M2UxNmMyN2E5NTU5 MTNlOTY4NTU1NDY4MTU0Njk2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9oZWFwUHJvZmlsZXIuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaGVhcFByb2ZpbGVyLmNzcwpAQCAtMTg3LDExICsxODcsMTEgQEAgYm9keS5p bmFjdGl2ZSAuaGVhcC1zbmFwc2hvdC1zaWRlYmFyLXRyZWUtaXRlbS53YWl0LnNlbGVjdGVkIC5p Y29uIHsKICAgICByaWdodDogMDsKIH0KIAotLmRldGFpbGVkLWhlYXBzaG90LXZpZXcgLmNvbnN0 cnVjdG9ycy12aWV3LWdyaWQgeworLmRldGFpbGVkLWhlYXBzaG90LXZpZXcgLmNsYXNzLXZpZXct Z3JpZCB7CiAgICAgdG9wOiAyMnB4OwogfQogCi0uZGV0YWlsZWQtaGVhcHNob3QtdmlldyAuY29u c3RydWN0b3JzLXZpZXctdG9vbGJhciB7CisuZGV0YWlsZWQtaGVhcHNob3QtdmlldyAuY2xhc3Mt dmlldy10b29sYmFyIHsKICAgICBoZWlnaHQ6IDIycHg7CiAgICAgYmFja2dyb3VuZC1jb2xvcjog I0RERDsKICAgICBkaXNwbGF5OiBibG9jazsKQEAgLTIwMSw3ICsyMDEsNyBAQCBib2R5LmluYWN0 aXZlIC5oZWFwLXNuYXBzaG90LXNpZGViYXItdHJlZS1pdGVtLndhaXQuc2VsZWN0ZWQgLmljb24g ewogICAgIHRvcDogMDsKIH0KIAotLmRldGFpbGVkLWhlYXBzaG90LXZpZXcgLmNvbnN0cnVjdG9y cy12aWV3LXRvb2xiYXIgaW5wdXQuY29uc3RydWN0b3JzLXZpZXctZmlsdGVyIHsKKy5kZXRhaWxl ZC1oZWFwc2hvdC12aWV3IC5jbGFzcy12aWV3LXRvb2xiYXIgaW5wdXQuY2xhc3MtbmFtZS1maWx0 ZXIgewogICAgIHdpZHRoOiAyMDBweDsKICAgICBoZWlnaHQ6IDE4cHg7CiAgICAgZm9udC1zaXpl OiAxMXB4Owo=