81639 2012-03-20 02:06:32 -0700 Fix the error type in JSAudioBufferSourceNodeCustom to pass layout test. 2012-03-29 08:55:08 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 sh919.park webkit-unassigned crogers dw.im dynastpsh eric.carlson pnormand s.choi webkit.review.bot oldest_to_newest 582870 0 sh919.park 2012-03-20 02:06:32 -0700 The layout tests for the WebAudio APIs have all passed using Chromium, but encountered 1 crash error in Gtk port. Crash List - LayoutTest/webaudio/audiobuffersource-channels.html The reason for causing crash is that it returns a wrong type (e.g., SyntaxError should have been TypeError). 587473 1 133731 sh919.park 2012-03-25 23:21:52 -0700 Created attachment 133731 Patch Initial patch! 590106 2 crogers 2012-03-28 10:33:31 -0700 This seems good, but adding Eric Carlson since he likely knows more about details of JSC bindings. 590671 3 eric.carlson 2012-03-28 17:50:12 -0700 (In reply to comment #0) > The layout tests for the WebAudio APIs have all passed using Chromium, > but encountered 1 crash error in Gtk port. > > Crash List > - LayoutTest/webaudio/audiobuffersource-channels.html > > The reason for causing crash is that it returns a wrong type (e.g., > SyntaxError should have been TypeError). Do you mean that the test actually crashed, or that it simply failed? 590695 4 sh919.park 2012-03-28 18:10:24 -0700 (In reply to comment #3) > (In reply to comment #0) > > The layout tests for the WebAudio APIs have all passed using Chromium, > > but encountered 1 crash error in Gtk port. > > > > Crash List > > - LayoutTest/webaudio/audiobuffersource-channels.html > > > > The reason for causing crash is that it returns a wrong type (e.g., > > SyntaxError should have been TypeError). > > Do you mean that the test actually crashed, or that it simply failed? Sorry for the confusion - the test was simply failed due to the error type mismatch. 591217 5 eric.carlson 2012-03-29 08:47:31 -0700 (In reply to comment #4) > > Sorry for the confusion - the test was simply failed due to the error type mismatch. No problem! I just wanted to make sure I understood the issue. 591224 6 133731 webkit.review.bot 2012-03-29 08:55:02 -0700 Comment on attachment 133731 Patch Clearing flags on attachment: 133731 Committed r112535: <http://trac.webkit.org/changeset/112535> 591225 7 webkit.review.bot 2012-03-29 08:55:08 -0700 All reviewed patches have been landed. Closing bug. 133731 2012-03-25 23:21:52 -0700 2012-03-29 08:55:02 -0700 Patch atch-[20120320]-[sh919.park@samsung.com]-[fix-the-error-type-in-JSAudioBufferSourceNodeCustom].patch text/plain 1914 sh919.park ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhN2MxZTRhLi45MWRhZTYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMDMtMjAgIFNhbmdoeXVuIFBhcmsgIDxzaDkxOS5wYXJrQHNhbXN1bmcuY29tPgor CisgICAgICAgIEZpeCB0aGUgZXJyb3IgdHlwZSBpbiBKU0F1ZGlvQnVmZmVyU291cmNlTm9kZUN1 c3RvbSB0byBwYXNzIGxheW91dCB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODE2MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0IDogTGF5b3V0VGVzdC93ZWJhdWRpby9hdWRpb2J1ZmZlcnNv dXJjZS1jaGFubmVscy5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0F1ZGlvQnVmZmVy U291cmNlTm9kZUN1c3RvbS5jcHA6CisKIDIwMTItMDMtMTUgIFBhdmVsIFBvZGl2aWxvdiAgPHBv ZGl2aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogc3VwcG9ydCBp bmxpbmUgc291cmNlIG1hcHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0F1ZGlvQnVmZmVyU291cmNlTm9kZUN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0F1ZGlvQnVmZmVyU291cmNlTm9kZUN1c3RvbS5jcHAKaW5kZXggMmQ5MTdlYi4u MzRiM2Q3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNBdWRpb0J1 ZmZlclNvdXJjZU5vZGVDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTQXVkaW9CdWZmZXJTb3VyY2VOb2RlQ3VzdG9tLmNwcApAQCAtMSw1ICsxLDYgQEAKIC8qCiAg KiBDb3B5cmlnaHQgKEMpIDIwMTAsIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMTIgU2Ftc3VuZyBFbGVjdHJvbmljcwogICoKICAqIFJlZGlzdHJp YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91 dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv d2luZyBjb25kaXRpb25zCkBAIC00MiwxMiArNDMsMTIgQEAgdm9pZCBKU0F1ZGlvQnVmZmVyU291 cmNlTm9kZTo6c2V0QnVmZmVyKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSkKICAgICBB dWRpb0J1ZmZlclNvdXJjZU5vZGUqIGltcCA9IHN0YXRpY19jYXN0PEF1ZGlvQnVmZmVyU291cmNl Tm9kZSo+KGltcGwoKSk7CiAgICAgQXVkaW9CdWZmZXIqIGJ1ZmZlciA9IHRvQXVkaW9CdWZmZXIo dmFsdWUpOwogICAgIGlmICghYnVmZmVyKSB7Ci0gICAgICAgIHRocm93RXJyb3IoZXhlYywgY3Jl YXRlU3ludGF4RXJyb3IoZXhlYywgIlZhbHVlIGlzIG5vdCBvZiB0eXBlIEF1ZGlvQnVmZmVyIikp OworICAgICAgICB0aHJvd0Vycm9yKGV4ZWMsIGNyZWF0ZVR5cGVFcnJvcihleGVjLCAiVmFsdWUg aXMgbm90IG9mIHR5cGUgQXVkaW9CdWZmZXIiKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAg ICAgCiAgICAgaWYgKCFpbXAtPnNldEJ1ZmZlcihidWZmZXIpKQotICAgICAgICB0aHJvd0Vycm9y KGV4ZWMsIGNyZWF0ZVN5bnRheEVycm9yKGV4ZWMsICJBdWRpb0J1ZmZlciB1bnN1cHBvcnRlZCBu dW1iZXIgb2YgY2hhbm5lbHMiKSk7CisgICAgICAgIHRocm93RXJyb3IoZXhlYywgY3JlYXRlVHlw ZUVycm9yKGV4ZWMsICJBdWRpb0J1ZmZlciB1bnN1cHBvcnRlZCBudW1iZXIgb2YgY2hhbm5lbHMi KSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK