81636 2012-03-20 01:17:37 -0700 [EFL] Change returned view mode in case of NULL of ewkView. 2012-03-22 08:18:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 k.czech webkit-unassigned eric g.czajkowski gyuyoung.kim kling lucas.de.marchi rakuco rniwa webkit.review.bot oldest_to_newest 582847 0 k.czech 2012-03-20 01:17:37 -0700 Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView. 582849 1 132777 k.czech 2012-03-20 01:23:11 -0700 Created attachment 132777 Change returned view mode in case of NULL of ewkView 582859 2 132777 gyuyoung.kim 2012-03-20 01:49:41 -0700 Comment on attachment 132777 Change returned view mode in case of NULL of ewkView LGTM. 582897 3 g.czajkowski 2012-03-20 03:20:47 -0700 LGTM. 583000 4 132777 rakuco 2012-03-20 06:18:03 -0700 Comment on attachment 132777 Change returned view mode in case of NULL of ewkView Looks good, thanks. 585273 5 k.czech 2012-03-22 07:50:59 -0700 CCing reviewers. 585280 6 132777 eric 2012-03-22 07:56:38 -0700 Comment on attachment 132777 Change returned view mode in case of NULL of ewkView I'm happy to rubber-stamp this, I know next-to-nothing about EFL however. 585308 7 132777 webkit.review.bot 2012-03-22 08:18:13 -0700 Comment on attachment 132777 Change returned view mode in case of NULL of ewkView Clearing flags on attachment: 132777 Committed r111703: <http://trac.webkit.org/changeset/111703> 585309 8 webkit.review.bot 2012-03-22 08:18:19 -0700 All reviewed patches have been landed. Closing bug. 132777 2012-03-20 01:23:11 -0700 2012-03-22 08:18:13 -0700 Change returned view mode in case of NULL of ewkView ewk-view-mode.patch text/plain 2007 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzMDY3NzVhLi43YTVlN2JkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMTYgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ2hhbmdlIHJldHVybmVkIHZpZXcgbW9kZSBpbiBj YXNlIG9mIE5VTEwgb2YgZXdrVmlldy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTgxNjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRnVuY3Rpb24gZXdrX3ZpZXdfbW9kZV9nZXQgcmV0dXJucyB3cm9uZyB2 aWV3IG1vZGUgaW4gY2FzZSBvZiBOVUxMIG9mIGV3a1ZpZXcuCisKKyAgICAgICAgKiBld2svZXdr X3ZpZXcuY3BwOgorICAgICAgICAoX0V3a19WaWV3X1ByaXZhdGVfRGF0YSk6CisgICAgICAgIChl d2tfdmlld19tb2RlX2dldCk6CisKIDIwMTItMDMtMTMgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUu Y29tPgogCiAgICAgICAgIFNlcGFyYXRlIE5PVElGSUNBVElPTlMgYW5kIExFR0FDWV9OT1RJRklD QVRJT05TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCAxN2E2ZWEwLi5jNzQ5MzVl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTM3NzcsOCArMzc3Nyw4IEBAIEVp bmFfQm9vbCBld2tfdmlld19tb2RlX3NldChFdmFzX09iamVjdCogZXdrVmlldywgRXdrX1ZpZXdf TW9kZSB2aWV3TW9kZSkKIAogRXdrX1ZpZXdfTW9kZSBld2tfdmlld19tb2RlX2dldChjb25zdCBF dmFzX09iamVjdCogZXdrVmlldykKIHsKLSAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKGV3 a1ZpZXcsIHNtYXJ0RGF0YSwgRVdLX1ZJRVdfTU9ERV9XSU5ET1dFRCk7Ci0gICAgRVdLX1ZJRVdf UFJJVl9HRVRfT1JfUkVUVVJOKHNtYXJ0RGF0YSwgcHJpdiwgRVdLX1ZJRVdfTU9ERV9XSU5ET1dF RCk7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihld2tWaWV3LCBzbWFydERhdGEsIEVX S19WSUVXX01PREVfSU5WQUxJRCk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNt YXJ0RGF0YSwgcHJpdiwgRVdLX1ZJRVdfTU9ERV9JTlZBTElEKTsKIAogICAgIHJldHVybiBzdGF0 aWNfY2FzdDxFd2tfVmlld19Nb2RlPihwcml2LT5wYWdlLT52aWV3TW9kZSgpKTsKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmgKaW5kZXggN2RlMGU0Ni4uMWM1MzMzNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmgKQEAgLTIyMzksNyArMjIzOSw4IEBAIEVBUEkgRWluYV9Cb29sIGV3a192aWV3 X21vZGVfc2V0KEV2YXNfT2JqZWN0ICpvLCBFd2tfVmlld19Nb2RlIHZpZXdfbW9kZSk7CiAgKgog ICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8gZ2V0IHRoZSB2aWV3IG1vZGUKICAqCi0gKiBAcmV0 dXJuIGVudW0gdmFsdWUgb2YgQGEgRXdrX1ZpZXdfTW9kZSB0aGF0IGluZGljYXRlcyBjdXJyZW50 IHZpZXcgbW9kZQorICogQHJldHVybiBlbnVtIHZhbHVlIG9mIEBhIEV3a19WaWV3X01vZGUgdGhh dCBpbmRpY2F0ZXMgY3VycmVudCB2aWV3IG1vZGUgb24gc3VjY2VzcyBvcgorICogICAgICAgICBF V0tfVklFV19NT0RFX0lOVkFMSUQgb3RoZXJ3aXNlCiAgKgogICogQHNlZSBld2tfdmlld19tb2Rl X3NldCgpCiAgKi8K