81633 2012-03-19 23:29:27 -0700 Use CSSPrimitiveValue::convertToLength() to handle CSSPropertyWebkitBoxReflect and in createGridTrackBreadth. 2012-03-20 16:19:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson menard webkit.review.bot oldest_to_newest 582792 0 macpherson 2012-03-19 23:29:27 -0700 Use CSSPrimitiveValue::convertToLength() to handle CSSPropertyWebkitBoxReflect and in createGridTrackBreadth. 582793 1 132767 macpherson 2012-03-19 23:30:22 -0700 Created attachment 132767 Patch 583573 2 132767 webkit.review.bot 2012-03-20 16:19:10 -0700 Comment on attachment 132767 Patch Clearing flags on attachment: 132767 Committed r111460: <http://trac.webkit.org/changeset/111460> 583574 3 webkit.review.bot 2012-03-20 16:19:14 -0700 All reviewed patches have been landed. Closing bug. 132767 2012-03-19 23:30:22 -0700 2012-03-20 16:19:10 -0700 Patch bug-81633-20120320173020.patch text/plain 3373 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzExNDJlNzIyZjgwOWZm OTI4NzRhZjlmNjEwNjAxOTBiYzQ4ZDg1NS4uM2M4Y2MwMWNmMTVhNGU0ZDIxOTYzZjEyZTIwYjg3 NmI3YjdlZTYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE5ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBVc2UgQ1NT UHJpbWl0aXZlVmFsdWU6OmNvbnZlcnRUb0xlbmd0aCgpIHRvIGhhbmRsZSBDU1NQcm9wZXJ0eVdl YmtpdEJveFJlZmxlY3QgYW5kIGluIGNyZWF0ZUdyaWRUcmFja0JyZWFkdGguCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTYzMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAvIHJlZmFj dG9yaW5nIG9ubHkuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpjb2xsZWN0TWF0Y2hpbmdSdWxlc0Zvckxp c3QpOgorCiAyMDEyLTAzLTE5ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQu b3JnPgogCiAgICAgICAgIE1vdmUgdGhlIGV4dHJhIGxvZ2ljYWwgaGVpZ2h0IGRpc3RyaWJ1dGlv biBpbnRvIFJlbmRlclRhYmxlIGFzIGEgbmV3IHN0ZXAgaW4gb3VyIGxheW91dCBhbGdvcml0aG0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCBkYjJlZTk3NzIzZmMx Y2M4OWQ3ZDFmNjlmY2FhNTI2ZTdjYmEwZTAyLi5hY2NmZmY5MmE0OTE2NTU3MmIyMjI2YWI0N2Q1 Yjg2ODAzYzg1NDg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxl Y3Rvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBA IC0yOTE4LDIzICsyOTE4LDE1IEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6dXNlU1ZHWm9vbVJ1 bGVzKCkKIAogc3RhdGljIGJvb2wgY3JlYXRlR3JpZFRyYWNrQnJlYWR0aChDU1NQcmltaXRpdmVW YWx1ZSogcHJpbWl0aXZlVmFsdWUsIENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBMZW5ndGgm IGxlbmd0aCkKIHsKLSAgICBpZiAocHJpbWl0aXZlVmFsdWUtPmdldElkZW50KCkgPT0gQ1NTVmFs dWVBdXRvKSB7Ci0gICAgICAgIGxlbmd0aCA9IExlbmd0aCgpOwotICAgICAgICByZXR1cm4gdHJ1 ZTsKLSAgICB9Ci0KLSAgICBpZiAocHJpbWl0aXZlVmFsdWUtPmlzTGVuZ3RoKCkpIHsKLSAgICAg ICAgbGVuZ3RoID0gcHJpbWl0aXZlVmFsdWUtPmNvbXB1dGVMZW5ndGg8TGVuZ3RoPihzZWxlY3Rv ci0+c3R5bGUoKSwgc2VsZWN0b3ItPnJvb3RFbGVtZW50U3R5bGUoKSwgc2VsZWN0b3ItPnN0eWxl KCktPmVmZmVjdGl2ZVpvb20oKSk7Ci0gICAgICAgIGxlbmd0aC5zZXRRdWlyayhwcmltaXRpdmVW YWx1ZS0+aXNRdWlya1ZhbHVlKCkpOwotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9CisgICAg TGVuZ3RoIHdvcmtpbmdMZW5ndGggPSBwcmltaXRpdmVWYWx1ZS0+Y29udmVydFRvTGVuZ3RoPEZp eGVkSW50ZWdlckNvbnZlcnNpb24gfCBQZXJjZW50Q29udmVyc2lvbiB8IEF1dG9Db252ZXJzaW9u PihzZWxlY3Rvci0+c3R5bGUoKSwgc2VsZWN0b3ItPnJvb3RFbGVtZW50U3R5bGUoKSwgc2VsZWN0 b3ItPnN0eWxlKCktPmVmZmVjdGl2ZVpvb20oKSk7CisgICAgaWYgKHdvcmtpbmdMZW5ndGguaXNV bmRlZmluZWQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKHByaW1pdGl2ZVZh bHVlLT5pc1BlcmNlbnRhZ2UoKSkgewotICAgICAgICBsZW5ndGggPSBMZW5ndGgocHJpbWl0aXZl VmFsdWUtPmdldERvdWJsZVZhbHVlKCksIFBlcmNlbnQpOwotICAgICAgICByZXR1cm4gdHJ1ZTsK LSAgICB9CisgICAgaWYgKHByaW1pdGl2ZVZhbHVlLT5pc0xlbmd0aCgpKQorICAgICAgICB3b3Jr aW5nTGVuZ3RoLnNldFF1aXJrKHByaW1pdGl2ZVZhbHVlLT5pc1F1aXJrVmFsdWUoKSk7CiAKLSAg ICByZXR1cm4gZmFsc2U7CisgICAgbGVuZ3RoID0gd29ya2luZ0xlbmd0aDsKKyAgICByZXR1cm4g dHJ1ZTsKIH0KIAogc3RhdGljIGJvb2wgY3JlYXRlR3JpZFRyYWNrTGlzdChDU1NWYWx1ZSogdmFs dWUsIFZlY3RvcjxMZW5ndGg+JiBsZW5ndGhzLCBDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3RvcikK QEAgLTMzNzAsMTIgKzMzNjIsOCBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVy dHkoaW50IGlkLCBDU1NWYWx1ZSAqdmFsdWUpCiAgICAgICAgIENTU1JlZmxlY3RWYWx1ZSogcmVm bGVjdFZhbHVlID0gc3RhdGljX2Nhc3Q8Q1NTUmVmbGVjdFZhbHVlKj4odmFsdWUpOwogICAgICAg ICBSZWZQdHI8U3R5bGVSZWZsZWN0aW9uPiByZWZsZWN0aW9uID0gU3R5bGVSZWZsZWN0aW9uOjpj cmVhdGUoKTsKICAgICAgICAgcmVmbGVjdGlvbi0+c2V0RGlyZWN0aW9uKHJlZmxlY3RWYWx1ZS0+ ZGlyZWN0aW9uKCkpOwotICAgICAgICBpZiAocmVmbGVjdFZhbHVlLT5vZmZzZXQoKSkgewotICAg ICAgICAgICAgaWYgKHJlZmxlY3RWYWx1ZS0+b2Zmc2V0KCktPmlzUGVyY2VudGFnZSgpKQotICAg ICAgICAgICAgICAgIHJlZmxlY3Rpb24tPnNldE9mZnNldChMZW5ndGgocmVmbGVjdFZhbHVlLT5v ZmZzZXQoKS0+Z2V0RG91YmxlVmFsdWUoKSwgUGVyY2VudCkpOwotICAgICAgICAgICAgZWxzZQot ICAgICAgICAgICAgICAgIHJlZmxlY3Rpb24tPnNldE9mZnNldChyZWZsZWN0VmFsdWUtPm9mZnNl dCgpLT5jb21wdXRlTGVuZ3RoPExlbmd0aD4oc3R5bGUoKSwgbV9yb290RWxlbWVudFN0eWxlLCB6 b29tRmFjdG9yKSk7Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKHJlZmxlY3RWYWx1ZS0+b2Zmc2V0 KCkpCisgICAgICAgICAgICByZWZsZWN0aW9uLT5zZXRPZmZzZXQocmVmbGVjdFZhbHVlLT5vZmZz ZXQoKS0+Y29udmVydFRvTGVuZ3RoPEZpeGVkSW50ZWdlckNvbnZlcnNpb24gfCBQZXJjZW50Q29u dmVyc2lvbj4oc3R5bGUoKSwgbV9yb290RWxlbWVudFN0eWxlLCB6b29tRmFjdG9yKSk7CiAgICAg ICAgIE5pbmVQaWVjZUltYWdlIG1hc2s7CiAgICAgICAgIG1hc2suc2V0TWFza0RlZmF1bHRzKCk7 CiAgICAgICAgIG1hcE5pbmVQaWVjZUltYWdlKHByb3BlcnR5LCByZWZsZWN0VmFsdWUtPm1hc2so KSwgbWFzayk7Cg==