81619 2012-03-19 19:10:26 -0700 [EFL] Fix build break because of PlatformString.h 2012-03-20 01:55:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim eric gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 582608 0 gyuyoung.kim 2012-03-19 19:10:26 -0700 wtf/PlatformString.h was removed. So, IconEfl.cpp file can't find PlatformString.h. This patch fixes this build error. 582612 1 132745 gyuyoung.kim 2012-03-19 19:12:19 -0700 Created attachment 132745 Patch 582736 2 132745 webkit.review.bot 2012-03-19 21:39:51 -0700 Comment on attachment 132745 Patch Clearing flags on attachment: 132745 Committed r111348: <http://trac.webkit.org/changeset/111348> 582737 3 webkit.review.bot 2012-03-19 21:39:56 -0700 All reviewed patches have been landed. Closing bug. 582749 4 eric 2012-03-19 22:16:40 -0700 I'm sorry I broke your build. This fix is wrong however. < > is used for system headers. Headers which are sought for beyond the current directory. <text/PlatformString> is suggesting that somehow "text" is some separate module, which is not true. This header should just be "PlatformString.h", I'm sorry for wrongly changing it to <wtf/PlatformString.h> earlier. <wtf/text/WTFString.h> is basically equivalent to PlatformString.h and some day we'll remove PlatformString.h I think. 582864 5 gyuyoung.kim 2012-03-20 01:55:09 -0700 (In reply to comment #4) > I'm sorry I broke your build. This fix is wrong however. > > < > is used for system headers. Headers which are sought for beyond the current directory. > > <text/PlatformString> is suggesting that somehow "text" is some separate module, which is not true. > > This header should just be "PlatformString.h", I'm sorry for wrongly changing it to <wtf/PlatformString.h> earlier. <wtf/text/WTFString.h> is basically equivalent to PlatformString.h and some day we'll remove PlatformString.h I think. Ah, thank you for your fix again. 132745 2012-03-19 19:12:19 -0700 2012-03-19 21:39:51 -0700 Patch bug-81619-20120320111220.patch text/plain 1254 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA1MTcyOWFhYzg0MjBh ZWViN2MxMzRmNTZlNDRjMzhkOTFhMTc0ZS4uNjg3MjIwODU2ZjhkZGFkMjAzZjlhMzBkM2Y2ZmUz NmU4NGY5YzNjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAzLTE5ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gRml4 IGJ1aWxkIGJyZWFrIGJlY2F1c2Ugb2YgUGxhdGZvcm1TdHJpbmcuaAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE2MTkKKworICAgICAgICBVbnJldmll d2VkLiBGaXggYnVpbGQgYnJlYWsgYmVjYXVzZSBvZiBQbGF0Zm9ybVN0cmluZy5oLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0ljb25FZmwuY3BwOiBJbmNsdWRlIFBsYXRmb3Jt U3RyaW5nLmggZnJvbSB0ZXh0IGRpcmVjdG9yeS4KKwogMjAxMi0wMy0xOSAgRmxvcmluIE1hbGl0 YSAgPGZtYWxpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZWxhdGl2ZS1oZWlnaHQgYmxvY2sg U1ZHIHJvb3Qgbm90IGxheWVkIG91dCBvbiBjb250YWluZXIgaGVpZ2h0IGNoYW5nZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0ljb25FZmwuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0ljb25FZmwuY3BwCmluZGV4IDI3 YTFlNjdjZjA2ZDNiMWNjMTVhYjRhZGQ1ODhmZTIwM2E3Y2U4YjAuLmU3NDgxMGE3MDk5OGFhMzdh ZDViM2UzMTMwNWRiNWE5ZmUxNDgwZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2VmbC9JY29uRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9lZmwvSWNvbkVmbC5jcHAKQEAgLTM4LDggKzM4LDggQEAKICNpbmNsdWRlICJN SU1FVHlwZVJlZ2lzdHJ5LmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKIAorI2luY2x1 ZGUgPHRleHQvUGxhdGZvcm1TdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgot I2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybVN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK