81586 2012-03-19 16:21:01 -0700 webkitpy: crashlog parsing is broken 2012-03-19 18:29:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71380 1 dpranke dpranke abarth ojan webkit.review.bot oldest_to_newest 582408 0 dpranke 2012-03-19 16:21:01 -0700 webkitpy: crashlog parsing is broken 582433 1 132712 dpranke 2012-03-19 16:34:31 -0700 Created attachment 132712 Patch 582458 2 132712 abarth 2012-03-19 16:50:33 -0700 Comment on attachment 132712 Patch Is this what was causing the truncated crash logs on the Mac bots? 582464 3 dpranke 2012-03-19 16:54:17 -0700 (In reply to comment #2) > (From update of attachment 132712 [details]) > Is this what was causing the truncated crash logs on the Mac bots? Yup. 582574 4 dpranke 2012-03-19 18:29:03 -0700 Committed r111291: <http://trac.webkit.org/changeset/111291> 132712 2012-03-19 16:34:31 -0700 2012-03-19 16:50:33 -0700 Patch bug-81586-20120319163430.patch text/plain 6148 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMjYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGIzMGY0YTViN2QxYmFjYTE1MGM0Y2Q4NWU5YThiNzE4 MjlhMzU4Ny4uZGQ5YzY5NGQzMWZhNTZkZGVlZjIyMGQyYjNjOTI4YjBkOTU3YzIwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMw IEBACiAyMDEyLTAzLTE5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHdlYmtpdHB5OiBjcmFzaGxvZyBwYXJzaW5nIGlzIGJyb2tlbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE1ODYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZWVraW5nIG9uIGEgZmlsZSBvcGVu ZWQgdGhyb3VnaCBjb2RlY3MoKSBhcHBlYXJzIHRvIG5vdCB3b3JrCisgICAgICAgIGNvcnJlY3Rs eSAoYXQgbGVhc3Qgb24gU0wpLgorICAgICAgICAKKyAgICAgICAgVGhlIGNvZGUgd2FzIG1vcmUg Y29tcGxpY2F0ZWQgdGhhbiBpdCBuZWVkZWQgdG8gYmUsIHNvIEkgaGF2ZQorICAgICAgICByZXZh bXBlZCBpdCB0byBqdXN0IHJlYWQgYSBmdWxsIGNyYXNobG9nIGF0IG9uY2UgYW5kIHRoZW4gbG9v aworICAgICAgICBmb3IgbWF0Y2hlcy4gCisgICAgICAgIAorICAgICAgICBJIGhhdmUgYWxzbyBh ZGRlZCB0aGUgYWJpbGl0eSB0byBvcHRpb25hbGx5IHByb3BhZ2F0ZQorICAgICAgICBlcnJvcnMg YmFjayAod2hpY2ggY2FuIGJlIGhlbHBmdWwgdG8gZGVidWcgcmFjZXMgd2hlbiBSZXBvcnRDcmFz aCBpcworICAgICAgICBzdGlsbCBydW5uaW5nIGFuZCB5b3UgbmVlZCB0byBzZWUgdGhhdCB5b3Ug Y291bGRuJ3Qgb3BlbiBzb21lCisgICAgICAgIGZpbGVzLCByYXRoZXIgdGhhbiBqdXN0IGlnbm9y aW5nIHRoZW0pLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2Ny YXNobG9ncy5weToKKyAgICAgICAgKENyYXNoTG9ncy5maW5kX25ld2VzdF9sb2cpOgorICAgICAg ICAoQ3Jhc2hMb2dzLl9maW5kX25ld2VzdF9sb2dfZGFyd2luKToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vY3Jhc2hsb2dzX3VuaXR0ZXN0LnB5OgorICAgICAgICAo Q3Jhc2hMb2dzVGVzdC50ZXN0X2ZpbmRfbG9nX2Rhcndpbik6CisKKzIwMTItMDMtMTkgIERpcmsg UHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgTlJXVCBydW5zIHNvbWUg dGVzdHMgdGhhdCBhcmUgc2tpcHBlZCB3aXRoIC1pIGNvbW1hbmQgbGluZSBvcHRpb24KICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNTM1CiAKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9jcmFzaGxvZ3MucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vY3Jhc2hsb2dzLnB5CmluZGV4 IGE2YjY1NzVmNjA0MTMxMTNjYTYxZjFmNzk0YTMzNmVlOTI4OWE2OTAuLmM2NDcyZDZhMDk5OWFm ZmI3YjdjZmIzM2ExZjgwYzcyMzA3MDYxMjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9jcmFzaGxvZ3MucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9ncy5weQpAQCAtMzUsOSArMzUsMTAgQEAgY2xhc3Mg Q3Jhc2hMb2dzKG9iamVjdCk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGZpbGVzeXN0ZW0pOgog ICAgICAgICBzZWxmLl9maWxlc3lzdGVtID0gZmlsZXN5c3RlbQogCi0gICAgZGVmIGZpbmRfbmV3 ZXN0X2xvZyhzZWxmLCBwcm9jZXNzX25hbWUsIHBpZD1Ob25lKToKKyAgICBkZWYgZmluZF9uZXdl c3RfbG9nKHNlbGYsIHByb2Nlc3NfbmFtZSwgcGlkPU5vbmUsIGluY2x1ZGVfZXJyb3JzPUZhbHNl KToKICAgICAgICAgaWYgc3lzLnBsYXRmb3JtID09ICJkYXJ3aW4iOgotICAgICAgICAgICAgcmV0 dXJuIHNlbGYuX2ZpbmRfbmV3ZXN0X2xvZ19kYXJ3aW4ocHJvY2Vzc19uYW1lLCBwaWQpCisgICAg ICAgICAgICByZXR1cm4gc2VsZi5fZmluZF9uZXdlc3RfbG9nX2Rhcndpbihwcm9jZXNzX25hbWUs IHBpZCwgaW5jbHVkZV9lcnJvcnMpCisgICAgICAgIHJldHVybiBOb25lCiAKICAgICBkZWYgX2xv Z19kaXJlY3RvcnlfZGFyd2luKHNlbGYpOgogICAgICAgICBsb2dfZGlyZWN0b3J5ID0gc2VsZi5f ZmlsZXN5c3RlbS5leHBhbmR1c2VyKCJ+IikKQEAgLTQ4LDI5ICs0OSwyNCBAQCBjbGFzcyBDcmFz aExvZ3Mob2JqZWN0KToKICAgICAgICAgICAgIGxvZ19kaXJlY3RvcnkgPSBzZWxmLl9maWxlc3lz dGVtLmpvaW4obG9nX2RpcmVjdG9yeSwgIkNyYXNoUmVwb3J0ZXIiKQogICAgICAgICByZXR1cm4g bG9nX2RpcmVjdG9yeQogCi0gICAgZGVmIF9maW5kX25ld2VzdF9sb2dfZGFyd2luKHNlbGYsIHBy b2Nlc3NfbmFtZSwgcGlkKToKKyAgICBkZWYgX2ZpbmRfbmV3ZXN0X2xvZ19kYXJ3aW4oc2VsZiwg cHJvY2Vzc19uYW1lLCBwaWQsIGluY2x1ZGVfZXJyb3JzKToKICAgICAgICAgZGVmIGlzX2NyYXNo X2xvZyhmcywgZGlycGF0aCwgYmFzZW5hbWUpOgogICAgICAgICAgICAgcmV0dXJuIGJhc2VuYW1l LnN0YXJ0c3dpdGgocHJvY2Vzc19uYW1lICsgIl8iKSBhbmQgYmFzZW5hbWUuZW5kc3dpdGgoIi5j cmFzaCIpCiAKICAgICAgICAgbG9nX2RpcmVjdG9yeSA9IHNlbGYuX2xvZ19kaXJlY3RvcnlfZGFy d2luKCkKICAgICAgICAgbG9ncyA9IHNlbGYuX2ZpbGVzeXN0ZW0uZmlsZXNfdW5kZXIobG9nX2Rp cmVjdG9yeSwgZmlsZV9maWx0ZXI9aXNfY3Jhc2hfbG9nKQotICAgICAgICBpZiBub3QgbG9nczoK LSAgICAgICAgICAgIHJldHVybiBOb25lCiAgICAgICAgIGZpcnN0X2xpbmVfcmVnZXggPSByZS5j b21waWxlKHInXlByb2Nlc3M6XHMrKD9QPHByb2Nlc3NfbmFtZT4uKikgXFsoP1A8cGlkPlxkKylc XSQnKQorICAgICAgICBlcnJvcnMgPSAnJwogICAgICAgICBmb3IgcGF0aCBpbiByZXZlcnNlZChz b3J0ZWQobG9ncykpOgogICAgICAgICAgICAgdHJ5OgotICAgICAgICAgICAgICAgIHdpdGggc2Vs Zi5fZmlsZXN5c3RlbS5vcGVuX3RleHRfZmlsZV9mb3JfcmVhZGluZyhwYXRoKSBhcyBmOgotICAg ICAgICAgICAgICAgICAgICBmaXJzdF9saW5lID0gZi5yZWFkbGluZSgpCisgICAgICAgICAgICAg ICAgZiA9IHNlbGYuX2ZpbGVzeXN0ZW0ucmVhZF90ZXh0X2ZpbGUocGF0aCkKKyAgICAgICAgICAg ICAgICBtYXRjaCA9IGZpcnN0X2xpbmVfcmVnZXgubWF0Y2goZlswOmYuZmluZCgnXG4nKV0pCisg ICAgICAgICAgICAgICAgaWYgbWF0Y2ggYW5kIG1hdGNoLmdyb3VwKCdwcm9jZXNzX25hbWUnKSA9 PSBwcm9jZXNzX25hbWUgYW5kIChwaWQgaXMgTm9uZSBvciBpbnQobWF0Y2guZ3JvdXAoJ3BpZCcp KSA9PSBwaWQpOgorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZXJyb3JzICsgZgorICAgICAg ICAgICAgZXhjZXB0IElPRXJyb3IsIGU6CisgICAgICAgICAgICAgICAgaWYgaW5jbHVkZV9lcnJv cnM6CisgICAgICAgICAgICAgICAgICAgIGVycm9ycyArPSAiRVJST1I6IEZhaWxlZCB0byByZWFk ICclcyc6ICVzXG4iICUgKHBhdGgsIHN0cihlKSkKIAotICAgICAgICAgICAgICAgICAgICBtYXRj aCA9IGZpcnN0X2xpbmVfcmVnZXgubWF0Y2goZmlyc3RfbGluZSkKLSAgICAgICAgICAgICAgICAg ICAgaWYgbm90IG1hdGNoOgotICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWUKLSAgICAg ICAgICAgICAgICAgICAgaWYgbWF0Y2guZ3JvdXAoJ3Byb2Nlc3NfbmFtZScpICE9IHByb2Nlc3Nf bmFtZToKLSAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCi0gICAgICAgICAgICAgICAg ICAgIGlmIHBpZCBpcyBub3QgTm9uZSBhbmQgaW50KG1hdGNoLmdyb3VwKCdwaWQnKSkgIT0gcGlk OgotICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWUKLQotICAgICAgICAgICAgICAgICAg ICBmLnNlZWsoMCwgb3MuU0VFS19TRVQpCi0gICAgICAgICAgICAgICAgICAgIHJldHVybiBmLnJl YWQoKQotICAgICAgICAgICAgZXhjZXB0IElPRXJyb3I6Ci0gICAgICAgICAgICAgICAgY29udGlu dWUKKyAgICAgICAgaWYgaW5jbHVkZV9lcnJvcnMgYW5kIGVycm9yczoKKyAgICAgICAgICAgIHJl dHVybiBlcnJvcnMKKyAgICAgICAgcmV0dXJuIE5vbmUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9jcmFzaGxvZ3NfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vY3Jhc2hsb2dzX3VuaXR0ZXN0LnB5CmluZGV4 IGFiMWE2YzJhZDJmNGM4NDg5M2E3Y2U1YjBlMWM0MjUwNTcyYTcwZjguLmUxMmIyMGRkNmJjN2Y4 MjQxZDFlMmY0ZmQ3ZTE5MDU3YTg5MDBmY2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9jcmFzaGxvZ3NfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9nc191bml0dGVzdC5weQpAQCAtMTAw LDMgKzEwMCw5IEBAIGNsYXNzIENyYXNoTG9nc1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAg ICAgICBzZWxmLmFzc2VydExpbmVzRXF1YWwobG9nLCBtb2NrX2NyYXNoX3JlcG9ydCkKICAgICAg ICAgbG9nID0gY3Jhc2hfbG9ncy5maW5kX25ld2VzdF9sb2coIkR1bXBSZW5kZXJUcmVlIiwgMjg1 MzEpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwobG9nLCBOb25lKQorCisgICAgICAgIGVycm9y cyA9ICJFUlJPUjogRmFpbGVkIHRvIHJlYWQgJy9Vc2Vycy9tb2NrL0xpYnJhcnkvTG9ncy9EaWFn bm9zdGljUmVwb3J0cy9EdW1wUmVuZGVyVHJlZV8yMDExLTA2LTEzLTE1MDcyMV9xdWFkemVuLmNy YXNoJzogW0Vycm5vIDJdIC9Vc2Vycy9tb2NrL0xpYnJhcnkvTG9ncy9EaWFnbm9zdGljUmVwb3J0 cy9EdW1wUmVuZGVyVHJlZV8yMDExLTA2LTEzLTE1MDcyMV9xdWFkemVuLmNyYXNoOiAnTm8gc3Vj aCBmaWxlIG9yIGRpcmVjdG9yeSdcbiIKKyAgICAgICAgbG9nID0gY3Jhc2hfbG9ncy5maW5kX25l d2VzdF9sb2coIkR1bXBSZW5kZXJUcmVlIiwgMjg1MzAsIGluY2x1ZGVfZXJyb3JzPVRydWUpCisg ICAgICAgIHNlbGYuYXNzZXJ0TGluZXNFcXVhbChsb2csIGVycm9ycyArIG1vY2tfY3Jhc2hfcmVw b3J0KQorICAgICAgICBsb2cgPSBjcmFzaF9sb2dzLmZpbmRfbmV3ZXN0X2xvZygiRHVtcFJlbmRl clRyZWUiLCAyODUzMSwgaW5jbHVkZV9lcnJvcnM9VHJ1ZSkKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChsb2csIGVycm9ycykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL3N5c3RlbS9maWxlc3lzdGVtLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL2ZpbGVzeXN0ZW0ucHkKaW5kZXggNjBiNjgwYzA2NTk1Y2U1ZWU2MjkxYjkxNGUzMWVl MGNiOTQwZjNiOC4uYzNhNjlhNTFlMzcyMzU4ZjRjMWI2N2Y3YmU5ZDBmNTAxOTMxMDI3ZCAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW0u cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW0u cHkKQEAgLTIwMSw2ICsyMDEsOCBAQCBjbGFzcyBGaWxlU3lzdGVtKG9iamVjdCk6CiAgICAgICAg ICAgICBmLndyaXRlKGNvbnRlbnRzKQogCiAgICAgZGVmIG9wZW5fdGV4dF9maWxlX2Zvcl9yZWFk aW5nKHNlbGYsIHBhdGgpOgorICAgICAgICAjIE5vdGU6IFRoZXJlIGFwcGVhcnMgdG8gYmUgYW4g aXNzdWUgd2l0aCB0aGUgcmV0dXJuZWQgZmlsZSBvYmplY3RzCisgICAgICAgICMgbm90IGJlaW5n IHNlZWthYmxlLiBTZWUgaHR0cDovL3N0YWNrb3ZlcmZsb3cuY29tL3F1ZXN0aW9ucy8xNTEwMTg4 L2Nhbi1zZWVrLWFuZC10ZWxsLXdvcmstd2l0aC11dGYtOC1lbmNvZGVkLWRvY3VtZW50cy1pbi1w eXRob24gLgogICAgICAgICByZXR1cm4gY29kZWNzLm9wZW4ocGF0aCwgJ3InLCAndXRmOCcpCiAK ICAgICBkZWYgb3Blbl90ZXh0X2ZpbGVfZm9yX3dyaXRpbmcoc2VsZiwgcGF0aCk6Cg==