81580 2012-03-19 16:08:04 -0700 webkitpy: allow instance data in TestFailure objects 2012-03-19 18:21:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71380 1 dpranke dpranke abarth eric ojan tony webkit.review.bot oldest_to_newest 582387 0 dpranke 2012-03-19 16:08:04 -0700 webkitpy: allow instance data in TestFailure objects 582390 1 132699 dpranke 2012-03-19 16:08:52 -0700 Created attachment 132699 Patch 582413 2 132699 eric 2012-03-19 16:22:36 -0700 Comment on attachment 132699 Patch I feel like I attempted this change before and someone shot it down. Don't these things get serialized/de-serialized as part of being passed around? I'm fine with this change, but Ojan may have opinions? 582430 3 132699 tony 2012-03-19 16:34:06 -0700 Comment on attachment 132699 Patch Looks like the reftest failure objects are already instances. Should be fine as long as we don't associate anything with the common failure types (which we create lots of instances of). 582445 4 dpranke 2012-03-19 16:45:00 -0700 (In reply to comment #2) > (From update of attachment 132699 [details]) > I feel like I attempted this change before and someone shot it down. Don't these things get serialized/de-serialized as part of being passed around? I'm fine with this change, but Ojan may have opinions? I may have shot it down before :) They do get serialized, but since we're just adding strings and ints, this is safe and although I didn't like the idea of instance data before, I don't quite recall why I didn't, and it's clearly useful now. 582566 5 dpranke 2012-03-19 18:21:26 -0700 Committed r111287: <http://trac.webkit.org/changeset/111287> 132699 2012-03-19 16:08:52 -0700 2012-03-19 16:34:06 -0700 Patch bug-81580-20120319160851.patch text/plain 6894 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMjYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGIzMGY0YTViN2QxYmFjYTE1MGM0Y2Q4NWU5YThiNzE4 MjlhMzU4Ny4uODQyOGJhZTIxNDRjZDhkNDFlN2FhMGUxMjlmZTkyNTg3YTdiZjkwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM4 IEBACiAyMDEyLTAzLTE5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHdlYmtpdHB5OiBhbGxvdyBpbnN0YW5jZSBkYXRhIGluIFRlc3RGYWlsdXJlIG9iamVj dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNTgw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVu dCBUZXN0RmFpbHVyZXMgYXJlIGJhc2ljYWxseSBlbnVtcywgYnV0IGl0IHdvdWxkIGJlIG5pY2Us CisgICAgICAgIGVzcGVjaWFsbHkgZm9yIGNyYXNoZXMsIGlmIHRoZXkgY29udGFpbmVkIHRoZSBu YW1lIGFuZCBwaWQgb2YKKyAgICAgICAgdGhlIHByb2Nlc3MgdGhhdCBjcmFzaGVkLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZmFpbHVyZXMu cHk6CisgICAgICAgIChUZXN0RmFpbHVyZS5tZXNzYWdlKToKKyAgICAgICAgKEZhaWx1cmVUaW1l b3V0Lm1lc3NhZ2UpOgorICAgICAgICAoRmFpbHVyZUNyYXNoKToKKyAgICAgICAgKEZhaWx1cmVD cmFzaC5fX2luaXRfXyk6CisgICAgICAgIChGYWlsdXJlQ3Jhc2gubWVzc2FnZSk6CisgICAgICAg IChGYWlsdXJlTWlzc2luZ1Jlc3VsdC5tZXNzYWdlKToKKyAgICAgICAgKEZhaWx1cmVUZXh0TWlz bWF0Y2gubWVzc2FnZSk6CisgICAgICAgIChGYWlsdXJlTWlzc2luZ0ltYWdlSGFzaC5tZXNzYWdl KToKKyAgICAgICAgKEZhaWx1cmVNaXNzaW5nSW1hZ2UubWVzc2FnZSk6CisgICAgICAgIChGYWls dXJlSW1hZ2VIYXNoTWlzbWF0Y2gubWVzc2FnZSk6CisgICAgICAgIChGYWlsdXJlSW1hZ2VIYXNo SW5jb3JyZWN0Lm1lc3NhZ2UpOgorICAgICAgICAoRmFpbHVyZVJlZnRlc3RNaXNtYXRjaC5tZXNz YWdlKToKKyAgICAgICAgKEZhaWx1cmVSZWZ0ZXN0TWlzbWF0Y2hEaWROb3RPY2N1ci5tZXNzYWdl KToKKyAgICAgICAgKEZhaWx1cmVSZWZ0ZXN0Tm9JbWFnZXNHZW5lcmF0ZWQubWVzc2FnZSk6Cisg ICAgICAgIChGYWlsdXJlTWlzc2luZ0F1ZGlvLm1lc3NhZ2UpOgorICAgICAgICAoRmFpbHVyZUF1 ZGlvTWlzbWF0Y2gubWVzc2FnZSk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvbW9kZWxzL3Rlc3RfZmFpbHVyZXNfdW5pdHRlc3QucHk6CisgICAgICAgIChUZXN0RmFp bHVyZXNUZXN0LnRlc3RfZXF1YWxzKToKKyAgICAgICAgKFRlc3RGYWlsdXJlc1Rlc3QpOgorICAg ICAgICAoVGVzdEZhaWx1cmVzVGVzdC50ZXN0X2NyYXNoZXMpOgorCisyMDEyLTAzLTE5ICBEaXJr IFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIE5SV1QgcnVucyBzb21l IHRlc3RzIHRoYXQgYXJlIHNraXBwZWQgd2l0aCAtaSBjb21tYW5kIGxpbmUgb3B0aW9uCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTUzNQogCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9m YWlsdXJlcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90 ZXN0X2ZhaWx1cmVzLnB5CmluZGV4IGYyZjI0NmUzMGE5ZThjNjM1NzRiMTlhNmQ3ODhjNjk1MjZl YzhlOTAuLjMyOGQ4NTI5ZmJhZDY3ZTA5NWRjMzgwMTNhNmU5OWYxNDBkODlhZWYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1 cmVzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90 ZXN0X2ZhaWx1cmVzLnB5CkBAIC04NSw4ICs4NSw3IEBAIGNsYXNzIFRlc3RGYWlsdXJlKG9iamVj dCk6CiAgICAgICAgICIiIkNyZWF0ZXMgYSBUZXN0RmFpbHVyZSBvYmplY3QgZnJvbSB0aGUgc3Bl Y2lmaWVkIHN0cmluZy4iIiIKICAgICAgICAgcmV0dXJuIGNQaWNrbGUubG9hZHMocykKIAotICAg IEBzdGF0aWNtZXRob2QKLSAgICBkZWYgbWVzc2FnZSgpOgorICAgIGRlZiBtZXNzYWdlKHNlbGYp OgogICAgICAgICAiIiJSZXR1cm5zIGEgc3RyaW5nIGRlc2NyaWJpbmcgdGhlIGZhaWx1cmUgaW4g bW9yZSBkZXRhaWwuIiIiCiAgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IKIApAQCAt MTEzLDggKzExMiw3IEBAIGNsYXNzIEZhaWx1cmVUaW1lb3V0KFRlc3RGYWlsdXJlKToKICAgICBk ZWYgX19pbml0X18oc2VsZiwgaXNfcmVmdGVzdD1GYWxzZSk6CiAgICAgICAgIHNlbGYuaXNfcmVm dGVzdCA9IGlzX3JlZnRlc3QKIAotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgbWVzc2FnZSgp OgorICAgIGRlZiBtZXNzYWdlKHNlbGYpOgogICAgICAgICByZXR1cm4gIlRlc3QgdGltZWQgb3V0 IgogCiAgICAgZGVmIGRyaXZlcl9uZWVkc19yZXN0YXJ0KHNlbGYpOgpAQCAtMTIyLDE0ICsxMjAs MTYgQEAgY2xhc3MgRmFpbHVyZVRpbWVvdXQoVGVzdEZhaWx1cmUpOgogCiAKIGNsYXNzIEZhaWx1 cmVDcmFzaChUZXN0RmFpbHVyZSk6Ci0gICAgIiIiRHVtcFJlbmRlclRyZWUgY3Jhc2hlZC4iIiIK LSAgICBkZWYgX19pbml0X18oc2VsZiwgaXNfcmVmdGVzdD1GYWxzZSk6CisgICAgIiIiRHVtcFJl bmRlclRyZWUvV2ViS2l0VGVzdFJ1bm5lciBjcmFzaGVkLiIiIgorICAgIGRlZiBfX2luaXRfXyhz ZWxmLCBpc19yZWZ0ZXN0PUZhbHNlLCBwcm9jZXNzX25hbWU9J0R1bXBSZW5kZXJUcmVlJywgcGlk PU5vbmUpOgorICAgICAgICBzZWxmLnByb2Nlc3NfbmFtZSA9IHByb2Nlc3NfbmFtZQorICAgICAg ICBzZWxmLnBpZCA9IHBpZAogICAgICAgICBzZWxmLmlzX3JlZnRlc3QgPSBpc19yZWZ0ZXN0CiAK LSAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIG1lc3NhZ2UoKToKLSAgICAgICAgIyBGSVhNRTog VGhpcyBpcyB3cm9uZyBmb3IgV2ViS2l0MiAod2hpY2ggdXNlcyBXZWJLaXRUZXN0UnVubmVyKS4K LSAgICAgICAgcmV0dXJuICJEdW1wUmVuZGVyVHJlZSBjcmFzaGVkIgorICAgIGRlZiBtZXNzYWdl KHNlbGYpOgorICAgICAgICBpZiBzZWxmLnBpZDoKKyAgICAgICAgICAgIHJldHVybiAiJXMgKHBp ZCAlZCkgY3Jhc2hlZCIgJSAoc2VsZi5wcm9jZXNzX25hbWUsIHNlbGYucGlkKQorICAgICAgICBy ZXR1cm4gc2VsZi5wcm9jZXNzX25hbWUgKyAiIGNyYXNoZWQiCiAKICAgICBkZWYgZHJpdmVyX25l ZWRzX3Jlc3RhcnQoc2VsZik6CiAgICAgICAgIHJldHVybiBUcnVlCkBAIC0xMzgsMzIgKzEzOCwy OCBAQCBjbGFzcyBGYWlsdXJlQ3Jhc2goVGVzdEZhaWx1cmUpOgogY2xhc3MgRmFpbHVyZU1pc3Np bmdSZXN1bHQoVGVzdEZhaWx1cmUpOgogICAgICIiIkV4cGVjdGVkIHJlc3VsdCB3YXMgbWlzc2lu Zy4iIiIKIAotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgbWVzc2FnZSgpOgorICAgIGRlZiBt ZXNzYWdlKHNlbGYpOgogICAgICAgICByZXR1cm4gIk5vIGV4cGVjdGVkIHJlc3VsdHMgZm91bmQi CiAKIAogY2xhc3MgRmFpbHVyZVRleHRNaXNtYXRjaChUZXN0RmFpbHVyZSk6CiAgICAgIiIiVGV4 dCBkaWZmIG91dHB1dCBmYWlsZWQuIiIiCiAKLSAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIG1l c3NhZ2UoKToKKyAgICBkZWYgbWVzc2FnZShzZWxmKToKICAgICAgICAgcmV0dXJuICJUZXh0IGRp ZmYgbWlzbWF0Y2giCiAKIAogY2xhc3MgRmFpbHVyZU1pc3NpbmdJbWFnZUhhc2goVGVzdEZhaWx1 cmUpOgogICAgICIiIkFjdHVhbCByZXN1bHQgaGFzaCB3YXMgbWlzc2luZy4iIiIKIAotICAgIEBz dGF0aWNtZXRob2QKLSAgICBkZWYgbWVzc2FnZSgpOgorICAgIGRlZiBtZXNzYWdlKHNlbGYpOgog ICAgICAgICByZXR1cm4gIk5vIGV4cGVjdGVkIGltYWdlIGhhc2ggZm91bmQiCiAKIAogY2xhc3Mg RmFpbHVyZU1pc3NpbmdJbWFnZShUZXN0RmFpbHVyZSk6CiAgICAgIiIiQWN0dWFsIHJlc3VsdCBp bWFnZSB3YXMgbWlzc2luZy4iIiIKIAotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgbWVzc2Fn ZSgpOgorICAgIGRlZiBtZXNzYWdlKHNlbGYpOgogICAgICAgICByZXR1cm4gIk5vIGV4cGVjdGVk IGltYWdlIGZvdW5kIgogCiAKQEAgLTE3MiwxNiArMTY4LDE0IEBAIGNsYXNzIEZhaWx1cmVJbWFn ZUhhc2hNaXNtYXRjaChUZXN0RmFpbHVyZSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGRpZmZf cGVyY2VudD0wKToKICAgICAgICAgc2VsZi5kaWZmX3BlcmNlbnQgPSBkaWZmX3BlcmNlbnQKIAot ICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgbWVzc2FnZSgpOgorICAgIGRlZiBtZXNzYWdlKHNl bGYpOgogICAgICAgICByZXR1cm4gIkltYWdlIG1pc21hdGNoIgogCiAKIGNsYXNzIEZhaWx1cmVJ bWFnZUhhc2hJbmNvcnJlY3QoVGVzdEZhaWx1cmUpOgogICAgICIiIkFjdHVhbCByZXN1bHQgaGFz aCBpcyBpbmNvcnJlY3QuIiIiCiAKLSAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIG1lc3NhZ2Uo KToKKyAgICBkZWYgbWVzc2FnZShzZWxmKToKICAgICAgICAgcmV0dXJuICJJbWFnZXMgbWF0Y2gs IGV4cGVjdGVkIGltYWdlIGhhc2ggaW5jb3JyZWN0LiAiCiAKIApAQCAtMTkxLDggKzE4NSw3IEBA IGNsYXNzIEZhaWx1cmVSZWZ0ZXN0TWlzbWF0Y2goVGVzdEZhaWx1cmUpOgogICAgIGRlZiBfX2lu aXRfXyhzZWxmLCByZWZlcmVuY2VfZmlsZW5hbWU9Tm9uZSk6CiAgICAgICAgIHNlbGYucmVmZXJl bmNlX2ZpbGVuYW1lID0gcmVmZXJlbmNlX2ZpbGVuYW1lCiAKLSAgICBAc3RhdGljbWV0aG9kCi0g ICAgZGVmIG1lc3NhZ2UoKToKKyAgICBkZWYgbWVzc2FnZShzZWxmKToKICAgICAgICAgcmV0dXJu ICJNaXNtYXRjaCB3aXRoIHJlZmVyZW5jZSIKIAogCkBAIC0yMDIsOCArMTk1LDcgQEAgY2xhc3Mg RmFpbHVyZVJlZnRlc3RNaXNtYXRjaERpZE5vdE9jY3VyKFRlc3RGYWlsdXJlKToKICAgICBkZWYg X19pbml0X18oc2VsZiwgcmVmZXJlbmNlX2ZpbGVuYW1lPU5vbmUpOgogICAgICAgICBzZWxmLnJl ZmVyZW5jZV9maWxlbmFtZSA9IHJlZmVyZW5jZV9maWxlbmFtZQogCi0gICAgQHN0YXRpY21ldGhv ZAotICAgIGRlZiBtZXNzYWdlKCk6CisgICAgZGVmIG1lc3NhZ2Uoc2VsZik6CiAgICAgICAgIHJl dHVybiAiTWlzbWF0Y2ggd2l0aCB0aGUgcmVmZXJlbmNlIGRpZCBub3Qgb2NjdXIiCiAKIApAQCAt MjEzLDI0ICsyMDUsMjEgQEAgY2xhc3MgRmFpbHVyZVJlZnRlc3ROb0ltYWdlc0dlbmVyYXRlZChU ZXN0RmFpbHVyZSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHJlZmVyZW5jZV9maWxlbmFtZT1O b25lKToKICAgICAgICAgc2VsZi5yZWZlcmVuY2VfZmlsZW5hbWUgPSByZWZlcmVuY2VfZmlsZW5h bWUKIAotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgbWVzc2FnZSgpOgorICAgIGRlZiBtZXNz YWdlKHNlbGYpOgogICAgICAgICByZXR1cm4gIlJlZnRlc3QgZGlkbid0IGdlbmVyYXRlIHBpeGVs IHJlc3VsdHMuIgogCiAKIGNsYXNzIEZhaWx1cmVNaXNzaW5nQXVkaW8oVGVzdEZhaWx1cmUpOgog ICAgICIiIkFjdHVhbCByZXN1bHQgaW1hZ2Ugd2FzIG1pc3NpbmcuIiIiCiAKLSAgICBAc3RhdGlj bWV0aG9kCi0gICAgZGVmIG1lc3NhZ2UoKToKKyAgICBkZWYgbWVzc2FnZShzZWxmKToKICAgICAg ICAgcmV0dXJuICJObyBleHBlY3RlZCBhdWRpbyBmb3VuZCIKIAogCiBjbGFzcyBGYWlsdXJlQXVk aW9NaXNtYXRjaChUZXN0RmFpbHVyZSk6CiAgICAgIiIiQXVkaW8gZmlsZXMgZGlkbid0IG1hdGNo LiIiIgogCi0gICAgQHN0YXRpY21ldGhvZAotICAgIGRlZiBtZXNzYWdlKCk6CisgICAgZGVmIG1l c3NhZ2Uoc2VsZik6CiAgICAgICAgIHJldHVybiAiQXVkaW8gbWlzbWF0Y2giCiAKIApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZmFp bHVyZXNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9t b2RlbHMvdGVzdF9mYWlsdXJlc191bml0dGVzdC5weQppbmRleCBlZDkxMDQ3Mzg5YjgyMGJkNzgy OTFiZGY1NjgzYzZkMjUzNWI3MTg3Li4zYjliYTMzZDBjYzA4ZTM3ZTEwYWQ4YWNjMGViNTlhMGEx MWViOWJiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9t b2RlbHMvdGVzdF9mYWlsdXJlc191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlc191bml0dGVzdC5weQpAQCAtNjMs MyArNjMsNyBAQCBjbGFzcyBUZXN0RmFpbHVyZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAg ICAgICAgIyBUaGUgaGFzaCBoYXBwZW5zIHRvIGJlIHRoZSBuYW1lIG9mIHRoZSBjbGFzcywgYnV0 IHNldHMgc3RpbGwgd29yazoKICAgICAgICAgY3Jhc2hfc2V0ID0gc2V0KFtGYWlsdXJlQ3Jhc2go KSwgIkZhaWx1cmVDcmFzaCJdKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGxlbihjcmFzaF9z ZXQpLCAyKQorCisgICAgZGVmIHRlc3RfY3Jhc2hlcyhzZWxmKToKKyAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbHMoRmFpbHVyZUNyYXNoKCkubWVzc2FnZSgpLCAnRHVtcFJlbmRlclRyZWUgY3Jhc2hl ZCcpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKEZhaWx1cmVDcmFzaChwcm9jZXNzX25hbWU9 J2ZvbycsIHBpZD0xMjM0KS5tZXNzYWdlKCksICdmb28gKHBpZCAxMjM0KSBjcmFzaGVkJykK