81576 2012-03-19 15:56:47 -0700 Add more Chromium WebKit API reviewers 2012-03-20 11:13:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd abarth dglazkov jamesr tkent webkit.review.bot oldest_to_newest 582369 0 fishd 2012-03-19 15:56:47 -0700 Add more Chromium WebKit API reviewers API wiki page is here: https://trac.webkit.org/wiki/ChromiumWebKitAPI Please extend it to help document quirks. 582373 1 132694 fishd 2012-03-19 15:59:27 -0700 Created attachment 132694 v1 patch 583250 2 132857 fishd 2012-03-20 11:10:51 -0700 Created attachment 132857 v2 patch Now with missing '|' character. 583252 3 fishd 2012-03-20 11:13:08 -0700 Landed as http://trac.webkit.org/changeset/111414 132694 2012-03-19 15:59:27 -0700 2012-03-20 11:10:51 -0700 v1 patch watch_1.txt text/plain 3340 fishd SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwODg3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAyLTI0ICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgQWRkIG1vcmUgQ2hyb21pdW0gV2ViS2l0IEFQSSByZXZpZXdlcnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNTc2CisKKyAgICAg ICAgU2ltcGxpZnkgd2F0Y2hsaXN0IHRvIGx1bXAgYWxsIFdlYktpdCBBUEkgaW50byBvbmUuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0OgorCiAyMDEyLTAyLTI0ICBEaXJrIFBy YW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHdlYmtpdHB5OiBjaGFuZ2Vs b2dfdW5pdHRlc3QgdGVzdF9mdXp6eV9yZXZpZXdlcl9tYXRjaCBpcyBzbG93CkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QJKHJldmlzaW9u IDExMDQwMykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxp c3QJKHdvcmtpbmcgY29weSkKQEAgLTIwLDkgKzIwLDcgQEAKICAgICAgICAgfSwKICAgICAgICAg IkNocm9taXVtUHVibGljQXBpIjogewogICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy8iCi0gICAgICAgIH0sCi0gICAgICAgICJDaHJvbWl1bVBs YXRmb3JtQXBpIjogewotICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljLyIKKyAgICAgICAgICAgICAgICAgICAgICAgIHIiU291cmNlL1BsYXRm b3JtL2Nocm9taXVtL3B1YmxpYy8iLAogICAgICAgICB9LAogICAgICAgICAiQXBwbGVNYWNQdWJs aWNBcGkiOiB7CiAgICAgICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL29iamMvUHVibGljRE9NSW50ZXJmYWNlcy5oIgpAQCAtMTQ4LDggKzE0Niw3IEBACiAgICAg ICAgICMgdHdvIGRpZmZlcmVudCBhY2NvdW50cyBhcyBmYXIgYXMgYnVnemlsbGEgaXMgY29uY2Vy bmVkLgogICAgICAgICAiQ2hyb21pdW1EdW1wUmVuZGVyVHJlZSI6IFsgInRrZW50QGNocm9taXVt Lm9yZyIsIF0sCiAgICAgICAgICJDaHJvbWl1bUdyYXBoaWNzIjogWyAiamFtZXNyQGNocm9taXVt Lm9yZyIsICJjYy1idWdzQGdvb2dsZS5jb20iIF0sCi0gICAgICAgICJDaHJvbWl1bVB1YmxpY0Fw aSI6IFsgImFiYXJ0aEB3ZWJraXQub3JnIiwgImZpc2hkQGNocm9taXVtLm9yZyIgXSwKLSAgICAg ICAgIkNocm9taXVtUGxhdGZvcm1BcGkiOiBbICJhYmFydGhAd2Via2l0Lm9yZyIsICJmaXNoZEBj aHJvbWl1bS5vcmciLCAiamFtZXNyQGNocm9taXVtLm9yZyIgXSwKKyAgICAgICAgIkNocm9taXVt UHVibGljQXBpIjogWyAiYWJhcnRoQHdlYmtpdC5vcmciLCAiZGdsYXprb3ZAY2hyb21pdW0ub3Jn IiwgImZpc2hkQGNocm9taXVtLm9yZyIsICJqYW1lc3JAY2hyb21pdW0ub3JnIiwgInRrZW50QGNo cm9taXVtLm9yZyIgXSwKICAgICAgICAgIkFwcGxlTWFjUHVibGljQXBpIjogWyAidGltb3RoeUBh cHBsZS5jb20iIF0sCiAgICAgICAgICJGb3JtcyI6IFsgInRrZW50QGNocm9taXVtLm9yZyIsIF0s CiAgICAgICAgICJHU3RyZWFtZXJHcmFwaGljcyI6IFsgImFsZXhpcy5tZW5hcmRAb3BlbmJvc3Nh Lm9yZyIsICJwbm9ybWFuZEBpZ2FsaWEuY29tIiwgImduc0Bnbm9tZS5vcmciIF0sCkBAIC0xNzQs MTAgKzE3MSwxMCBAQAogICAgICAgICAiU2Nyb2xsaW5nQ29vcmRpbmF0b3IiOiBbICJhbmRlcnNj YUBhcHBsZS5jb20iLCAiamFtZXNyQGNocm9taXVtLm9yZyIsICJ0b25pa2l0b29Ad2Via2l0Lm9y ZyIgXSwKICAgICB9LAogICAgICJNRVNTQUdFX1JVTEVTIjogewotICAgICAgICAiQ2hyb21pdW1Q dWJsaWNBcGkiOiBbICJQbGVhc2Ugd2FpdCBmb3IgYXBwcm92YWwgZnJvbSBmaXNoZEBjaHJvbWl1 bS5vcmcgYmVmb3JlIHN1Ym1pdHRpbmcgIgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJiZWNhdXNlIHRoaXMgcGF0Y2ggY29udGFpbnMgY2hhbmdlcyB0byB0aGUgQ2hyb21pdW0gcHVi bGljIEFQSS4iLCBdLAotICAgICAgICAiQ2hyb21pdW1QbGF0Zm9ybUFwaSI6IFsgIlBsZWFzZSB3 YWl0IGZvciBhcHByb3ZhbCBmcm9tIGZpc2hkQGNocm9taXVtLm9yZywgYWJhcnRoQHdlYmtpdC5v cmcgb3IgamFtZXNyQGNocm9taXVtLm9yZyBiZWZvcmUgc3VibWl0dGluZyAiCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiYmVjYXVzZSB0aGlzIHBhdGNoIGNvbnRhaW5zIGNoYW5n ZXMgdG8gdGhlIENocm9taXVtIHBsYXRmb3JtIEFQSS4iLCBdLAorICAgICAgICAiQ2hyb21pdW1Q dWJsaWNBcGkiOiBbICJQbGVhc2Ugd2FpdCBmb3IgYXBwcm92YWwgZnJvbSBhYmFydGhAd2Via2l0 Lm9yZywgZGdsYXprb3ZAY2hyb21pdW0ub3JnLCAiCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgImZpc2hkQGNocm9taXVtLm9yZywgamFtZXNyQGNocm9taXVtLm9yZyBvciB0a2VudEBj aHJvbWl1bS5vcmcgYmVmb3JlICIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAic3Vi bWl0dGluZywgYXMgdGhpcyBwYXRjaCBjb250YWlucyBjaGFuZ2VzIHRvIHRoZSBDaHJvbWl1bSBw dWJsaWMgQVBJLiAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlNlZSBhbHNvIGh0 dHBzOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvQ2hyb21pdW1XZWJLaXRBUEkuIiBdLAogICAgICAg ICAiQXBwbGVNYWNQdWJsaWNBcGkiOiBbICJQbGVhc2Ugd2FpdCBmb3IgYXBwcm92YWwgZnJvbSB0 aW1vdGh5QGFwcGxlLmNvbSAob3IgYW5vdGhlciBtZW1iZXIgIgogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJvZiB0aGUgQXBwbGUgU2FmYXJpIFRlYW0pIGJlZm9yZSBzdWJtaXR0aW5n ICIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiYmVjYXVzZSB0aGlzIHBhdGNoIGNv bnRhaW5zIGNoYW5nZXMgdG8gdGhlIEFwcGxlIE1hYyAiCg== 132857 2012-03-20 11:10:51 -0700 2012-03-20 11:13:25 -0700 v2 patch watch_2.txt text/plain 3341 fishd SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwODg3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAyLTI0ICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgQWRkIG1vcmUgQ2hyb21pdW0gV2ViS2l0IEFQSSByZXZpZXdlcnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNTc2CisKKyAgICAg ICAgU2ltcGxpZnkgd2F0Y2hsaXN0IHRvIGx1bXAgYWxsIFdlYktpdCBBUEkgaW50byBvbmUuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0OgorCiAyMDEyLTAyLTI0ICBEaXJrIFBy YW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHdlYmtpdHB5OiBjaGFuZ2Vs b2dfdW5pdHRlc3QgdGVzdF9mdXp6eV9yZXZpZXdlcl9tYXRjaCBpcyBzbG93CkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QJKHJldmlzaW9u IDExMDQwMykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxp c3QJKHdvcmtpbmcgY29weSkKQEAgLTIwLDkgKzIwLDcgQEAKICAgICAgICAgfSwKICAgICAgICAg IkNocm9taXVtUHVibGljQXBpIjogewogICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy8iCi0gICAgICAgIH0sCi0gICAgICAgICJDaHJvbWl1bVBs YXRmb3JtQXBpIjogewotICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljLyIKKyAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvIiwKICAgICAgICAgfSwKICAgICAgICAgIkFwcGxlTWFjUHVi bGljQXBpIjogewogICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9vYmpjL1B1YmxpY0RPTUludGVyZmFjZXMuaCIKQEAgLTE0OCw4ICsxNDYsNyBAQAogICAg ICAgICAjIHR3byBkaWZmZXJlbnQgYWNjb3VudHMgYXMgZmFyIGFzIGJ1Z3ppbGxhIGlzIGNvbmNl cm5lZC4KICAgICAgICAgIkNocm9taXVtRHVtcFJlbmRlclRyZWUiOiBbICJ0a2VudEBjaHJvbWl1 bS5vcmciLCBdLAogICAgICAgICAiQ2hyb21pdW1HcmFwaGljcyI6IFsgImphbWVzckBjaHJvbWl1 bS5vcmciLCAiY2MtYnVnc0Bnb29nbGUuY29tIiBdLAotICAgICAgICAiQ2hyb21pdW1QdWJsaWNB cGkiOiBbICJhYmFydGhAd2Via2l0Lm9yZyIsICJmaXNoZEBjaHJvbWl1bS5vcmciIF0sCi0gICAg ICAgICJDaHJvbWl1bVBsYXRmb3JtQXBpIjogWyAiYWJhcnRoQHdlYmtpdC5vcmciLCAiZmlzaGRA Y2hyb21pdW0ub3JnIiwgImphbWVzckBjaHJvbWl1bS5vcmciIF0sCisgICAgICAgICJDaHJvbWl1 bVB1YmxpY0FwaSI6IFsgImFiYXJ0aEB3ZWJraXQub3JnIiwgImRnbGF6a292QGNocm9taXVtLm9y ZyIsICJmaXNoZEBjaHJvbWl1bS5vcmciLCAiamFtZXNyQGNocm9taXVtLm9yZyIsICJ0a2VudEBj aHJvbWl1bS5vcmciIF0sCiAgICAgICAgICJBcHBsZU1hY1B1YmxpY0FwaSI6IFsgInRpbW90aHlA YXBwbGUuY29tIiBdLAogICAgICAgICAiRm9ybXMiOiBbICJ0a2VudEBjaHJvbWl1bS5vcmciLCBd LAogICAgICAgICAiR1N0cmVhbWVyR3JhcGhpY3MiOiBbICJhbGV4aXMubWVuYXJkQG9wZW5ib3Nz YS5vcmciLCAicG5vcm1hbmRAaWdhbGlhLmNvbSIsICJnbnNAZ25vbWUub3JnIiBdLApAQCAtMTc0 LDEwICsxNzEsMTAgQEAKICAgICAgICAgIlNjcm9sbGluZ0Nvb3JkaW5hdG9yIjogWyAiYW5kZXJz Y2FAYXBwbGUuY29tIiwgImphbWVzckBjaHJvbWl1bS5vcmciLCAidG9uaWtpdG9vQHdlYmtpdC5v cmciIF0sCiAgICAgfSwKICAgICAiTUVTU0FHRV9SVUxFUyI6IHsKLSAgICAgICAgIkNocm9taXVt UHVibGljQXBpIjogWyAiUGxlYXNlIHdhaXQgZm9yIGFwcHJvdmFsIGZyb20gZmlzaGRAY2hyb21p dW0ub3JnIGJlZm9yZSBzdWJtaXR0aW5nICIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiYmVjYXVzZSB0aGlzIHBhdGNoIGNvbnRhaW5zIGNoYW5nZXMgdG8gdGhlIENocm9taXVtIHB1 YmxpYyBBUEkuIiwgXSwKLSAgICAgICAgIkNocm9taXVtUGxhdGZvcm1BcGkiOiBbICJQbGVhc2Ug d2FpdCBmb3IgYXBwcm92YWwgZnJvbSBmaXNoZEBjaHJvbWl1bS5vcmcsIGFiYXJ0aEB3ZWJraXQu b3JnIG9yIGphbWVzckBjaHJvbWl1bS5vcmcgYmVmb3JlIHN1Ym1pdHRpbmcgIgotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgImJlY2F1c2UgdGhpcyBwYXRjaCBjb250YWlucyBjaGFu Z2VzIHRvIHRoZSBDaHJvbWl1bSBwbGF0Zm9ybSBBUEkuIiwgXSwKKyAgICAgICAgIkNocm9taXVt UHVibGljQXBpIjogWyAiUGxlYXNlIHdhaXQgZm9yIGFwcHJvdmFsIGZyb20gYWJhcnRoQHdlYmtp dC5vcmcsIGRnbGF6a292QGNocm9taXVtLm9yZywgIgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJmaXNoZEBjaHJvbWl1bS5vcmcsIGphbWVzckBjaHJvbWl1bS5vcmcgb3IgdGtlbnRA Y2hyb21pdW0ub3JnIGJlZm9yZSAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInN1 Ym1pdHRpbmcsIGFzIHRoaXMgcGF0Y2ggY29udGFpbnMgY2hhbmdlcyB0byB0aGUgQ2hyb21pdW0g cHVibGljIEFQSS4gIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJTZWUgYWxzbyBo dHRwczovL3RyYWMud2Via2l0Lm9yZy93aWtpL0Nocm9taXVtV2ViS2l0QVBJLiIgXSwKICAgICAg ICAgIkFwcGxlTWFjUHVibGljQXBpIjogWyAiUGxlYXNlIHdhaXQgZm9yIGFwcHJvdmFsIGZyb20g dGltb3RoeUBhcHBsZS5jb20gKG9yIGFub3RoZXIgbWVtYmVyICIKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAib2YgdGhlIEFwcGxlIFNhZmFyaSBUZWFtKSBiZWZvcmUgc3VibWl0dGlu ZyAiCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImJlY2F1c2UgdGhpcyBwYXRjaCBj b250YWlucyBjaGFuZ2VzIHRvIHRoZSBBcHBsZSBNYWMgIgo=