8156 2006-04-03 09:27:14 -0700 FrameMac::submitForm is busted after Vector changes 2006-04-12 18:49:49 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 eric adele sullivan oldest_to_newest 38396 0 eric 2006-04-03 09:27:14 -0700 I made some changes a while back to how form submission worked, and I busted FrameMac::submitForm. Strangely enough, no one has seemed to notice. However, WebKit is no longer seeing any form submission data, like it used to. This call: if (!request.doPost()) { [_bridge loadURL:request.url().getNSURL() referrer:[_bridge referrer] reload:request.reload userGesture:true target:request.frameName triggeringEvent:_currentEvent form:_formAboutToBeSubmitted formValues:_formValuesAboutToBeSubmitted]; _formAboutToBeSubmitted and _formValuesAboutToBeSubmitted are always nil. Those values are now held down on Frame, and just need to be converted from WebCore types into NS types and sent up to WebKit. It's simple to fix. I'm filing this bug so I don't forget. Maybe somone who knows more about that code path can comment as to why no one has noticed this being broken. Maybe WebKit no longer needs to know about form submission data (unless it's for autofill?) 38463 1 darin 2006-04-03 21:10:59 -0700 Yes, it's primarily for auto-fill. 39030 2 adele 2006-04-12 10:50:16 -0700 I have a patch to fix this.