81557 2012-03-19 13:54:16 -0700 [chromium] Remove misleading double-if 2012-03-19 15:27:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer cc-bugs enne jamesr piman reveman webkit.review.bot oldest_to_newest 582191 0 danakj 2012-03-19 13:54:16 -0700 [chromium] Remove misleading double-if 582193 1 132660 danakj 2012-03-19 13:54:59 -0700 Created attachment 132660 Patch 582197 2 danakj 2012-03-19 13:56:13 -0700 The code does the following: m_paintRect = dirtyLayerRect; if (dirtyLayerRect.isEmpty()) return; // Now we know dirtyLayerRect is not empty. Thus m_paintRect is not empty. The check below is always true. if (!m_paintRect.isEmpty()) m_requestedUpdateTilesRect = IntRect(left, top, right - left + 1, bottom - top + 1); 582221 3 132660 enne 2012-03-19 14:09:19 -0700 Comment on attachment 132660 Patch Yeah, that check looks totally unnecessary. 582319 4 132660 webkit.review.bot 2012-03-19 15:27:40 -0700 Comment on attachment 132660 Patch Clearing flags on attachment: 132660 Committed r111260: <http://trac.webkit.org/changeset/111260> 582320 5 webkit.review.bot 2012-03-19 15:27:44 -0700 All reviewed patches have been landed. Closing bug. 132660 2012-03-19 13:54:59 -0700 2012-03-19 15:27:40 -0700 Patch bug-81557-20120319165458.patch text/plain 1935 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE1YTBmMGRhMmU3MzZl NDI3YzYyZjRhYWJhMjAzYTVkYzg2YmIzMy4uMWNkY2EzYjUyYWJmOTRhOTA4N2ZjMDdiNzBlZjNi MGQ3YTY3NWE3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE5ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIG1pc2xlYWRpbmcgZG91YmxlLWlmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MTU1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFNpbXBsZSBjb2RlIGNsZWFudXAsIG5vIGZ1bmN0aW9uYWxpdHkgY2hh bmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNo cm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkTGF5ZXJDaHJvbWl1bTo6cHJlcGFy ZVRvVXBkYXRlVGlsZXMpOgorCiAyMDEyLTAzLTE5ICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNo bW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIFBsYXRmb3JtTWVkaWFF bmdpbmVDbGFzc05hbWUgZm9yIGJsYWNrYmVycnkgaW4gcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQ bGF5ZXIuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNocm9taXVtLmNwcAppbmRleCBmN2E0MDA4NjIx YmE0NmY2ZTg0YTJkNzk4ZTFhMjg3NDhlNDFjOTNlLi4xNjZkY2IxY2VkMjAyYTE5MDU1OTRmMWU3 MGJiNGU4YjQxZGQ3MzQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTQ2 Niw4ICs0NjYsNyBAQCB2b2lkIFRpbGVkTGF5ZXJDaHJvbWl1bTo6cHJlcGFyZVRvVXBkYXRlVGls ZXMoYm9vbCBpZGxlLCBpbnQgbGVmdCwgaW50IHRvcCwgaW50CiAgICAgLy8gRHVlIHRvIGJvcmRl cnMsIHdoZW4gdGhlIHBhaW50IHJlY3QgaXMgZXh0ZW5kZWQgdG8gdGlsZSBib3VuZGFyaWVzLCBp dAogICAgIC8vIG1heSBlbmQgdXAgb3ZlcmxhcHBpbmcgbW9yZSB0aWxlcyB0aGFuIHRoZSBvcmln aW5hbCBjb250ZW50IHJlY3QuIFJlY29yZAogICAgIC8vIHRoZSBvcmlnaW5hbCB0aWxlcyBzbyB3 ZSBkb24ndCB1cGxvYWQgbW9yZSB0aWxlcyB0aGFuIG5lY2Vzc2FyeS4KLSAgICBpZiAoIW1fcGFp bnRSZWN0LmlzRW1wdHkoKSkKLSAgICAgICAgbV9yZXF1ZXN0ZWRVcGRhdGVUaWxlc1JlY3QgPSBJ bnRSZWN0KGxlZnQsIHRvcCwgcmlnaHQgLSBsZWZ0ICsgMSwgYm90dG9tIC0gdG9wICsgMSk7Cisg ICAgbV9yZXF1ZXN0ZWRVcGRhdGVUaWxlc1JlY3QgPSBJbnRSZWN0KGxlZnQsIHRvcCwgcmlnaHQg LSBsZWZ0ICsgMSwgYm90dG9tIC0gdG9wICsgMSk7CiAKICAgICAvLyBDYWxsaW5nIHByZXBhcmVU b1VwZGF0ZSgpIGNhbGxzIGludG8gV2ViS2l0IHRvIHBhaW50LCB3aGljaCBtYXkgaGF2ZSB0aGUg c2lkZQogICAgIC8vIGVmZmVjdCBvZiBkaXNhYmxpbmcgY29tcG9zaXRpbmcsIHdoaWNoIGNhdXNl cyBvdXIgcmVmZXJlbmNlIHRvIHRoZSB0ZXh0dXJlIHVwZGF0ZXIgdG8gYmUgZGVsZXRlZC4K