81536 2012-03-19 12:15:21 -0700 [BlackBerry] speed up text selection for large selections 2012-03-29 13:34:03 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 525.x (Safari 3.2) Other Other RESOLVED FIXED P2 Normal --- 82650 0 tabbott webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 582031 0 tabbott 2012-03-19 12:15:21 -0700 Doing a selectAll on http://en.wikipedia.org/wiki/Albert_Einstein takes more than one second (1.395534s). Most of the time is spent creating the consolidated IntRectRegion. 582073 1 tabbott 2012-03-19 12:44:11 -0700 Internal PR 136593 582204 2 132662 tabbott 2012-03-19 14:00:53 -0700 Created attachment 132662 fast patch 582220 3 132662 rwlbuis 2012-03-19 14:09:01 -0700 Comment on attachment 132662 fast patch View in context: https://bugs.webkit.org/attachment.cgi?id=132662&action=review Can fix some prefixes. > Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:118 > + BlackBerry::Platform::IntRect selectionBoundingBox; Probably don't need the BlackBerry prefix. 582224 4 132666 tabbott 2012-03-19 14:10:29 -0700 Created attachment 132666 extra prefixes removed 582228 5 132666 rwlbuis 2012-03-19 14:13:06 -0700 Comment on attachment 132666 extra prefixes removed LGTM. 582310 6 132666 webkit.review.bot 2012-03-19 15:17:50 -0700 Comment on attachment 132666 extra prefixes removed Clearing flags on attachment: 132666 Committed r111259: <http://trac.webkit.org/changeset/111259> 582311 7 webkit.review.bot 2012-03-19 15:17:55 -0700 All reviewed patches have been landed. Closing bug. 132662 2012-03-19 14:00:53 -0700 2012-03-19 14:10:29 -0700 fast patch 0001-2012-03-19-Tyler-Abbott-tabbott-rim.com.patch text/plain 3627 tabbott RnJvbSBlMWM5ZmE5MzAzMWE0NDlhM2Q3OWM5M2NhNWQ4NjU2NjEyNjE2ODI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUeWxlciBBYmJvdHQgPHRhYmJvdHRAcmltLmNvbT4KRGF0ZTog TW9uLCAxOSBNYXIgMjAxMiAxMzoxMDozMiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDMt MTkgIFR5bGVyIEFiYm90dCAgPHRhYmJvdHRAcmltLmNvbT4KCiAgICAgICAgUFIgMTM2NTkzCgog ICAgICAgIFdoZW4gc2VsZWN0aW5nIGxhcmdlIGRpc2pvaW50IGFyZWFzIG9mIHRleHQgdGhlIGNv c3QKICAgICAgICBvZiBjYWxjdWxhdGluZyB0aGUgSW50UmVjdFJlZ2lvbiB1bmlvbiBiZWNvbWVz IHZlcnkKICAgICAgICBleHBlbnNpdmUuIFNpbXBseSBwbGFjaW5nIGFsbCBvZiB0aGUgdGV4dCBx dWFkcyBpbnRvCiAgICAgICAgdGhlIEludFJlY3RSZWdpb24gaXMgZmFzdGVyIGRlc3BpdGUgdGhl IGxhcmdlciBtZW1vcnkKICAgICAgICBmb290cHJpbnQgYW5kIHRoZSBhZGRpdGlvbmFsIGNhbGN1 bGF0aW9ucyBhdCByZW5kZXIKICAgICAgICB0aW1lLgoKICAgICAgICBSZXZpZXdlZCBpbnRlcm5h bGx5IGJ5IE1pa2UgRmVudG9uCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5k bGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpn ZXRDb25zb2xpZGF0ZWRSZWdpb25PZlRleHRRdWFkc0ZvclNlbGVjdGlvbik6Ci0tLQogU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysr KysrKysrKysrKysrCiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRs ZXIuY3BwICB8ICAgMTEgKysrKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCA5 NTc0ODdlLi5jYWNlMzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMCBAQAorMjAxMi0wMy0xOSAgVHlsZXIgQWJib3R0ICA8dGFiYm90dEByaW0uY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBzcGVlZCB1cCB0ZXh0IHNlbGVjdGlvbiBmb3IgbGFyZ2Ugc2Vs ZWN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODE1MzYKKworICAgICAgICBXaGVuIHNlbGVjdGluZyBsYXJnZSBkaXNqb2ludCBhcmVhcyBvZiB0 ZXh0IHRoZSBjb3N0CisgICAgICAgIG9mIGNhbGN1bGF0aW5nIHRoZSBJbnRSZWN0UmVnaW9uIHVu aW9uIGJlY29tZXMgdmVyeQorICAgICAgICBleHBlbnNpdmUuIFNpbXBseSBwbGFjaW5nIGFsbCBv ZiB0aGUgdGV4dCBxdWFkcyBpbnRvCisgICAgICAgIHRoZSBJbnRSZWN0UmVnaW9uIGlzIGZhc3Rl ciBkZXNwaXRlIHRoZSBsYXJnZXIgbWVtb3J5CisgICAgICAgIGZvb3RwcmludCBhbmQgdGhlIGFk ZGl0aW9uYWwgY2FsY3VsYXRpb25zIGF0IHJlbmRlcgorICAgICAgICB0aW1lLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0 aW9uSGFuZGxlcjo6Z2V0Q29uc29saWRhdGVkUmVnaW9uT2ZUZXh0UXVhZHNGb3JTZWxlY3Rpb24p OgorCiAyMDEyLTAzLTA4ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CiAKICAgICAg ICAgW0JsYWNrQmVycnldIEFsd2F5cyB1c2UgdGhlIGN1cnJlbnQgZm9jdXNlZCBub2RlIHdoZW4g cHJvY2Vzc2luZyBmb2N1cyBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4IDgzODVk ZWUuLjAzYjhlYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC0xMTIsMTUgKzExMiwxOCBA QCB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OmdldENvbnNvbGlkYXRlZFJlZ2lvbk9mVGV4dFF1YWRz Rm9yU2VsZWN0aW9uKGNvbnN0IFZpc2libAogICAgICAgICAvLyBmcmFtZVBvc2l0aW9uIGlzIGlu IG1haW4gZnJhbWUgY29vcmRpbmF0ZXMuCiAgICAgICAgIFdlYkNvcmU6OkludFBvaW50IGZyYW1l UG9zaXRpb24gPSBtX3dlYlBhZ2UtPmZyYW1lT2Zmc2V0KG1fd2ViUGFnZS0+Zm9jdXNlZE9yTWFp bkZyYW1lKCkpOwogCi0gICAgICAgIC8vIFRoZSByYW5nZXMgcmVjdCBsaXN0IGlzIGJhc2VkIG9u IHJlbmRlciBlbGVtZW50cyBhbmQgbWF5IGluY2x1ZGUgbXVsdGlwbGUgYWRqYWNlbnQgcmVjdHMu Ci0gICAgICAgIC8vIFVzZSBJbnRSZWN0UmVnaW9uIHRvIGNvbnNvbGlkYXRlIHRoZXNlIHJlY3Rz IGludG8gYmFuZHMgYXMgd2VsbCBhcyBhIGNvbnRhaW5lciB0byBwYXNzCi0gICAgICAgIC8vIHRv IHRoZSBjbGllbnQuCisgICAgICAgIC8vIENvbnZlcnQgdGhlIHRleHQgcXVhZHMgaW50byBhIG1v cmUgcGxhdGZvcm0gZnJpZW5keQorICAgICAgICAvLyBJbnRSZWN0UmVnaW9uIGFuZCBhZGp1c3Qg Zm9yIHN1YmZyYW1lcy4KKyAgICAgICAgc3RkOjp2ZWN0b3I8QmxhY2tCZXJyeTo6UGxhdGZvcm06 OkludFJlY3Q+IGFkanVzdGVkSW50UmVjdHM7CisgICAgICAgIEJsYWNrQmVycnk6OlBsYXRmb3Jt OjpJbnRSZWN0IHNlbGVjdGlvbkJvdW5kaW5nQm94OwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkg PSAwOyBpIDwgcXVhZExpc3Quc2l6ZSgpOyBpKyspIHsKICAgICAgICAgICAgIFdlYkNvcmU6Oklu dFJlY3QgZW5jbG9zaW5nUmVjdCA9IHF1YWRMaXN0W2ldLmVuY2xvc2luZ0JvdW5kaW5nQm94KCk7 CiAgICAgICAgICAgICBlbmNsb3NpbmdSZWN0LmludGVyc2VjdChmcmFtZVJlY3QpOwogICAgICAg ICAgICAgZW5jbG9zaW5nUmVjdC5tb3ZlKGZyYW1lUG9zaXRpb24ueCgpLCBmcmFtZVBvc2l0aW9u LnkoKSk7Ci0gICAgICAgICAgICByZWdpb24gPSB1bmlvblJlZ2lvbnMocmVnaW9uLCBJbnRSZWN0 UmVnaW9uKGVuY2xvc2luZ1JlY3QpKTsKKyAgICAgICAgICAgIGFkanVzdGVkSW50UmVjdHMucHVz aF9iYWNrKGVuY2xvc2luZ1JlY3QpOworICAgICAgICAgICAgc2VsZWN0aW9uQm91bmRpbmdCb3gg PSB1bmlvbk9mUmVjdHMoZW5jbG9zaW5nUmVjdCwgc2VsZWN0aW9uQm91bmRpbmdCb3gpOwogICAg ICAgICB9CisgICAgICAgIHJlZ2lvbiA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpJbnRSZWN0UmVn aW9uKHNlbGVjdGlvbkJvdW5kaW5nQm94LCBhZGp1c3RlZEludFJlY3RzLnNpemUoKSwgYWRqdXN0 ZWRJbnRSZWN0cyk7CiAgICAgfQogfQogCi0tIAoxLjcuMQoK 132666 2012-03-19 14:10:29 -0700 2012-03-19 15:17:50 -0700 extra prefixes removed 0001-2012-03-19-Tyler-Abbott-tabbott-rim.com.patch text/plain 3581 tabbott RnJvbSBlNDBlNzRkMDg0OWM1N2RjYjNhNzM3YzNjNzcwYzI5Mzg0YjMyYTRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUeWxlciBBYmJvdHQgPHRhYmJvdHRAcmltLmNvbT4KRGF0ZTog TW9uLCAxOSBNYXIgMjAxMiAxMzoxMDozMiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDMt MTkgIFR5bGVyIEFiYm90dCAgPHRhYmJvdHRAcmltLmNvbT4KCiAgICAgICAgUFIgMTM2NTkzCgog ICAgICAgIFdoZW4gc2VsZWN0aW5nIGxhcmdlIGRpc2pvaW50IGFyZWFzIG9mIHRleHQgdGhlIGNv c3QKICAgICAgICBvZiBjYWxjdWxhdGluZyB0aGUgSW50UmVjdFJlZ2lvbiB1bmlvbiBiZWNvbWVz IHZlcnkKICAgICAgICBleHBlbnNpdmUuIFNpbXBseSBwbGFjaW5nIGFsbCBvZiB0aGUgdGV4dCBx dWFkcyBpbnRvCiAgICAgICAgdGhlIEludFJlY3RSZWdpb24gaXMgZmFzdGVyIGRlc3BpdGUgdGhl IGxhcmdlciBtZW1vcnkKICAgICAgICBmb290cHJpbnQgYW5kIHRoZSBhZGRpdGlvbmFsIGNhbGN1 bGF0aW9ucyBhdCByZW5kZXIKICAgICAgICB0aW1lLgoKICAgICAgICBSZXZpZXdlZCBpbnRlcm5h bGx5IGJ5IE1pa2UgRmVudG9uCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5k bGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpn ZXRDb25zb2xpZGF0ZWRSZWdpb25PZlRleHRRdWFkc0ZvclNlbGVjdGlvbik6Ci0tLQogU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysr KysrKysrKysrKysrCiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRs ZXIuY3BwICB8ICAgMTEgKysrKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCA5 NTc0ODdlLi5jYWNlMzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMCBAQAorMjAxMi0wMy0xOSAgVHlsZXIgQWJib3R0ICA8dGFiYm90dEByaW0uY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XSBzcGVlZCB1cCB0ZXh0IHNlbGVjdGlvbiBmb3IgbGFyZ2Ugc2Vs ZWN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODE1MzYKKworICAgICAgICBXaGVuIHNlbGVjdGluZyBsYXJnZSBkaXNqb2ludCBhcmVhcyBvZiB0 ZXh0IHRoZSBjb3N0CisgICAgICAgIG9mIGNhbGN1bGF0aW5nIHRoZSBJbnRSZWN0UmVnaW9uIHVu aW9uIGJlY29tZXMgdmVyeQorICAgICAgICBleHBlbnNpdmUuIFNpbXBseSBwbGFjaW5nIGFsbCBv ZiB0aGUgdGV4dCBxdWFkcyBpbnRvCisgICAgICAgIHRoZSBJbnRSZWN0UmVnaW9uIGlzIGZhc3Rl ciBkZXNwaXRlIHRoZSBsYXJnZXIgbWVtb3J5CisgICAgICAgIGZvb3RwcmludCBhbmQgdGhlIGFk ZGl0aW9uYWwgY2FsY3VsYXRpb25zIGF0IHJlbmRlcgorICAgICAgICB0aW1lLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9T ZWxlY3Rpb25IYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6U2VsZWN0 aW9uSGFuZGxlcjo6Z2V0Q29uc29saWRhdGVkUmVnaW9uT2ZUZXh0UXVhZHNGb3JTZWxlY3Rpb24p OgorCiAyMDEyLTAzLTA4ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CiAKICAgICAg ICAgW0JsYWNrQmVycnldIEFsd2F5cyB1c2UgdGhlIGN1cnJlbnQgZm9jdXNlZCBub2RlIHdoZW4g cHJvY2Vzc2luZyBmb2N1cyBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCmluZGV4IDgzODVk ZWUuLjlhOGY4OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCkBAIC0xMTIsMTUgKzExMiwxOCBA QCB2b2lkIFNlbGVjdGlvbkhhbmRsZXI6OmdldENvbnNvbGlkYXRlZFJlZ2lvbk9mVGV4dFF1YWRz Rm9yU2VsZWN0aW9uKGNvbnN0IFZpc2libAogICAgICAgICAvLyBmcmFtZVBvc2l0aW9uIGlzIGlu IG1haW4gZnJhbWUgY29vcmRpbmF0ZXMuCiAgICAgICAgIFdlYkNvcmU6OkludFBvaW50IGZyYW1l UG9zaXRpb24gPSBtX3dlYlBhZ2UtPmZyYW1lT2Zmc2V0KG1fd2ViUGFnZS0+Zm9jdXNlZE9yTWFp bkZyYW1lKCkpOwogCi0gICAgICAgIC8vIFRoZSByYW5nZXMgcmVjdCBsaXN0IGlzIGJhc2VkIG9u IHJlbmRlciBlbGVtZW50cyBhbmQgbWF5IGluY2x1ZGUgbXVsdGlwbGUgYWRqYWNlbnQgcmVjdHMu Ci0gICAgICAgIC8vIFVzZSBJbnRSZWN0UmVnaW9uIHRvIGNvbnNvbGlkYXRlIHRoZXNlIHJlY3Rz IGludG8gYmFuZHMgYXMgd2VsbCBhcyBhIGNvbnRhaW5lciB0byBwYXNzCi0gICAgICAgIC8vIHRv IHRoZSBjbGllbnQuCisgICAgICAgIC8vIENvbnZlcnQgdGhlIHRleHQgcXVhZHMgaW50byBhIG1v cmUgcGxhdGZvcm0gZnJpZW5keQorICAgICAgICAvLyBJbnRSZWN0UmVnaW9uIGFuZCBhZGp1c3Qg Zm9yIHN1YmZyYW1lcy4KKyAgICAgICAgc3RkOjp2ZWN0b3I8UGxhdGZvcm06OkludFJlY3Q+IGFk anVzdGVkSW50UmVjdHM7CisgICAgICAgIFBsYXRmb3JtOjpJbnRSZWN0IHNlbGVjdGlvbkJvdW5k aW5nQm94OwogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcXVhZExpc3Quc2l6ZSgp OyBpKyspIHsKICAgICAgICAgICAgIFdlYkNvcmU6OkludFJlY3QgZW5jbG9zaW5nUmVjdCA9IHF1 YWRMaXN0W2ldLmVuY2xvc2luZ0JvdW5kaW5nQm94KCk7CiAgICAgICAgICAgICBlbmNsb3NpbmdS ZWN0LmludGVyc2VjdChmcmFtZVJlY3QpOwogICAgICAgICAgICAgZW5jbG9zaW5nUmVjdC5tb3Zl KGZyYW1lUG9zaXRpb24ueCgpLCBmcmFtZVBvc2l0aW9uLnkoKSk7Ci0gICAgICAgICAgICByZWdp b24gPSB1bmlvblJlZ2lvbnMocmVnaW9uLCBJbnRSZWN0UmVnaW9uKGVuY2xvc2luZ1JlY3QpKTsK KyAgICAgICAgICAgIGFkanVzdGVkSW50UmVjdHMucHVzaF9iYWNrKGVuY2xvc2luZ1JlY3QpOwor ICAgICAgICAgICAgc2VsZWN0aW9uQm91bmRpbmdCb3ggPSB1bmlvbk9mUmVjdHMoZW5jbG9zaW5n UmVjdCwgc2VsZWN0aW9uQm91bmRpbmdCb3gpOwogICAgICAgICB9CisgICAgICAgIHJlZ2lvbiA9 IEludFJlY3RSZWdpb24oc2VsZWN0aW9uQm91bmRpbmdCb3gsIGFkanVzdGVkSW50UmVjdHMuc2l6 ZSgpLCBhZGp1c3RlZEludFJlY3RzKTsKICAgICB9CiB9CiAKLS0gCjEuNy4xCgo=