81509 2012-03-19 07:32:59 -0700 [Qt] fast/table/max-width-integer-overflow.html differs on 32- and 64-bit systems 2014-02-03 03:20:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID Qt, QtTriaged P2 Normal --- 67976 1 jbadics webkit-unassigned eric jbadics macpherson ossy webkit.review.bot oldest_to_newest 581769 0 jbadics 2012-03-19 07:32:59 -0700 From revision #111156 32-bit and 64-bit QtWebKit versions give different results on fast/table/max-width-integer-overflow-expected.html Thist test should be put on the skipped list since there is no solution for both the 32-bit and 64-bit versions to give the same results. 581806 1 jbadics 2012-03-19 08:02:10 -0700 The expected.txt in r111156 works fine on 32-bit systems. But on 64-bit systems some modifications should be made to work well: diff --git a/LayoutTests/platform/qt/fast/table/max-width-integer-overflow-expected.txt b/LayoutTests/platform/qt/fast/table/max-width-integer-overflow-expected.txt index 9171655..392ec4c 100644 --- a/LayoutTests/platform/qt/fast/table/max-width-integer-overflow-expected.txt +++ b/LayoutTests/platform/qt/fast/table/max-width-integer-overflow-expected.txt @@ -6,16 +6,16 @@ layer at (0,0) size 800x600 RenderTable {TABLE} at (0,0) size 780x24 [bgcolor=#FF0000] RenderTableSection {TBODY} at (0,0) size 780x24 RenderTableRow {TR} at (0,0) size 780x24 - RenderTableCell {TD} at (0,0) size 770x24 [r=0 c=0 rs=1 cs=1] - RenderTable {TABLE} at (0,0) size 770x24 - RenderTableSection {TBODY} at (0,0) size 770x24 - RenderTableRow {TR} at (0,0) size 770x24 - RenderTableCell {TD} at (0,0) size 770x24 [r=0 c=0 rs=1 cs=1] - RenderBlock {DIV} at (0,0) size 770x24 - RenderTable {TABLE} at (0,0) size 770x24 [bgcolor=#008000] - RenderTableSection {TBODY} at (0,0) size 770x24 - RenderTableRow {TR} at (0,2) size 770x20 - RenderTableCell {TD} at (2,11) size 762x2 [r=0 c=0 rs=1 cs=1] - RenderTableCell {TD} at (766,11) size 2x2 [r=0 c=1 rs=1 cs=1] - RenderTableCell {TD} at (770,0) size 10x24 [r=0 c=1 rs=1 cs=1] + RenderTableCell {TD} at (0,0) size 780x24 [r=0 c=0 rs=1 cs=1] + RenderTable {TABLE} at (0,0) size 780x24 + RenderTableSection {TBODY} at (0,0) size 780x24 + RenderTableRow {TR} at (0,0) size 780x24 + RenderTableCell {TD} at (0,0) size 780x24 [r=0 c=0 rs=1 cs=1] + RenderBlock {DIV} at (0,0) size 780x24 + RenderTable {TABLE} at (0,0) size 780x24 [bgcolor=#008000] + RenderTableSection {TBODY} at (0,0) size 780x24 + RenderTableRow {TR} at (0,2) size 780x20 + RenderTableCell {TD} at (2,11) size 772x2 [r=0 c=0 rs=1 cs=1] + RenderTableCell {TD} at (776,11) size 2x2 [r=0 c=1 rs=1 cs=1] + RenderTableCell {TD} at (780,0) size 10x24 [r=0 c=1 rs=1 cs=1] RenderBlock {DIV} at (0,0) size 10x24 [bgcolor=#008000] 581808 2 132585 jbadics 2012-03-19 08:08:37 -0700 Created attachment 132585 proposed patch 581809 3 webkit.review.bot 2012-03-19 08:10:11 -0700 Attachment 132585 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 582796 4 132585 ossy 2012-03-19 23:36:04 -0700 Comment on attachment 132585 proposed patch Skip landed in http://trac.webkit.org/changeset/111363 582797 5 ossy 2012-03-19 23:42:12 -0700 (In reply to comment #1) > The expected.txt in r111156 works fine on 32-bit systems. > But on 64-bit systems some modifications should be made to work well: Before r111156, it passed on 32 bit and 64 bit too. After r111156, it passes on 32 bit, but fails on 64 bit. If we do the same change on Qt as you did on Mac by r111156, it will make the test pass on 64 bit, and fail on 32 bit. > diff --git a/LayoutTests/platform/qt/fast/table/max-width-integer-overflow-expected.txt b/LayoutTests/platform/qt/fast/table/max-width-integer-overflow-expected.txt --- : correct expected result on 32 bit always, and on 64 bit before r111156 +++ : correct expected result on 64 bit after r111156 582798 6 ossy 2012-03-19 23:43:28 -0700 Any idea? Maybe you can reproduce it on other 32/64 bit platforms too. 582809 7 macpherson 2012-03-20 00:02:42 -0700 Just to make sure we understand what's going on, we used to clamp Lengths to 2^28 bits. Lengths themselves have supported the full range of int (and also float) lengths for a while, but we were artificially clamping some values to 2^28 anyway. https://bugs.webkit.org/show_bug.cgi?id=67976 removed that clamping, so the full range of values supported by Length can be used. If you're seeing different values on 32 and 64 bit systems, that must mean that sizeof(int) is different on those systems - which is surprising to me, since a lot of webkit code seems to assume that sizeof(int)==4 (or at least ==sizeof(float)) for data structure packing. In any case, I don't think it's a bug, at least insofar as the range of lengths is not defined by the CSS spec. 975425 8 jturcotte 2014-02-03 03:20:26 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 132585 2012-03-19 08:08:37 -0700 2012-03-19 23:36:04 -0700 proposed patch gard0319_3.patch text/plain 1094 jbadics ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMjU3MTJhLi4wNzdjY2UzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDMt MTkgIErDoW5vcyBCYWRpY3MgIDxqYmFkaWNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBm YXN0L3RhYmxlL21heC13aWR0aC1pbnRlZ2VyLW92ZXJmbG93Lmh0bWwgc2hvdWxkIGJlIHNraXBw ZWQgYmVjYXVzZSBpdCBnaXZlcworICAgICAgICBkaWZmZXJlbnQgcmVzdWx0cyBvbiAzMi0gYW5k IDY0LWJpdCBzeXN0ZW1zLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMi0wMy0xOSAgQmFsYXpzIEFu a2VzICA8YmFua0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgW1F0XSBHYXJkZW5pbmcuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCAwMjhhOWFlLi40ZTA1YWVhIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L3F0L1NraXBwZWQKQEAgLTEzNDEsNiArMTM0MSw3IEBAIHN2Zy96b29tL3RleHQvem9vbS1jb29y ZHMtdmlld2F0dHItMDEtYi5zdmcKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUyODEwCiBmYXN0L3JlcGFpbnQvbW92aW5nLXNoYWRvdy1vbi1jb250YWluZXIuaHRt bAogZmFzdC9yZXBhaW50L21vdmluZy1zaGFkb3ctb24tcGF0aC5odG1sCitmYXN0L3RhYmxlL21h eC13aWR0aC1pbnRlZ2VyLW92ZXJmbG93Lmh0bWwKIHN2Zy9hcy1pbWFnZS9pbWctcHJlc2VydmVB c3BlY3RSYXRpby1zdXBwb3J0LTEuaHRtbAogc3ZnL2JhdGlrL21hc2tpbmcvbWFza1JlZ2lvbnMu c3ZnCiBzdmcvY2xpcC1wYXRoL2RlZXAtbmVzdGVkLWNsaXAtaW4tbWFzay1kaWZmZXJlbnQtdW5p dFR5cGVzLnN2Zwo=