81502 2012-03-19 01:40:58 -0700 x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue 2012-03-19 11:22:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/27027/steps/compile/logs/stdio P2 Normal --- 1 leviw webkit-unassigned jamesr ossy webkit.review.bot oldest_to_newest 581695 0 leviw 2012-03-19 01:40:58 -0700 When WebCore is built with the set of compilation flags used in the Google Chrome official builds, x86 gcc generates a broken copy constructor which results in the following failure: In file included from third_party/WebKit/Source/JavaScriptCore/wtf/HashMap.h:24, from third_party/WebKit/Source/WebCore/platform/KURL.h:31, from third_party/WebKit/Source/WebCore/platform/network/BlobData.h:34, from third_party/WebKit/Source/WebCore/fileapi/Blob.h:34, from third_party/WebKit/Source/WebCore/fileapi/File.h:29, from third_party/WebKit/Source/WebCore/platform/network/chromium/ResourceResponse.h:30, from third_party/WebKit/Source/WebCore/platform/network/AuthenticationChallengeBase.h:30, from third_party/WebKit/Source/WebCore/platform/network/chromium/AuthenticationChallenge.h:30, from third_party/WebKit/Source/WebCore/platform/network/ResourceHandle.h:29, from third_party/WebKit/Source/WebCore/loader/ResourceLoaderOptions.h:34, from third_party/WebKit/Source/WebCore/loader/cache/CachedResource.h:30, from third_party/WebKit/Source/WebCore/loader/cache/CachedImage.h:26, from third_party/WebKit/Source/WebCore/rendering/RenderObject.h:29, from third_party/WebKit/Source/WebCore/rendering/RenderBoxModelObject.h:27, from third_party/WebKit/Source/WebCore/rendering/RenderBox.h:26, from third_party/WebKit/Source/WebCore/rendering/RenderBlock.h:29, from third_party/WebKit/Source/WebCore/rendering/RenderTable.h:30, from third_party/WebKit/Source/WebCore/rendering/RenderTableSection.h:28, from third_party/WebKit/Source/WebCore/rendering/RenderTableSection.cpp:27: third_party/WebKit/Source/JavaScriptCore/wtf/HashTraits.h: In member function 'void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::rehash(int) [with Key = std::pair<const WebCore::RenderTableCell*, int>, Value = std::pair<std::pair<const WebCore::RenderTableCell*, int>, WebCore::CollapsedBorderValue>, Extractor = WTF::PairFirstExtractor<std::pair<std::pair<const WebCore::RenderTableCell*, int>, WebCore::CollapsedBorderValue> >, HashFunctions = WTF::PairHash<const WebCore::RenderTableCell*, int>, Traits = WTF::PairHashTraits<WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >, WTF::HashTraits<WebCore::CollapsedBorderValue> >, KeyTraits = WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >]': third_party/WebKit/Source/JavaScriptCore/wtf/HashTraits.h:153: error: '__y' may be used uninitialized in this function third_party/WebKit/Source/JavaScriptCore/wtf/HashTraits.h:153: note: '__y' was declared here In file included from third_party/WebKit/Source/WebCore/platform/KURL.h:31, from third_party/WebKit/Source/WebCore/platform/network/BlobData.h:34, from third_party/WebKit/Source/WebCore/fileapi/Blob.h:34, from third_party/WebKit/Source/WebCore/fileapi/File.h:29, from third_party/WebKit/Source/WebCore/platform/network/chromium/ResourceResponse.h:30, from third_party/WebKit/Source/WebCore/platform/network/AuthenticationChallengeBase.h:30, from third_party/WebKit/Source/WebCore/platform/network/chromium/AuthenticationChallenge.h:30, from third_party/WebKit/Source/WebCore/platform/network/ResourceHandle.h:29, from third_party/WebKit/Source/WebCore/loader/ResourceLoaderOptions.h:34, from third_party/WebKit/Source/WebCore/loader/cache/CachedResource.h:30, from third_party/WebKit/Source/WebCore/loader/cache/CachedImage.h:26, from third_party/WebKit/Source/WebCore/rendering/RenderObject.h:29, from third_party/WebKit/Source/WebCore/rendering/RenderBoxModelObject.h:27, from third_party/WebKit/Source/WebCore/rendering/RenderBox.h:26, from third_party/WebKit/Source/WebCore/rendering/RenderBlock.h:29, from third_party/WebKit/Source/WebCore/rendering/RenderTable.h:30, from third_party/WebKit/Source/WebCore/rendering/RenderTableSection.h:28, from third_party/WebKit/Source/WebCore/rendering/RenderTableSection.cpp:27: third_party/WebKit/Source/WebCore/rendering/RenderTableSection.cpp: In member function 'std::pair<typename WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::iterator, bool> WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::set(const typename KeyTraitsArg::TraitType&, typename MappedTraitsArg::PassInType) [with KeyArg = std::pair<const WebCore::RenderTableCell*, int>, MappedArg = WebCore::CollapsedBorderValue, HashArg = WTF::PairHash<const WebCore::RenderTableCell*, int>, KeyTraitsArg = WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >, MappedTraitsArg = WTF::HashTraits<WebCore::CollapsedBorderValue>]': third_party/WebKit/Source/WebCore/rendering/RenderTableSection.cpp:1424: error: '__y' may be used uninitialized in this function third_party/WebKit/Source/JavaScriptCore/wtf/HashTraits.h:153: note: '__y' was declared here make: *** [out/Release/obj.target/webcore_rendering/third_party/WebKit/Source/WebCore/rendering/RenderTableSection.o] Error 1 581698 1 132559 hbono 2012-03-19 02:19:30 -0700 Created attachment 132559 A speculative fix Greetings, It seems gcc (x86) somehow creates a broken copy constructor (used by HashSet<> in the RenderTableSection class) because the CollapsedBorderValue class does not have a copy constructor. This change adds a copy constructor to the CollapsedBorderValue class so GCC can use it. (The "Google Chrome Linux" bot can compile RenderTableSelection.cpp without errors when I locally applied this change: <ttp://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/18598>.) Regards, Hironori Bono 581700 2 132559 morrita 2012-03-19 02:34:27 -0700 Comment on attachment 132559 A speculative fix r=me. Having a link to this bug in the code will prevent this from accidental future removal. 581707 3 132563 hbono 2012-03-19 02:43:09 -0700 Created attachment 132563 A speculative fix 2 (added a comment) Greetings Morita-san, Thanks for your review and a comment. I have added a comment to the constructor. Regards, Hironori Bono 581723 4 132563 webkit.review.bot 2012-03-19 03:34:46 -0700 Comment on attachment 132563 A speculative fix 2 (added a comment) Clearing flags on attachment: 132563 Committed r111171: <http://trac.webkit.org/changeset/111171> 581724 5 webkit.review.bot 2012-03-19 03:34:50 -0700 All reviewed patches have been landed. Closing bug. 581967 6 tony 2012-03-19 11:22:51 -0700 *** Bug 81498 has been marked as a duplicate of this bug. *** 132559 2012-03-19 02:19:30 -0700 2012-03-19 02:43:09 -0700 A speculative fix issue81502-patch0.txt text/plain 1505 hbono SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTE2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTE5ICBIaXJvbm9y aSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBhIGNvcHkgY29uc3Ry dWN0b3IgdG8gQ29sbGFwc2VkQm9yZGVyVmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRHVlIHRvIHRoZSBsYWNrIG9mIHRoaXMgY29weSBjb25zdHJ1 Y3RvciwgR0NDICh4ODYpIGNyZWF0ZXMgYSBicm9rZW4gY29weQorICAgICAgICBjb25zdHJ1Y3Rv ciBhbmQgaXQgY2F1c2VzIGEgYnVpbGQgYnJlYWsgb24gR29vZ2xlIENocm9tZS4KKworICAgICAg ICAqIHJlbmRlcmluZy9zdHlsZS9Db2xsYXBzZWRCb3JkZXJWYWx1ZS5oOgorICAgICAgICAoV2Vi Q29yZTo6Q29sbGFwc2VkQm9yZGVyVmFsdWU6OkNvbGxhcHNlZEJvcmRlclZhbHVlKToKKyAgICAg ICAgKENvbGxhcHNlZEJvcmRlclZhbHVlKToKKwogMjAxMi0wMy0xOCAgTWF0dCBGYWxrZW5oYWdl biAgPGZhbGtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRmFsbGJhY2sgdG8gY29tbW9uIHNj cmlwdCB3aGVuIHBlci1zY3JpcHQgZm9udCBzZXR0aW5nIGlzIHRoZSBlbXB0eSBzdHJpbmcKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9Db2xsYXBzZWRCb3JkZXJWYWx1ZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9Db2xsYXBzZWRC b3JkZXJWYWx1ZS5oCShyZXZpc2lvbiAxMTExNTApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvQ29sbGFwc2VkQm9yZGVyVmFsdWUuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNiAr MzYsMTMgQEAgcHVibGljOgogICAgIHsKICAgICB9CiAKKyAgICBDb2xsYXBzZWRCb3JkZXJWYWx1 ZShjb25zdCBDb2xsYXBzZWRCb3JkZXJWYWx1ZSYgb3RoZXIpCisgICAgICAgIDogbV9ib3JkZXIo b3RoZXIubV9ib3JkZXIpCisgICAgICAgICwgbV9ib3JkZXJDb2xvcihvdGhlci5tX2JvcmRlckNv bG9yKQorICAgICAgICAsIG1fcHJlY2VkZW5jZShvdGhlci5tX3ByZWNlZGVuY2UpCisgICAgewor ICAgIH0KKwogICAgIENvbGxhcHNlZEJvcmRlclZhbHVlKGNvbnN0IEJvcmRlclZhbHVlJiBiLCBD b2xvciBjLCBFQm9yZGVyUHJlY2VkZW5jZSBwKQogICAgICAgICA6IG1fYm9yZGVyKGIpCiAgICAg ICAgICwgbV9ib3JkZXJDb2xvcihjKQo= 132563 2012-03-19 02:43:09 -0700 2012-03-19 03:34:46 -0700 A speculative fix 2 (added a comment) issue81502-patch1.txt text/plain 1646 hbono SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTE2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTE5ICBIaXJvbm9y aSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBhIGNvcHkgY29uc3Ry dWN0b3IgdG8gQ29sbGFwc2VkQm9yZGVyVmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRHVlIHRvIHRoZSBsYWNrIG9mIHRoaXMgY29weSBjb25zdHJ1 Y3RvciwgR0NDICh4ODYpIGNyZWF0ZXMgYSBicm9rZW4gY29weQorICAgICAgICBjb25zdHJ1Y3Rv ciBhbmQgaXQgY2F1c2VzIGEgYnVpbGQgYnJlYWsgb24gR29vZ2xlIENocm9tZS4KKworICAgICAg ICAqIHJlbmRlcmluZy9zdHlsZS9Db2xsYXBzZWRCb3JkZXJWYWx1ZS5oOgorICAgICAgICAoV2Vi Q29yZTo6Q29sbGFwc2VkQm9yZGVyVmFsdWU6OkNvbGxhcHNlZEJvcmRlclZhbHVlKToKKyAgICAg ICAgKENvbGxhcHNlZEJvcmRlclZhbHVlKToKKwogMjAxMi0wMy0xOCAgTWF0dCBGYWxrZW5oYWdl biAgPGZhbGtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRmFsbGJhY2sgdG8gY29tbW9uIHNj cmlwdCB3aGVuIHBlci1zY3JpcHQgZm9udCBzZXR0aW5nIGlzIHRoZSBlbXB0eSBzdHJpbmcKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9Db2xsYXBzZWRCb3JkZXJWYWx1ZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9Db2xsYXBzZWRC b3JkZXJWYWx1ZS5oCShyZXZpc2lvbiAxMTExNTApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvQ29sbGFwc2VkQm9yZGVyVmFsdWUuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNiAr MzYsMTUgQEAgcHVibGljOgogICAgIHsKICAgICB9CiAKKyAgICAvLyBUaGlzIGNvcHkgY29uc3Ry dWN0b3IgaXMgZm9yIHByZXZlbnRpbmcgR0NDICh4ODYpIGZyb20gY3JlYXRpbmcgYW4KKyAgICAv LyB1bmV4cGVjdGVkIG9uZSBhcyB3cml0dGVuIGluIDxodHRwOi8vd2Via2l0Lm9yZy9iLzgxNTAy Pi4KKyAgICBDb2xsYXBzZWRCb3JkZXJWYWx1ZShjb25zdCBDb2xsYXBzZWRCb3JkZXJWYWx1ZSYg b3RoZXIpCisgICAgICAgIDogbV9ib3JkZXIob3RoZXIubV9ib3JkZXIpCisgICAgICAgICwgbV9i b3JkZXJDb2xvcihvdGhlci5tX2JvcmRlckNvbG9yKQorICAgICAgICAsIG1fcHJlY2VkZW5jZShv dGhlci5tX3ByZWNlZGVuY2UpCisgICAgeworICAgIH0KKwogICAgIENvbGxhcHNlZEJvcmRlclZh bHVlKGNvbnN0IEJvcmRlclZhbHVlJiBiLCBDb2xvciBjLCBFQm9yZGVyUHJlY2VkZW5jZSBwKQog ICAgICAgICA6IG1fYm9yZGVyKGIpCiAgICAgICAgICwgbV9ib3JkZXJDb2xvcihjKQo=