81482 2012-03-18 20:12:24 -0700 Cross-platform processor core counter: fix build on FreeBSD. 2012-03-29 01:56:22 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco landry webkit.review.bot zherczeg oldest_to_newest 581583 0 rakuco 2012-03-18 20:12:24 -0700 Cross-platform processor core counter: fix build on FreeBSD. 581584 1 132530 rakuco 2012-03-18 20:13:22 -0700 Created attachment 132530 Patch 581586 2 webkit.review.bot 2012-03-18 20:15:14 -0700 Attachment 132530 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/NumberOfCores.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 581590 3 rakuco 2012-03-18 20:19:04 -0700 (In reply to comment #2) > Attachment 132530 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 > Source/JavaScriptCore/wtf/NumberOfCores.cpp:31: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This is a false positive, sys/types.h must come before sys/sysctl.h. 581665 4 zherczeg 2012-03-19 00:16:56 -0700 There is no other OS where this include order caused any trouble. Where is this documentation (a link please)? If this is only FreeBSD specific then add a comment please. 581790 5 rakuco 2012-03-19 07:46:26 -0700 (In reply to comment #4) > There is no other OS where this include order caused any trouble. It may have broken OpenBSD and NetBSD too, since the requirements are pretty much the same. I don't have access to an OS X machine to check what they do differently for this include order reversal to work (this part of their libraries comes from FreeBSD). > Where is this documentation (a link please)? If this is only FreeBSD specific then add a comment please. The man pages for NetBSD, OpenBSD, FreeBSD and Darwin all show that sys/sysctl.h must be included after either sys/param.h or sys/types.h: - http://netbsd.gw.com/cgi-bin/man-cgi?sysctl+3+NetBSD-current - http://www.openbsd.org/cgi-bin/man.cgi?query=sysctl&sektion=3&arch=i386&apropos=0&manpath=OpenBSD+Current - http://www.freebsd.org/cgi/man.cgi?query=sysctl&sektion=3&apropos=0&manpath=FreeBSD+9.0-RELEASE - https://developer.apple.com/library/mac/#documentation/Darwin/Reference/Manpages/man3/sysctl.3.html#//apple_ref/doc/man/3/sysctl u_int is a typedef defined in sys/types.h on FreeBSD (and probably other BSDs too). And including sys/types.h or sys/param.h before is part of the OpenBSD and FreeBSD style guides: - http://www.freebsd.org/cgi/man.cgi?query=style&apropos=0&sektion=0&manpath=FreeBSD+9.0-RELEASE&arch=default&format=html - http://www.openbsd.org/cgi-bin/man.cgi?query=style&apropos=0&sektion=0&manpath=OpenBSD+Current&arch=i386&format=html 581804 6 zherczeg 2012-03-19 08:00:39 -0700 Poor design :( Headers should include what they need. Do you think this will be fixed in the future? Ok, if noone objects I can give you an r+ but please upload a new patch with a comment in the header file which clearly states why we break the WK style guides. 581849 7 132594 rakuco 2012-03-19 09:13:48 -0700 Created attachment 132594 Same patch with some additional comments in the code 581852 8 rakuco 2012-03-19 09:14:41 -0700 (In reply to comment #6) > Poor design :( Headers should include what they need. Do you think this will be fixed in the future? I don't think so, I guess it's part of the design. See select(2) or stat(2) on Linux as well -- they too need additional headers in a certain order. > Ok, if noone objects I can give you an r+ but please upload a new patch with a comment in the header file which clearly states why we break the WK style guides. Done. 581853 9 webkit.review.bot 2012-03-19 09:17:49 -0700 Attachment 132594 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/NumberOfCores.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 581877 10 132594 zherczeg 2012-03-19 09:40:10 -0700 Comment on attachment 132594 Same patch with some additional comments in the code r=me 581886 11 132594 rakuco 2012-03-19 09:48:49 -0700 Comment on attachment 132594 Same patch with some additional comments in the code Clearing flags on attachment: 132594 Committed r111195: <http://trac.webkit.org/changeset/111195> 581887 12 rakuco 2012-03-19 09:48:58 -0700 All reviewed patches have been landed. Closing bug. 590939 13 landry 2012-03-29 01:28:59 -0700 Note that on OpenBSD it also needs sys/param.h before sys/sysctl.h and sys/types.h, otherwise some #defines are missing (as stated in comment #5). Should i reopen this bug or file a new one ? 590948 14 zherczeg 2012-03-29 01:48:33 -0700 File a new one. 590953 15 landry 2012-03-29 01:56:22 -0700 #82585. 132530 2012-03-18 20:13:22 -0700 2012-03-19 09:13:42 -0700 Patch bug-81482-20120319001320.patch text/plain 1559 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm OGJlYTM3M2I0MmI1NDEzZDFlZGY3YjA2NGE1Y2QxNTU5MDU0NmNhLi5mOGViNWI3MzA3ODI5MzYy NjRhMzZhYWUwM2QyMjhkNWEyNmRkODFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0wMy0xOCAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFrdWNvQEZy ZWVCU0Qub3JnPgorCisgICAgICAgIENyb3NzLXBsYXRmb3JtIHByb2Nlc3NvciBjb3JlIGNvdW50 ZXI6IGZpeCBidWlsZCBvbiBGcmVlQlNELgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODE0ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgZG9jdW1lbnRhdGlvbiBvZiBzeXNjdGwoMykgc2hvd3MgdGhh dCA8c3lzL3R5cGVzLmg+IHNob3VsZCBiZQorICAgICAgICBpbmNsdWRlZCBiZWZvcmUgPHN5cy9z eXNjdGwuaD4gKHN5cy90eXBlcy5oIHRlbmRzIHRvIGJlIHRoZSBmaXJzdAorICAgICAgICBpbmNs dWRlZCBoZWFkZXIgaW4gZ2VuZXJhbCkuCisKKyAgICAgICAgVGhpcyBzaG91bGQgZml4IHRoZSBi dWlsZCBvbiBGcmVlQlNEIGFuZCBvdGhlciBzeXN0ZW1zIHdoZXJlCisgICAgICAgIHN5c2N0bC5o IHJlYWxseSBkZXBlbmRzIG9uIHR5cGVzIGRlZmluZWQgaW4gdHlwZXMuaC4KKworICAgICAgICAq IHd0Zi9OdW1iZXJPZkNvcmVzLmNwcDoKKwogMjAxMi0wMy0xNyAgR2F2aW4gQmFycmFjbG91Z2gg IDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgU3RyZW5ndGggcmVkdWN0aW9uLCBS ZWdFeHAuZXhlYyAtPiBSZWdFeHAudGVzdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTnVt YmVyT2ZDb3Jlcy5jcHAKaW5kZXggMWU3ZjQ1ZjVjNjkxMDNjNTI3NzQ5YzMxM2FmYThkOWY5Yzcx YTBhMi4uODAxYTdiZTc2ZjEyZTRlMGVmZGY0ZWE0MzFlZDYwYzEyZDE5MzhhYyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL051bWJlck9mQ29yZXMuY3BwCkBAIC0yNyw4ICsyNyw4IEBA CiAjaW5jbHVkZSAiTnVtYmVyT2ZDb3Jlcy5oIgogCiAjaWYgT1MoREFSV0lOKSB8fCBPUyhPUEVO QlNEKSB8fCBPUyhORVRCU0QpIHx8IE9TKEZSRUVCU0QpCi0jaW5jbHVkZSA8c3lzL3N5c2N0bC5o PgogI2luY2x1ZGUgPHN5cy90eXBlcy5oPgorI2luY2x1ZGUgPHN5cy9zeXNjdGwuaD4KICNlbGlm IE9TKExJTlVYKSB8fCBPUyhBSVgpIHx8IE9TKFNPTEFSSVMpCiAjaW5jbHVkZSA8dW5pc3RkLmg+ CiAjZWxpZiBPUyhXSU5ET1dTKQo= 132594 2012-03-19 09:13:48 -0700 2012-03-19 09:48:49 -0700 Same patch with some additional comments in the code bug-81482-20120319131505.patch text/plain 1750 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 OTgzMjYwZGE1ZTBlZjMwMzg0MjlkMGQyMjMxZWY4YmVjYmU2ZjI1Li42OWMzOGJlOWMzMWYwMWYz ZmMwODM3ZGU3MjczNjUwZGQyZDkyNmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0wMy0xOSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFrdWNvQEZy ZWVCU0Qub3JnPgorCisgICAgICAgIENyb3NzLXBsYXRmb3JtIHByb2Nlc3NvciBjb3JlIGNvdW50 ZXI6IGZpeCBidWlsZCBvbiBGcmVlQlNELgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODE0ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgZG9jdW1lbnRhdGlvbiBvZiBzeXNjdGwoMykgc2hvd3MgdGhh dCA8c3lzL3R5cGVzLmg+IHNob3VsZCBiZQorICAgICAgICBpbmNsdWRlZCBiZWZvcmUgPHN5cy9z eXNjdGwuaD4gKHN5cy90eXBlcy5oIHRlbmRzIHRvIGJlIHRoZSBmaXJzdAorICAgICAgICBpbmNs dWRlZCBoZWFkZXIgaW4gZ2VuZXJhbCkuCisKKyAgICAgICAgVGhpcyBzaG91bGQgZml4IHRoZSBi dWlsZCBvbiBGcmVlQlNEIGFuZCBvdGhlciBzeXN0ZW1zIHdoZXJlCisgICAgICAgIHN5c2N0bC5o IHJlYWxseSBkZXBlbmRzIG9uIHR5cGVzIGRlZmluZWQgaW4gdHlwZXMuaC4KKworICAgICAgICAq IHd0Zi9OdW1iZXJPZkNvcmVzLmNwcDoKKwogMjAxMi0wMy0xOSAgR2F2aW4gQmFycmFjbG91Z2gg IDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgSlNDYWxsYmFja0Z1bmN0aW9uOjp0 b1N0cmluZ0NhbGxiYWNrL3ZhbHVlT2ZDYWxsYmFjayBkbyBub3QgaGFuZGxlIDAgcmV0dXJuIHZh bHVlIGZyb20gY29udmVydFRvVHlwZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9OdW1iZXJPZkNvcmVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTnVtYmVy T2ZDb3Jlcy5jcHAKaW5kZXggMWU3ZjQ1ZjVjNjkxMDNjNTI3NzQ5YzMxM2FmYThkOWY5YzcxYTBh Mi4uODU4OGY0MTkwMjk0MTA1NGQ2ZmVkZjEyMzZkMDlhYmFmOTU3MjY2NiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdW1iZXJPZkNvcmVzLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL051bWJlck9mQ29yZXMuY3BwCkBAIC0yNyw4ICsyNywxMCBAQAog I2luY2x1ZGUgIk51bWJlck9mQ29yZXMuaCIKIAogI2lmIE9TKERBUldJTikgfHwgT1MoT1BFTkJT RCkgfHwgT1MoTkVUQlNEKSB8fCBPUyhGUkVFQlNEKQotI2luY2x1ZGUgPHN5cy9zeXNjdGwuaD4K Ky8vIHN5cy90eXBlcy5oIG11c3QgY29tZSBiZWZvcmUgc3lzL3N5c2N0bC5oIGJlY2F1c2UgdGhl IGxhdHRlciB1c2VzCisvLyBkYXRhIHR5cGVzIGRlZmluZWQgaW4gdGhlIGZvcm1lci4gU2VlIHN5 c2N0bCgzKSBhbmQgc3R5bGUoOSkuCiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CisjaW5jbHVkZSA8 c3lzL3N5c2N0bC5oPgogI2VsaWYgT1MoTElOVVgpIHx8IE9TKEFJWCkgfHwgT1MoU09MQVJJUykK ICNpbmNsdWRlIDx1bmlzdGQuaD4KICNlbGlmIE9TKFdJTkRPV1MpCg==