81481 2012-03-18 20:00:36 -0700 webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD. 2012-05-07 16:14:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco abarth gustavo jchaffraix mrobinson webkit.review.bot oldest_to_newest 581577 0 rakuco 2012-03-18 20:00:36 -0700 webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD. 581578 1 132528 rakuco 2012-03-18 20:01:07 -0700 Created attachment 132528 Patch 581580 2 webkit.review.bot 2012-03-18 20:06:07 -0700 Attachment 132528 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitdi..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 581585 3 132531 rakuco 2012-03-18 20:14:08 -0700 Created attachment 132531 Patch 582606 4 132531 mrobinson 2012-03-19 19:08:21 -0700 Comment on attachment 132531 Patch Sorry. Removing r+ flag, because of Adam's comments here: https://bugs.webkit.org/show_bug.cgi?id=81465 606069 5 132531 jchaffraix 2012-04-19 16:02:17 -0700 Comment on attachment 132531 Patch Looks sane (if it still applies). 606095 6 132531 jchaffraix 2012-04-19 16:14:56 -0700 Comment on attachment 132531 Patch Clearing r+ again pending the missing discussion (missed abarth & mrobinson comments, my apologies for the noise) 618062 7 132531 webkit.review.bot 2012-05-07 16:14:16 -0700 Comment on attachment 132531 Patch Clearing flags on attachment: 132531 Committed r116366: <http://trac.webkit.org/changeset/116366> 618063 8 webkit.review.bot 2012-05-07 16:14:21 -0700 All reviewed patches have been landed. Closing bug. 132528 2012-03-18 20:01:07 -0700 2012-03-18 20:14:01 -0700 Patch bug-81481-20120319000105.patch text/plain 1581 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTIzNDllMzMxZGNmN2E2MzMyZGVhMzMxODg2NWY2Y2I3 MjQyYjlkNy4uOTcwMzUwNGQzNDZlY2ZhY2ZmOWQ1NmU1ODJkMDIyZjVlODM0YzVjZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAzLTE4ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29ARnJlZUJTRC5v cmc+CisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BT ISkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGcmVl QlNEIGhhcyB0aGUgc2FtZSBzeXNjdGwgaW50ZXJmYWNlIHByZXNlbnQgaW4gRGFyd2luIHRvIHF1 ZXJ5CisgICAgICAgIHRoZSBudW1iZXIgb2YgQ1BVcyBhdmFpbGFibGUsIHNvIHVzZSB0aGF0IHRv by4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWlu ZU51bWJlck9mQ1BVcyk6IFNoYXJlIHRoZSBzeXNjdGwgY2FsbCB3aXRoIERhcndpbi4KKyAgICAg ICAgKGlzRnJlZUJTRCk6IEFkZGVkLgorCiAyMDEyLTAzLTE3ICBSYXBoYWVsIEt1Ym8gZGEgQ29z dGEgIDxyYWt1Y29ARnJlZUJTRC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZDsgc3dpdGNoIHRv IHVzaW5nIG15IEZyZWVCU0Qub3JnIGVtYWlsIGFkZHJlc3MsIHRoZQpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmlu ZGV4IGU2OTY4YWIwMGRjMzkxY2VkNDA5ZjYwMjgxNDQwMWYxMzRlZTYxZjguLjEyNGMxOGZmZTQw MTRiMzgyNDA3YWVlOWVmN2I0NTkxZWJiMzU0MGIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTMzOCw3 ICszMzgsNyBAQCBzdWIgZGV0ZXJtaW5lTnVtYmVyT2ZDUFVzCiAgICAgfSBlbHNpZiAoaXNXaW5k b3dzKCkgfHwgaXNDeWd3aW4oKSkgewogICAgICAgICAjIEFzc3VtZXMgY3lnd2luCiAgICAgICAg ICRudW1iZXJPZkNQVXMgPSBgbHMgL3Byb2MvcmVnaXN0cnkvSEtFWV9MT0NBTF9NQUNISU5FL0hB UkRXQVJFL0RFU0NSSVBUSU9OL1N5c3RlbS9DZW50cmFsUHJvY2Vzc29yIHwgd2MgLXdgOwotICAg IH0gZWxzaWYgKGlzRGFyd2luKCkpIHsKKyAgICB9IGVsc2lmIChpc0RhcndpbigpIHx8IGlzRnJl ZUJTRCgpKSB7CiAgICAgICAgIGNob21wKCRudW1iZXJPZkNQVXMgPSBgc3lzY3RsIC1uIGh3Lm5j cHVgKTsKICAgICB9CiB9CkBAIC0xMjU2LDYgKzEyNTYsMTEgQEAgc3ViIGlzTGludXgoKQogICAg IHJldHVybiAoJF5PIGVxICJsaW51eCIpIHx8IDA7CiB9CiAKK3N1YiBpc0ZyZWVCU0QoKQorewor ICAgIHJldHVybiAoJF5PIGVxICJmcmVlYnNkIikgfHwgMDsKK30KKwogc3ViIGlzQVJNKCkKIHsK ICAgICByZXR1cm4gJENvbmZpZ3thcmNobmFtZX0gPX4gL15hcm0tLzsK 132531 2012-03-18 20:14:08 -0700 2012-05-07 16:14:16 -0700 Patch bug-81481-20120319001406.patch text/plain 1650 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTIzNDllMzMxZGNmN2E2MzMyZGVhMzMxODg2NWY2Y2I3 MjQyYjlkNy4uZmZhMDA3OGExMjZjYzI0YWZhYjUxNDJkMDgyZTZkYjA3ZDIwYTc5NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAzLTE4ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29ARnJlZUJTRC5v cmc+CisKKyAgICAgICAgd2Via2l0ZGlycy5wbTogTWFrZSBkZXRlcm1pbmVOdW1iZXJPZkNQVXMg d29yayBvbiBGcmVlQlNELgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODE0ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGcmVlQlNEIGhhcyB0aGUgc2FtZSBzeXNjdGwgaW50ZXJmYWNlIHByZXNlbnQgaW4g RGFyd2luIHRvIHF1ZXJ5CisgICAgICAgIHRoZSBudW1iZXIgb2YgQ1BVcyBhdmFpbGFibGUsIHNv IHVzZSB0aGF0IHRvby4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAg ICAgKGRldGVybWluZU51bWJlck9mQ1BVcyk6IFNoYXJlIHRoZSBzeXNjdGwgY2FsbCB3aXRoIERh cndpbi4KKyAgICAgICAgKGlzRnJlZUJTRCk6IEFkZGVkLgorCiAyMDEyLTAzLTE3ICBSYXBoYWVs IEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29ARnJlZUJTRC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZDsgc3dpdGNoIHRvIHVzaW5nIG15IEZyZWVCU0Qub3JnIGVtYWlsIGFkZHJlc3MsIHRoZQpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCmluZGV4IGU2OTY4YWIwMGRjMzkxY2VkNDA5ZjYwMjgxNDQwMWYxMzRlZTYxZjgu LjEyNGMxOGZmZTQwMTRiMzgyNDA3YWVlOWVmN2I0NTkxZWJiMzU0MGIgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0KQEAgLTMzOCw3ICszMzgsNyBAQCBzdWIgZGV0ZXJtaW5lTnVtYmVyT2ZDUFVzCiAgICAgfSBl bHNpZiAoaXNXaW5kb3dzKCkgfHwgaXNDeWd3aW4oKSkgewogICAgICAgICAjIEFzc3VtZXMgY3ln d2luCiAgICAgICAgICRudW1iZXJPZkNQVXMgPSBgbHMgL3Byb2MvcmVnaXN0cnkvSEtFWV9MT0NB TF9NQUNISU5FL0hBUkRXQVJFL0RFU0NSSVBUSU9OL1N5c3RlbS9DZW50cmFsUHJvY2Vzc29yIHwg d2MgLXdgOwotICAgIH0gZWxzaWYgKGlzRGFyd2luKCkpIHsKKyAgICB9IGVsc2lmIChpc0Rhcndp bigpIHx8IGlzRnJlZUJTRCgpKSB7CiAgICAgICAgIGNob21wKCRudW1iZXJPZkNQVXMgPSBgc3lz Y3RsIC1uIGh3Lm5jcHVgKTsKICAgICB9CiB9CkBAIC0xMjU2LDYgKzEyNTYsMTEgQEAgc3ViIGlz TGludXgoKQogICAgIHJldHVybiAoJF5PIGVxICJsaW51eCIpIHx8IDA7CiB9CiAKK3N1YiBpc0Zy ZWVCU0QoKQoreworICAgIHJldHVybiAoJF5PIGVxICJmcmVlYnNkIikgfHwgMDsKK30KKwogc3Vi IGlzQVJNKCkKIHsKICAgICByZXR1cm4gJENvbmZpZ3thcmNobmFtZX0gPX4gL15hcm0tLzsK