81477 2012-03-18 17:50:10 -0700 CSS3 calc: make mask images work with mixed percent/absolute 2012-03-19 11:02:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 16662 1 mikelawther mikelawther macpherson menard webkit.review.bot oldest_to_newest 581539 0 mikelawther 2012-03-18 17:50:10 -0700 CSS3 calc: make mask images work with mixed percent/absolute 581540 1 132514 mikelawther 2012-03-18 17:52:34 -0700 Created attachment 132514 Patch 581541 2 mikelawther 2012-03-18 17:54:34 -0700 For your reviewing pleasure, this is the testcase that is now passing: http://trac.webkit.org/browser/trunk/LayoutTests/css3/calc/simple-composited-mask.html Just linking it here since it doesn't show up in the review as the test itself is unchanged. 581906 3 132514 ojan 2012-03-19 10:23:13 -0700 Comment on attachment 132514 Patch Sigh. So much duplicate code. It's not your fault though. If you wanted to do a cleanup patch after this, you could move the duplicated code in mapFillSize into a static helper function (i.e. lines 4230-4239 are identical to 4241-4250). r=me if you decide to do that. 581941 4 132514 webkit.review.bot 2012-03-19 11:02:53 -0700 Comment on attachment 132514 Patch Clearing flags on attachment: 132514 Committed r111205: <http://trac.webkit.org/changeset/111205> 581943 5 webkit.review.bot 2012-03-19 11:02:58 -0700 All reviewed patches have been landed. Closing bug. 132514 2012-03-18 17:52:34 -0700 2012-03-19 11:02:53 -0700 Patch bug-81477-20120319115231.patch text/plain 5123 mikelawther U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwOTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQyMmYzMTIyYWQyZWI5 NjMxMzgzYmU4MWEwNjUwM2E2OWViYWY4Yi4uY2FhYmNhN2M5MzhiYTJhYmYxMDU5NmNkMDliZTE3 Nzk3MGM3M2U4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE4ICBNaWtl IExhd3RoZXIgIDxtaWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ1NTMyBjYWxj OiBtYWtlIG1hc2sgaW1hZ2VzIHdvcmsgd2l0aCBtaXhlZCBwZXJjZW50L2Fic29sdXRlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTQ3NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGNzczMvY2Fs Yy9zaW1wbGUtY29tcG9zaXRlZC1tYXNrLWV4cGVjdGVkLmh0bWwKKworICAgICAgICAqIGNzcy9D U1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6 OmNvbGxlY3RNYXRjaGluZ1J1bGVzRm9yTGlzdCk6CisKIDIwMTItMDMtMTUgIE1pa2UgTGF3dGhl ciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MzIGNhbGM6IG1peGVk IHBlcmNlbnQvYWJzb2x1dGUgZXhwcmVzc2lvbnMgZm9yIGdyYWRpZW50cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IGM1MTY1NTg3Y2ZlODU1NGRhMWZiNWQ4NGRh OGVmMWQ5ZWIyMmU5OGUuLjlhYjRmNTAyODgwYmZiMmVmMDM4MmFkYTJlMjA1YmZkNWUxMjU5MDkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTQyMzMsNiArNDIz Myw4IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6bWFwRmlsbFNpemUoQ1NTUHJvcGVydHlJRCwg RmlsbExheWVyKiBsYXllciwgQ1NTVmFsdWUqIHZhCiAgICAgICAgIGZpcnN0TGVuZ3RoID0gZmly c3QtPmNvbXB1dGVMZW5ndGg8TGVuZ3RoPihzdHlsZSgpLCBtX3Jvb3RFbGVtZW50U3R5bGUsIHpv b21GYWN0b3IpOwogICAgIGVsc2UgaWYgKGZpcnN0LT5pc1BlcmNlbnRhZ2UoKSkKICAgICAgICAg Zmlyc3RMZW5ndGggPSBMZW5ndGgoZmlyc3QtPmdldERvdWJsZVZhbHVlKCksIFBlcmNlbnQpOwor ICAgIGVsc2UgaWYgKGZpcnN0LT5pc0NhbGN1bGF0ZWRQZXJjZW50YWdlV2l0aExlbmd0aCgpKQor ICAgICAgICBmaXJzdExlbmd0aCA9IExlbmd0aChmaXJzdC0+Y3NzQ2FsY1ZhbHVlKCktPnRvQ2Fs Y1ZhbHVlKHN0eWxlKCksIG1fcm9vdEVsZW1lbnRTdHlsZSwgem9vbUZhY3RvcikpOwogICAgIGVs c2UKICAgICAgICAgcmV0dXJuOwogCkBAIC00MjQyLDYgKzQyNDQsOCBAQCB2b2lkIENTU1N0eWxl U2VsZWN0b3I6Om1hcEZpbGxTaXplKENTU1Byb3BlcnR5SUQsIEZpbGxMYXllciogbGF5ZXIsIENT U1ZhbHVlKiB2YQogICAgICAgICBzZWNvbmRMZW5ndGggPSBzZWNvbmQtPmNvbXB1dGVMZW5ndGg8 TGVuZ3RoPihzdHlsZSgpLCBtX3Jvb3RFbGVtZW50U3R5bGUsIHpvb21GYWN0b3IpOwogICAgIGVs c2UgaWYgKHNlY29uZC0+aXNQZXJjZW50YWdlKCkpCiAgICAgICAgIHNlY29uZExlbmd0aCA9IExl bmd0aChzZWNvbmQtPmdldERvdWJsZVZhbHVlKCksIFBlcmNlbnQpOworICAgIGVsc2UgaWYgKHNl Y29uZC0+aXNDYWxjdWxhdGVkUGVyY2VudGFnZVdpdGhMZW5ndGgoKSkKKyAgICAgICAgc2Vjb25k TGVuZ3RoID0gTGVuZ3RoKHNlY29uZC0+Y3NzQ2FsY1ZhbHVlKCktPnRvQ2FsY1ZhbHVlKHN0eWxl KCksIG1fcm9vdEVsZW1lbnRTdHlsZSwgem9vbUZhY3RvcikpOwogICAgIGVsc2UKICAgICAgICAg cmV0dXJuOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNWQ1ZGNjNTcwOWNkZjU5ZTJhNGRkNWEyODc1MTM5ZmIwYjM4NGI2 OC4uZDE0OTRjNDUwOTM3MjYyZjdiMzg0MDQ4NGY3YzQyYThmOGQ0OGM1OCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTAzLTE4ICBNaWtlIExhd3RoZXIgIDxtaWtlbGF3dGhlckBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgQ1NTMyBjYWxjOiBtYWtlIG1hc2sgaW1hZ2VzIHdvcmsgd2l0aCBt aXhlZCBwZXJjZW50L2Fic29sdXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MTQ3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogY3NzMy9jYWxjL3NpbXBsZS1jb21wb3NpdGVkLW1hc2stZXhwZWN0ZWQu aHRtbDogUmVuYW1lZCBmcm9tIExheW91dFRlc3RzL2NzczMvY2FsYy9zaW1wbGUtY29tcG9zaXRl ZC1tYXNrLWV4cGVjdGVkLW1pc21hdGNoLmh0bWwuCisKIDIwMTItMDMtMTUgIE1pa2UgTGF3dGhl ciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MzIGNhbGM6IG1peGVk IHBlcmNlbnQvYWJzb2x1dGUgZXhwcmVzc2lvbnMgZm9yIGdyYWRpZW50cwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvY3NzMy9jYWxjL3NpbXBsZS1jb21wb3NpdGVkLW1hc2stZXhwZWN0ZWQtbWlz bWF0Y2guaHRtbCBiL0xheW91dFRlc3RzL2NzczMvY2FsYy9zaW1wbGUtY29tcG9zaXRlZC1tYXNr LWV4cGVjdGVkLW1pc21hdGNoLmh0bWwKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGMw OTA5NDUyZTA1ZDQxMTM4MThmNmIzMWY2ZGFjODhlY2Y1MjljYTcuLjAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvY3NzMy9jYWxjL3NpbXBs ZS1jb21wb3NpdGVkLW1hc2stZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbAorKysgL2Rldi9udWxsCkBA IC0xLDMxICswLDAgQEAKLTwhRE9DVFlQRSBodG1sPgotPHN0eWxlPgotICAgICNjb250YWluZXIg ewotICAgICAgICBoZWlnaHQ6IDc2MHB4OwotICAgICAgICB3aWR0aDogMjYwcHg7Ci0gICAgICAg IGJvcmRlcjogc29saWQgYmxhY2s7Ci0gICAgICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKLSAg ICB9Ci0gICAgLmJveCB7Ci0gICAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKLSAgICAgICAgd2lk dGg6IDIwMHB4OwotICAgICAgICBoZWlnaHQ6IDIwMHB4OwotICAgICAgICBtYXJnaW46IDMwcHg7 Ci0gICAgICAgIGJvcmRlcjogMTBweCBzb2xpZCBibGFjazsKLSAgICAgICAgYmFja2dyb3VuZC1j b2xvcjogcmdiYSgxMDAsIDEwMCwgMjU1LCAwLjgpOwotICAgICAgICAtd2Via2l0LWJveC1zaXpp bmc6IGJvcmRlci1ib3g7Ci0gICAgICAgIC13ZWJraXQtYm94LXNoYWRvdzogYmxhY2sgMCA0cHgg NHB4OwotICAgIH0KLQotICAgICNjb250YWluZXIgLm1hc2tlZCB7Ci0gICAgICAgIC13ZWJraXQt bWFzay1pbWFnZTogdXJsKHJlc291cmNlcy9hbHBoYS1ncmFkaWVudC5wbmcpOwotICAgICAgICAt d2Via2l0LW1hc2stcmVwZWF0OiByZXBlYXQ7Ci0gICAgICAgIC13ZWJraXQtbWFzay1zaXplOiA1 MHB4OwotICAgIH0KLTwvc3R5bGU+Ci08cD5UZXN0aW5nIG1hc2tzIG9uIGNvbXBvc2l0aW5nIGxh eWVycy48L3A+Ci08ZGl2IGlkPSJjb250YWluZXIiPgotICAgIDxkaXYgY2xhc3M9Im1hc2tlZCBi b3giPjwvZGl2PgotICAgIDxkaXYgY2xhc3M9Im1hc2tlZCBib3giPjwvZGl2PgotICAgIDxkaXYg Y2xhc3M9Im1hc2tlZCBib3giPjwvZGl2PgotPC9kaXY+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9jc3MzL2NhbGMvc2ltcGxlLWNvbXBvc2l0ZWQtbWFzay1leHBlY3RlZC5odG1sIGIvTGF5b3V0 VGVzdHMvY3NzMy9jYWxjL3NpbXBsZS1jb21wb3NpdGVkLW1hc2stZXhwZWN0ZWQuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5jMDkwOTQ1MmUwNWQ0MTEzODE4ZjZiMzFmNmRhYzg4ZWNmNTI5Y2E3Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9jYWxjL3NpbXBsZS1jb21wb3NpdGVkLW1hc2st ZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDMxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxzdHlsZT4K KyAgICAjY29udGFpbmVyIHsKKyAgICAgICAgaGVpZ2h0OiA3NjBweDsKKyAgICAgICAgd2lkdGg6 IDI2MHB4OworICAgICAgICBib3JkZXI6IHNvbGlkIGJsYWNrOworICAgICAgICBkaXNwbGF5OiBp bmxpbmUtYmxvY2s7CisgICAgfQorICAgIC5ib3ggeworICAgICAgICBwb3NpdGlvbjogcmVsYXRp dmU7CisgICAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgaGVpZ2h0OiAyMDBweDsKKyAgICAg ICAgbWFyZ2luOiAzMHB4OworICAgICAgICBib3JkZXI6IDEwcHggc29saWQgYmxhY2s7CisgICAg ICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMTAwLCAxMDAsIDI1NSwgMC44KTsKKyAgICAgICAg LXdlYmtpdC1ib3gtc2l6aW5nOiBib3JkZXItYm94OworICAgICAgICAtd2Via2l0LWJveC1zaGFk b3c6IGJsYWNrIDAgNHB4IDRweDsKKyAgICB9CisKKyAgICAjY29udGFpbmVyIC5tYXNrZWQgewor ICAgICAgICAtd2Via2l0LW1hc2staW1hZ2U6IHVybChyZXNvdXJjZXMvYWxwaGEtZ3JhZGllbnQu cG5nKTsKKyAgICAgICAgLXdlYmtpdC1tYXNrLXJlcGVhdDogcmVwZWF0OworICAgICAgICAtd2Vi a2l0LW1hc2stc2l6ZTogNTBweDsKKyAgICB9Cis8L3N0eWxlPgorPHA+VGVzdGluZyBtYXNrcyBv biBjb21wb3NpdGluZyBsYXllcnMuPC9wPgorPGRpdiBpZD0iY29udGFpbmVyIj4KKyAgICA8ZGl2 IGNsYXNzPSJtYXNrZWQgYm94Ij48L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJtYXNrZWQgYm94Ij48 L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJtYXNrZWQgYm94Ij48L2Rpdj4KKzwvZGl2Pgo=