81474 2012-03-18 11:47:55 -0700 Fix compile when FULLSCREEN_API is not enabled on Mac 2012-03-18 12:17:34 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki psolanki oldest_to_newest 581476 0 psolanki 2012-03-18 11:47:55 -0700 Build fails if FULLSCREEN_API is not enabled on mac. We should guard the code inside ENABLE(FULLSCREEN_API). 581477 1 132500 psolanki 2012-03-18 11:50:05 -0700 Created attachment 132500 Patch 581480 2 132500 adachan 2012-03-18 11:59:24 -0700 Comment on attachment 132500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132500&action=review > Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:29 > +#if ENABLE(FULLSCREEN_API) Can '#import "WebCoreFullScreenWindow.h"' be placed inside the #if ENABLE(FULLSCREEN_API) block? 581481 3 132500 psolanki 2012-03-18 12:10:37 -0700 Comment on attachment 132500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132500&action=review >> Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:29 >> +#if ENABLE(FULLSCREEN_API) > > Can '#import "WebCoreFullScreenWindow.h"' be placed inside the #if ENABLE(FULLSCREEN_API) block? Yeah, it probably should. I will make that change before committing. Thanks for the review. 581482 4 psolanki 2012-03-18 12:17:34 -0700 Committed r111135: <http://trac.webkit.org/changeset/111135> 132500 2012-03-18 11:50:05 -0700 2012-03-18 12:10:37 -0700 Patch bug-81474-20120318115004.patch text/plain 2096 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUyNjM4OTE2YjYzOGU1 MWM4Yjg2MjdmNGRhOWQxODk4MTg2MzRmMS4uZDQwYTRkMDNkZDA1Y2FlZmYxNTFhMDEwMmU4Nzcy Yzg2OTVkOTY1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTE4ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZSB3 aGVuIEZVTExTQ1JFRU5fQVBJIGlzIG5vdCBlbmFibGVkIG9uIE1hYworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE0NzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHdWFyZCB0aGUgZnVsbCBzY3JlZW4gYXBp IGNvZGUgaW5zaWRlIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIGJlY2F1c2Ugbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZvcm0v bWFjL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lmg6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1dl YkNvcmVGdWxsU2NyZWVuV2luZG93Lm1tOgorCiAyMDEyLTAzLTE0ICBNYXJrIFBpbGdyaW0gIDxw aWxncmltQGNocm9taXVtLm9yZz4KIAogICAgICAgICBNb3ZlIEVudHJpZXNDYWxsYmFjayB0byBN b2R1bGVzL2ZpbGVzeXN0ZW0vCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9XZWJDb3JlRnVsbFNjcmVlbldpbmRvdy5oCmluZGV4IDIxNGU2NzNhNzc0NzU0YmY5NzRjNTUx Mjk1NjJlZjFkMmY5MmNjMmEuLmRlNjM2NWE5NDE4MjE0NDQ0YzcxODFiNWUwY2RkZWRlNTk2MThh YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNj cmVlbldpbmRvdy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVs bFNjcmVlbldpbmRvdy5oCkBAIC0yNiw3ICsyNiwxMSBAQAogI2lmbmRlZiBXZWJDb3JlRnVsbFNj cmVlbldpbmRvd19oCiAjZGVmaW5lIFdlYkNvcmVGdWxsU2NyZWVuV2luZG93X2gKIAorI2lmIEVO QUJMRShGVUxMU0NSRUVOX0FQSSkKKwogQGludGVyZmFjZSBXZWJDb3JlRnVsbFNjcmVlbldpbmRv dyA6IE5TV2luZG93CiBAZW5kCiAKKyNlbmRpZiAvLyBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCisK ICNlbmRpZiAvLyBXZWJDb3JlRnVsbFNjcmVlbldpbmRvd19oCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3JlZW5XaW5kb3cubW0KaW5kZXggYjYy NDgzYjMwMTVlOTNkY2EyN2I5ZDA0NDFiYmQ2YTU1ZjMzMjk0MS4uZjE3NjcxNTk4MTc0NmE4MGMy Zjc4MjY3MDRiYmQwNDM0NGE2NDFlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuV2luZG93Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlbldpbmRvdy5tbQpAQCAtMjYsNiArMjYsOCBAQAog I2ltcG9ydCAiY29uZmlnLmgiCiAjaW1wb3J0ICJXZWJDb3JlRnVsbFNjcmVlbldpbmRvdy5oIgog CisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorCiBAaW1wbGVtZW50YXRpb24gV2ViQ29yZUZ1 bGxTY3JlZW5XaW5kb3cKIAogLSAoaWQpaW5pdFdpdGhDb250ZW50UmVjdDooTlNSZWN0KWNvbnRl bnRSZWN0IHN0eWxlTWFzazooTlNVSW50ZWdlcilhU3R5bGUgYmFja2luZzooTlNCYWNraW5nU3Rv cmVUeXBlKWJ1ZmZlcmluZ1R5cGUgZGVmZXI6KEJPT0wpZmxhZwpAQCAtNjYsMyArNjgsNCBAQAog fQogQGVuZAogCisjZW5kaWYgLy8gRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQo=