81470 2012-03-18 04:29:34 -0700 [Qt] Don't prepare SQL statements when the database is not open 2012-03-18 17:23:37 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf kenneth oldest_to_newest 581444 0 ahf 2012-03-18 04:29:34 -0700 We are currently preparing the SQL statements in the cookie jar regardless of whether or not the database is actually open. Due to this the terminal will be spammed with messages like: QSqlQuery::prepare: database not open Patch coming up. 581445 1 132488 ahf 2012-03-18 04:31:46 -0700 Created attachment 132488 Patch 581446 2 ahf 2012-03-18 04:32:09 -0700 Adding Dr. Kenneth for review! 581530 3 ahf 2012-03-18 17:23:37 -0700 Committed r111142: <http://trac.webkit.org/changeset/111142> 132488 2012-03-18 04:31:46 -0700 2012-03-18 08:05:35 -0700 Patch bug-81470-20120318123147.patch text/plain 2658 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjIwZmYxNmYyMTg5MGYy YmJhYmUyOWM1NzZlY2IyYTVhNmU1ZGU0Zi4uYmI2NmZkMTRiM2E3N2Q2YjY5ZTc0OTQ1MjBlNjk3 NGNjMDdkNDdiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTE4ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgorCisgICAgICAgIFtR dF0gRG9uJ3QgcHJlcGFyZSBTUUwgc3RhdGVtZW50cyB3aGVuIHRoZSBkYXRhYmFzZSBpcyBub3Qg b3BlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE0 NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHJl YWR5IGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9D b29raWVKYXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRDb29raWVKYXJRdDo6ZGVs ZXRlQ29va2llc0Zvckhvc3RuYW1lKToKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZENvb2tpZUph clF0OjpkZWxldGVBbGxDb29raWVzKToKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZENvb2tpZUph clF0OjpzZXRDb29raWVzRnJvbVVybCk6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRDb29raWVK YXJRdDo6bG9hZENvb2tpZXMpOgorCiAyMDEyLTAzLTE1ICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFs ZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgogCiAgICAgICAgIFdJUDogVmlicmF0aW9uLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwCmluZGV4IGY3NmNlOTRmZTFj ZmM3YmUxMTA2YjdhZWQ5MmQyNWQ2ZWViM2RhZDUuLjgxNmE4ZTBmZDE3MzA4MTUyZmFjMWJhNjU0 MWVhNWRjMWVhMGZhM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0Nv b2tpZUphclF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJR dC5jcHAKQEAgLTIwMiw2ICsyMDIsOSBAQCB2b2lkIFNoYXJlZENvb2tpZUphclF0OjpnZXRIb3N0 bmFtZXNXaXRoQ29va2llcyhIYXNoU2V0PFN0cmluZz4mIGhvc3RuYW1lcykKIAogdm9pZCBTaGFy ZWRDb29raWVKYXJRdDo6ZGVsZXRlQ29va2llc0Zvckhvc3RuYW1lKGNvbnN0IFN0cmluZyYgaG9z dG5hbWUpCiB7CisgICAgaWYgKCFtX2RhdGFiYXNlLmlzT3BlbigpKQorICAgICAgICByZXR1cm47 CisKICAgICBRTGlzdDxRTmV0d29ya0Nvb2tpZT4gY29va2llcyA9IGFsbENvb2tpZXMoKTsKICAg ICBRTGlzdDxRTmV0d29ya0Nvb2tpZT46Okl0ZXJhdG9yIGl0ID0gY29va2llcy5iZWdpbigpOwog ICAgIFFMaXN0PFFOZXR3b3JrQ29va2llPjo6SXRlcmF0b3IgZW5kID0gY29va2llcy5lbmQoKTsK QEAgLTIyMCw2ICsyMjMsOSBAQCB2b2lkIFNoYXJlZENvb2tpZUphclF0OjpkZWxldGVDb29raWVz Rm9ySG9zdG5hbWUoY29uc3QgU3RyaW5nJiBob3N0bmFtZSkKIAogdm9pZCBTaGFyZWRDb29raWVK YXJRdDo6ZGVsZXRlQWxsQ29va2llcygpCiB7CisgICAgaWYgKCFtX2RhdGFiYXNlLmlzT3Blbigp KQorICAgICAgICByZXR1cm47CisKICAgICBRU3FsUXVlcnkgc3FsUXVlcnkobV9kYXRhYmFzZSk7 CiAgICAgc3FsUXVlcnkucHJlcGFyZShRTGF0aW4xU3RyaW5nKCJERUxFVEUgKiBGUk9NIGNvb2tp ZXMiKSk7CiAgICAgc3FsUXVlcnkuZXhlYygpOwpAQCAtMjQ1LDYgKzI1MSwxMCBAQCBib29sIFNo YXJlZENvb2tpZUphclF0OjpzZXRDb29raWVzRnJvbVVybChjb25zdCBRTGlzdDxRTmV0d29ya0Nv b2tpZT4mIGNvb2tpZUxpcwogewogICAgIGlmICghUU5ldHdvcmtDb29raWVKYXI6OnNldENvb2tp ZXNGcm9tVXJsKGNvb2tpZUxpc3QsIHVybCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg IGlmICghbV9kYXRhYmFzZS5pc09wZW4oKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAg UVNxbFF1ZXJ5IHNxbFF1ZXJ5KG1fZGF0YWJhc2UpOwogICAgIHNxbFF1ZXJ5LnByZXBhcmUoUUxh dGluMVN0cmluZygiSU5TRVJUIE9SIFJFUExBQ0UgSU5UTyBjb29raWVzIChjb29raWVJZCwgY29v a2llKSBWQUxVRVMgKDpjb29raWVJZHZhbHVlLCA6Y29va2lldmFsdWUpIikpOwogICAgIFFWYXJp YW50TGlzdCBjb29raWVzSWRzOwpAQCAtMjc0LDYgKzI4NCw5IEBAIHZvaWQgU2hhcmVkQ29va2ll SmFyUXQ6OmVuc3VyZURhdGFiYXNlVGFibGUoKQogCiB2b2lkIFNoYXJlZENvb2tpZUphclF0Ojps b2FkQ29va2llcygpCiB7CisgICAgaWYgKCFtX2RhdGFiYXNlLmlzT3BlbigpKQorICAgICAgICBy ZXR1cm47CisKICAgICBRTGlzdDxRTmV0d29ya0Nvb2tpZT4gY29va2llczsKICAgICBRU3FsUXVl cnkgc3FsUXVlcnkobV9kYXRhYmFzZSk7CiAgICAgc3FsUXVlcnkucHJlcGFyZShRTGF0aW4xU3Ry aW5nKCJTRUxFQ1QgY29va2llIEZST00gY29va2llcyIpKTsK