81463 2012-03-17 19:14:33 -0700 [Chromium] PlatformContextSkia::m_drawingToImageBuffer is not correctly set when using per-tile painting. 2012-03-18 09:51:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reveman reveman cc-bugs danakj enne jamesr reed webkit.review.bot oldest_to_newest 581403 0 reveman 2012-03-17 19:14:33 -0700 PlatformContextSkia::setDrawingToImageBuffer() is not called properly when using per-tile painting. This causes skia to use sub-pixel text rendering when it shouldn't. Issue was previously reported as: http://code.google.com/p/skia/issues/detail?id=477 581404 1 132477 reveman 2012-03-17 19:16:58 -0700 Created attachment 132477 Patch 581407 2 132477 webkit.review.bot 2012-03-17 20:20:35 -0700 Comment on attachment 132477 Patch Clearing flags on attachment: 132477 Committed r111131: <http://trac.webkit.org/changeset/111131> 581408 3 webkit.review.bot 2012-03-17 20:20:39 -0700 All reviewed patches have been landed. Closing bug. 581464 4 danakj 2012-03-18 09:51:06 -0700 @enne this is going to interact with enabling subpixel AA work. 132477 2012-03-17 19:16:58 -0700 2012-03-17 20:20:35 -0700 Patch bug-81463-20120317221657.patch text/plain 2739 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc5MGFhNjM3OGI3ZjE1 NDA0ZTA5ZjQ1Y2RkOTJiMDcyZjgxMjc2OS4uZjQwOTc4NTY3M2FhMjFhNmUwN2QwZTIwOGFjMjIx YjExZThhYzEzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTE3ICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBQ bGF0Zm9ybUNvbnRleHRTa2lhOjptX2RyYXdpbmdUb0ltYWdlQnVmZmVyIGlzIG5vdCBjb3JyZWN0 bHkgc2V0IHdoZW4gdXNpbmcgcGVyLXRpbGUgcGFpbnRpbmcuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTQ2MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgUGxhdGZvcm1Db250ZXh0U2tpYTo6c2V0 RHJhd2luZ1RvSW1hZ2VCdWZmZXIoKSBmcm9tCisgICAgICAgIFNrUGljdHVyZUNhbnZhc0xheWVy VGV4dHVyZVVwZGF0ZXI6OnByZXBhcmVUb1VwZGF0ZSBzbyB0aGF0IHN1Yi1waXhlbAorICAgICAg ICB0ZXh0IHJlbmRlcmluZyBpcyBub3QgdXNlZCBpbmNvcnJlY3RseSB3aXRoIHBlci10aWxlIHBh aW50aW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1NrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6cHJl cGFyZVRvVXBkYXRlKToKKwogMjAxMi0wMy0xNyAgSm9lIFRob21hcyAgPGpvZXRob21hc0Btb3Rv cm9sYS5jb20+CiAKICAgICAgICAgbW92ZSBjYWxjKlZhbHVlIGZ1bmN0aW9ucyBvdXQgZnJvbSBM ZW5ndGggKGFuZCBwbGF0Zm9ybSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL1NrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2tQaWN0dXJlQ2Fu dmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAKaW5kZXggNWFlN2VlNmE5NGFhZmRjMWUzM2YzNDk2 NmJiYmQzZDc1ZGIwYTRiYi4uYjYyNzVlNjQ3NzMyYTk2ODkxMDM2OWU4MzZiMjdmNDhmNTMxYTEw ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v U2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJl VXBkYXRlci5jcHAKQEAgLTQ4LDEyICs0OCwxNyBAQCBTa1BpY3R1cmVDYW52YXNMYXllclRleHR1 cmVVcGRhdGVyOjp+U2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcigpCiB7CiB9CiAK LXZvaWQgU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6cHJlcGFyZVRvVXBkYXRl KGNvbnN0IEludFJlY3QmIGNvbnRlbnRSZWN0LCBjb25zdCBJbnRTaXplJiAvKiB0aWxlU2l6ZSAq LywgaW50IC8qIGJvcmRlclRleGVscyAqLywgZmxvYXQgY29udGVudHNTY2FsZSwgSW50UmVjdCog cmVzdWx0aW5nT3BhcXVlUmVjdCkKK3ZvaWQgU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBk YXRlcjo6cHJlcGFyZVRvVXBkYXRlKGNvbnN0IEludFJlY3QmIGNvbnRlbnRSZWN0LCBjb25zdCBJ bnRTaXplJiAvKiB0aWxlU2l6ZSAqLywgaW50IGJvcmRlclRleGVscywgZmxvYXQgY29udGVudHNT Y2FsZSwgSW50UmVjdCogcmVzdWx0aW5nT3BhcXVlUmVjdCkKIHsKICAgICBTa0NhbnZhcyogY2Fu dmFzID0gbV9waWN0dXJlLmJlZ2luUmVjb3JkaW5nKGNvbnRlbnRSZWN0LndpZHRoKCksIGNvbnRl bnRSZWN0LmhlaWdodCgpKTsKICAgICBQbGF0Zm9ybUNvbnRleHRTa2lhIHBsYXRmb3JtQ29udGV4 dChjYW52YXMpOwogICAgIHBsYXRmb3JtQ29udGV4dC5zZXREZWZlcnJlZCh0cnVlKTsKICAgICBw bGF0Zm9ybUNvbnRleHQuc2V0VHJhY2tPcGFxdWVSZWdpb24oIW1fbGF5ZXJJc09wYXF1ZSk7Cisg ICAgLy8gQXNzdW1wdGlvbjogaWYgYSB0aWxlciBpcyB1c2luZyBib3JkZXIgdGV4ZWxzLCB0aGVu IGl0IGlzIGJlY2F1c2UgdGhlCisgICAgLy8gbGF5ZXIgaXMgbGlrZWx5IHRvIGJlIGZpbHRlcmVk IG9yIHRyYW5zZm9ybWVkLiBCZWNhdXNlIGl0IG1pZ2h0IGJlCisgICAgLy8gdHJhbnNmb3JtZWQs IHNldCBpbWFnZSBidWZmZXIgZmxhZyB0byBkcmF3IHRoZSB0ZXh0IGluIGdyYXlzY2FsZQorICAg IC8vIGluc3RlYWQgb2YgdXNpbmcgc3VicGl4ZWwgYW50aWFsaWFzaW5nLgorICAgIHBsYXRmb3Jt Q29udGV4dC5zZXREcmF3aW5nVG9JbWFnZUJ1ZmZlcihib3JkZXJUZXhlbHMgPyB0cnVlIDogZmFs c2UpOwogICAgIEdyYXBoaWNzQ29udGV4dCBncmFwaGljc0NvbnRleHQoJnBsYXRmb3JtQ29udGV4 dCk7CiAgICAgcGFpbnRDb250ZW50cyhncmFwaGljc0NvbnRleHQsIHBsYXRmb3JtQ29udGV4dCwg Y29udGVudFJlY3QsIGNvbnRlbnRzU2NhbGUpOwogICAgIG1fcGljdHVyZS5lbmRSZWNvcmRpbmco KTsK