81457 2012-03-17 12:55:38 -0700 [chromium] Make pixel-accurate wheel scrolling be unanimated 2012-03-19 16:31:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 81458 1 rjkroege rjkroege danakj davemoore jamesr scottbyer webkit.review.bot oldest_to_newest 581361 0 rjkroege 2012-03-17 12:55:38 -0700 Make pixel-accurate wheel scrolling not be animated in ScrollAnimatorNone 581363 1 132469 rjkroege 2012-03-17 12:58:25 -0700 Created attachment 132469 Patch 581364 2 rjkroege 2012-03-17 12:59:40 -0700 I think we need this if we're keeping ScrollAnimatorNone in the code path for handling animated wheels. jamesr@: care to review? 581367 3 132469 scottbyer 2012-03-17 13:01:35 -0700 Comment on attachment 132469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132469&action=review > Source/WebCore/platform/ScrollAnimatorNone.cpp:421 > + return ScrollAnimator::scroll(orientation, granularity, step, multiplier); I haven't been able to confirm on Windows yet, but on Linux, mouse wheels seem to be coming through here, so we'd lose smooth scrolling in that case. It's still behind a flag there, so for the short term that might be OK, but this might also affect the GTK WebKit builds as well. 581369 4 rjkroege 2012-03-17 13:10:17 -0700 (In reply to comment #3) > (From update of attachment 132469 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132469&action=review > > > Source/WebCore/platform/ScrollAnimatorNone.cpp:421 > > + return ScrollAnimator::scroll(orientation, granularity, step, multiplier); > > I haven't been able to confirm on Windows yet, but on Linux, mouse wheels seem to be coming through here, so we'd lose smooth scrolling in that case. It's still behind a flag there, so for the short term that might be OK, but this might also affect the GTK WebKit builds as well. change could be chromium platform only? trivial to do. smooth-scrolling can be temporarily disabled on Linux chrome. 581370 5 132471 rjkroege 2012-03-17 13:16:13 -0700 Created attachment 132471 Patch 581372 6 132471 scottbyer 2012-03-17 13:22:25 -0700 Comment on attachment 132471 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132471&action=review > Source/WebCore/platform/ScrollAnimatorNone.cpp:421 > +#if PLATFORM(CHROMIUM) Yes, I think this is sufficient until we can get the differentiation between the touch and wheel events down into here. 581381 7 132471 jamesr 2012-03-17 15:17:01 -0700 Comment on attachment 132471 Patch This is the WebMouseWheelEvent::hasPreciseScrollingDeltas bool, right? I think this is fine for now. 581383 8 rjkroege 2012-03-17 16:10:08 -0700 (In reply to comment #7) > (From update of attachment 132471 [details]) > This is the WebMouseWheelEvent::hasPreciseScrollingDeltas bool, right? I think this is fine for now. yes 581385 9 132471 webkit.review.bot 2012-03-17 16:57:41 -0700 Comment on attachment 132471 Patch Clearing flags on attachment: 132471 Committed r111128: <http://trac.webkit.org/changeset/111128> 581386 10 webkit.review.bot 2012-03-17 16:57:46 -0700 All reviewed patches have been landed. Closing bug. 581488 11 danakj 2012-03-18 14:34:27 -0700 Think this broke a unit test. [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from ScrollAnimatorEnabled [ RUN ] ScrollAnimatorEnabled.Enabled ../../third_party/WebKit/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp:128: Failure Expected: (100) != (scrollAnimatorNone.currentX()), actual: 100 vs 100 [ FAILED ] ScrollAnimatorEnabled.Enabled (0 ms) [----------] 1 test from ScrollAnimatorEnabled (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ScrollAnimatorEnabled.Enabled 582425 12 danakj 2012-03-19 16:31:30 -0700 Working now! 132469 2012-03-17 12:58:25 -0700 2012-03-17 13:16:09 -0700 Patch bug-81457-20120317155823.patch text/plain 1674 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU1NDYzM2Y1ODU4NmRl ZDU4ODc3ZDZmNGNhNDIxZmY4ZmYxZTVlMy4uY2EyNDcxNzY4ZGNiOTg5Y2EzYWFiM2ZiYWVhOWJi OGJkNzc1ODZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTE3ICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IE1ha2UgcGl4ZWwtYWNjdXJhdGUgd2hlZWwgc2Nyb2xsaW5nIGJlIHVuYW5pbWF0ZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDU3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3Jv bGxBbmltYXRvck5vbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25l OjpzY3JvbGwpOgorCiAyMDEyLTAzLTE1ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxp dmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gVW5yZXZpZXdlZC4gQnVpbGQgZml4ZXMgZm9yIE1h YyBhbmQgRE9NIGJpbmRpbmdzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsQW5pbWF0b3JOb25lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFu aW1hdG9yTm9uZS5jcHAKaW5kZXggOTY4NDRmN2ViM2M5MjM3MjRjNmRjYTFiOTFkZDM4ZTkyNzk3 OGE5Yy4uMWUzMDM1YmFhMmJjYTExNTk2NmVmNDZlNWQ3ZmMyMjIxODdkMzQyZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCkBAIC00MTgsOCAr NDE4LDcgQEAgYm9vbCBTY3JvbGxBbmltYXRvck5vbmU6OnNjcm9sbChTY3JvbGxiYXJPcmllbnRh dGlvbiBvcmllbnRhdGlvbiwgU2Nyb2xsR3JhbnVsYXIKICAgICAgICAgcGFyYW1ldGVycyA9IFBh cmFtZXRlcnModHJ1ZSwgMTUgKiBrVGlja1RpbWUsIDEwICoga1RpY2tUaW1lLCBDdWJpYywgNSAq IGtUaWNrVGltZSwgQ3ViaWMsIDUgKiBrVGlja1RpbWUsIExpbmVhciwgMSk7CiAgICAgICAgIGJy ZWFrOwogICAgIGNhc2UgU2Nyb2xsQnlQaXhlbDoKLSAgICAgICAgcGFyYW1ldGVycyA9IFBhcmFt ZXRlcnModHJ1ZSwgMTEgKiBrVGlja1RpbWUsIDIgKiBrVGlja1RpbWUsIEN1YmljLCAzICoga1Rp Y2tUaW1lLCBDdWJpYywgMyAqIGtUaWNrVGltZSwgUXVhZHJhdGljLCAxLjI1KTsKLSAgICAgICAg YnJlYWs7CisgICAgICAgIHJldHVybiBTY3JvbGxBbmltYXRvcjo6c2Nyb2xsKG9yaWVudGF0aW9u LCBncmFudWxhcml0eSwgc3RlcCwgbXVsdGlwbGllcik7CiAgICAgY2FzZSBTY3JvbGxCeVBpeGVs VmVsb2NpdHk6CiAgICAgICAgIC8vIEZJWE1FOiBHZW5lcmFsaXplIHRoZSBzY3JvbGwgaW50ZXJm YWNlIHRvIHN1cHBvcnQgYSByaWNoZXIgc2V0IG9mIHBhcmFtZXRlcnMuCiAgICAgICAgIGlmICht X2ZpcnN0VmVsb2NpdHlTZXQpIHsK 132471 2012-03-17 13:16:13 -0700 2012-03-17 16:57:41 -0700 Patch bug-81457-20120317161612.patch text/plain 1773 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU1NDYzM2Y1ODU4NmRl ZDU4ODc3ZDZmNGNhNDIxZmY4ZmYxZTVlMy4uY2EyNDcxNzY4ZGNiOTg5Y2EzYWFiM2ZiYWVhOWJi OGJkNzc1ODZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTE3ICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IE1ha2UgcGl4ZWwtYWNjdXJhdGUgd2hlZWwgc2Nyb2xsaW5nIGJlIHVuYW5pbWF0ZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDU3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3Jv bGxBbmltYXRvck5vbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JOb25l OjpzY3JvbGwpOgorCiAyMDEyLTAzLTE1ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxp dmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gVW5yZXZpZXdlZC4gQnVpbGQgZml4ZXMgZm9yIE1h YyBhbmQgRE9NIGJpbmRpbmdzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsQW5pbWF0b3JOb25lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFu aW1hdG9yTm9uZS5jcHAKaW5kZXggOTY4NDRmN2ViM2M5MjM3MjRjNmRjYTFiOTFkZDM4ZTkyNzk3 OGE5Yy4uOTRkMTkzMGNiYmM2MzVmMjM3ODEyNDc4N2EzOTEwOWI1Nzc5MWVjZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCkBAIC00MTgsOCAr NDE4LDEzIEBAIGJvb2wgU2Nyb2xsQW5pbWF0b3JOb25lOjpzY3JvbGwoU2Nyb2xsYmFyT3JpZW50 YXRpb24gb3JpZW50YXRpb24sIFNjcm9sbEdyYW51bGFyCiAgICAgICAgIHBhcmFtZXRlcnMgPSBQ YXJhbWV0ZXJzKHRydWUsIDE1ICoga1RpY2tUaW1lLCAxMCAqIGtUaWNrVGltZSwgQ3ViaWMsIDUg KiBrVGlja1RpbWUsIEN1YmljLCA1ICoga1RpY2tUaW1lLCBMaW5lYXIsIDEpOwogICAgICAgICBi cmVhazsKICAgICBjYXNlIFNjcm9sbEJ5UGl4ZWw6CisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisg ICAgICAgIC8vIEZJWE1FOiBwbHVtYiBhIGZsYWcgc3BlY2lmeWluZyBwcmVjaXNlIGRlbHRhcy4K KyAgICAgICAgcmV0dXJuIFNjcm9sbEFuaW1hdG9yOjpzY3JvbGwob3JpZW50YXRpb24sIGdyYW51 bGFyaXR5LCBzdGVwLCBtdWx0aXBsaWVyKTsKKyNlbHNlCiAgICAgICAgIHBhcmFtZXRlcnMgPSBQ YXJhbWV0ZXJzKHRydWUsIDExICoga1RpY2tUaW1lLCAyICoga1RpY2tUaW1lLCBDdWJpYywgMyAq IGtUaWNrVGltZSwgQ3ViaWMsIDMgKiBrVGlja1RpbWUsIFF1YWRyYXRpYywgMS4yNSk7CiAgICAg ICAgIGJyZWFrOworI2VuZGlmCiAgICAgY2FzZSBTY3JvbGxCeVBpeGVsVmVsb2NpdHk6CiAgICAg ICAgIC8vIEZJWE1FOiBHZW5lcmFsaXplIHRoZSBzY3JvbGwgaW50ZXJmYWNlIHRvIHN1cHBvcnQg YSByaWNoZXIgc2V0IG9mIHBhcmFtZXRlcnMuCiAgICAgICAgIGlmIChtX2ZpcnN0VmVsb2NpdHlT ZXQpIHsK