81445 2012-03-16 23:19:27 -0700 Simplify SmallStrings 2012-03-23 11:51:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 benjamin benjamin barraclough ggaren oldest_to_newest 581265 0 benjamin 2012-03-16 23:19:27 -0700 You might wonder why SmallStrings has a public clear() and count(), so do I. 581268 1 132449 benjamin 2012-03-16 23:26:13 -0700 Created attachment 132449 Patch 582609 2 benjamin 2012-03-19 19:11:42 -0700 Committed r111306: <http://trac.webkit.org/changeset/111306> 586375 3 132449 darin 2012-03-23 09:04:40 -0700 Comment on attachment 132449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132449&action=review > Source/JavaScriptCore/runtime/SmallStrings.cpp:74 > + m_emptyString = 0; Would be even better to use an initializer for this instead of assignment in the body of the function. 586558 4 benjamin 2012-03-23 11:51:01 -0700 > > Source/JavaScriptCore/runtime/SmallStrings.cpp:74 > > + m_emptyString = 0; > > Would be even better to use an initializer for this instead of assignment in the body of the function. This was the first of a pair of patch. The second actually did that, so no worries :) 132449 2012-03-16 23:26:13 -0700 2012-03-23 09:04:40 -0700 Patch bug-81445-20120316232612.patch text/plain 3055 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OGE5YTNhODMwMDFiODc5Yzc5ODI2OTc1MGMyNDU1NTA3YmJkNjQ2Li43YTk1ODMzZWRhMTc0ZWNi NjAzMTIxZjg3ZGNkNGI4MjNiZjI5MDFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxMi0wMy0xNiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBTaW1wbGlmeSBTbWFsbFN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDQ1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU21hbGxTdHJpbmdzIGhhZCB0d28gbWV0aG9k cyB0aGF0IHNob3VsZCBub3QgYmUgcHVibGljOiBjb3VudCgpIGFuZCBjbGVhcigpLgorCisgICAg ICAgIFRoZSBtZXRob2QgY2xlYXIoKSBpcyBlZmZlY3RpdmVseSByZXBsYWNlZCBieSBmaW5hbGl6 ZVNtYWxsU3RyaW5ncygpLiBUaGUgYm9keQorICAgICAgICBvZiB0aGUgbWV0aG9kIHdhcyBtb3Zl ZCB0byB0aGUgY29uc3RydWN0b3Igc2luY2UgdGhlIGNvZGUgaXMgb2J2aW91cy4KKworICAgICAg ICBUaGUgbWV0aG9kIGNvdW50KCkgaXMgdW51c2VkLgorCisgICAgICAgICogcnVudGltZS9TbWFs bFN0cmluZ3MuY3BwOgorICAgICAgICAoSlNDOjpTbWFsbFN0cmluZ3M6OlNtYWxsU3RyaW5ncyk6 CisgICAgICAgICogcnVudGltZS9TbWFsbFN0cmluZ3MuaDoKKyAgICAgICAgKFNtYWxsU3RyaW5n cyk6CisKIDIwMTItMDMtMTYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAK ICAgICAgICAgSW1wcm92ZSBkaWFnbm9zdGljIGJlbmVmaXQgb2YgSlNHbG9iYWxEYXRhOjptX2lz SW5pdGlhbGl6aW5nT2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TbWFsbFN0cmluZ3MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU21h bGxTdHJpbmdzLmNwcAppbmRleCBjYWYyMDFjM2RiYTU1YTUzZjZjMjYwODA4OTk3MjhhYmY0OWU5 YWIxLi5mZTExM2M1ZjA1ZjFiOTljNWRmOTc0YjE2ODA1YzZmNjkwZWI0YmZkIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmluZ3MuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5jcHAKQEAgLTcwLDcgKzcw LDEwIEBAIFNtYWxsU3RyaW5nc1N0b3JhZ2U6OlNtYWxsU3RyaW5nc1N0b3JhZ2UoKQogU21hbGxT dHJpbmdzOjpTbWFsbFN0cmluZ3MoKQogewogICAgIENPTVBJTEVfQVNTRVJUKHNpbmdsZUNoYXJh Y3RlclN0cmluZ0NvdW50ID09IHNpemVvZihtX3NpbmdsZUNoYXJhY3RlclN0cmluZ3MpIC8gc2l6 ZW9mKG1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5nc1swXSksIElzTnVtQ2hhcmFjdGVyc0NvbnN0SW5T eW5jV2l0aENsYXNzVXNhZ2UpOwotICAgIGNsZWFyKCk7CisKKyAgICBtX2VtcHR5U3RyaW5nID0g MDsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2luZ2xlQ2hhcmFjdGVyU3RyaW5nQ291 bnQ7ICsraSkKKyAgICAgICAgbV9zaW5nbGVDaGFyYWN0ZXJTdHJpbmdzW2ldID0gMDsKIH0KIAog U21hbGxTdHJpbmdzOjp+U21hbGxTdHJpbmdzKCkKQEAgLTg0LDI1ICs4Nyw2IEBAIHZvaWQgU21h bGxTdHJpbmdzOjpmaW5hbGl6ZVNtYWxsU3RyaW5ncygpCiAgICAgICAgIGZpbmFsaXplKG1fc2lu Z2xlQ2hhcmFjdGVyU3RyaW5nc1tpXSk7CiB9CiAKLXZvaWQgU21hbGxTdHJpbmdzOjpjbGVhcigp Ci17Ci0gICAgbV9lbXB0eVN0cmluZyA9IDA7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8 IHNpbmdsZUNoYXJhY3RlclN0cmluZ0NvdW50OyArK2kpCi0gICAgICAgIG1fc2luZ2xlQ2hhcmFj dGVyU3RyaW5nc1tpXSA9IDA7Ci19Ci0KLXVuc2lnbmVkIFNtYWxsU3RyaW5nczo6Y291bnQoKSBj b25zdAotewotICAgIHVuc2lnbmVkIGNvdW50ID0gMDsKLSAgICBpZiAobV9lbXB0eVN0cmluZykK LSAgICAgICAgKytjb3VudDsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2luZ2xlQ2hh cmFjdGVyU3RyaW5nQ291bnQ7ICsraSkgewotICAgICAgICBpZiAobV9zaW5nbGVDaGFyYWN0ZXJT dHJpbmdzW2ldKQotICAgICAgICAgICAgKytjb3VudDsKLSAgICB9Ci0gICAgcmV0dXJuIGNvdW50 OwotfQotCiB2b2lkIFNtYWxsU3RyaW5nczo6Y3JlYXRlRW1wdHlTdHJpbmcoSlNHbG9iYWxEYXRh KiBnbG9iYWxEYXRhKQogewogICAgIEFTU0VSVCghbV9lbXB0eVN0cmluZyk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmluZ3MuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCmluZGV4IGNkOGU2MzA5NTBmNDIw OGExMTFlMzY3ZDU4ZTdjZGIyYzYxN2ZlZGIuLjFjZTcwOTU5ZThmMDI3Y2JmOWQzMGJhNmI4NmQx ZGRlYjJjMjRiNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Nt YWxsU3RyaW5ncy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3Ry aW5ncy5oCkBAIC02Myw5ICs2Myw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBKU19FWFBP UlRfUFJJVkFURSBTdHJpbmdJbXBsKiBzaW5nbGVDaGFyYWN0ZXJTdHJpbmdSZXAodW5zaWduZWQg Y2hhciBjaGFyYWN0ZXIpOwogCiAgICAgICAgIHZvaWQgZmluYWxpemVTbWFsbFN0cmluZ3MoKTsK LSAgICAgICAgdm9pZCBjbGVhcigpOwotCi0gICAgICAgIHVuc2lnbmVkIGNvdW50KCkgY29uc3Q7 CiAKICAgICAgICAgSlNTdHJpbmcqKiBzaW5nbGVDaGFyYWN0ZXJTdHJpbmdzKCkgeyByZXR1cm4g Jm1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5nc1swXTsgfQogCg==