81432 2012-03-16 17:27:48 -0700 Account for sample-rate in convolution normalization 2012-03-16 17:49:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers oldest_to_newest 581130 0 crogers 2012-03-16 17:27:48 -0700 Account for sample-rate in convolution normalization 581133 1 crogers 2012-03-16 17:30:03 -0700 Tested on many impulse-responses at 44.1KHz, 48KHz, and 96KHz to verify that volume differences are now fixed. 581135 2 132424 crogers 2012-03-16 17:31:02 -0700 Created attachment 132424 Patch 581142 3 132424 jamesr 2012-03-16 17:35:02 -0700 Comment on attachment 132424 Patch OK. What's the state of testing for this sort of code? 581143 4 crogers 2012-03-16 17:36:59 -0700 There's a generic convolution test which covers nearly all cases, but we still should write a more specialized test here. 581154 5 crogers 2012-03-16 17:49:42 -0700 Committed r111100: <http://trac.webkit.org/changeset/111100> 132424 2012-03-16 17:31:02 -0700 2012-03-16 17:35:02 -0700 Patch bug-81432-20120316173101.patch text/plain 2790 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYxZDE4NzMyZGI1ZTg0 MWRjMDQ5OWFjZTQ2MzgxMjJmNDFkOWQ1OC4uYTNhNTg5ODAzNjc5NGIwMTYwNmEyNGQ3NzgxMzli Mjk4YzRjMDNmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTE2ICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgQWNjb3VudCBmb3Igc2Ft cGxlLXJhdGUgaW4gY29udm9sdXRpb24gbm9ybWFsaXphdGlvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE0MzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL1JldmVyYi5jcHA6 CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmNhbGN1bGF0ZU5vcm1hbGl6 YXRpb25TY2FsZSk6CisgICAgICAgICogd2ViYXVkaW8vQ29udm9sdmVyTm9kZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDb252b2x2ZXJOb2RlOjpzZXRCdWZmZXIpOgorCiAyMDEyLTAzLTE2ICBM ZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBQcmVwYXJlIFJl bmRlck9iamVjdCBmb3IgRnJhY3Rpb25hbExheW91dFVuaXRzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9SZXZlcmIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vUmV2ZXJiLmNwcAppbmRleCA0NzQ2OGExNzNmMmFkZGMxYjRhNTFiODJjMWQ5YmQ3 YTYwZTk3MDIxLi5jYTczMTdkMWViMWUxNGFlY2MxNmJjYTM3MDU4Yjc1ODBjNjgxODkyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9SZXZlcmIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1JldmVyYi5jcHAKQEAgLTUxLDYgKzUxLDcgQEAg dXNpbmcgbmFtZXNwYWNlIFZlY3Rvck1hdGg7CiAKIC8vIEVtcGlyaWNhbCBnYWluIGNhbGlicmF0 aW9uIHRlc3RlZCBhY3Jvc3MgbWFueSBpbXB1bHNlIHJlc3BvbnNlcyB0byBlbnN1cmUgcGVyY2Vp dmVkIHZvbHVtZSBpcyBzYW1lIGFzIGRyeSAodW5wcm9jZXNzZWQpIHNpZ25hbAogY29uc3QgZmxv YXQgR2FpbkNhbGlicmF0aW9uID0gLTU4OworY29uc3QgZmxvYXQgR2FpbkNhbGlicmF0aW9uU2Ft cGxlUmF0ZSA9IDQ0MTAwOwogCiAvLyBBIG1pbmltdW0gcG93ZXIgdmFsdWUgdG8gd2hlbiBub3Jt YWxpemluZyBhIHNpbGVudCAob3IgdmVyeSBxdWlldCkgaW1wdWxzZSByZXNwb25zZQogY29uc3Qg ZmxvYXQgTWluUG93ZXIgPSAwLjAwMDEyNWY7CkBAIC03OSw2ICs4MCwxMCBAQCBzdGF0aWMgZmxv YXQgY2FsY3VsYXRlTm9ybWFsaXphdGlvblNjYWxlKEF1ZGlvQnVzKiByZXNwb25zZSkKIAogICAg IHNjYWxlICo9IHBvd2YoMTAsIEdhaW5DYWxpYnJhdGlvbiAqIDAuMDVmKTsgLy8gY2FsaWJyYXRl IHRvIG1ha2UgcGVyY2VpdmVkIHZvbHVtZSBzYW1lIGFzIHVucHJvY2Vzc2VkCiAKKyAgICAvLyBT Y2FsZSBkZXBlbmRzIG9uIHNhbXBsZS1yYXRlLgorICAgIGlmIChyZXNwb25zZS0+c2FtcGxlUmF0 ZSgpKQorICAgICAgICBzY2FsZSAqPSBHYWluQ2FsaWJyYXRpb25TYW1wbGVSYXRlIC8gcmVzcG9u c2UtPnNhbXBsZVJhdGUoKTsKKwogICAgIC8vIFRydWUtc3RlcmVvIGNvbXBlbnNhdGlvbgogICAg IGlmIChyZXNwb25zZS0+bnVtYmVyT2ZDaGFubmVscygpID09IDQpCiAgICAgICAgIHNjYWxlICo9 IDAuNWY7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9Db252b2x2ZXJOb2Rl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0NvbnZvbHZlck5vZGUuY3BwCmluZGV4IGFi NzU5M2VhNzJjM2YyOTQyMTM5ZWQ3NTYxOTBkMWQ3NGNkZjkwMjQuLmMyNWNlNDRhZDAyNWZkYTVi YjJhYzVjODljOTJmMjY3YTJiMjUzZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1 ZGlvL0NvbnZvbHZlck5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0NvbnZv bHZlck5vZGUuY3BwCkBAIC0xMzIsNyArMTMyLDkgQEAgdm9pZCBDb252b2x2ZXJOb2RlOjpzZXRC dWZmZXIoQXVkaW9CdWZmZXIqIGJ1ZmZlcikKICAgICBBdWRpb0J1cyBidWZmZXJCdXMobnVtYmVy T2ZDaGFubmVscywgYnVmZmVyTGVuZ3RoLCBmYWxzZSk7CiAgICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IG51bWJlck9mQ2hhbm5lbHM7ICsraSkKICAgICAgICAgYnVmZmVyQnVzLnNldENoYW5u ZWxNZW1vcnkoaSwgYnVmZmVyLT5nZXRDaGFubmVsRGF0YShpKS0+ZGF0YSgpLCBidWZmZXJMZW5n dGgpOwotICAgIAorCisgICAgYnVmZmVyQnVzLnNldFNhbXBsZVJhdGUoYnVmZmVyLT5zYW1wbGVS YXRlKCkpOworCiAgICAgLy8gQ3JlYXRlIHRoZSByZXZlcmIgd2l0aCB0aGUgZ2l2ZW4gaW1wdWxz ZSByZXNwb25zZS4KICAgICBib29sIHVzZUJhY2tncm91bmRUaHJlYWRzID0gIWNvbnRleHQoKS0+ aXNPZmZsaW5lQ29udGV4dCgpOwogICAgIE93blB0cjxSZXZlcmI+IHJldmVyYiA9IGFkb3B0UHRy KG5ldyBSZXZlcmIoJmJ1ZmZlckJ1cywgQXVkaW9Ob2RlOjpQcm9jZXNzaW5nU2l6ZUluRnJhbWVz LCBNYXhGRlRTaXplLCAyLCB1c2VCYWNrZ3JvdW5kVGhyZWFkcywgbV9ub3JtYWxpemUpKTsK