81414 2012-03-16 15:08:44 -0700 Web Inspector: newly added CSS rules shouldn’t rewrite HTML content in the resources panel 2012-05-25 06:50:23 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 me apavlov aneganov apavlov bweinstein caseq joepeck keishi lajlev loislo paulirish pfeldman pmuellr rik timothy yurys oldest_to_newest 581008 0 me 2012-03-16 15:08:44 -0700 http://www.screenr.com/jvN8 Adding CSS rule rewrites HTML content in the resources panel. Wouldn’t it be better put it into the new item under "Stylesheets" category? 582963 1 132804 apavlov 2012-03-20 05:05:02 -0700 Created attachment 132804 Patch 582967 2 132804 vsevik 2012-03-20 05:07:50 -0700 Comment on attachment 132804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132804&action=review > Source/WebCore/ChangeLog:3 > + Web Inspector: newly added CSS rules shouldn’t rewrite HTML content in the resources panel shouldn't 582969 3 apavlov 2012-03-20 05:17:41 -0700 Committed r111384: <http://trac.webkit.org/changeset/111384> 583150 4 me 2012-03-20 09:41:40 -0700 Now newly added CSS rules don’t change HTML content, which is good, but how do I see them in resources panel? I might want to save them. I originally suggested to add 'new item under "Stylesheets" category', but you haven’t implemented it and marked the issue as RESOLVED FIXED without any comments. 583164 5 apavlov 2012-03-20 09:56:34 -0700 The landed patch fixes the erroneous behavior stated in the bug summary. The behavior you suggest is not that easy to implement UI-wise, since a page can contain an arbitrary number of inline stylesheets, all of which should be displayed consistently in the Resources panel. Also, it is not wise to postpone a fix for such a conspicuous bug until a complicated solution is in place. That said, you can track the progress of bug 62294 which attempts to implement what you want to see. 583414 6 me 2012-03-20 13:56:37 -0700 Chrome fires the following code on adding new CSS rules. Does your patch change that? chrome.devtools.inspectedWindow.onResourceContentCommitted.addListener(function(event) { event.type // 'document' event.url // URL of HTML page }); 583470 7 apavlov 2012-03-20 14:38:01 -0700 (In reply to comment #6) > Chrome fires the following code on adding new CSS rules. Does your patch change that? > > chrome.devtools.inspectedWindow.onResourceContentCommitted.addListener(function(event) { > event.type // 'document' > event.url // URL of HTML page > }); This extension event is (indirectly) dispatched from WebInspector.Resource.prototype.addRevision(), which is no longer called when a stylesheet with a URL corresponding to a non-stylesheet resource is changed. Andrey, is the first part of this statement correct? AFAIU, your ExtensionServer subscribes to the WebInspector.ResourceTreeModel.EventTypes.ResourceContentCommitted event dispatched from WebInspector.Resource.prototype.addRevision(). 584845 8 me 2012-03-21 18:06:48 -0700 (In reply to comment #7) > (In reply to comment #6) > > Chrome fires the following code on adding new CSS rules. Does your patch change that? > > > > chrome.devtools.inspectedWindow.onResourceContentCommitted.addListener(function(event) { > > event.type // 'document' > > event.url // URL of HTML page > > }); I just checked, Chrome 19.0.1076.0 canary does not fire it anymore. It makes saving newly added CSS rules impossible, please roll it back! 585090 9 apavlov 2012-03-22 02:54:30 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Chrome fires the following code on adding new CSS rules. Does your patch change that? > > > > > > chrome.devtools.inspectedWindow.onResourceContentCommitted.addListener(function(event) { > > > event.type // 'document' > > > event.url // URL of HTML page > > > }); > > I just checked, Chrome 19.0.1076.0 canary does not fire it anymore. It makes saving newly added CSS rules impossible, please roll it back! So, you are fine with rewriting the main document HTML content the way it was before the fix (the onResourceContentCommitted event you describe means just that)? What do you expect to see in the Resources panel when a new rule is added? 585096 10 me 2012-03-22 03:09:38 -0700 https://groups.google.com/forum/#!topic/google-chrome-developer-tools/-c37nQPrcv4 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #6) > > > > Chrome fires the following code on adding new CSS rules. Does your patch change that? > > > > > > > > chrome.devtools.inspectedWindow.onResourceContentCommitted.addListener(function(event) { > > > > event.type // 'document' > > > > event.url // URL of HTML page > > > > }); > > > > I just checked, Chrome 19.0.1076.0 canary does not fire it anymore. It makes saving newly added CSS rules impossible, please roll it back! > > So, you are fine with rewriting the main document HTML content the way it was before the fix (the onResourceContentCommitted event you describe means just that)? What do you expect to see in the Resources panel when a new rule is added? It allowed me to catch newly added CSS rules, now it doesn’t. It does have issues https://groups.google.com/forum/#!topic/google-chrome-developer-tools/-c37nQPrcv4 but it’s better to keep it as until better substitute is found. 600126 11 lajlev 2012-04-11 01:20:43 -0700 Any idea when it gonna be fixed? 631365 12 aneganov 2012-05-23 01:13:10 -0700 I see it is "FIXED". Well, the fixness means avioding responsibility, I suspect. Do you every consider consequences? This change is a disaster. It is blocking for all web devs moved their development partially or fully from their off-line apps to DevTools. Now watching this demolishing change I feel dismayed, and the only option now is to rollback to 18th. Thank you! 631406 13 pfeldman 2012-05-23 02:09:37 -0700 (In reply to comment #12) > I see it is "FIXED". Well, the fixness means avioding responsibility, I suspect. > Do you every consider consequences? > > This change is a disaster. It is blocking for all web devs moved their development partially or fully from their off-line apps to DevTools. > > Now watching this demolishing change I feel dismayed, and the only option now is to rollback to 18th. > > Thank you! Nikita, do you think you can address it on your end? 631428 14 me 2012-05-23 02:34:52 -0700 (In reply to comment #13) > (In reply to comment #12) > > I see it is "FIXED". Well, the fixness means avioding responsibility, I suspect. > > Do you every consider consequences? > > > > This change is a disaster. It is blocking for all web devs moved their development partially or fully from their off-line apps to DevTools. > > > > Now watching this demolishing change I feel dismayed, and the only option now is to rollback to 18th. > > > > Thank you! > > Nikita, do you think you can address it on your end? No. onResourceContentCommitted doesn’t fire. It used to do. 631434 15 pfeldman 2012-05-23 02:42:51 -0700 (In reply to comment #14) > (In reply to comment #13) > > (In reply to comment #12) > > > I see it is "FIXED". Well, the fixness means avioding responsibility, I suspect. > > > Do you every consider consequences? > > > > > > This change is a disaster. It is blocking for all web devs moved their development partially or fully from their off-line apps to DevTools. > > > > > > Now watching this demolishing change I feel dismayed, and the only option now is to rollback to 18th. > > > > > > Thank you! > > > > Nikita, do you think you can address it on your end? > > No. onResourceContentCommitted doesn’t fire. It used to do. So we are talking about (+) "New Style Rule" action. Users that are adding rules into the existing stylesheets via editing them are not affected? 631486 16 me 2012-05-23 04:14:50 -0700 (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > (In reply to comment #12) > > > > I see it is "FIXED". Well, the fixness means avioding responsibility, I suspect. > > > > Do you every consider consequences? > > > > > > > > This change is a disaster. It is blocking for all web devs moved their development partially or fully from their off-line apps to DevTools. > > > > > > > > Now watching this demolishing change I feel dismayed, and the only option now is to rollback to 18th. > > > > > > > > Thank you! > > > > > > Nikita, do you think you can address it on your end? > > > > No. onResourceContentCommitted doesn’t fire. It used to do. > > So we are talking about (+) "New Style Rule" action. Users that are adding rules into the existing stylesheets via editing them are not affected? Correct. 632895 17 pfeldman 2012-05-24 10:12:33 -0700 I landed http://trac.webkit.org/changeset/118367 that introduces the concept of the virtual resource for the inspector stylesheet. Could you check if your extension can be tweaked to support it? 632896 18 pfeldman 2012-05-24 10:12:54 -0700 (In reply to comment #17) > I landed http://trac.webkit.org/changeset/118367 that introduces the concept of the virtual resource for the inspector stylesheet. Could you check if your extension can be tweaked to support it? (That was for Nikita) 633889 19 me 2012-05-25 06:50:23 -0700 (In reply to comment #17) > I landed http://trac.webkit.org/changeset/118367 that introduces the concept of the virtual resource for the inspector stylesheet. Could you check if your extension can be tweaked to support it? It works again https://github.com/NV/chrome-devtools-autosave/commit/627534b32edc87619e448ab882e877726663f714. Thanks! 132804 2012-03-20 05:05:02 -0700 2012-03-20 05:07:50 -0700 Patch bug-81414-20120320160500.patch text/plain 3356 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDA2YjBiOWZiZTNhZTRl NjQ3MTM5NWY5YTVmMDAwY2U5ZjVhNGZlMS4uZDM3NjM3OGVlOGY0MWVmZmEwMTJiN2JmZDk0YmYx ODhjZjM4OTM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTIwICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogbmV3bHkgYWRkZWQgQ1NTIHJ1bGVzIHNob3VsZG7igJl0IHJld3JpdGUgSFRNTCBjb250 ZW50IGluIHRoZSByZXNvdXJjZXMgcGFuZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgxNDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVNb2RlbFJlc291cmNlQmluZGluZy5wcm90 b3R5cGUuX3N0eWxlU2hlZXRDaGFuZ2VkLnNldENvbnRlbnQpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkNTU1N0eWxlTW9kZWxSZXNvdXJjZUJpbmRpbmcucHJvdG90eXBlLl9zdHlsZVNoZWV0Q2hh bmdlZCk6CisKIDIwMTItMDMtMjAgIEx1a2UgTWFjcGhlcnNvbiAgPG1hY3BoZXJzb25AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBtaW4gYW5kIG1heCBwYXJhbWV0ZXJzIGZyb20gQ1NT UHJpbWl0aXZlVmFsdWUncyByb3VuZEZvckltcHJlY2lzZUNvbnZlcnNpb24gZnVuY3Rpb24uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9k ZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwu anMKaW5kZXggNzJhOWNmZTkzYzQ0ZTJjZDU3ZTI5NmIzYmViZGIxOTc3MjhiOWRmMy4uYjI3N2Ji ZTYxNWUzODI2MDcxNzFhYjhmYjYxNzMwY2UxNTA1MTM0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DU1NTdHlsZU1vZGVsLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVNb2RlbC5qcwpAQCAtODc1LDcgKzg3 NSw3IEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZU1vZGVsUmVzb3VyY2VCaW5kaW5nLnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgICAgIHZhciByZXNvdXJj ZSA9IFdlYkluc3BlY3Rvci5yZXNvdXJjZUZvclVSTCh1cmwpOwotICAgICAgICAgICAgaWYgKCFy ZXNvdXJjZSkKKyAgICAgICAgICAgIGlmICghcmVzb3VyY2UgfHwgcmVzb3VyY2UudHlwZSAhPT0g V2ViSW5zcGVjdG9yLlJlc291cmNlLlR5cGUuU3R5bGVzaGVldCkKICAgICAgICAgICAgICAgICBy ZXR1cm47CiAKICAgICAgICAgICAgIHZhciBtYWpvckNoYW5nZSA9IGV2ZW50LmRhdGEubWFqb3JD aGFuZ2U7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggZGM3OWI1YzkyZjZlYjMxNjZjNDRiYjE5YTc2NjcxZTZiYmQzMjJhMC4u ZDkzNzVlMzIwODc3ZjYzMjYzNDYxOTAxMjVhNDMyNzYwMTU5NDZjOSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDEyLTAzLTIwICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogbmV3bHkgYWRkZWQgQ1NTIHJ1bGVzIHNob3Vs ZG7igJl0IHJld3JpdGUgSFRNTCBjb250ZW50IGluIHRoZSByZXNvdXJjZXMgcGFuZWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDE0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Ivc3R5 bGVzL3N0eWxlcy1hZGQtbmV3LXJ1bGUuaHRtbDoKKwogMjAxMi0wMy0yMCAgS2Vpc2hpIEhhdHRv cmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEZpeGluZyBtaW1l IHR5cGUgZm9yIHRlc3QgZXhwZWN0YXRpb24gcG5nIGZpbGVzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtYWRkLW5ldy1ydWxlLmh0bWwgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy1hZGQtbmV3LXJ1bGUuaHRtbAppbmRleCAxNmIz YTI4MDE1ZThhZmUwMWM5OWM0MDZhMTk4MzkwZjhmMDRiMjY5Li4zNGQ2ZjYwZDcwZTg2Zjc3N2Nl N2ExOTVkY2FkMTg1M2E4ZDAwOGQ0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv c3R5bGVzL3N0eWxlcy1hZGQtbmV3LXJ1bGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0 b3Ivc3R5bGVzL3N0eWxlcy1hZGQtbmV3LXJ1bGUuaHRtbApAQCAtOCw4ICs4LDEwIEBAIGZ1bmN0 aW9uIHRlc3QoKQogewogICAgIFdlYkluc3BlY3Rvci5zaG93UGFuZWwoImVsZW1lbnRzIik7CiAg ICAgSW5zcGVjdG9yVGVzdC5zZWxlY3ROb2RlQW5kV2FpdEZvclN0eWxlcygiaW5zcGVjdGVkIiwg c3RlcDEpOworICAgIEluc3BlY3RvclRlc3QuYWRkU25pZmZlcihXZWJJbnNwZWN0b3IuUmVzb3Vy Y2UucHJvdG90eXBlLCAiYWRkUmV2aXNpb24iLCByZXZpc2lvbkFkZGVkKTsKIAogICAgIHZhciB0 cmVlRWxlbWVudDsKKyAgICB2YXIgaGFzUmVzb3VyY2VDaGFuZ2VkOwogCiAgICAgZnVuY3Rpb24g c3RlcDEoKQogICAgIHsKQEAgLTUwLDggKzUyLDE1IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgIHsK ICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIkFmdGVyIGFkZGluZyBuZXcgcnVsZSAo b3RoZXIpOiIpOwogICAgICAgICBJbnNwZWN0b3JUZXN0LmR1bXBTZWxlY3RlZEVsZW1lbnRTdHls ZXModHJ1ZSwgZmFsc2UsIHRydWUpOworICAgICAgICBpZiAoaGFzUmVzb3VyY2VDaGFuZ2VkKQor ICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIkVycm9yOiBtYWluIHJlc291cmNl IGNvbnRlbnQgY2hhbmdlZCIpOwogICAgICAgICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgp OwogICAgIH0KKworICAgIGZ1bmN0aW9uIHJldmlzaW9uQWRkZWQoKQorICAgIHsKKyAgICAgICAg aGFzUmVzb3VyY2VDaGFuZ2VkID0gdHJ1ZTsKKyAgICB9CiB9CiAKIDwvc2NyaXB0Pgo=