8137 2006-04-02 07:23:20 -0700 REGRESSION: scrolling on Google maps continues after the mouse is released outside the window 2006-12-19 12:44:27 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED http://maps.google.com GoogleBug, HasReduction, InRadar, Regression P1 Normal --- 1 ap ggaren alice.barraclough ap darin ian joost mitz mjs oldest_to_newest 38271 0 ap 2006-04-02 07:23:20 -0700 The same problem as in bug 5923, but apparently with a different cause (as the layout test still passes). Steps to reproduce: 1. Go to http://maps.google.com 2. Click the mouse anywhere on the map, drag until the mouse pointer goes outside the Safari window 3. Release the mouse button 4. Move the mouse pointer back into the window Results: the map scrolls, although the mouse button is not down Expected results (as in Safari 2.0.3): it shouldn't 38279 1 mitz 2006-04-02 10:48:31 -0700 This time around the problem seems to be that the final mouseup event is not delivered, because of the mouseDown check in RenderLayer::shouldApplyImplicitCapture(), which was introduced in r13601. 38302 2 darin 2006-04-02 16:50:07 -0700 Maciej, your change log for r13601 says nothing about what you were trying to accomplish with that check-in, so I am not comfortable making a change. But it does seem clear that a mouse up event wants to participate in the capture even though the mouse is no longer down at the time it's generated. 38303 3 darin 2006-04-02 16:50:44 -0700 We'll need a test case, so attaching the NeedsReduction keyword. 42489 4 alice.barraclough 2006-05-16 09:51:23 -0700 <rdar://problem/4549745> 49456 5 joost 2006-07-12 10:20:36 -0700 Adding GoogleBug keyword in one big change. 43530 6 ap 2006-12-02 12:20:24 -0800 (In reply to comment #1) > This time around the problem seems to be that the final mouseup event is not > delivered, because of the mouseDown check in > RenderLayer::shouldApplyImplicitCapture(), which was introduced in r13601. This method no longer exists due to refactoring, but the problem remains. I couldn't quickly find where this logic was moved. 43499 7 mitz 2006-12-02 14:34:28 -0800 (In reply to comment #6) > (In reply to comment #1) > This method no longer exists due to refactoring, but the problem remains. I > couldn't quickly find where this logic was moved. > Now in RenderLayer::hitTestLayer(), the request.active condition: // We didn't hit any layer. However if the mouse is down, we must always at least be inside // the render view. if (request.active && renderer()->isRenderView()) { renderer()->setInnerNode(result); return this; } 41394 8 ggaren 2006-12-18 09:39:10 -0800 I'm working on this. 41302 9 11906 ggaren 2006-12-18 15:03:47 -0800 Created attachment 11906 reduction 41239 10 11910 ggaren 2006-12-18 15:56:25 -0800 Created attachment 11910 reduction New reduction. Mitz pointed out that the old reduction tested for behavior that, though different in shipping Safari, was incorrect. 41209 11 ggaren 2006-12-19 00:19:10 -0800 Committed revision 18304. 41051 12 mitz 2006-12-19 12:44:27 -0800 (In reply to comment #11) > Committed revision 18304. > The patch caused bug 11880. 11906 2006-12-18 15:03:47 -0800 2006-12-18 15:56:25 -0800 reduction mouseup-outside-target.html text/html 1049 ggaren PHA+VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgYW4gZWxlbWVudCB0aGF0IHJlY2VpdmVzIGEgbW91 c2UgZG93biBldmVudCByZWNlaXZlcwphIGNvcnJlc3BvbmRpbmcgbW91c2UgdXAgZXZlbnQgd2hl biB0aGUgbW91c2UgdXAgaGFwcGVucyBvdXRzaWRlIHRoZSBlbGVtZW50J3MKYm91bmRzLgo8L3A+ CjxwPklmIHRoZSB0ZXN0IHBhc3NlcywgeW91J2xsIHNlZSBhIFBBU1MgbWVzc2FnZSBiZWxvdy4K PC9wPgoKPHA+VG8gcnVuIHRoaXMgdGVzdCBpbiBTYWZhcmk6CjxvbD4KICAgIDxsaT5Nb3VzZSBk b3duIGluc2lkZSB0aGUgYnV0dG9uLjwvbGk+CiAgICA8bGk+TW92ZSB0aGUgbW91c2Ugb3V0c2lk ZSB0aGUgYnV0dG9uLjwvbGk+CiAgICA8bGk+TW91c2UgdXAuPC9saT4KPC9vbD4KPC9wPgo8aW5w dXQgdHlwZT0iYnV0dG9uIiBpZD0iYnV0dG9uIiB2YWx1ZT0iYnV0dG9uISIgb25tb3VzZXVwPSJi dXR0b25fbW91c2VVcCh0aGlzLCBldmVudCkiPjwvaW5wdXQ+Cjxocj4KPHByZSBpZD0ibG9nIj5G QUlMOiBtb3VzZSB1cCBldmVudCBkaWQgbm90IGZpcmU8L3ByZT4KCjxzY3JpcHQ+CmZ1bmN0aW9u IG1haW4oKQp7CiAgICBpZiAoIXdpbmRvdy5ldmVudFNlbmRlcikKICAgICAgICByZXR1cm47CiAg ICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICByZXR1cm47CgogICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgCiAgICBldmVudFNlbmRlci5t b3VzZU1vdmVUbyg0MCwgMjE1KTsgLy8gYnV0dG9uIGNvb3JkaW5hdGVzCiAgICBldmVudFNlbmRl ci5tb3VzZURvd24oKTsKICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDQwLCA0MTUpOyAvLyBi ZWxvdyBidXR0b24gY29vcmRpbmF0ZXMKICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKfQoKZnVu Y3Rpb24gYnV0dG9uX21vdXNlVXAoYnV0dG9uLCBldmVudCkKewogICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2xvZycpLmlubmVySFRNTCA9ICJQQVNTOiBtb3VzZXVwIGV2ZW50IGZpcmVkXG4i Owp9CgptYWluKCk7Cjwvc2NyaXB0Pgo= 11910 2006-12-18 15:56:25 -0800 2006-12-18 15:56:25 -0800 reduction mouseup-outside-document.html text/html 979 ggaren PHA+VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgYSBkb2N1bWVudCB0aGF0IHJlY2VpdmVzIGEgbW91 c2UgZG93biBldmVudCByZWNlaXZlcwphIGNvcnJlc3BvbmRpbmcgbW91c2UgdXAgZXZlbnQgd2hl biB0aGUgbW91c2UgdXAgaGFwcGVucyBvdXRzaWRlIHRoZSB3aW5kb3cuCjwvcD4KPHA+SWYgdGhl IHRlc3QgcGFzc2VzLCB5b3UnbGwgc2VlIGEgUEFTUyBtZXNzYWdlIGJlbG93Lgo8L3A+Cgo8cD5U byBydW4gdGhpcyB0ZXN0IGluIFNhZmFyaToKPG9sPgogICAgPGxpPk1vdXNlIGRvd24gaW5zaWRl IHRoZSBkb2N1bWVudC48L2xpPgogICAgPGxpPk1vdmUgdGhlIG1vdXNlIG91dHNpZGUgdGhlIHdp bmRvdy48L2xpPgogICAgPGxpPk1vdXNlIHVwLjwvbGk+Cjwvb2w+CjwvcD4KPGhyPgo8cHJlIGlk PSJsb2ciPkZBSUw6IG1vdXNlIHVwIGV2ZW50IGRpZCBub3QgZmlyZTwvcHJlPgoKPHNjcmlwdD4K ZnVuY3Rpb24gbWFpbigpCnsKICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNldXAi LCBkb2N1bWVudF9tb3VzZVVwLCBmYWxzZSk7CiAgICAKICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpCiAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwog ICAgCiAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CiAgICAgICAgZXZlbnRTZW5kZXIubW91 c2VNb3ZlVG8oMjAsIDIwKTsgLy8gaW4gd2luZG93CiAgICAgICAgZXZlbnRTZW5kZXIubW91c2VE b3duKCk7CiAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oNDAwMCwgMjE1KTsgLy8gb3V0 c2lkZSB3aW5kb3cKICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CiAgICB9Cn0KCmZ1bmN0 aW9uIGRvY3VtZW50X21vdXNlVXAoKQp7CiAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbG9n JykuaW5uZXJIVE1MID0gIlBBU1M6IG1vdXNldXAgZXZlbnQgZmlyZWRcbiI7Cn0KCm1haW4oKTsK PC9zY3JpcHQ+Cg==