81360 2012-03-16 09:29:11 -0700 [chromium] Improve CSS3 filters performance for blur() and drop-shadow(). 2012-03-16 21:08:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco cc-bugs jamesr webkit.review.bot oldest_to_newest 580577 0 senorblanco 2012-03-16 09:29:11 -0700 [chromium] Improve CSS3 filters performance for blur() and drop-shadow(). 580579 1 132296 senorblanco 2012-03-16 09:30:45 -0700 Created attachment 132296 Patch 580592 2 132300 senorblanco 2012-03-16 09:43:29 -0700 Created attachment 132300 Patch 580594 3 senorblanco 2012-03-16 09:44:12 -0700 (In reply to comment #2) > Created an attachment (id=132300) [details] > Patch With the previous change, drop-shadow() was showing some truncated pixels on the layout tests, so I've reverted that part of the change. 580792 4 132300 jamesr 2012-03-16 12:23:31 -0700 Comment on attachment 132300 Patch Cool 580817 5 senorblanco 2012-03-16 12:45:19 -0700 Committed r111047: <http://trac.webkit.org/changeset/111047> 581240 6 jamesr 2012-03-16 20:39:51 -0700 compositing/shadows/shadow-drawing.html changed behavior on windows with this patch: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=compositing%2Fshadows%2Fshadow-drawing.html I kinda think the new results look better, but could you take a look? 581245 7 senorblanco 2012-03-16 21:08:56 -0700 (In reply to comment #6) > compositing/shadows/shadow-drawing.html changed behavior on windows with this patch: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=compositing%2Fshadows%2Fshadow-drawing.html > > I kinda think the new results look better, but could you take a look? This test has no -webkit-filter, so I think it must be something else. Not sure what's going on, but if you look at the Vista results, they changed at http://trac.webkit.org/log/?verbose=on&rev=111013&stop_rev=111012. 132296 2012-03-16 09:30:45 -0700 2012-03-16 09:43:20 -0700 Patch bug-81360-20120316123044.patch text/plain 2402 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTAxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTE2ICBTdGVwaGVu IFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g SW1wcm92ZSBDU1MzIGZpbHRlcnMgcGVyZm9ybWFuY2Ugb24gYmx1ciBhbmQgZHJvcC1zaGFkb3cu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTM2MAor CisgICAgICAgIFRoaXMgY2hhbmdlIGltcHJvdmVzIGJsdXIgcGVyZm9ybWFuY2UgYnkgMi0yLjVY IG9uIGJsdXJyZWQgQ1NTCisgICAgICAgIDNEIHRyYW5zZm9ybXMgYW5kIGFjY2VsZXJhdGVkIGNh bnZhcyBkZW1vcyBieSBza2lwcGluZyBhbiB1bm5lY2Vzc2FyeQorICAgICAgICB0ZXh0dXJlIGFs bG9jYXRpb24gYW5kIGJpdG1hcCBkcmF3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgbGF5b3V0IHRlc3RzIGluIGNz czMvZmlsdGVycy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND UmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NSZW5kZXJTdXJm YWNlRmlsdGVyczo6YXBwbHkpOgorICAgICAgICBDYWxsIFNrQ2FudmFzOjpkcmF3U3ByaXRlKCkg ZGlyZWN0bHkgaW5zdGVhZCBvZiB1c2luZworICAgICAgICBzYXZlTGF5ZXIoKS9yZXN0b3JlKCku CisKIDIwMTItMDMtMTYgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbRm9ybXNdIFRoZSAicHJvZ3Jlc3MiIGVsZW1lbnQgc2hvdWxkIG5vdCBiZSBhIGZv cm0tYXNzb2NpYXRlZCBlbGVtZW50LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NSZW5kZXJTdXJmYWNlRmlsdGVycy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NSZW5kZXJT dXJmYWNlRmlsdGVycy5jcHAJKHJldmlzaW9uIDExMTAxMykKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yNzQsMTAgKzI3NCw3IEBAIFNrQml0bWFwIENDUmVuZGVyU3VyZmFj ZUZpbHRlcnM6OmFwcGx5KGMKICAgICAgICAgICAgIFNrQXV0b1RVbnJlZjxTa0ltYWdlRmlsdGVy PiBmaWx0ZXIobmV3IFNrQmx1ckltYWdlRmlsdGVyKHN0ZFgsIHN0ZFkpKTsKICAgICAgICAgICAg IFNrUGFpbnQgcGFpbnQ7CiAgICAgICAgICAgICBwYWludC5zZXRJbWFnZUZpbHRlcihmaWx0ZXIu Z2V0KCkpOwotICAgICAgICAgICAgcGFpbnQuc2V0Q29sb3IoMHhGRkZGRkZGRik7Ci0gICAgICAg ICAgICBjYW52YXMuc2F2ZUxheWVyKDAsICZwYWludCk7Ci0gICAgICAgICAgICBjYW52YXMuZHJh d0JpdG1hcChzb3VyY2UsIDAsIDApOwotICAgICAgICAgICAgY2FudmFzLnJlc3RvcmUoKTsKKyAg ICAgICAgICAgIGNhbnZhcy5kcmF3U3ByaXRlKHNvdXJjZSwgMCwgMCwgJnBhaW50KTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgRmlsdGVyT3BlcmF0aW9uOjpE Uk9QX1NIQURPVzogewpAQCAtMjg4LDkgKzI4NSw3IEBAIFNrQml0bWFwIENDUmVuZGVyU3VyZmFj ZUZpbHRlcnM6OmFwcGx5KGMKICAgICAgICAgICAgIHBhaW50LnNldEltYWdlRmlsdGVyKGJsdXJG aWx0ZXIuZ2V0KCkpOwogICAgICAgICAgICAgcGFpbnQuc2V0Q29sb3JGaWx0ZXIoY29sb3JGaWx0 ZXIuZ2V0KCkpOwogICAgICAgICAgICAgcGFpbnQuc2V0WGZlcm1vZGVNb2RlKFNrWGZlcm1vZGU6 OmtTcmNPdmVyX01vZGUpOwotICAgICAgICAgICAgY2FudmFzLnNhdmVMYXllcigwLCAmcGFpbnQp OwotICAgICAgICAgICAgY2FudmFzLmRyYXdCaXRtYXAoc291cmNlLCBvcC0+eCgpLCAtb3AtPnko KSk7Ci0gICAgICAgICAgICBjYW52YXMucmVzdG9yZSgpOworICAgICAgICAgICAgY2FudmFzLmRy YXdTcHJpdGUoc291cmNlLCBvcC0+eCgpLCAtb3AtPnkoKSwgJnBhaW50KTsKICAgICAgICAgICAg IGNhbnZhcy5kcmF3Qml0bWFwKHNvdXJjZSwgMCwgMCk7CiAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgfQo= 132300 2012-03-16 09:43:29 -0700 2012-03-16 12:23:31 -0700 Patch bug-81360-20120316124327.patch text/plain 1875 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTAxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTE2ICBTdGVwaGVu IFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g SW1wcm92ZSBDU1MzIGZpbHRlciBibHVyIHBlcmZvcm1hbmNlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEzNjAKKworICAgICAgICBUaGlzIGNoYW5n ZSBpbXByb3ZlcyBibHVyIHBlcmZvcm1hbmNlIGJ5IDItMi41WCBvbiBibHVycmVkIENTUworICAg ICAgICAzRCB0cmFuc2Zvcm1zIGFuZCBhY2NlbGVyYXRlZCBjYW52YXMgZGVtb3MgYnkgc2tpcHBp bmcgYW4gdW5uZWNlc3NhcnkKKyAgICAgICAgdGV4dHVyZSBhbGxvY2F0aW9uIGFuZCBiaXRtYXAg ZHJhdy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b3ZlcmVkIGJ5IGV4aXN0aW5nIGxheW91dCB0ZXN0cyBpbiBjc3MzL2ZpbHRlcnMuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2VGaWx0ZXJz LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNDUmVuZGVyU3VyZmFjZUZpbHRlcnM6OmFwcGx5KToK KyAgICAgICAgQ2FsbCBTa0NhbnZhczo6ZHJhd1Nwcml0ZSgpIGRpcmVjdGx5IGluc3RlYWQgb2Yg dXNpbmcKKyAgICAgICAgc2F2ZUxheWVyKCkvcmVzdG9yZSgpLgorCiAyMDEyLTAzLTE2ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Zvcm1zXSBUaGUg InByb2dyZXNzIiBlbGVtZW50IHNob3VsZCBub3QgYmUgYSBmb3JtLWFzc29jaWF0ZWQgZWxlbWVu dC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND UmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwCShy ZXZpc2lvbiAxMTEwMTMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9jYy9DQ1JlbmRlclN1cmZhY2VGaWx0ZXJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc0 LDEwICsyNzQsNyBAQCBTa0JpdG1hcCBDQ1JlbmRlclN1cmZhY2VGaWx0ZXJzOjphcHBseShjCiAg ICAgICAgICAgICBTa0F1dG9UVW5yZWY8U2tJbWFnZUZpbHRlcj4gZmlsdGVyKG5ldyBTa0JsdXJJ bWFnZUZpbHRlcihzdGRYLCBzdGRZKSk7CiAgICAgICAgICAgICBTa1BhaW50IHBhaW50OwogICAg ICAgICAgICAgcGFpbnQuc2V0SW1hZ2VGaWx0ZXIoZmlsdGVyLmdldCgpKTsKLSAgICAgICAgICAg IHBhaW50LnNldENvbG9yKDB4RkZGRkZGRkYpOwotICAgICAgICAgICAgY2FudmFzLnNhdmVMYXll cigwLCAmcGFpbnQpOwotICAgICAgICAgICAgY2FudmFzLmRyYXdCaXRtYXAoc291cmNlLCAwLCAw KTsKLSAgICAgICAgICAgIGNhbnZhcy5yZXN0b3JlKCk7CisgICAgICAgICAgICBjYW52YXMuZHJh d1Nwcml0ZShzb3VyY2UsIDAsIDAsICZwYWludCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgfQogICAgICAgICBjYXNlIEZpbHRlck9wZXJhdGlvbjo6RFJPUF9TSEFET1c6IHsK