81357 2012-03-16 09:07:04 -0700 build-webkit launcher instructions use wrong relative path for Qt 2012-03-16 17:13:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 tomz dtharp webkit.review.bot oldest_to_newest 580559 0 tomz 2012-03-16 09:07:04 -0700 build-webkit is printing the launcher-path relative to the current working directory at the end of the script, but is not taking into account that the script will exit to it's original working directory. For --qt builds, this means that the path is relative to the WebKitBuild dir and causes an extra ../ at the beginning. 580982 1 132386 dtharp 2012-03-16 14:50:40 -0700 Created attachment 132386 Patch 581039 2 tomz 2012-03-16 15:31:38 -0700 Looks good to me. Fixes the problem and get's rid of a bogus assumption. 581043 3 132386 eric 2012-03-16 15:32:47 -0700 Comment on attachment 132386 Patch OK. 581116 4 132386 webkit.review.bot 2012-03-16 17:13:22 -0700 Comment on attachment 132386 Patch Clearing flags on attachment: 132386 Committed r111093: <http://trac.webkit.org/changeset/111093> 581117 5 webkit.review.bot 2012-03-16 17:13:26 -0700 All reviewed patches have been landed. Closing bug. 132386 2012-03-16 14:50:40 -0700 2012-03-16 17:13:22 -0700 Patch bug-81357-20120316145004.patch text/plain 1308 dtharp U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMDI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWEyM2JjNGViZTBkZDYxNGFmNzFiOWYzZDFiOWRiYTgz NWU2N2Q4Yi4uM2Y2NTAwZTA5ZmY0YTI5YTg0ODllZmI0NzE3ZTQzNzcyNzI1NjFlNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAzLTE2ICBEYXZlIFRoYXJwICA8ZHRoYXJwQGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIGJ1aWxkLXdlYmtpdCBsYXVuY2hlciBpbnN0cnVjdGlvbnMgdXNlIHdyb25nIHJlbGF0 aXZlIHBhdGggZm9yIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MTM1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEVuc3VyZSB3ZSBhcmUgYXQgdGhlIHByb3BlciBkaXJlY3RvcnkgYmVmb3JlIGdlbmVy YXRpbmcgcnVuLWxhdW5jaGVyCisgICAgICAgIGluc3RydWN0aW9ucy4KKworICAgICAgICAqIFNj cmlwdHMvYnVpbGQtd2Via2l0OgorCiAyMDEyLTAzLTE2ICBEaW51IEphY29iICA8ZGludS5qYWNv YkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XVtXazJdIEFzc2VydGlvbiBGYWlsdXJlIGFuZCBj cmFzaCBvbiBmaWxlIHVwbG9hZApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCBjY2M0MzE1NzVhMGUwMDFjOTU4 NTEzNjlkNzUxN2UyMDExMTIyZmIzLi4wYmRmODc2NmJhNDk4M2ExMmIxYmI3NDg3MTg5YTRmMWEw NDQ0Nzg1IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29s cy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNzQyLDYgKzc0MiwxMCBAQCBleGl0IGlmICRjbGVh bjsKICMgRG9uJ3QgcmVwb3J0IGNvbmdyYXRzIG1lc3NhZ2UgaWYgYnVpbGQgd2FzIGludGVycnVw dGVkIGJ5IHRoZSB1c2VyLgogZXhpdCBpZiAoJHJlc3VsdCAmIDEyNykgPT0gU0lHSU5UOwogCisj IEV4cGxpY2l0bHkgY2hkaXIgYmFjayB0byB3aGVyZSBleGl0IHdpbGwgdGFrZSB1cyBhbnl3YXks IHNpbmNlIHRoZSBmb2xsb3dpbmcgImxhdW5jaGVyIgorIyBtZXNzYWdlIGlzIHJlbGF0aXZlIHRv IHRoYXQgZGlyZWN0b3J5LgorY2hkaXIgJG9yaWdpbmFsV29ya2luZ0RpcmVjdG9yeTsKKwogIyBX cml0ZSBvdXQgY29uZ3JhdHVsYXRpb25zIG1lc3NhZ2UuCiB3cml0ZUNvbmdyYXRzKCk7CiAK