81350 2012-03-16 07:40:40 -0700 SVG setCurrentTime with pauseAnimations bug. 2012-06-26 03:06:54 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr jgw rakssvg webkit.review.bot zimmermann oldest_to_newest 580501 0 pdr 2012-03-16 07:40:40 -0700 Unconfirmed defect report from user: when I call setCurrentTime(0), a call to unpauseAnimations() afterwards introduces a 1s pause. May be related to: https://bugs.webkit.org/show_bug.cgi?id=12073 581071 1 132410 pdr 2012-03-16 16:10:50 -0700 Created attachment 132410 Repro case Attaching a small repro case: it looks like calling setCurrentTime while paused is broken. 640534 2 rakssvg 2012-06-04 06:21:50 -0700 Actually its not 1s. If in the code setCurrentTime() and unPauseAnimation() are called together means they are in consecutive lines of code then the animation starts after a time which is the time difference between the call to pauseAnimation() and unPauseAnimation(). Pretty strange !! 640537 3 rakssvg 2012-06-04 06:25:04 -0700 Hi Joel, Can you take a look at this ? Maybe it is part of BUG 12073 640540 4 pdr 2012-06-04 06:28:27 -0700 (In reply to comment #3) > Hi Joel, Can you take a look at this ? Maybe it is part of BUG 12073 I don't think Joel is able to look at this so it is up for grabs :) Also, a good starter bug for new webkittens. 657270 5 149448 pdr 2012-06-25 21:47:16 -0700 Created attachment 149448 Fix setCurrentTime for paused animations 657445 6 149448 zimmermann 2012-06-26 02:44:42 -0700 Comment on attachment 149448 Fix setCurrentTime for paused animations pdr++, r=me. 657458 7 149448 webkit.review.bot 2012-06-26 03:06:49 -0700 Comment on attachment 149448 Fix setCurrentTime for paused animations Clearing flags on attachment: 149448 Committed r121246: <http://trac.webkit.org/changeset/121246> 657459 8 webkit.review.bot 2012-06-26 03:06:54 -0700 All reviewed patches have been landed. Closing bug. 132410 2012-03-16 16:10:50 -0700 2012-03-16 16:10:50 -0700 Repro case setCurrentTime.html text/html 1450 pdr PD94bWwgdmVyc2lvbj0nMS4wJyBzdGFuZGFsb25lPSdubyc/Pgo8IURPQ1RZUEUgc3ZnIFBVQkxJ QyAnLS8vVzNDLy9EVEQgU1ZHIDIwMDAxMTAyLy9FTicgJ2h0dHA6Ly93d3cudzMub3JnL1RSLzIw MDAvQ1ItU1ZHLTIwMDAxMTAyL0RURC9zdmctMjAwMDExMDIuZHRkJz4KPHN2ZyBpZD0ncm9vdCcg d2lkdGg9JzUwMHB4JyBoZWlnaHQ9JzMwMHB4JyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAw MC9zdmcnIHhtbG5zOnhsaW5rPSdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJz4KICAgPHRp dGxlPnNldEN1cnJlbnRUaW1lIGJ1ZzwvdGl0bGU+CiAgIDxzY3JpcHQ+PCFbQ0RBVEFbCiAgICAg IGZ1bmN0aW9uIHNldFRpbWUodmFsKSB7CiAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdyb290Jykuc2V0Q3VycmVudFRpbWUodmFsKTsKICAgICAgfQoKICAgICAgZnVuY3Rpb24gcGF1 c2UoKSB7CiAgICAgICAgIHZhciByb290ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jvb3Qn KTsKICAgICAgICAgaWYgKHJvb3QuYW5pbWF0aW9uc1BhdXNlZCgpKQogICAgICAgICAgICByb290 LnVucGF1c2VBbmltYXRpb25zKCk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgcm9vdC5wYXVz ZUFuaW1hdGlvbnMoKTsKICAgICAgfQogICBdXT48L3NjcmlwdD4KCiAgIDxlbGxpcHNlIGN4PScw JyBjeT0nNTAnIHJ4PScxMCcgcnk9JzEwJyBmaWxsPScjZjAwJz4KICAgICAgPGFuaW1hdGUgYXR0 cmlidXRlTmFtZT0nY3gnIGJlZ2luPScwcycgZHVyPScxMHMnIGZyb209JzEwMCcgdG89JzMwMCcg ZmlsbD0nZnJlZXplJyByZXBlYXRDb3VudD0naW5kZWZpbml0ZScvPgogICA8L2VsbGlwc2U+Cgog ICA8dGV4dCB4PScxMDAnIHk9JzMwJyBmb250LXNpemU9JzE4cHgnIGZpbGw9J2NyaW1zb24nIHRl eHQtYW5jaG9yPSdtaWRkbGUnIG9uY2xpY2s9J3NldFRpbWUoMCknPjA8L3RleHQ+CiAgIDx0ZXh0 IHg9JzIwMCcgeT0nMzAnIGZvbnQtc2l6ZT0nMThweCcgZmlsbD0nY3JpbXNvbicgdGV4dC1hbmNo b3I9J21pZGRsZScgb25jbGljaz0nc2V0VGltZSg1KSc+NTwvdGV4dD4KICAgPHRleHQgeD0nMzAw JyB5PSczMCcgZm9udC1zaXplPScxOHB4JyBmaWxsPSdjcmltc29uJyB0ZXh0LWFuY2hvcj0nbWlk ZGxlJyBvbmNsaWNrPSdzZXRUaW1lKDkpJz45PC90ZXh0PgogICA8dGV4dCBpZD0ncGF1c2UnIHg9 JzQwMCcgeT0nMzAnIGZvbnQtc2l6ZT0nMThweCcgZmlsbD0nY3JpbXNvbicgdGV4dC1hbmNob3I9 J21pZGRsZScgb25jbGljaz0ncGF1c2UoKSc+UGF1c2UvVW5wYXVzZTwvdGV4dD4KICAgPHRleHQg eD0nMjAwJyB5PScxNTAnIGZvbnQtc2l6ZT0nMThweCcgZmlsbD0nY3JpbXNvbicgdGV4dC1hbmNo b3I9J21pZGRsZSc+UHJlc3MgcGF1c2UsIGNsaWNrIHplcm8sIGNsaWNrIHVucGF1c2UuIE5vdGlj ZSAxcyBkZWxheS48L3RleHQ+Cjwvc3ZnPg== 149448 2012-06-25 21:47:16 -0700 2012-06-26 03:06:49 -0700 Fix setCurrentTime for paused animations 81350.1.patch text/plain 4231 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMTIyNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTI1ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IHNldEN1cnJlbnRUaW1lIGZv ciBwYXVzZWQgYW5pbWF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODEzNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTTUlMVGltZUNvbnRhaW5lcjo6c2V0RWxhcHNlZCB3YXMgbm90IHJlc2V0dGlu ZyB0aGUgcGF1c2UgdGltZSwgYnJlYWtpbmcKKyAgICAgICAgc2V0Q3VycmVudFRpbWUgaWYgdGhl IGFuaW1hdGlvbiB3YXMgcGF1c2VkLgorCisgICAgICAgIFRlc3Q6IHN2Zy9jdXN0b20vYW5pbWF0 ZS1wYXVzZS1yZXN1bWUuaHRtbAorCisgICAgICAgICogc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNv bnRhaW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTTUlMVGltZUNvbnRhaW5lcjo6c2V0RWxh cHNlZCk6CisKIDIwMTItMDYtMjUgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgW2Nocm9taXVtXSBDQ092ZXJkcmF3TWV0cmljcyBzaG91bGQgdXNlIHRoZSBk ZXZpY2VWaWV3cG9ydFNpemUgdG8gY291bnQgYWN0dWFsIHBpeGVscwpJbmRleDogU291cmNlL1dl YkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TTUlMVGltZUNvbnRhaW5lci5jcHAJKHJldmlz aW9uIDEyMTE0MikKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU01JTFRpbWVDb250 YWluZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzEsOCArMTMxLDEyIEBAIHZvaWQgU01JTFRp bWVDb250YWluZXI6OnNldEVsYXBzZWQoU01JTFQKICAgICBpZiAobV9iZWdpblRpbWUpCiAgICAg ICAgIG1fdGltZXIuc3RvcCgpOwogCi0gICAgbV9iZWdpblRpbWUgPSBjdXJyZW50VGltZSgpIC0g dGltZS52YWx1ZSgpOworICAgIGRvdWJsZSBub3cgPSBjdXJyZW50VGltZSgpOworICAgIG1fYmVn aW5UaW1lID0gbm93IC0gdGltZS52YWx1ZSgpOworCiAgICAgbV9hY2N1bXVsYXRlZFBhdXNlVGlt ZSA9IDA7CisgICAgaWYgKG1fcGF1c2VUaW1lKQorICAgICAgICBtX3BhdXNlVGltZSA9IG5vdzsK IAogICAgIFZlY3RvcjxTVkdTTUlMRWxlbWVudCo+IHRvUmVzZXQ7CiAgICAgY29weVRvVmVjdG9y KG1fc2NoZWR1bGVkQW5pbWF0aW9ucywgdG9SZXNldCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjEy MjUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx OCBAQAorMjAxMi0wNi0yNSAgUGhpbGlwIFJvZ2VycyAgPHBkckBnb29nbGUuY29tPgorCisgICAg ICAgIEZpeCBzZXRDdXJyZW50VGltZSBmb3IgcGF1c2VkIGFuaW1hdGlvbnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMzUwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IGRvZXMgbm90IHVz ZSB0aGUgU1ZHIGFuaW1hdGlvbiB0ZXN0IGZyYW1ld29yayBiZWNhdXNlIHRoZSBmcmFtZXdvcmsK KyAgICAgICAgd29ya3MgYnkgcGF1c2luZyBhbmltYXRpb25zIGFuZCB0ZXN0aW5nIGFuaW1hdGVk IHZhbHVlcyBhdCBmaXhlZCB0aW1lcworICAgICAgICAodGhyb3VnaCBjYWxsaW5nIHNldEN1cnJl bnRUaW1lKS4gVGVzdGluZyB0aGlzIHBhdGNoIHJlcXVpcmVzIHRoYXQgd2UgcnVuCisgICAgICAg IHRoZSBhbmltYXRpb24gYW5kIGNhbm5vdCBiZSB0ZXN0ZWQgd2l0aCB0aGUgYW5pbWF0aW9uIHRl c3QgZnJhbWV3b3JrLgorCisgICAgICAgICogc3ZnL2N1c3RvbS9hbmltYXRlLXBhdXNlLXJlc3Vt ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vYW5pbWF0ZS1wYXVz ZS1yZXN1bWUuaHRtbDogQWRkZWQuCisKIDIwMTItMDYtMjUgIEZ1bWl0b3NoaSBVa2FpICA8dWth aUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRlIGNocm9taXVtIHRl c3QgZXhwZWN0YXRpb25zLgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9hbmltYXRlLXBh dXNlLXJlc3VtZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1 c3RvbS9hbmltYXRlLXBhdXNlLXJlc3VtZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9zdmcvY3VzdG9tL2FuaW1hdGUtcGF1c2UtcmVzdW1lLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1 c3RvbS9hbmltYXRlLXBhdXNlLXJlc3VtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3N2Zy9jdXN0b20vYW5pbWF0ZS1wYXVzZS1yZXN1bWUuaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL3N2Zy9jdXN0b20vYW5pbWF0ZS1wYXVzZS1yZXN1bWUuaHRtbAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwzNyBAQAorPCFET0NUWVBFIEhUTUw+Cis8aHRtbD4KKzwhLS0KKyAgICBU ZXN0IGZvciBXSzgxMzUwOiBzZXRDdXJyZW50VGltZSgpIHNob3VsZCB3b3JrIHdoZW4gYW5pbWF0 aW9uIGlzIHBhdXNlZC4KKy0tPgorPGJvZHk+CisgICAgPHN2ZyBpZD0ic3ZnIiB3aWR0aD0iNDAw IiBoZWlnaHQ9IjQwMCI+CisgICAgICAgIDxyZWN0IGlkPSJyZWN0IiB4PSIwIiB5PSIwIiB3aWR0 aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4iPgorICAgICAgICAgICAgPGFuaW1hdGUg YXR0cmlidXRlTmFtZT0ieCIgZnJvbT0iMjAwIiB0bz0iNDAwIiBiZWdpbj0iMHMiIGR1cj0iNHMi IC8+CisgICAgICAgIDwvcmVjdD4KKyAgICA8L3N2Zz4KKyAgICA8c2NyaXB0PgorICAgICAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGls RG9uZSgpOworICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgICAgIH0K KworICAgICAgICB2YXIgc3ZnID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN2ZyIpOworICAg ICAgICB2YXIgcmVjdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZWN0Iik7CisKKyAgICAg ICAgc3ZnLnBhdXNlQW5pbWF0aW9ucygpOworICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkg eworICAgICAgICAgICAgc3ZnLnNldEN1cnJlbnRUaW1lKDQpOworICAgICAgICAgICAgc3ZnLnVu cGF1c2VBbmltYXRpb25zKCk7CisgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewor ICAgICAgICAgICAgICAgIGlmIChyZWN0LnguYW5pbVZhbC52YWx1ZSA9PSAwKQorICAgICAgICAg ICAgICAgICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICJQQVNTIjsKKyAgICAgICAgICAg ICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0g IkZBSUwgOiByZWN0LnguYW5pbVZhbC52YWx1ZSB3YXMgIiArIHJlY3QueC5hbmltVmFsLnZhbHVl ICsgIiBidXQgd2UgZXhwZWN0ZWQgMC4iOworCisgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy50 ZXN0UnVubmVyKQorICAgICAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsK KyAgICAgICAgICAgIH0sIDEpOworICAgICAgICB9LCA1MCk7CisgICAgPC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==