81347 2012-03-16 06:37:29 -0700 Web Inspector: HeapSnapshot: merge two long operations into one. 2012-03-16 06:50:52 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 580460 0 loislo 2012-03-16 06:37:29 -0700 We have two log post processing operations on the heap snapshot. The first one is buildAggregates for Summary view, the second one is the buildRetainers. The users feel bad when they wait for Summary view for 20 sec and after first click wait another 20 sec for the retainers tree. 580461 1 132271 loislo 2012-03-16 06:39:34 -0700 Created attachment 132271 Patch 580474 2 loislo 2012-03-16 06:50:52 -0700 Committed r111003: <http://trac.webkit.org/changeset/111003> 132271 2012-03-16 06:39:34 -0700 2012-03-16 06:42:09 -0700 Patch bug-81347-20120316173932.patch text/plain 2946 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwOTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI2ZjNjZDQ5MmVmNTQ5 ZjQ1ZjhlMDhmY2FhM2M4NDBmM2U4N2Y4OC4uYjU5ZGRlNWJiZDk1ZDUyZDY5MGEwMzY5NzkxMGNi ZjgyNWRlMzdjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE2ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBIZWFwU25hcHNob3Q6IG1lcmdlIHR3byBsb25nIG9wZXJhdGlvbnMgaW50byBvbmUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTM0NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9IZWFwU25hcHNob3QuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNu YXBzaG90LnByb3RvdHlwZS5hZ2dyZWdhdGVzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFw U25hcHNob3QucHJvdG90eXBlLl9idWlsZEFnZ3JlZ2F0ZXMpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUuX2J1aWxkQWdncmVnYXRlcy5mb3JEb21pbmF0ZWRO b2Rlcyk6CisKIDIwMTItMDMtMTYgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTA5NzYuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCmlu ZGV4IDI3ZWU1OTQ5ZjkxMTllYTU4ZDNmMzI1YWIwZWE2MDI0NTFlNGMzYmEuLjRiNGQ2MDIzZDFk Y2NhNjc5MWY4YmMwNzZmOWM0M2Q2YWMzZjJjNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzCkBAIC04OTMsNiArODkzLDkgQEAg V2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUgPSB7CiAKICAgICBhZ2dyZWdhdGVz OiBmdW5jdGlvbihzb3J0ZWRJbmRleGVzLCBrZXksIGZpbHRlclN0cmluZykKICAgICB7CisgICAg ICAgIGlmICghdGhpcy5fcmV0YWluZXJzKQorICAgICAgICAgICAgdGhpcy5fYnVpbGRSZXRhaW5l cnMoKTsKKwogICAgICAgICBpZiAoIXRoaXMuX2FnZ3JlZ2F0ZXMpIHsKICAgICAgICAgICAgIHRo aXMuX2FnZ3JlZ2F0ZXMgPSB7fTsKICAgICAgICAgICAgIHRoaXMuX2FnZ3JlZ2F0ZXNTb3J0ZWRG bGFncyA9IHt9OwpAQCAtMTAyNSw3ICsxMDI4LDcgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hv dC5wcm90b3R5cGUgPSB7CiAKICAgICBfYnVpbGRBZ2dyZWdhdGVzOiBmdW5jdGlvbihmaWx0ZXIp CiAgICAgewotICAgICAgICBmdW5jdGlvbiBzaG91bGRTa2lwKG5vZGUsIGNsYXNzSW5kZXgpCisg ICAgICAgIGZ1bmN0aW9uIHNob3VsZFNraXAobm9kZSkKICAgICAgICAgewogICAgICAgICAgICAg aWYgKGZpbHRlciAmJiAhZmlsdGVyKG5vZGUpKQogICAgICAgICAgICAgICAgIHJldHVybiB0cnVl OwpAQCAtMTAzOSw5ICsxMDQyLDkgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHZhciBub2RlID0gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RO b2RlKHRoaXMsIHRoaXMubm9kZUluZGV4ZXNbMF0pOwogICAgICAgICBmb3IgKHZhciBpID0gMDsg aSA8IHRoaXMubm9kZUNvdW50OyArK2kpIHsKICAgICAgICAgICAgIG5vZGUubm9kZUluZGV4ID0g dGhpcy5ub2RlSW5kZXhlc1tpXTsKLSAgICAgICAgICAgIHZhciBjbGFzc0luZGV4ID0gbm9kZS5j bGFzc0luZGV4OwotICAgICAgICAgICAgaWYgKHNob3VsZFNraXAobm9kZSwgY2xhc3NJbmRleCkp CisgICAgICAgICAgICBpZiAoc2hvdWxkU2tpcChub2RlKSkKICAgICAgICAgICAgICAgICBjb250 aW51ZTsKKyAgICAgICAgICAgIHZhciBjbGFzc0luZGV4ID0gbm9kZS5jbGFzc0luZGV4OwogICAg ICAgICAgICAgaWYgKCEoY2xhc3NJbmRleCBpbiBhZ2dyZWdhdGVzKSkgewogICAgICAgICAgICAg ICAgIHZhciBub2RlVHlwZSA9IG5vZGUudHlwZTsKICAgICAgICAgICAgICAgICB2YXIgbmFtZU1h dHRlcnMgPSBub2RlVHlwZSA9PT0gIm9iamVjdCIgfHwgbm9kZVR5cGUgPT09ICJuYXRpdmUiOwpA QCAtMTA2NSw3ICsxMDY4LDcgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICB2YXIgbm9kZSA9IG5ldyBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90 Tm9kZShzbmFwc2hvdCwgbm9kZUluZGV4KTsKICAgICAgICAgICAgIHZhciBjbGFzc0luZGV4ID0g bm9kZS5jbGFzc0luZGV4OwogICAgICAgICAgICAgdmFyIHNlZW4gPSAhIXNlZW5DbGFzc05hbWVJ bmRleGVzW2NsYXNzSW5kZXhdOwotICAgICAgICAgICAgaWYgKCFzZWVuICYmIGNsYXNzSW5kZXgg aW4gYWdncmVnYXRlcyAmJiAhc2hvdWxkU2tpcChub2RlLCBjbGFzc0luZGV4KSkgeworICAgICAg ICAgICAgaWYgKCFzZWVuICYmIGNsYXNzSW5kZXggaW4gYWdncmVnYXRlcyAmJiAhc2hvdWxkU2tp cChub2RlKSkgewogICAgICAgICAgICAgICAgIGFnZ3JlZ2F0ZXNbY2xhc3NJbmRleF0ubWF4UmV0 ICs9IG5vZGUucmV0YWluZWRTaXplOwogICAgICAgICAgICAgICAgIHNlZW5DbGFzc05hbWVJbmRl eGVzW2NsYXNzSW5kZXhdID0gdHJ1ZTsKICAgICAgICAgICAgIH0K