81334 2012-03-16 05:09:04 -0700 Web Inspector: Implement snippets evaluation. 2012-03-20 10:47:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 75094 0 vsevik webkit-unassigned apavlov bweinstein dglazkov joepeck keishi loislo ossy pfeldman pmuellr podivilov rik szledan timothy webkit.review.bot yurys oldest_to_newest 580392 0 vsevik 2012-03-16 05:09:04 -0700 Implement snippets evaluation. 580395 1 132252 vsevik 2012-03-16 05:12:11 -0700 Created attachment 132252 Patch 580401 2 132252 podivilov 2012-03-16 05:17:15 -0700 Comment on attachment 132252 Patch looks good! 580419 3 132252 pfeldman 2012-03-16 05:37:29 -0700 Comment on attachment 132252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132252&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:665 > + evaluateAndAppendResult: function(text) Should evaluateUsingTextPrompt accept optional parameter that allows not showing the expression in the text prompt? 580424 4 132252 webkit.review.bot 2012-03-16 05:47:38 -0700 Comment on attachment 132252 Patch Attachment 132252 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11960375 New failing tests: inspector/debugger/snippets-model.html 582015 5 vsevik 2012-03-19 12:02:46 -0700 Committed r111212: <http://trac.webkit.org/changeset/111212> 582884 6 szledan 2012-03-20 02:56:18 -0700 The inspector/debugger/snippets-model.html test fails on Qt. --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/snippets-model-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/snippets-model-actual.txt @@ -1,3 +1,4 @@ +FAIL: Timed out waiting for notifyDone to be called Tests snippets model. @@ -37,9 +38,4 @@ Running: testEvaluate Last evaluation source url for snippet: snippets://1_1 -Snippet script added, sourceURL = snippets://1_1 -Last evaluation source url for snippet: snippets://2_2 -Snippet script added, sourceURL = snippets://2_2 -Last evaluation source url for snippet: snippets://1_3 -Snippet script added, sourceURL = snippets://1_3 I will skip this until it is fixed. 582909 7 ossy 2012-03-20 03:44:42 -0700 Reopen to fix it. Skipped on Qt - http://trac.webkit.org/changeset/111378/trunk/LayoutTests/platform/qt/Skipped Please unskip with the proper fix. 583218 8 vsevik 2012-03-20 10:47:10 -0700 (In reply to comment #7) > Reopen to fix it. Skipped on Qt - http://trac.webkit.org/changeset/111378/trunk/LayoutTests/platform/qt/Skipped > > Please unskip with the proper fix. Committed r111409: <http://trac.webkit.org/changeset/111409> 132252 2012-03-16 05:12:11 -0700 2012-03-16 05:47:38 -0700 Patch bug-81334-20120316161209.patch text/plain 6674 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E5ZDI3NTEzNTk5ZDI5 ZGZmMzhjODM5ZTQ5OTU2NGQyNzNiYjhjNS4uNjM4OTAzY2NhMGYwYzA5NzRkYTUxNWE0YzM4Yjkw MjViZmYxNGUwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTE2ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEltcGxlbWVudCBzbmlwcGV0cyBldmFsdWF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEzMzQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlLmV2YWx1 YXRlQW5kQXBwZW5kUmVzdWx0KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Njcmlw dE1hcHBpbmcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTWFpblNjcmlwdE1hcHBpbmcpOgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU25pcHBldHNNb2RlbC5qczoKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qczoKKwogMjAxMi0wMy0xNSAgQW5kcmV5 IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IG5vcm1hbGl6ZSB2ZXJ0aWNhbCBvdmVydmlldyBiYXJzIGJ5IGxvbmdlc3QgYmFyLCBub3QgYnkg bG9uZ2VzdCBmcmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9Db25zb2xlVmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv Q29uc29sZVZpZXcuanMKaW5kZXggYzlkNWRmMGM1Y2Y1MjljMDRkODg3NzRkOTdlYTE4OTFiYzQ0 MzE1NC4uOGRlMDhkMDg0MzExMTQ1MTQ4YWU5MjBiNTBkNDk5MWExNGQxMjhiYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCkBAIC02 NjIsNiArNjYyLDE5IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUgPSB7CiAg ICAgICAgIFdlYkluc3BlY3Rvci51c2VyTWV0cmljcy5Db25zb2xlRXZhbHVhdGVkLnJlY29yZCgp OwogICAgIH0sCiAKKyAgICBldmFsdWF0ZUFuZEFwcGVuZFJlc3VsdDogZnVuY3Rpb24odGV4dCkK KyAgICB7CisgICAgICAgIGZ1bmN0aW9uIHByaW50UmVzdWx0KHJlc3VsdCwgd2FzVGhyb3duKQor ICAgICAgICB7CisgICAgICAgICAgICBpZiAoIXJlc3VsdCkKKyAgICAgICAgICAgICAgICByZXR1 cm47CisKKyAgICAgICAgICAgIHRoaXMuX2FwcGVuZENvbnNvbGVNZXNzYWdlKG5ldyBXZWJJbnNw ZWN0b3IuQ29uc29sZUNvbW1hbmRSZXN1bHQocmVzdWx0LCB3YXNUaHJvd24sIG51bGwsIHRoaXMu X2xpbmtpZmllcikpOworICAgICAgICB9CisKKyAgICAgICAgdGhpcy5ldmFsSW5JbnNwZWN0ZWRX aW5kb3codGV4dCwgImNvbnNvbGUiLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBwcmludFJlc3VsdC5i aW5kKHRoaXMpKTsKKyAgICB9LAorCiAgICAgZWxlbWVudHNUb1Jlc3RvcmVTY3JvbGxQb3NpdGlv bnNGb3I6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHJldHVybiBbdGhpcy5tZXNzYWdlc0Vs ZW1lbnRdOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T Y3JpcHRNYXBwaW5nLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3Jp cHRNYXBwaW5nLmpzCmluZGV4IDJhMWExYmI2YzRlM2MzMTdhOWNiNDA2YzI3OTNjMTExM2YyNjlk Y2IuLmI1MjcwOGI0YTY5MTVjOWQwYTMyOWZmODQzZTk0ZWQxY2U3MjRlNDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0TWFwcGluZy5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdE1hcHBpbmcuanMKQEAg LTc1LDE0ICs3NSw4IEBAIFdlYkluc3BlY3Rvci5NYWluU2NyaXB0TWFwcGluZyA9IGZ1bmN0aW9u KCkKICAgICB0aGlzLl9tYXBwaW5ncy5wdXNoKHRoaXMuX3Jlc291cmNlTWFwcGluZyk7CiAgICAg dGhpcy5fY29tcGlsZXJNYXBwaW5nID0gbmV3IFdlYkluc3BlY3Rvci5Db21waWxlclNjcmlwdE1h cHBpbmcoKTsKICAgICB0aGlzLl9tYXBwaW5ncy5wdXNoKHRoaXMuX2NvbXBpbGVyTWFwcGluZyk7 Ci0KLSAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX21hcHBpbmdzLmxlbmd0aDsgKytpKQot ICAgICAgICB0aGlzLl9tYXBwaW5nc1tpXS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5T Y3JpcHRNYXBwaW5nLkV2ZW50cy5VSVNvdXJjZUNvZGVMaXN0Q2hhbmdlZCwgdGhpcy5faGFuZGxl VUlTb3VyY2VDb2RlTGlzdENoYW5nZWQsIHRoaXMpOwotCi0gICAgaWYgKFdlYkluc3BlY3Rvci5l eHBlcmltZW50c1NldHRpbmdzLnNuaXBwZXRzU3VwcG9ydC5pc0VuYWJsZWQoKSkgewotICAgICAg ICB0aGlzLl9zbmlwcGV0c01hcHBpbmcgPSBuZXcgV2ViSW5zcGVjdG9yLlNuaXBwZXRzU2NyaXB0 TWFwcGluZygpOwotICAgICAgICB0aGlzLl9tYXBwaW5ncy5wdXNoKHRoaXMuX3NuaXBwZXRzTWFw cGluZyk7Ci0gICAgfQorICAgIHRoaXMuX3NuaXBwZXRzTWFwcGluZyA9IG5ldyBXZWJJbnNwZWN0 b3IuU25pcHBldHNTY3JpcHRNYXBwaW5nKCk7CisgICAgdGhpcy5fbWFwcGluZ3MucHVzaCh0aGlz Ll9zbmlwcGV0c01hcHBpbmcpOwogCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLl9tYXBw aW5ncy5sZW5ndGg7ICsraSkKICAgICAgICAgdGhpcy5fbWFwcGluZ3NbaV0uYWRkRXZlbnRMaXN0 ZW5lcihXZWJJbnNwZWN0b3IuU2NyaXB0TWFwcGluZy5FdmVudHMuVUlTb3VyY2VDb2RlTGlzdENo YW5nZWQsIHRoaXMuX2hhbmRsZVVJU291cmNlQ29kZUxpc3RDaGFuZ2VkLCB0aGlzKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU25pcHBldHNNb2RlbC5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU25pcHBldHNNb2RlbC5qcwpp bmRleCA5YzdlNDhkZTk3NTRiNTE1YTQ0ODljZTZmOGEzNWM0OGJlMWU5ZTI4Li40MzU1NmNmZmI4 ZjM0ZmE4ZTYyY2NkN2UxNjI4MmFjMmI5ZTAzOTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NuaXBwZXRzTW9kZWwuanMKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TbmlwcGV0c01vZGVsLmpzCkBAIC0xMjksNyArMTI5LDcg QEAgV2ViSW5zcGVjdG9yLlNuaXBwZXRzTW9kZWwucHJvdG90eXBlID0gewogICAgICAgICB2YXIg c291cmNlVVJMID0gdGhpcy5fc291cmNlVVJMRm9yU25pcHBldChzbmlwcGV0LCBldmFsdWF0aW9u SW5kZXgpOwogICAgICAgICBzbmlwcGV0Ll9sYXN0RXZhbHVhdGlvblNvdXJjZVVSTCA9IHNvdXJj ZVVSTDsKICAgICAgICAgdmFyIGV4cHJlc3Npb24gPSAiXG4vL0Agc291cmNlVVJMPSIgKyBzb3Vy Y2VVUkwgKyAiXG4iICsgc25pcHBldC5jb250ZW50OwotICAgICAgICAvLyBGSVhNRTogZXZhbHVh dGUgc25pcHBldCBoZXJlLgorICAgICAgICBXZWJJbnNwZWN0b3IuY29uc29sZVZpZXcuZXZhbHVh dGVBbmRBcHBlbmRSZXN1bHQoZXhwcmVzc2lvbik7CiAgICAgfSwKIAogICAgIC8qKgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCAzOTNk YWIxNTgwZGUzNThiMjI3MjNiODBjY2Q0YTUyY2ZlYTkxMTkxLi4yYzc1MTgwNmExNzk2ZmQ3Zjll ZWEwY2VmYzU1NjMyMWMwZmNjMTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtNDA2LDggKzQwNiw3IEBAIFdlYkluc3BlY3Rvci5f ZG9Mb2FkZWREb25lV2l0aENhcGFiaWxpdGllcyA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLmNvbnNv bGUuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuQ29uc29sZU1vZGVsLkV2ZW50cy5SZXBl YXRDb3VudFVwZGF0ZWQsIHRoaXMuX3VwZGF0ZUVycm9yQW5kV2FybmluZ0NvdW50cywgdGhpcyk7 CiAKICAgICB0aGlzLmRlYnVnZ2VyTW9kZWwgPSBuZXcgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTW9k ZWwoKTsKLSAgICBpZiAoV2ViSW5zcGVjdG9yLmV4cGVyaW1lbnRzU2V0dGluZ3Muc25pcHBldHNT dXBwb3J0LmlzRW5hYmxlZCgpKQotICAgICAgICB0aGlzLnNuaXBwZXRzTW9kZWwgPSBuZXcgV2Vi SW5zcGVjdG9yLlNuaXBwZXRzTW9kZWwoKTsKKyAgICB0aGlzLnNuaXBwZXRzTW9kZWwgPSBuZXcg V2ViSW5zcGVjdG9yLlNuaXBwZXRzTW9kZWwoKTsKICAgICB0aGlzLmRlYnVnZ2VyUHJlc2VudGF0 aW9uTW9kZWwgPSBuZXcgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwoKTsK IAogICAgIHRoaXMuZHJhd2VyID0gbmV3IFdlYkluc3BlY3Rvci5EcmF3ZXIoKTsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4 MDFkZjk0N2EzZTYzMjYwMzM1MmEwZDUzMTM1MTgyYTc1Njc4N2Y4Li5lYmQ4YzIyMTEzN2VmZmQ0 NzYzNzQzMGFjOGY2MGMwNWU2M2UxYTU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDMt MTYgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2Vi IEluc3BlY3RvcjogSW1wbGVtZW50IHNuaXBwZXRzIGV2YWx1YXRpb24uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTMzNAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL3Nu aXBwZXRzLW1vZGVsLmh0bWw6CisKIDIwMTItMDMtMTUgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29v Z2xlLmNvbT4KIAogICAgICAgICBUZW1wb3JhcmlseSBza2lwIHN2Zy9jdXN0b20vZGVsZXRlLXRl eHQtY3Jhc2guaHRtbCBvbiBtYWMgYW5kIHdpbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2RlYnVnZ2VyL3NuaXBwZXRzLW1vZGVsLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvZGVidWdnZXIvc25pcHBldHMtbW9kZWwuaHRtbAppbmRleCBkYWE2MGMyYzA0YzIyNmQzODZl OGUwNGYxYzRhNjgzMjU2NGNiMWRiLi45MmZjNDA2ZDYyZWViYzFhYmZkYWMwNmEwMzU3YTBiYTg2 MWQyMmQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvc25pcHBl dHMtbW9kZWwuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvc25pcHBl dHMtbW9kZWwuaHRtbApAQCAtMTIsOCArMTIsOCBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICB9CiAK ICAgICAvLyBGSVhNRTogUmVtb3ZlIG9uY2Ugc25pcHBldHMgYXJlIHRha2VuIG91dCBvZiBleHBl cmltZW50cy4KLSAgICBpZiAoIVdlYkluc3BlY3Rvci5leHBlcmltZW50c1NldHRpbmdzLnNuaXBw ZXRzU3VwcG9ydC5pc0VuYWJsZWQoKSkKLSAgICAgICAgV2ViSW5zcGVjdG9yLnNuaXBwZXRzTW9k ZWwgPSBuZXcgV2ViSW5zcGVjdG9yLlNuaXBwZXRzTW9kZWwoKTsKKyAgICBXZWJJbnNwZWN0b3Iu ZXhwZXJpbWVudHNTZXR0aW5ncy5zbmlwcGV0c1N1cHBvcnQgPSB7fTsKKyAgICBXZWJJbnNwZWN0 b3IuZXhwZXJpbWVudHNTZXR0aW5ncy5zbmlwcGV0c1N1cHBvcnQuaXNFbmFibGVkID0gZnVuY3Rp b24oKSB7IHJldHVybiB0cnVlOyB9OwogCiAgICAgSW5zcGVjdG9yVGVzdC5ydW5UZXN0U3VpdGUo WwogICAgICAgICBmdW5jdGlvbiB0ZXN0Q3JlYXRlUmVuYW1lRWRpdERlbGV0ZShuZXh0KQpAQCAt MTAzLDkgKzEwMyw2IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmFkZFJlc3VsdCgiU25pcHBldCBzY3JpcHQgYWRkZWQsIHNvdXJjZVVSTCA9ICIg KyBzY3JpcHQuc291cmNlVVJMKTsKICAgICAgICAgICAgICAgICAgICAgY2FsbGJhY2soKTsKICAg ICAgICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQg YmUgcmVtb3ZlZCBvbmNlIHNuaXBwZXRzIGV2YWx1YXRpb24gaXRzZWxmIGlzIGltcGxlbWVudGVk LgotICAgICAgICAgICAgICAgIGNhbGxiYWNrKCk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAg ICAgIGV2YWx1YXRlU25pcHBldEFuZER1bXBFdmFsdWF0aW9uRGV0YWlscyhzbmlwcGV0MSwgc3Rl cDIpOwo=