81324 2012-03-16 02:43:40 -0700 Rename getElementInShadowTreeStack to getNodeInShadowTreeStack 2012-03-21 00:06:25 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P4 Enhancement --- 0 kaustubh.ra webkit-unassigned hayato kaustubh.ra morrita webkit.review.bot oldest_to_newest 580311 0 kaustubh.ra 2012-03-16 02:43:40 -0700 With reference to the comments from Hayato in bug https://bugs.webkit.org/show_bug.cgi?id=81102, "We should rename getElementInShadowTreeStack since it can return ShadowRoot, which is not Element. That is an unintentional usage that it can return ShadowRoot. So we should rename it to getNodeInShadowTreeStack." 582911 1 132790 kaustubh.ra 2012-03-20 03:47:17 -0700 Created attachment 132790 Patch 583671 2 hayato 2012-03-20 18:06:43 -0700 Okay. You need r+ from reviewers. (In reply to comment #1) > Created an attachment (id=132790) [details] > Patch 583862 3 132790 webkit.review.bot 2012-03-21 00:06:21 -0700 Comment on attachment 132790 Patch Clearing flags on attachment: 132790 Committed r111505: <http://trac.webkit.org/changeset/111505> 583863 4 webkit.review.bot 2012-03-21 00:06:25 -0700 All reviewed patches have been landed. Closing bug. 132790 2012-03-20 03:47:17 -0700 2012-03-21 00:06:21 -0700 Patch 81324.patch text/plain 7195 kaustubh.ra SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExMTM3OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAzLTIwICBLYXVzdHViaCBBdHJhd2Fs a2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgorCisgICAgICAgIFJlbmFtZSBnZXRFbGVtZW50 SW5TaGFkb3dUcmVlU3RhY2sgdG8gZ2V0Tm9kZUluU2hhZG93VHJlZVN0YWNrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTMyNAorCisgICAgICAgIFNp bmNlIGdldEVsZW1lbnRJblNoYWRvd1RyZWVTdGFjayByZXR1cm5zIFNoYWRvd1Jvb3QgYXMgd2Vs bCB3aGljaCBpcyBub3QgYW4gZWxlbWVudAorICAgICAgICBpdCBzaG91bGQgYmUgcmVuYW1lZCB0 byBnZXROb2RlSW5TaGFkb3dUcmVlU3RhY2suCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvYWNjZXNzLWtleS5odG1sOgor ICAgICAgICAqIGZhc3QvZG9tL3NoYWRvdy9nZXQtZWxlbWVudC1ieS1pZC1pbi1zaGFkb3ctcm9v dC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vc2hhZG93L2dldC1lbGVtZW50LWJ5 LWlkLWluLXNoYWRvdy1yb290Lmh0bWw6CisgICAgICAgICogZmFzdC9kb20vc2hhZG93L3Jlc291 cmNlcy9zaGFkb3ctZG9tLmpzOgorICAgICAgICAoZ2V0Tm9kZUluU2hhZG93VHJlZVN0YWNrKToK KyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvc2hhZG93LWJvdW5kYXJ5LWV2ZW50cy5odG1sOgor CiAyMDEyLTAzLTIwICBTemlsYXJkIExlZGFuICA8c3psZWRhbkBpbmYudS1zemVnZWQuaHU+CiAK ICAgICAgICAgW1F0XSBHYXJkZW5pbmcsIHNraXAgZmFpbGluZyB0ZXN0cywgYWRkIHBsYXRmb3Jt IHNwZWNpZmljIGV4cGVjdGVkIGZpbGVzLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hh ZG93L2FjY2Vzcy1rZXkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9z aGFkb3cvYWNjZXNzLWtleS5odG1sCShyZXZpc2lvbiAxMTEzNzgpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvYWNjZXNzLWtleS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC02MSw3ICs2 MSw3IEBAIGZ1bmN0aW9uIHByZXBhcmVET01UcmVlKHBhcmVudCkKICAgICAgICAgICAgICAgICdz aGFkb3dDL2lucHV0RCcsICdzaGFkb3dDL2lucHV0RScsCiAgICAgICAgICAgICAgICAnc2hhZG93 Qy9zaGFkb3dGL2lucHV0RyddOwogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgaWRzLmxlbmd0aDsg KytpKSB7Ci0gICAgICAgIHZhciBlbGVtZW50ID0gZ2V0RWxlbWVudEluU2hhZG93VHJlZVN0YWNr KGlkc1tpXSk7CisgICAgICAgIHZhciBlbGVtZW50ID0gZ2V0Tm9kZUluU2hhZG93VHJlZVN0YWNr KGlkc1tpXSk7CiAgICAgICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcignZm9jdXMnLCByZWNv cmRFdmVudCwgZmFsc2UpOwogICAgIH0KIH0KQEAgLTgyLDEyICs4MiwxMiBAQCBmdW5jdGlvbiB0 ZXN0KCkKICAgICBwcmVzc0FjY2Vzc0tleSgnYScpOwogICAgIHNob3VsZEJlKCdkaXNwYXRjaGVk RXZlbnQoImZvY3VzIiknLCAnWyJpbnB1dEUiXScpOwogCi0gICAgZ2V0RWxlbWVudEluU2hhZG93 VHJlZVN0YWNrKCdzaGFkb3dDL2lucHV0RCcpLmZvY3VzKCk7CisgICAgZ2V0Tm9kZUluU2hhZG93 VHJlZVN0YWNrKCdzaGFkb3dDL2lucHV0RCcpLmZvY3VzKCk7CiAgICAgY2xlYXJFdmVudFJlY29y ZHMoKTsKICAgICBwcmVzc0FjY2Vzc0tleSgnYScpOwogICAgIHNob3VsZEJlKCdkaXNwYXRjaGVk RXZlbnQoImZvY3VzIiknLCAnWyJpbnB1dEUiXScpOwogCi0gICAgZ2V0RWxlbWVudEluU2hhZG93 VHJlZVN0YWNrKCdzaGFkb3dDL3NoYWRvd0YvaW5wdXRHJykuZm9jdXMoKTsKKyAgICBnZXROb2Rl SW5TaGFkb3dUcmVlU3RhY2soJ3NoYWRvd0Mvc2hhZG93Ri9pbnB1dEcnKS5mb2N1cygpOwogICAg IGNsZWFyRXZlbnRSZWNvcmRzKCk7CiAgICAgcHJlc3NBY2Nlc3NLZXkoJ2EnKTsKICAgICBzaG91 bGRCZSgnZGlzcGF0Y2hlZEV2ZW50KCJmb2N1cyIpJywgJ1siaW5wdXRFIl0nKTsKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9nZXQtZWxlbWVudC1ieS1pZC1pbi1zaGFkb3ctcm9v dC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93 L2dldC1lbGVtZW50LWJ5LWlkLWluLXNoYWRvdy1yb290LWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MTExMzc4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2dldC1lbGVtZW50LWJ5LWlk LWluLXNoYWRvdy1yb290LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMywxMSArMywx MSBAQCBUZXN0cyB0byBlbnN1cmUgdGhhdCBpbnRlcm5hbHMuZ2V0RWxlbWVuCiBPbiBzdWNjZXNz LCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAi VEVTVCBDT01QTEVURSIuCiAKIAotUEFTUyBnZXRFbGVtZW50SW5TaGFkb3dUcmVlU3RhY2soJ2Rp dkEvaW5wdXRCJykuaWQgaXMgImlucHV0QiIKLVBBU1MgZ2V0RWxlbWVudEluU2hhZG93VHJlZVN0 YWNrKCdkaXZBL2RpdkMnKS5pZCBpcyAiZGl2QyIKLVBBU1MgZ2V0RWxlbWVudEluU2hhZG93VHJl ZVN0YWNrKCdkaXZBL2RpdkMvaW5wdXREJykuaWQgaXMgImlucHV0RCIKLVBBU1MgZ2V0RWxlbWVu dEluU2hhZG93VHJlZVN0YWNrKCdkaXZBL2RpdkMvL2lucHV0RScpLmlkIGlzICJpbnB1dEUiCi1Q QVNTIGdldEVsZW1lbnRJblNoYWRvd1RyZWVTdGFjaygnZGl2QS9kaXZDLy8vaW5wdXRGJykuaWQg aXMgImlucHV0RiIKK1BBU1MgZ2V0Tm9kZUluU2hhZG93VHJlZVN0YWNrKCdkaXZBL2lucHV0Qicp LmlkIGlzICJpbnB1dEIiCitQQVNTIGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnZGl2QS9kaXZD JykuaWQgaXMgImRpdkMiCitQQVNTIGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnZGl2QS9kaXZD L2lucHV0RCcpLmlkIGlzICJpbnB1dEQiCitQQVNTIGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygn ZGl2QS9kaXZDLy9pbnB1dEUnKS5pZCBpcyAiaW5wdXRFIgorUEFTUyBnZXROb2RlSW5TaGFkb3dU cmVlU3RhY2soJ2RpdkEvZGl2Qy8vL2lucHV0RicpLmlkIGlzICJpbnB1dEYiCiBQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL3NoYWRvdy9nZXQtZWxlbWVudC1ieS1pZC1pbi1zaGFkb3ctcm9vdC5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9nZXQtZWxlbWVudC1ieS1p ZC1pbi1zaGFkb3ctcm9vdC5odG1sCShyZXZpc2lvbiAxMTEzNzgpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvZ2V0LWVsZW1lbnQtYnktaWQtaW4tc2hhZG93LXJvb3QuaHRtbAkod29y a2luZyBjb3B5KQpAQCAtMjksMTEgKzI5LDExIEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAKICAgICBwcmVwYXJlRG9tVHJlZShk b2N1bWVudC5ib2R5KTsKLSAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImdldEVsZW1lbnRJblNo YWRvd1RyZWVTdGFjaygnZGl2QS9pbnB1dEInKS5pZCIsICdpbnB1dEInKTsKLSAgICBzaG91bGRC ZUVxdWFsVG9TdHJpbmcoImdldEVsZW1lbnRJblNoYWRvd1RyZWVTdGFjaygnZGl2QS9kaXZDJyku aWQiLCAnZGl2QycpOwotICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZ2V0RWxlbWVudEluU2hh ZG93VHJlZVN0YWNrKCdkaXZBL2RpdkMvaW5wdXREJykuaWQiLCAnaW5wdXREJyk7Ci0gICAgc2hv dWxkQmVFcXVhbFRvU3RyaW5nKCJnZXRFbGVtZW50SW5TaGFkb3dUcmVlU3RhY2soJ2RpdkEvZGl2 Qy8vaW5wdXRFJykuaWQiLCAnaW5wdXRFJyk7Ci0gICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJn ZXRFbGVtZW50SW5TaGFkb3dUcmVlU3RhY2soJ2RpdkEvZGl2Qy8vL2lucHV0RicpLmlkIiwgJ2lu cHV0RicpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZ2V0Tm9kZUluU2hhZG93VHJlZVN0 YWNrKCdkaXZBL2lucHV0QicpLmlkIiwgJ2lucHV0QicpOworICAgIHNob3VsZEJlRXF1YWxUb1N0 cmluZygiZ2V0Tm9kZUluU2hhZG93VHJlZVN0YWNrKCdkaXZBL2RpdkMnKS5pZCIsICdkaXZDJyk7 CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJnZXROb2RlSW5TaGFkb3dUcmVlU3RhY2soJ2Rp dkEvZGl2Qy9pbnB1dEQnKS5pZCIsICdpbnB1dEQnKTsKKyAgICBzaG91bGRCZUVxdWFsVG9TdHJp bmcoImdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnZGl2QS9kaXZDLy9pbnB1dEUnKS5pZCIsICdp bnB1dEUnKTsKKyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImdldE5vZGVJblNoYWRvd1RyZWVT dGFjaygnZGl2QS9kaXZDLy8vaW5wdXRGJykuaWQiLCAnaW5wdXRGJyk7CiB9CiAKIHRlc3QoKTsK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctYm91bmRhcnktZXZlbnRz Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1i b3VuZGFyeS1ldmVudHMuaHRtbAkocmV2aXNpb24gMTExMzc4KQorKysgTGF5b3V0VGVzdHMvZmFz dC9kb20vc2hhZG93L3NoYWRvdy1ib3VuZGFyeS1ldmVudHMuaHRtbAkod29ya2luZyBjb3B5KQpA QCAtODksNyArODksNyBAQCBmdW5jdGlvbiBwcmVwYXJlRE9NVHJlZShwYXJlbnQpCiAgICAgICAg ICAgICAgICAnc2hhZG93RC9zaGFkb3dGL3NoYWRvd0cvZGl2SCcsICdzaGFkb3dEL3NoYWRvd0Yv c2hhZG93Ry9kaXZJJywKICAgICAgICAgICAgICAgICdzaGFkb3dEL2RpdkonLCAnc2hhZG93RC9z aGFkb3dLJywgJ3NoYWRvd0Qvc2hhZG93Sy9kaXZMJ107CiAgICAgZm9yICh2YXIgaSA9IDA7IGkg PCBpZHMubGVuZ3RoOyArK2kpIHsKLSAgICAgICAgdmFyIGVsZW1lbnQgPSBnZXRFbGVtZW50SW5T aGFkb3dUcmVlU3RhY2soaWRzW2ldKTsKKyAgICAgICAgdmFyIGVsZW1lbnQgPSBnZXROb2RlSW5T aGFkb3dUcmVlU3RhY2soaWRzW2ldKTsKICAgICAgICAgZWxlbWVudC5hZGRFdmVudExpc3RlbmVy KCdtb3VzZW92ZXInLCByZWNvcmRFdmVudCwgZmFsc2UpOwogICAgICAgICBlbGVtZW50LmFkZEV2 ZW50TGlzdGVuZXIoJ21vdXNlb3V0JywgcmVjb3JkRXZlbnQsIGZhbHNlKTsKICAgICAgICAgZWxl bWVudC5hZGRFdmVudExpc3RlbmVyKCdmb2N1c2luJywgcmVjb3JkRXZlbnQsIGZhbHNlKTsKQEAg LTEwMiwxNyArMTAyLDE3IEBAIGZ1bmN0aW9uIHByZXBhcmVET01UcmVlKHBhcmVudCkKIGZ1bmN0 aW9uIG1vdmVNb3VzZShvbGRFbGVtZW50SWQsIG5ld0VsZW1lbnRJZCwgbWVzc2FnZSkKIHsKICAg ICBkZWJ1ZygnXG4nICsgbWVzc2FnZSArICdcbicgKyAnTW92aW5nIG1vdXNlIGZyb20gJyArIG9s ZEVsZW1lbnRJZCArICcgdG8gJyArIG5ld0VsZW1lbnRJZCk7Ci0gICAgbW92ZU1vdXNlT3Zlcihn ZXRFbGVtZW50SW5TaGFkb3dUcmVlU3RhY2sob2xkRWxlbWVudElkKSk7CisgICAgbW92ZU1vdXNl T3ZlcihnZXROb2RlSW5TaGFkb3dUcmVlU3RhY2sob2xkRWxlbWVudElkKSk7CiAgICAgY2xlYXJF dmVudFJlY29yZHMoKTsKLSAgICBtb3ZlTW91c2VPdmVyKGdldEVsZW1lbnRJblNoYWRvd1RyZWVT dGFjayhuZXdFbGVtZW50SWQpKTsKKyAgICBtb3ZlTW91c2VPdmVyKGdldE5vZGVJblNoYWRvd1Ry ZWVTdGFjayhuZXdFbGVtZW50SWQpKTsKIH0KIAogZnVuY3Rpb24gbW92ZUZvY3VzKG9sZEVsZW1l bnRJZCwgbmV3RWxlbWVudElkLCBtZXNzYWdlKQogewogICAgIGRlYnVnKCdcbicgKyBtZXNzYWdl ICsgJ1xuJyArICdNb3ZpbmcgZm9jdXMgZnJvbSAnICsgb2xkRWxlbWVudElkICsgJyB0byAnICsg bmV3RWxlbWVudElkKTsKLSAgICBnZXRFbGVtZW50SW5TaGFkb3dUcmVlU3RhY2sob2xkRWxlbWVu dElkKS5mb2N1cygpOworICAgIGdldE5vZGVJblNoYWRvd1RyZWVTdGFjayhvbGRFbGVtZW50SWQp LmZvY3VzKCk7CiAgICAgY2xlYXJFdmVudFJlY29yZHMoKTsKLSAgICBnZXRFbGVtZW50SW5TaGFk b3dUcmVlU3RhY2sobmV3RWxlbWVudElkKS5mb2N1cygpOworICAgIGdldE5vZGVJblNoYWRvd1Ry ZWVTdGFjayhuZXdFbGVtZW50SWQpLmZvY3VzKCk7CiB9CiAKIGZ1bmN0aW9uIHRlc3QoKQpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3Jlc291cmNlcy9zaGFkb3ctZG9tLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9yZXNvdXJjZXMvc2hhZG93 LWRvbS5qcwkocmV2aXNpb24gMTExMzc4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93 L3Jlc291cmNlcy9zaGFkb3ctZG9tLmpzCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0Miw3IEBA IGZ1bmN0aW9uIGlzU2hhZG93Um9vdChub2RlKQogCiAvLyBZb3UgY2FuIHNwZWZpZnkgeW91bmdl clNoYWRvd1Jvb3QgYnkgY29uc2VjdXRpdmUgc2xhc2hlcy4KIC8vIFNlZSBMYXlvdXRUZXN0cy9m YXN0L2RvbS9zaGFkb3cvZ2V0LWVsZW1lbnQtYnktaWQtaW4tc2hhZG93LXJvb3QuaHRtbCBmb3Ig YWN0dWFsIHVzYWdlcy4KLWZ1bmN0aW9uIGdldEVsZW1lbnRJblNoYWRvd1RyZWVTdGFjayhwYXRo KQorZnVuY3Rpb24gZ2V0Tm9kZUluU2hhZG93VHJlZVN0YWNrKHBhdGgpCiB7CiAgICAgdmFyIGlk cyA9IHBhdGguc3BsaXQoJy8nKTsKICAgICB2YXIgbm9kZSA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKGlkc1swXSk7Cg==