<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>8132</bug_id>
          
          <creation_ts>2006-04-01 19:06:03 -0800</creation_ts>
          <short_desc>CSS parser sometimes accepts real number as integer</short_desc>
          <delta_ts>2007-08-03 22:52:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>416.x</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.gtalbot.org/BrowserBugsSection/Opera9Bugs/RGBTests.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gérard Talbot (no longer involved)">browserbugs2</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>38245</commentid>
    <comment_count>0</comment_count>
    <who name="Gérard Talbot (no longer involved)">browserbugs2</who>
    <bug_when>2006-04-01 19:06:03 -0800</bug_when>
    <thetext>rgb(int, int, float) is accepted by the CSS parser when it should trigger an error and subsequent error condition.

References:

&quot;The format of an RGB value in the functional notation is &apos;rgb(&apos; followed by a comma-separated list of three numerical values (either three *_integer_* values or three percentage values) followed by &apos;)&apos;.&quot; 
CSS 2.1, Section 4.3.6 Colors
http://www.w3.org/TR/CSS21/syndata.html#value-def-color

&quot;An &lt;integer&gt; consists of one or more digits &quot;0&quot; to &quot;9&quot;. A &lt;number&gt; can either be an &lt;integer&gt;, or it can be zero or more digits followed by a dot (.) followed by one or more digits.&quot; 
CSS 2.1, Section 4.3.1 Integers and real numbers
http://www.w3.org/TR/CSS21/syndata.html#q15

&quot;illegal values, or values with illegal parts, are treated as if the declaration weren&apos;t there at all&quot; 
CSS1 Forward compatibility
http://www.w3.org/TR/CSS1#forward-compatible-parsing


So, an integer, according to CSS 2.1, clearly excludes the presence of a dot (.), therefore 
selector {color: rgb(0, 0, 128.0);}
should trigger a CSS parsing error and the whole declaration should be dropped, ignored. This is what the testcase at provided URL tests.

Safari 2.02 (41613) fails the second line of the testcase at provided URL: the 2nd line is blue and not green.

Another good testpage is:
http://www.hixie.ch/tests/evil/css/css21/tests/t040306-syntax-01-f.htm

I searched for a duplicate and couldn&apos;t find one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38881</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2006-04-10 10:44:24 -0700</bug_when>
    <thetext>FWIW, WinIE 6 and Safari give identical results for the test from the bug URL - but Firefox passes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41362</commentid>
    <comment_count>2</comment_count>
      <attachid>8128</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2006-05-05 14:06:02 -0700</bug_when>
    <thetext>Created attachment 8128
Proposed patch

This patch solves the problem, but I do not know whether it has the right approach.
Also the new flag true_float should probably part of a bit string. Because of this
I do not request a review yet, but would like some feedback :)
Cheers,

Rob.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41436</commentid>
    <comment_count>3</comment_count>
      <attachid>8141</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2006-05-07 04:52:13 -0700</bug_when>
    <thetext>Created attachment 8141
Updated patch

Updated version after feedback from othermaciej.
No extra shift/reduce conflicts are added because of this patch.
Cheers,

Rob.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41445</commentid>
    <comment_count>4</comment_count>
      <attachid>8141</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-05-07 10:28:14 -0700</bug_when>
    <thetext>Comment on attachment 8141
Updated patch

 num             [0-9]+|[0-9]*&quot;.&quot;[0-9]+
+intnum          [0-9]+|[0-9]*

This looks wrong to me. [0-9]+ would be correct, the [0-9]* part is not relevant nor do we need a &quot;|&quot;.

I&apos;m also unclear on how flex handles the ambiguity since both {num} and {intnum} can match the same thing. We might need to rearrange the regular expressions so that is not the case.

I suggest using INTEGER instead of INTNUMBER and perhaps changing the name of NUMBER to something like FLOAT.

We need a test case. We don&apos;t check in bug fixes without test cases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41461</commentid>
    <comment_count>5</comment_count>
      <attachid>8151</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2006-05-07 13:16:57 -0700</bug_when>
    <thetext>Created attachment 8151
Updated patch after darins feedback

Indeed the regexp was badly copy-pasted, corrected now. I think it also
increases the number of conflicts, but the tests show no difference. Finally, I took
the original testcase and places it in css2.1/,  not sure if that is the best place, but the
testcase itself is pretty clear IMHO.
Cheers,

Rob.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41484</commentid>
    <comment_count>6</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-05-07 18:45:44 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; I think it also increases the number of conflicts, but the tests show no difference.

I believe a change to the lexer could change the number of conflicts. Conflicts are something in the Bison-generated parser, not the Flex-generated lexer.

&gt; I took the original testcase and placed it in css2.1

The test case is not included in the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41485</commentid>
    <comment_count>7</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-05-07 18:46:13 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; The test case is not included in the patch.

Oops, my bad. It is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41486</commentid>
    <comment_count>8</comment_count>
      <attachid>8151</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-05-07 18:50:20 -0700</bug_when>
    <thetext>Comment on attachment 8151
Updated patch after darins feedback

+  | IMPORT_SYM maybe_space string_or_uri maybe_space maybe_media_list {
+        $$ = static_cast&lt;CSSParser *&gt;(parser)-&gt;createImportRule($3, $5);
+    }

What does this change have to do with the bug you&apos;re fixing? Looks like something else you were working on?

I think it&apos;s quite ugly that isInt is there all the time, but only used for the CSS_NUMBER case. Might need at least a comment to make that clear.

review- just because of the IMPORT_SYM line; no need for more review, but we need a patch without that change</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41509</commentid>
    <comment_count>9</comment_count>
      <attachid>8162</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2006-05-08 00:58:00 -0700</bug_when>
    <thetext>Created attachment 8162
Updated patch, removing unrelated code

Indeed I had bits from another patch in there. Just shows that creating
patches while watching a movie is a bad idea :)
Cheers,

Rob.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42080</commentid>
    <comment_count>10</comment_count>
      <attachid>8162</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2006-05-12 01:00:21 -0700</bug_when>
    <thetext>Comment on attachment 8162
Updated patch, removing unrelated code

Hmm, no idea why I didnt ask
for review before :}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42190</commentid>
    <comment_count>11</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2006-05-13 08:08:16 -0700</bug_when>
    <thetext>Landed the test into fast/css, rather than css2.1 (the latter contains W3C tests).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>42205</commentid>
    <comment_count>12</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2006-05-13 10:26:02 -0700</bug_when>
    <thetext>Landed in r14352</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>8128</attachid>
            <date>2006-05-05 14:06:02 -0700</date>
            <delta_ts>2006-05-07 04:52:13 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>8132.diff</filename>
            <type>text/plain</type>
            <size>3077</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9j
c3MvY3NzcGFyc2VyLmNwcAkocmV2aXNpb24gMTQyMDkpCisrKyBXZWJDb3JlL2Nzcy9jc3NwYXJz
ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTgsNyArMzE4LDcgQEAKICAgICAgICAgICAgIGIg
PSB0cnVlOwogICAgICAgICB9CiAgICAgICAgIGlmICghYiAmJiAodW5pdGZsYWdzICYgRkludGVn
ZXIpICYmCi0gICAgICAgICAgICAgKHZhbHVlLT5mVmFsdWUgLSAoaW50KXZhbHVlLT5mVmFsdWUp
IDwgMC4wMDEpCisgICAgICAgICAgICAgKCh2YWx1ZS0+ZlZhbHVlIC0gKGludCl2YWx1ZS0+ZlZh
bHVlKSA8IDAuMDAxKSAmJiB2YWx1ZS0+dHJ1ZV9mbG9hdCAhPSAxKQogICAgICAgICAgICAgYiA9
IHRydWU7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19Q
RVJDRU5UQUdFOgpAQCAtMjYzMCw2ICsyNjMwLDcgQEAKICAgICBjYXNlIFBFUkNFTlRBR0U6CiAg
ICAgICAgIGxlbmd0aC0tOwogICAgIGNhc2UgTlVNQkVSOgorICAgIGNhc2UgSU5UTlVNQkVSOgog
ICAgICAgICB5eWx2YWwtPnZhbCA9IERlcHJlY2F0ZWRTdHJpbmcoKFFDaGFyICopdCwgbGVuZ3Ro
KS50b0RvdWJsZSgpOwogICAgICAgICBicmVhazsKIApJbmRleDogV2ViQ29yZS9jc3MvQ1NTR3Jh
bW1hci55Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQkocmV2aXNpb24g
MTQyMDkpCisrKyBXZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkJKHdvcmtpbmcgY29weSkKQEAgLTE5
OSw2ICsxOTksNyBAQAogJXRva2VuIDxzdHJpbmc+IERJTUVOCiAldG9rZW4gPHZhbD4gUEVSQ0VO
VEFHRQogJXRva2VuIDx2YWw+IE5VTUJFUgorJXRva2VuIDx2YWw+IElOVE5VTUJFUgogCiAldG9r
ZW4gPHN0cmluZz4gVVJJCiAldG9rZW4gPHN0cmluZz4gRlVOQ1RJT04KQEAgLTkyMCw4ICs5MjEs
MTMgQEAKICAgOwogCiB1bmFyeV90ZXJtOgotICBOVU1CRVIgbWF5YmVfc3BhY2UgeyAkJC5pZCA9
IDA7ICQkLmZWYWx1ZSA9ICQxOyAkJC51bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1C
RVI7IH0KLSAgfCBQRVJDRU5UQUdFIG1heWJlX3NwYWNlIHsgJCQuaWQgPSAwOyAkJC5mVmFsdWUg
PSAkMTsgJCQudW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUEVSQ0VOVEFHRTsgfQorICBJ
TlROVU1CRVIgbWF5YmVfc3BhY2UgeworICQkLmlkID0gMDsgJCQuZlZhbHVlID0gKGludCkkMTsg
JCQudW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVSOworIH0KKyB8ICBOVU1CRVIg
bWF5YmVfc3BhY2UgeworICQkLmlkID0gMDsgJCQudHJ1ZV9mbG9hdCA9IDE7ICQkLmZWYWx1ZSA9
ICQxOyAkJC51bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVI7CisgfQorIHwgUEVS
Q0VOVEFHRSBtYXliZV9zcGFjZSB7ICQkLmlkID0gMDsgJCQuZlZhbHVlID0gJDE7ICQkLnVuaXQg
PSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BFUkNFTlRBR0U7IH0KICAgfCBQWFMgbWF5YmVfc3Bh
Y2UgeyAkJC5pZCA9IDA7ICQkLmZWYWx1ZSA9ICQxOyAkJC51bml0ID0gQ1NTUHJpbWl0aXZlVmFs
dWU6OkNTU19QWDsgfQogICB8IENNUyBtYXliZV9zcGFjZSB7ICQkLmlkID0gMDsgJCQuZlZhbHVl
ID0gJDE7ICQkLnVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX0NNOyB9CiAgIHwgTU1TIG1h
eWJlX3NwYWNlIHsgJCQuaWQgPSAwOyAkJC5mVmFsdWUgPSAkMTsgJCQudW5pdCA9IENTU1ByaW1p
dGl2ZVZhbHVlOjpDU1NfTU07IH0KSW5kZXg6IFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5oCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5oCShyZXZpc2lvbiAxNDIwOSkKKysrIFdl
YkNvcmUvY3NzL2Nzc3BhcnNlci5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSw3IEBACiAg
ICAgCiAgICAgc3RydWN0IFZhbHVlIHsKICAgICAgICAgaW50IGlkOworICAgICAgICBpbnQgdHJ1
ZV9mbG9hdDsKICAgICAgICAgdW5pb24gewogICAgICAgICAgICAgZG91YmxlIGZWYWx1ZTsKICAg
ICAgICAgICAgIGludCBpVmFsdWU7CkluZGV4OiBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAkocmV2aXNpb24gMTQyMDkp
CisrKyBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAkod29ya2luZyBjb3B5KQpAQCAtMTQsNiAr
MTQsNyBAQAogaWRlbnQgICAgICAgICAgIC0/e25tc3RhcnR9e25tY2hhcn0qCiBuYW1lICAgICAg
ICAgICAge25tY2hhcn0rCiBudW0gICAgICAgICAgICAgWzAtOV0rfFswLTldKiIuIlswLTldKwor
aW50bnVtICAgICAgICAgIFswLTldK3xbMC05XSoKIHN0cmluZyAgICAgICAgICB7c3RyaW5nMX18
e3N0cmluZzJ9CiB1cmwgICAgICAgICAgICAgKFshIyQlJiotfl18e25vbmFzY2lpfXx7ZXNjYXBl
fSkqCiB3ICAgICAgICAgICAgICAgWyBcdFxyXG5cZl0qCkBAIC03MCw2ICs3MSw3IEBACiB7bnVt
fWtIeiAgICAgICAgICAgICAgICB7eXlUb2sgPSBLSEVSWjsgcmV0dXJuIHl5VG9rO30KIHtudW19
e2lkZW50fSAgICAgICAgICAgIHt5eVRvayA9IERJTUVOOyByZXR1cm4geXlUb2s7fQoge251bX0l
KyAgICAgICAgICAgICAgICAge3l5VG9rID0gUEVSQ0VOVEFHRTsgcmV0dXJuIHl5VG9rO30KK3tp
bnRudW19ICAgICAgICAgICAgICAgIHt5eVRvayA9IElOVE5VTUJFUjsgcmV0dXJuIHl5VG9rO30K
IHtudW19ICAgICAgICAgICAgICAgICAgIHt5eVRvayA9IE5VTUJFUjsgcmV0dXJuIHl5VG9rO30K
IAogInVybCgie3d9e3N0cmluZ317d30iKSIge3l5VG9rID0gVVJJOyByZXR1cm4geXlUb2s7fQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>8141</attachid>
            <date>2006-05-07 04:52:13 -0700</date>
            <delta_ts>2006-05-08 00:58:00 -0700</delta_ts>
            <desc>Updated patch</desc>
            <filename>8132-2.diff</filename>
            <type>text/plain</type>
            <size>4047</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAxNDIxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjIgQEAKKzIwMDYtMDUtMDcgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBUk5JTkc6IE5P
IFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1
Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04MTMyCisgICAgICAgIENTUyBw
YXJzZXIgc29tZXRpbWVzIGFjY2VwdHMgcmVhbCBudW1iZXIgYXMgaW50ZWdlcgorCisgICAgICAg
IEFkZCBhIGJvb2xlYW4gdmFyaWFibGUgcGVyIGNzcyB2YWx1ZSB0byBjYXRjaCB3aGV0aGVyIHZh
bHVlcworICAgICAgICBhcmUgc3BlY2lmaWVkIGFzIGZsb2F0cyBvciBpbnRlZ2Vycy4KKyAKKyAg
ICAgICAgKiBjc3MvQ1NTR3JhbW1hci55OgorICAgICAgICAqIGNzcy9jc3NwYXJzZXIuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjp2YWxpZFVuaXQpOgorICAgICAgICAoV2ViQ29y
ZTo6Q1NTUGFyc2VyOjpsZXgpOgorICAgICAgICAqIGNzcy9jc3NwYXJzZXIuaDoKKyAgICAgICAg
KiBjc3MvdG9rZW5pemVyLmZsZXg6CisKIDIwMDYtMDUtMDYgIERhdmlkIEh5YXR0ICA8aHlhdHRA
YXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBXZWJDb3JlRm9udCB0byBGb250UGxhdGZvcm1E
YXRhIGFuZCBXZWJUZXh0UmVuZGVyZXIgdG8gRm9udERhdGEuICBNZXJnZSB0aGVtIGludG8gdGhl
CkluZGV4OiBXZWJDb3JlL2Nzcy9jc3NwYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv
Y3NzL2Nzc3BhcnNlci5jcHAJKHJldmlzaW9uIDE0MjE2KQorKysgV2ViQ29yZS9jc3MvY3NzcGFy
c2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE3LDggKzMxNyw3IEBAIGJvb2wgQ1NTUGFyc2Vy
Ojp2YWxpZFVuaXQoVmFsdWUqIHZhbHVlLCAKICAgICAgICAgICAgIHZhbHVlLT51bml0ID0gQ1NT
UHJpbWl0aXZlVmFsdWU6OkNTU19QWDsKICAgICAgICAgICAgIGIgPSB0cnVlOwogICAgICAgICB9
Ci0gICAgICAgIGlmICghYiAmJiAodW5pdGZsYWdzICYgRkludGVnZXIpICYmCi0gICAgICAgICAg
ICAgKHZhbHVlLT5mVmFsdWUgLSAoaW50KXZhbHVlLT5mVmFsdWUpIDwgMC4wMDEpCisgICAgICAg
IGlmICghYiAmJiAodW5pdGZsYWdzICYgRkludGVnZXIpICYmIHZhbHVlLT5pc0ludCkKICAgICAg
ICAgICAgIGIgPSB0cnVlOwogICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1ByaW1pdGl2ZVZh
bHVlOjpDU1NfUEVSQ0VOVEFHRToKQEAgLTI2MzAsNiArMjYyOSw3IEBAIGludCBDU1NQYXJzZXI6
OmxleCh2b2lkICpfeXlsdmFsKSB7CiAgICAgY2FzZSBQRVJDRU5UQUdFOgogICAgICAgICBsZW5n
dGgtLTsKICAgICBjYXNlIE5VTUJFUjoKKyAgICBjYXNlIElOVE5VTUJFUjoKICAgICAgICAgeXls
dmFsLT52YWwgPSBEZXByZWNhdGVkU3RyaW5nKChRQ2hhciAqKXQsIGxlbmd0aCkudG9Eb3VibGUo
KTsKICAgICAgICAgYnJlYWs7CiAKSW5kZXg6IFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkJKHJldmlzaW9uIDE0MjE2KQorKysg
V2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55CSh3b3JraW5nIGNvcHkpCkBAIC0xOTksNiArMTk5LDcg
QEAgc3RhdGljIGludCBjc3N5eWxleChZWVNUWVBFICp5eWx2YWwpIHsgcgogJXRva2VuIDxzdHJp
bmc+IERJTUVOCiAldG9rZW4gPHZhbD4gUEVSQ0VOVEFHRQogJXRva2VuIDx2YWw+IE5VTUJFUgor
JXRva2VuIDx2YWw+IElOVE5VTUJFUgogCiAldG9rZW4gPHN0cmluZz4gVVJJCiAldG9rZW4gPHN0
cmluZz4gRlVOQ1RJT04KQEAgLTkyMCw3ICs5MjEsOCBAQCB0ZXJtOgogICA7CiAKIHVuYXJ5X3Rl
cm06Ci0gIE5VTUJFUiBtYXliZV9zcGFjZSB7ICQkLmlkID0gMDsgJCQuZlZhbHVlID0gJDE7ICQk
LnVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUjsgfQorICBJTlROVU1CRVIgbWF5
YmVfc3BhY2UgeyAkJC5pZCA9IDA7ICQkLmlzSW50ID0gdHJ1ZTsgJCQuZlZhbHVlID0gJDE7ICQk
LnVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUjsgfQorICB8IE5VTUJFUiBtYXli
ZV9zcGFjZSB7ICQkLmlkID0gMDsgJCQuaXNJbnQgPSBmYWxzZTsgJCQuZlZhbHVlID0gJDE7ICQk
LnVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUjsgfQogICB8IFBFUkNFTlRBR0Ug
bWF5YmVfc3BhY2UgeyAkJC5pZCA9IDA7ICQkLmZWYWx1ZSA9ICQxOyAkJC51bml0ID0gQ1NTUHJp
bWl0aXZlVmFsdWU6OkNTU19QRVJDRU5UQUdFOyB9CiAgIHwgUFhTIG1heWJlX3NwYWNlIHsgJCQu
aWQgPSAwOyAkJC5mVmFsdWUgPSAkMTsgJCQudW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf
UFg7IH0KICAgfCBDTVMgbWF5YmVfc3BhY2UgeyAkJC5pZCA9IDA7ICQkLmZWYWx1ZSA9ICQxOyAk
JC51bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19DTTsgfQpJbmRleDogV2ViQ29yZS9jc3Mv
Y3NzcGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmgJKHJldmlz
aW9uIDE0MjE2KQorKysgV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAg
LTU1LDYgKzU1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIAogICAgIHN0cnVjdCBWYWx1
ZSB7CiAgICAgICAgIGludCBpZDsKKyAgICAgICAgYm9vbCBpc0ludDsKICAgICAgICAgdW5pb24g
ewogICAgICAgICAgICAgZG91YmxlIGZWYWx1ZTsKICAgICAgICAgICAgIGludCBpVmFsdWU7Cklu
ZGV4OiBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nz
cy90b2tlbml6ZXIuZmxleAkocmV2aXNpb24gMTQyMTYpCisrKyBXZWJDb3JlL2Nzcy90b2tlbml6
ZXIuZmxleAkod29ya2luZyBjb3B5KQpAQCAtMTQsNiArMTQsNyBAQCBzdHJpbmcyICAgICAgICAg
XCcoW1x0ICEjJCUmKC1+XXxcXHtubH18CiBpZGVudCAgICAgICAgICAgLT97bm1zdGFydH17bm1j
aGFyfSoKIG5hbWUgICAgICAgICAgICB7bm1jaGFyfSsKIG51bSAgICAgICAgICAgICBbMC05XSt8
WzAtOV0qIi4iWzAtOV0rCitpbnRudW0gICAgICAgICAgWzAtOV0rfFswLTldKgogc3RyaW5nICAg
ICAgICAgIHtzdHJpbmcxfXx7c3RyaW5nMn0KIHVybCAgICAgICAgICAgICAoWyEjJCUmKi1+XXx7
bm9uYXNjaWl9fHtlc2NhcGV9KSoKIHcgICAgICAgICAgICAgICBbIFx0XHJcblxmXSoKQEAgLTcw
LDYgKzcxLDcgQEAgcmFuZ2UgICAgICAgICAgIFw/ezEsNn18e2h9KFw/ezAsNX18e2h9KAoge251
bX1rSHogICAgICAgICAgICAgICAge3l5VG9rID0gS0hFUlo7IHJldHVybiB5eVRvazt9CiB7bnVt
fXtpZGVudH0gICAgICAgICAgICB7eXlUb2sgPSBESU1FTjsgcmV0dXJuIHl5VG9rO30KIHtudW19
JSsgICAgICAgICAgICAgICAgIHt5eVRvayA9IFBFUkNFTlRBR0U7IHJldHVybiB5eVRvazt9Cit7
aW50bnVtfSAgICAgICAgICAgICAgICB7eXlUb2sgPSBJTlROVU1CRVI7IHJldHVybiB5eVRvazt9
CiB7bnVtfSAgICAgICAgICAgICAgICAgICB7eXlUb2sgPSBOVU1CRVI7IHJldHVybiB5eVRvazt9
CiAKICJ1cmwoInt3fXtzdHJpbmd9e3d9IikiIHt5eVRvayA9IFVSSTsgcmV0dXJuIHl5VG9rO30K
</data>
<flag name="review"
          id="2259"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>8151</attachid>
            <date>2006-05-07 13:16:57 -0700</date>
            <delta_ts>2006-05-08 00:58:00 -0700</delta_ts>
            <desc>Updated patch after darins feedback</desc>
            <filename>8132-3.diff</filename>
            <type>text/plain</type>
            <size>5682</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDE0MjE4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwNi0wNS0wNyAgUm9iIEJ1aXMgIDxzZXQgRU1B
SUxfQUREUkVTUyBlbnZpcm9ubWVudCB2YXJpYWJsZT4KKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzczIuMS9yZ2ItZmxvYXQuaHRtbDogQWRkZWQu
CisKIDIwMDYtMDUtMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBueXBvcC5jb20+CiAKICAg
ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9jc3MyLjEvcmdiLWZs
b2F0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvY3NzMi4xL3JnYi1mbG9hdC5odG1s
CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvY3NzMi4xL3JnYi1mbG9hdC5odG1sCShyZXZp
c2lvbiAwKQpAQCAtMCwwICsxLDIwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL1czQy8v
RFREIEhUTUwgNC4wMS8vRU4iICJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9zdHJpY3QuZHRk
Ij4KKworPGh0bWwgbGFuZz0iZW4iPgorCis8aGVhZCBwcm9maWxlPSJodHRwOi8vd3d3LmlldGYu
b3JnL3JmYy9yZmMyNzMxLnR4dCI+CisKKzx0aXRsZT5DU1MgMi4xIFRlc3QgU3VpdGU6IFJHQiBj
b2xvciBzeW50YXggZXJyb3IgaGFuZGxpbmc8L3RpdGxlPgorCis8c3R5bGUgdHlwZT0idGV4dC9j
c3MiPgorYm9keSB7Y29sb3I6IGdyZWVuO30KK2gxI2Zsb2F0bnVtbnVtIHtjb2xvcjogcmdiKDI1
NS4wLCAwLCAwKTt9CitoMSNudW1udW1mbG9hdCB7Y29sb3I6IHJnYigwLCAwLCAxMjguMCk7fQor
PC9zdHlsZT4KKzwvaGVhZD4KKworPGJvZHk+Cis8aDEgaWQ9ImZsb2F0bnVtbnVtIj5UaGlzIHNo
b3VsZCBiZSBncmVlbiwgbm90IHJlZDwvaDE+Cis8aDEgaWQ9Im51bW51bWZsb2F0Ij5UaGlzIHNo
b3VsZCBiZSBncmVlbiwgbm90IGJsdWU8L2gxPgorPC9ib2R5PjwvaHRtbD4KKwpJbmRleDogV2Vi
Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9u
IDE0MjE4KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwy
MCBAQAorMjAwNi0wNS0wNyAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGZvciBodHRwOi8vYnVnemls
bGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTgxMzIKKyAgICAgICAgQ1NTIHBhcnNl
ciBzb21ldGltZXMgYWNjZXB0cyByZWFsIG51bWJlciBhcyBpbnRlZ2VyCisKKyAgICAgICAgQWRk
IGEgYm9vbGVhbiB2YXJpYWJsZSBwZXIgY3NzIHZhbHVlIHRvIGNhdGNoIHdoZXRoZXIgdmFsdWVz
CisgICAgICAgIGFyZSBzcGVjaWZpZWQgYXMgZmxvYXRzIG9yIGludGVnZXJzLgorCisgICAgICAg
ICogY3NzL0NTU0dyYW1tYXIueToKKyAgICAgICAgKiBjc3MvY3NzcGFyc2VyLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6dmFsaWRVbml0KToKKyAgICAgICAgKFdlYkNvcmU6OkNT
U1BhcnNlcjo6bGV4KToKKyAgICAgICAgKiBjc3MvY3NzcGFyc2VyLmg6CisgICAgICAgICogY3Nz
L3Rva2VuaXplci5mbGV4OgorCiAyMDA2LTA1LTA3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBA
bnlwb3AuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogV2ViQ29yZS9j
c3MvY3NzcGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9jc3NwYXJzZXIuY3Bw
CShyZXZpc2lvbiAxNDIxOCkKKysrIFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTMxNyw4ICszMTcsNyBAQCBib29sIENTU1BhcnNlcjo6dmFsaWRVbml0KFZhbHVl
KiB2YWx1ZSwgCiAgICAgICAgICAgICB2YWx1ZS0+dW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpD
U1NfUFg7CiAgICAgICAgICAgICBiID0gdHJ1ZTsKICAgICAgICAgfQotICAgICAgICBpZiAoIWIg
JiYgKHVuaXRmbGFncyAmIEZJbnRlZ2VyKSAmJgotICAgICAgICAgICAgICh2YWx1ZS0+ZlZhbHVl
IC0gKGludCl2YWx1ZS0+ZlZhbHVlKSA8IDAuMDAxKQorICAgICAgICBpZiAoIWIgJiYgKHVuaXRm
bGFncyAmIEZJbnRlZ2VyKSAmJiB2YWx1ZS0+aXNJbnQpCiAgICAgICAgICAgICBiID0gdHJ1ZTsK
ICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BFUkNFTlRB
R0U6CkBAIC0yNjI5LDcgKzI2MjgsOCBAQCBpbnQgQ1NTUGFyc2VyOjpsZXgodm9pZCAqX3l5bHZh
bCkgewogICAgIGNhc2UgU0VDUzoKICAgICBjYXNlIFBFUkNFTlRBR0U6CiAgICAgICAgIGxlbmd0
aC0tOwotICAgIGNhc2UgTlVNQkVSOgorICAgIGNhc2UgRkxPQVQ6CisgICAgY2FzZSBJTlRFR0VS
OgogICAgICAgICB5eWx2YWwtPnZhbCA9IERlcHJlY2F0ZWRTdHJpbmcoKFFDaGFyICopdCwgbGVu
Z3RoKS50b0RvdWJsZSgpOwogICAgICAgICBicmVhazsKIApJbmRleDogV2ViQ29yZS9jc3MvQ1NT
R3JhbW1hci55Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQkocmV2aXNp
b24gMTQyMTgpCisrKyBXZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkJKHdvcmtpbmcgY29weSkKQEAg
LTE5OCw3ICsxOTgsOCBAQCBzdGF0aWMgaW50IGNzc3l5bGV4KFlZU1RZUEUgKnl5bHZhbCkgeyBy
CiAldG9rZW4gPHZhbD4gS0hFUloKICV0b2tlbiA8c3RyaW5nPiBESU1FTgogJXRva2VuIDx2YWw+
IFBFUkNFTlRBR0UKLSV0b2tlbiA8dmFsPiBOVU1CRVIKKyV0b2tlbiA8dmFsPiBGTE9BVAorJXRv
a2VuIDx2YWw+IElOVEVHRVIKIAogJXRva2VuIDxzdHJpbmc+IFVSSQogJXRva2VuIDxzdHJpbmc+
IEZVTkNUSU9OCkBAIC0zNTAsNiArMzUxLDkgQEAgaW1wb3J0OgogICAgIElNUE9SVF9TWU0gbWF5
YmVfc3BhY2Ugc3RyaW5nX29yX3VyaSBtYXliZV9zcGFjZSBtYXliZV9tZWRpYV9saXN0ICc7JyB7
CiAgICAgICAgICQkID0gc3RhdGljX2Nhc3Q8Q1NTUGFyc2VyICo+KHBhcnNlciktPmNyZWF0ZUlt
cG9ydFJ1bGUoJDMsICQ1KTsKICAgICB9CisgIHwgSU1QT1JUX1NZTSBtYXliZV9zcGFjZSBzdHJp
bmdfb3JfdXJpIG1heWJlX3NwYWNlIG1heWJlX21lZGlhX2xpc3QgeworICAgICAgICAkJCA9IHN0
YXRpY19jYXN0PENTU1BhcnNlciAqPihwYXJzZXIpLT5jcmVhdGVJbXBvcnRSdWxlKCQzLCAkNSk7
CisgICAgfQogICB8IElNUE9SVF9TWU0gZXJyb3IgaW52YWxpZF9ibG9jayB7CiAgICAgICAgICQk
ID0gMDsKICAgICB9CkBAIC05MjAsNyArOTI0LDggQEAgdGVybToKICAgOwogCiB1bmFyeV90ZXJt
OgotICBOVU1CRVIgbWF5YmVfc3BhY2UgeyAkJC5pZCA9IDA7ICQkLmZWYWx1ZSA9ICQxOyAkJC51
bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVI7IH0KKyAgSU5URUdFUiBtYXliZV9z
cGFjZSB7ICQkLmlkID0gMDsgJCQuaXNJbnQgPSB0cnVlOyAkJC5mVmFsdWUgPSAkMTsgJCQudW5p
dCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfTlVNQkVSOyB9CisgIHwgRkxPQVQgbWF5YmVfc3Bh
Y2UgeyAkJC5pZCA9IDA7ICQkLmlzSW50ID0gZmFsc2U7ICQkLmZWYWx1ZSA9ICQxOyAkJC51bml0
ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVI7IH0KICAgfCBQRVJDRU5UQUdFIG1heWJl
X3NwYWNlIHsgJCQuaWQgPSAwOyAkJC5mVmFsdWUgPSAkMTsgJCQudW5pdCA9IENTU1ByaW1pdGl2
ZVZhbHVlOjpDU1NfUEVSQ0VOVEFHRTsgfQogICB8IFBYUyBtYXliZV9zcGFjZSB7ICQkLmlkID0g
MDsgJCQuZlZhbHVlID0gJDE7ICQkLnVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYOyB9
CiAgIHwgQ01TIG1heWJlX3NwYWNlIHsgJCQuaWQgPSAwOyAkJC5mVmFsdWUgPSAkMTsgJCQudW5p
dCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfQ007IH0KSW5kZXg6IFdlYkNvcmUvY3NzL2Nzc3Bh
cnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5oCShyZXZpc2lvbiAx
NDIxOCkKKysrIFdlYkNvcmUvY3NzL2Nzc3BhcnNlci5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSw2
ICs1NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAKICAgICBzdHJ1Y3QgVmFsdWUgewog
ICAgICAgICBpbnQgaWQ7CisgICAgICAgIGJvb2wgaXNJbnQ7CiAgICAgICAgIHVuaW9uIHsKICAg
ICAgICAgICAgIGRvdWJsZSBmVmFsdWU7CiAgICAgICAgICAgICBpbnQgaVZhbHVlOwpJbmRleDog
V2ViQ29yZS9jc3MvdG9rZW5pemVyLmZsZXgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvdG9r
ZW5pemVyLmZsZXgJKHJldmlzaW9uIDE0MjE4KQorKysgV2ViQ29yZS9jc3MvdG9rZW5pemVyLmZs
ZXgJKHdvcmtpbmcgY29weSkKQEAgLTE0LDYgKzE0LDcgQEAgc3RyaW5nMiAgICAgICAgIFwnKFtc
dCAhIyQlJigtfl18XFx7bmx9fAogaWRlbnQgICAgICAgICAgIC0/e25tc3RhcnR9e25tY2hhcn0q
CiBuYW1lICAgICAgICAgICAge25tY2hhcn0rCiBudW0gICAgICAgICAgICAgWzAtOV0rfFswLTld
KiIuIlswLTldKworaW50bnVtICAgICAgICAgIFswLTldKwogc3RyaW5nICAgICAgICAgIHtzdHJp
bmcxfXx7c3RyaW5nMn0KIHVybCAgICAgICAgICAgICAoWyEjJCUmKi1+XXx7bm9uYXNjaWl9fHtl
c2NhcGV9KSoKIHcgICAgICAgICAgICAgICBbIFx0XHJcblxmXSoKQEAgLTcwLDcgKzcxLDggQEAg
cmFuZ2UgICAgICAgICAgIFw/ezEsNn18e2h9KFw/ezAsNX18e2h9KAoge251bX1rSHogICAgICAg
ICAgICAgICAge3l5VG9rID0gS0hFUlo7IHJldHVybiB5eVRvazt9CiB7bnVtfXtpZGVudH0gICAg
ICAgICAgICB7eXlUb2sgPSBESU1FTjsgcmV0dXJuIHl5VG9rO30KIHtudW19JSsgICAgICAgICAg
ICAgICAgIHt5eVRvayA9IFBFUkNFTlRBR0U7IHJldHVybiB5eVRvazt9Ci17bnVtfSAgICAgICAg
ICAgICAgICAgICB7eXlUb2sgPSBOVU1CRVI7IHJldHVybiB5eVRvazt9Cit7aW50bnVtfSAgICAg
ICAgICAgICAgICB7eXlUb2sgPSBJTlRFR0VSOyByZXR1cm4geXlUb2s7fQore251bX0gICAgICAg
ICAgICAgICAgICAge3l5VG9rID0gRkxPQVQ7IHJldHVybiB5eVRvazt9CiAKICJ1cmwoInt3fXtz
dHJpbmd9e3d9IikiIHt5eVRvayA9IFVSSTsgcmV0dXJuIHl5VG9rO30KICJ1cmwoInt3fXt1cmx9
e3d9IikiICAgIHt5eVRvayA9IFVSSTsgcmV0dXJuIHl5VG9rO30K
</data>
<flag name="review"
          id="2263"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>8162</attachid>
            <date>2006-05-08 00:58:00 -0700</date>
            <delta_ts>2006-05-12 20:51:58 -0700</delta_ts>
            <desc>Updated patch, removing unrelated code</desc>
            <filename>8132-4.diff</filename>
            <type>text/plain</type>
            <size>5288</size>
            <attacher name="Rob Buis">rwlbuis</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDE0MjI2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwNi0wNS0wOCAgUm9iIEJ1aXMgIDxidWlzQGtk
ZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBjc3MyLjEvcmdiLWZsb2F0Lmh0bWw6IEFkZGVkLgorCiAyMDA2LTA1LTA4ICBBbGV4ZXkgUHJv
c2t1cnlha292ICA8YXBAbnlwb3AuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJ
bmRleDogTGF5b3V0VGVzdHMvY3NzMi4xL3JnYi1mbG9hdC5odG1sCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh
eW91dFRlc3RzL2NzczIuMS9yZ2ItZmxvYXQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl
c3RzL2NzczIuMS9yZ2ItZmxvYXQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMCBAQAor
PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov
L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+CisKKzxodG1sIGxhbmc9ImVuIj4KKwor
PGhlYWQgcHJvZmlsZT0iaHR0cDovL3d3dy5pZXRmLm9yZy9yZmMvcmZjMjczMS50eHQiPgorCis8
dGl0bGU+Q1NTIDIuMSBUZXN0IFN1aXRlOiBSR0IgY29sb3Igc3ludGF4IGVycm9yIGhhbmRsaW5n
PC90aXRsZT4KKworPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KK2JvZHkge2NvbG9yOiBncmVlbjt9
CitoMSNmbG9hdG51bW51bSB7Y29sb3I6IHJnYigyNTUuMCwgMCwgMCk7fQoraDEjbnVtbnVtZmxv
YXQge2NvbG9yOiByZ2IoMCwgMCwgMTI4LjApO30KKzwvc3R5bGU+Cis8L2hlYWQ+CisKKzxib2R5
PgorPGgxIGlkPSJmbG9hdG51bW51bSI+VGhpcyBzaG91bGQgYmUgZ3JlZW4sIG5vdCByZWQ8L2gx
PgorPGgxIGlkPSJudW1udW1mbG9hdCI+VGhpcyBzaG91bGQgYmUgZ3JlZW4sIG5vdCBibHVlPC9o
MT4KKzwvYm9keT48L2h0bWw+CisKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDIyNikKKysrIFdlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDYtMDUtMDggIFJvYiBCdWlz
ICA8YnVpc0BrZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVn
LmNnaT9pZD04MTMyCisgICAgICAgIENTUyBwYXJzZXIgc29tZXRpbWVzIGFjY2VwdHMgcmVhbCBu
dW1iZXIgYXMgaW50ZWdlcgorCisgICAgICAgIEFkZCBhIGJvb2xlYW4gdmFyaWFibGUgcGVyIGNz
cyB2YWx1ZSB0byBjYXRjaCB3aGV0aGVyIHZhbHVlcworICAgICAgICBhcmUgc3BlY2lmaWVkIGFz
IGZsb2F0cyBvciBpbnRlZ2Vycy4KKworICAgICAgICAqIGNzcy9DU1NHcmFtbWFyLnk6CisgICAg
ICAgICogY3NzL2Nzc3BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnZh
bGlkVW5pdCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OmxleCk6CisgICAgICAgICog
Y3NzL2Nzc3BhcnNlci5oOgorICAgICAgICAqIGNzcy90b2tlbml6ZXIuZmxleDoKKwogMjAwNi0w
NS0wNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAgICAgICAgIAogICAgICAgICBT
dWdnZXN0ZWQgYnkgTWl0ei4gUmV2aWV3ZWQgYW5kIGxhbmRlZCBieSBNYWNpZWouCkluZGV4OiBX
ZWJDb3JlL2Nzcy9jc3NwYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL2Nzc3Bh
cnNlci5jcHAJKHJldmlzaW9uIDE0MjI2KQorKysgV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtMzE3LDggKzMxNyw3IEBAIGJvb2wgQ1NTUGFyc2VyOjp2YWxpZFVu
aXQoVmFsdWUqIHZhbHVlLCAKICAgICAgICAgICAgIHZhbHVlLT51bml0ID0gQ1NTUHJpbWl0aXZl
VmFsdWU6OkNTU19QWDsKICAgICAgICAgICAgIGIgPSB0cnVlOwogICAgICAgICB9Ci0gICAgICAg
IGlmICghYiAmJiAodW5pdGZsYWdzICYgRkludGVnZXIpICYmCi0gICAgICAgICAgICAgKHZhbHVl
LT5mVmFsdWUgLSAoaW50KXZhbHVlLT5mVmFsdWUpIDwgMC4wMDEpCisgICAgICAgIGlmICghYiAm
JiAodW5pdGZsYWdzICYgRkludGVnZXIpICYmIHZhbHVlLT5pc0ludCkKICAgICAgICAgICAgIGIg
PSB0cnVlOwogICAgICAgICBicmVhazsKICAgICBjYXNlIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf
UEVSQ0VOVEFHRToKQEAgLTI2MjksNyArMjYyOCw4IEBAIGludCBDU1NQYXJzZXI6OmxleCh2b2lk
ICpfeXlsdmFsKSB7CiAgICAgY2FzZSBTRUNTOgogICAgIGNhc2UgUEVSQ0VOVEFHRToKICAgICAg
ICAgbGVuZ3RoLS07Ci0gICAgY2FzZSBOVU1CRVI6CisgICAgY2FzZSBGTE9BVDoKKyAgICBjYXNl
IElOVEVHRVI6CiAgICAgICAgIHl5bHZhbC0+dmFsID0gRGVwcmVjYXRlZFN0cmluZygoUUNoYXIg
Kil0LCBsZW5ndGgpLnRvRG91YmxlKCk7CiAgICAgICAgIGJyZWFrOwogCkluZGV4OiBXZWJDb3Jl
L2Nzcy9DU1NHcmFtbWFyLnkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55
CShyZXZpc2lvbiAxNDIyNikKKysrIFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQkod29ya2luZyBj
b3B5KQpAQCAtMTk4LDcgKzE5OCw4IEBAIHN0YXRpYyBpbnQgY3NzeXlsZXgoWVlTVFlQRSAqeXls
dmFsKSB7IHIKICV0b2tlbiA8dmFsPiBLSEVSWgogJXRva2VuIDxzdHJpbmc+IERJTUVOCiAldG9r
ZW4gPHZhbD4gUEVSQ0VOVEFHRQotJXRva2VuIDx2YWw+IE5VTUJFUgorJXRva2VuIDx2YWw+IEZM
T0FUCisldG9rZW4gPHZhbD4gSU5URUdFUgogCiAldG9rZW4gPHN0cmluZz4gVVJJCiAldG9rZW4g
PHN0cmluZz4gRlVOQ1RJT04KQEAgLTkyMCw3ICs5MjEsOCBAQCB0ZXJtOgogICA7CiAKIHVuYXJ5
X3Rlcm06Ci0gIE5VTUJFUiBtYXliZV9zcGFjZSB7ICQkLmlkID0gMDsgJCQuZlZhbHVlID0gJDE7
ICQkLnVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUjsgfQorICBJTlRFR0VSIG1h
eWJlX3NwYWNlIHsgJCQuaWQgPSAwOyAkJC5pc0ludCA9IHRydWU7ICQkLmZWYWx1ZSA9ICQxOyAk
JC51bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVI7IH0KKyAgfCBGTE9BVCBtYXli
ZV9zcGFjZSB7ICQkLmlkID0gMDsgJCQuaXNJbnQgPSBmYWxzZTsgJCQuZlZhbHVlID0gJDE7ICQk
LnVuaXQgPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUjsgfQogICB8IFBFUkNFTlRBR0Ug
bWF5YmVfc3BhY2UgeyAkJC5pZCA9IDA7ICQkLmZWYWx1ZSA9ICQxOyAkJC51bml0ID0gQ1NTUHJp
bWl0aXZlVmFsdWU6OkNTU19QRVJDRU5UQUdFOyB9CiAgIHwgUFhTIG1heWJlX3NwYWNlIHsgJCQu
aWQgPSAwOyAkJC5mVmFsdWUgPSAkMTsgJCQudW5pdCA9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf
UFg7IH0KICAgfCBDTVMgbWF5YmVfc3BhY2UgeyAkJC5pZCA9IDA7ICQkLmZWYWx1ZSA9ICQxOyAk
JC51bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19DTTsgfQpJbmRleDogV2ViQ29yZS9jc3Mv
Y3NzcGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmgJKHJldmlz
aW9uIDE0MjI2KQorKysgV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAg
LTU1LDYgKzU1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIAogICAgIHN0cnVjdCBWYWx1
ZSB7CiAgICAgICAgIGludCBpZDsKKyAgICAgICAgYm9vbCBpc0ludDsKICAgICAgICAgdW5pb24g
ewogICAgICAgICAgICAgZG91YmxlIGZWYWx1ZTsKICAgICAgICAgICAgIGludCBpVmFsdWU7Cklu
ZGV4OiBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nz
cy90b2tlbml6ZXIuZmxleAkocmV2aXNpb24gMTQyMjYpCisrKyBXZWJDb3JlL2Nzcy90b2tlbml6
ZXIuZmxleAkod29ya2luZyBjb3B5KQpAQCAtMTQsNiArMTQsNyBAQCBzdHJpbmcyICAgICAgICAg
XCcoW1x0ICEjJCUmKC1+XXxcXHtubH18CiBpZGVudCAgICAgICAgICAgLT97bm1zdGFydH17bm1j
aGFyfSoKIG5hbWUgICAgICAgICAgICB7bm1jaGFyfSsKIG51bSAgICAgICAgICAgICBbMC05XSt8
WzAtOV0qIi4iWzAtOV0rCitpbnRudW0gICAgICAgICAgWzAtOV0rCiBzdHJpbmcgICAgICAgICAg
e3N0cmluZzF9fHtzdHJpbmcyfQogdXJsICAgICAgICAgICAgIChbISMkJSYqLX5dfHtub25hc2Np
aX18e2VzY2FwZX0pKgogdyAgICAgICAgICAgICAgIFsgXHRcclxuXGZdKgpAQCAtNzAsNyArNzEs
OCBAQCByYW5nZSAgICAgICAgICAgXD97MSw2fXx7aH0oXD97MCw1fXx7aH0oCiB7bnVtfWtIeiAg
ICAgICAgICAgICAgICB7eXlUb2sgPSBLSEVSWjsgcmV0dXJuIHl5VG9rO30KIHtudW19e2lkZW50
fSAgICAgICAgICAgIHt5eVRvayA9IERJTUVOOyByZXR1cm4geXlUb2s7fQoge251bX0lKyAgICAg
ICAgICAgICAgICAge3l5VG9rID0gUEVSQ0VOVEFHRTsgcmV0dXJuIHl5VG9rO30KLXtudW19ICAg
ICAgICAgICAgICAgICAgIHt5eVRvayA9IE5VTUJFUjsgcmV0dXJuIHl5VG9rO30KK3tpbnRudW19
ICAgICAgICAgICAgICAgIHt5eVRvayA9IElOVEVHRVI7IHJldHVybiB5eVRvazt9Cit7bnVtfSAg
ICAgICAgICAgICAgICAgICB7eXlUb2sgPSBGTE9BVDsgcmV0dXJuIHl5VG9rO30KIAogInVybCgi
e3d9e3N0cmluZ317d30iKSIge3l5VG9rID0gVVJJOyByZXR1cm4geXlUb2s7fQogInVybCgie3d9
e3VybH17d30iKSIgICAge3l5VG9rID0gVVJJOyByZXR1cm4geXlUb2s7fQo=
</data>
<flag name="review"
          id="2315"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>