81315 2012-03-16 00:00:04 -0700 [EFL][DRT]Do not create ScrollbarEfl when mockScrollbar is enabled. 2012-05-08 12:35:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79853 1 ryuan.choi ryuan.choi gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 580206 0 ryuan.choi 2012-03-16 00:00:04 -0700 DRT use mockScrollbar to draw platform independent scrollbar. But, WebKit/Efl creates custom scrollbar which is not related to ScrollbarTheme, so custom scrollbar is still created although mockScrollbar is enabled. 580225 1 132218 ryuan.choi 2012-03-16 00:25:46 -0700 Created attachment 132218 Patch 580243 2 132218 gyuyoung.kim 2012-03-16 00:47:33 -0700 Comment on attachment 132218 Patch Attachment 132218 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11964060 580244 3 132218 buildbot 2012-03-16 00:48:13 -0700 Comment on attachment 132218 Patch Attachment 132218 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11962136 580257 4 132224 ryuan.choi 2012-03-16 01:07:09 -0700 Created attachment 132224 fixTypo 611180 5 132224 rakuco 2012-04-26 19:21:15 -0700 Comment on attachment 132224 fixTypo View in context: https://bugs.webkit.org/attachment.cgi?id=132224&action=review Makes sense. > Source/WebCore/ChangeLog:8 > + ScrollbarEfl creates custom scrollbars as separeted layer and they are s/separeted/separated/ 612470 6 139410 ryuan.choi 2012-04-29 18:30:08 -0700 Created attachment 139410 Patch 612471 7 ryuan.choi 2012-04-29 18:30:56 -0700 (In reply to comment #5) > (From update of attachment 132224 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132224&action=review > > Makes sense. > > > Source/WebCore/ChangeLog:8 > > + ScrollbarEfl creates custom scrollbars as separeted layer and they are > > s/separeted/separated/ Sorry, fixed. 618716 8 139410 webkit.review.bot 2012-05-08 12:35:52 -0700 Comment on attachment 139410 Patch Clearing flags on attachment: 139410 Committed r116450: <http://trac.webkit.org/changeset/116450> 618718 9 webkit.review.bot 2012-05-08 12:35:57 -0700 All reviewed patches have been landed. Closing bug. 132218 2012-03-16 00:25:46 -0700 2012-03-16 01:07:04 -0700 Patch bug-81315-20120316162544.patch text/plain 2058 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwOTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA0NDBmMjcyOTcwYWE5 N2RmNGVmZjE4NmUwNzU2NTM4YTA0MzQ1YS4uMDdhNTZmZTg3MmM4NWY5M2VkNzY4OTc3YjZkOTMy YzZlNjdkOWE3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTE2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtEUlRdRG8g bm90IGNyZWF0ZSBTY3JvbGxiYXJFZmwgd2hlbiBtb2NrU2Nyb2xsYmFyIGlzIGVuYWJsZWQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTMxNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNjcm9sbGJhckVm bCBjcmVhdGVzIGN1c3RvbSBzY3JvbGxiYXJzIGFzIHNlcGFyZXRlZCBsYXllciBhbmQgdGhleSBh cmUKKyAgICAgICAgbm90IHJlbGF0ZWQgdG8gU2Nyb2xsYmFyVGhlbWUuCisgICAgICAgIFNvLCBE UlQvRWZsIGNyZWF0ZXMgY3VzdG9tIHNjcm9sbGJhcnMgb24gd2VidmlldyB3aGljaCBwYWludHMg bW9ja1Njcm9sbGJhci4KKworICAgICAgICBUaGlzIHBhdGNoIHByZXZlbnRzIGNyZWF0aW5nIGN1 c3RvbSBzY3JvbGxiYXJzIHdoZW4gbW9ja1Njcm9sbGJhciBpcyBlbmFibGVkLgorCisgICAgICAg IEJlY2F1c2UgRFJUL0VmbCBvbmx5IHJlbmRlcnMgdGhlIHdlYnZpZXcgbm93LCBleHBlY3RlZCBy ZXN1bHRzIGFyZSBzYW1lCisgICAgICAgIHVudGlsIEJ1ZyA3OTg1MyBpcyBsYW5kZWQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcDoKKyAgICAgICAgKFNjcm9sbGJh cjo6Y3JlYXRlTmF0aXZlU2Nyb2xsYmFyKToKKwogMjAxMi0wMy0xNSAgSGFucyBXZW5uYm9yZyAg PGhhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNwZWVjaCBKYXZhU2NyaXB0IEFQSTogU3Bl ZWNoUmVjb2duaXRpb24sIENvbnRyb2xsZXIgYW5kIENsaWVudApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcAppbmRleCAxODM2OTFhNWQ3ZmZkMDI5OTM2YjBm YzdjNDU1ZWFlZjgzZTQwZDUzLi4zMmE4ODU0ZjlhMDk0MTNhY2E4OTQ3ZWJiYzhmM2RjNTA1NTVm MjFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZs LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcApA QCAtMjksOSArMjksOSBAQAogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUg Ikhvc3RXaW5kb3cuaCIKICNpbmNsdWRlICJJbnRSZWN0LmgiCi0jaW5jbHVkZSAiTm90SW1wbGVt ZW50ZWQuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyVGhlbWUuaCIK KyNpbmNsdWRlICJTZXR0aW5nLmgiCiAKICNpbmNsdWRlIDxFY29yZS5oPgogI2luY2x1ZGUgPEVk amUuaD4KQEAgLTQ0LDYgKzQ0LDkgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIFBhc3NS ZWZQdHI8U2Nyb2xsYmFyPiBTY3JvbGxiYXI6OmNyZWF0ZU5hdGl2ZVNjcm9sbGJhcihTY3JvbGxh YmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEsIFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9u LCBTY3JvbGxiYXJDb250cm9sU2l6ZSBzaXplKQogeworICAgIGlmIChTZXR0aW5nczo6bW9ja1Nj cm9sbGJhcnNFbmFibGVkKCkpCisgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2Nyb2xsYmFy KHNjcm9sbGFibGVBcmVhLCBvcmllbnRhdGlvbiwgc2l6ZSkpOworCiAgICAgcmV0dXJuIGFkb3B0 UmVmKG5ldyBTY3JvbGxiYXJFZmwoc2Nyb2xsYWJsZUFyZWEsIG9yaWVudGF0aW9uLCBzaXplKSk7 CiB9CiAK 132224 2012-03-16 01:07:09 -0700 2012-04-29 18:30:01 -0700 fixTypo bug-81315-20120316170708.patch text/plain 2045 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwOTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY1NjQwYTk0YmQ0MTYx NzBiMGY2ZjFkNGUzZDU5ZTk4YTBkZjJjNi4uMDIxMzc3ODU0YmRiZTQ4MzZhZTAyOTI2NDZkNWI4 OGVkNTg5MDQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTE2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtEUlRdRG8g bm90IGNyZWF0ZSBTY3JvbGxiYXJFZmwgd2hlbiBtb2NrU2Nyb2xsYmFyIGlzIGVuYWJsZWQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTMxNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNjcm9sbGJhckVm bCBjcmVhdGVzIGN1c3RvbSBzY3JvbGxiYXJzIGFzIHNlcGFyZXRlZCBsYXllciBhbmQgdGhleSBh cmUKKyAgICAgICAgbm90IHJlbGF0ZWQgdG8gU2Nyb2xsYmFyVGhlbWUuCisgICAgICAgIFNvLCBE UlQvRWZsIGNyZWF0ZXMgY3VzdG9tIHNjcm9sbGJhcnMgb24gd2VidmlldyB3aGljaCBwYWludHMg bW9ja1Njcm9sbGJhci4KKworICAgICAgICBUaGlzIHBhdGNoIHByZXZlbnRzIGNyZWF0aW5nIGN1 c3RvbSBzY3JvbGxiYXJzIHdoZW4gbW9ja1Njcm9sbGJhciBpcyBlbmFibGVkLgorCisgICAgICAg IEJlY2F1c2UgRFJUL0VmbCBvbmx5IHJlbmRlcnMgdGhlIHdlYnZpZXcgbm93LCBleHBlY3RlZCBy ZXN1bHRzIGFyZSBzYW1lCisgICAgICAgIHVudGlsIEJ1ZyA3OTg1MyBpcyBsYW5kZWQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcDoKKyAgICAgICAgKFNjcm9sbGJh cjo6Y3JlYXRlTmF0aXZlU2Nyb2xsYmFyKToKKwogMjAxMi0wMy0xNiAgTWFyayBQaWxncmltICA8 cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTW92ZSBET01XaW5kb3dGaWxlU3lzdGVt IHRvIE1vZHVsZXMvZmlsZXN5c3RlbS8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Nj cm9sbGJhckVmbC5jcHAKaW5kZXggMTgzNjkxYTVkN2ZmZDAyOTkzNmIwZmM3YzQ1NWVhZWY4M2U0 MGQ1My4uNjVkZDY4ZDQ2ZWZmNmQwYjcyMTBiMjg4MjdlNGE5YTJmNzNhZWQ4MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKQEAgLTI5LDkgKzI5LDkg QEAKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJIb3N0V2luZG93Lmgi CiAjaW5jbHVkZSAiSW50UmVjdC5oIgotI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5j bHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlNjcm9sbGJhclRoZW1lLmgiCisjaW5jbHVkZSAiU2V0 dGluZ3MuaCIKIAogI2luY2x1ZGUgPEVjb3JlLmg+CiAjaW5jbHVkZSA8RWRqZS5oPgpAQCAtNDQs NiArNDQsOSBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogUGFzc1JlZlB0cjxTY3JvbGxi YXI+IFNjcm9sbGJhcjo6Y3JlYXRlTmF0aXZlU2Nyb2xsYmFyKFNjcm9sbGFibGVBcmVhKiBzY3Jv bGxhYmxlQXJlYSwgU2Nyb2xsYmFyT3JpZW50YXRpb24gb3JpZW50YXRpb24sIFNjcm9sbGJhckNv bnRyb2xTaXplIHNpemUpCiB7CisgICAgaWYgKFNldHRpbmdzOjptb2NrU2Nyb2xsYmFyc0VuYWJs ZWQoKSkKKyAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTY3JvbGxiYXIoc2Nyb2xsYWJsZUFy ZWEsIG9yaWVudGF0aW9uLCBzaXplKSk7CisKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNjcm9s bGJhckVmbChzY3JvbGxhYmxlQXJlYSwgb3JpZW50YXRpb24sIHNpemUpKTsKIH0KIAo= 139410 2012-04-29 18:30:08 -0700 2012-05-08 12:35:52 -0700 Patch bug-81315-20120430103006.patch text/plain 2059 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM4ODYzYTQ5N2E1OGEx YWViZWNmNDRjNjNkNzM3MTJjMDk2MDU0YS4uNWZjNmU0M2JhNGEzZWJiYzU0NzVjZDY5ODRiNDBj OGYyMWE1YTczZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTI5ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtEUlRdRG8g bm90IGNyZWF0ZSBTY3JvbGxiYXJFZmwgd2hlbiBtb2NrU2Nyb2xsYmFyIGlzIGVuYWJsZWQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTMxNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNjcm9sbGJhckVm bCBjcmVhdGVzIGN1c3RvbSBzY3JvbGxiYXJzIGFzIHNlcGFyYXRlZCBsYXllciBhbmQgdGhleSBh cmUKKyAgICAgICAgbm90IHJlbGF0ZWQgdG8gU2Nyb2xsYmFyVGhlbWUuCisgICAgICAgIFNvLCBE UlQvRWZsIGNyZWF0ZXMgY3VzdG9tIHNjcm9sbGJhcnMgb24gd2VidmlldyB3aGljaCBwYWludHMg bW9ja1Njcm9sbGJhci4KKworICAgICAgICBUaGlzIHBhdGNoIHByZXZlbnRzIGNyZWF0aW5nIGN1 c3RvbSBzY3JvbGxiYXJzIHdoZW4gbW9ja1Njcm9sbGJhciBpcyBlbmFibGVkLgorCisgICAgICAg IEJlY2F1c2UgRFJUL0VmbCBvbmx5IHJlbmRlcnMgdGhlIHdlYnZpZXcgbm93LCBleHBlY3RlZCBy ZXN1bHRzIGFyZSBzYW1lCisgICAgICAgIHVudGlsIEJ1ZyA3OTg1MyBpcyBsYW5kZWQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcDoKKyAgICAgICAgKFNjcm9sbGJh cjo6Y3JlYXRlTmF0aXZlU2Nyb2xsYmFyKToKKwogMjAxMi0wNC0yOSAgTHVrZSBNYWNwaGVyc29u ICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5pdGlhbGl6ZSBtZW1iZXIg dmFyaWFibGVzIGluIENTU1BhcnNlcidzIGNvbnN0cnVjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcAppbmRleCAxODM2OTFhNWQ3ZmZkMDI5OTM2YjBm YzdjNDU1ZWFlZjgzZTQwZDUzLi42NWRkNjhkNDZlZmY2ZDBiNzIxMGIyODgyN2U0YTlhMmY3M2Fl ZDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZs LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcApA QCAtMjksOSArMjksOSBAQAogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUg Ikhvc3RXaW5kb3cuaCIKICNpbmNsdWRlICJJbnRSZWN0LmgiCi0jaW5jbHVkZSAiTm90SW1wbGVt ZW50ZWQuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyVGhlbWUuaCIK KyNpbmNsdWRlICJTZXR0aW5ncy5oIgogCiAjaW5jbHVkZSA8RWNvcmUuaD4KICNpbmNsdWRlIDxF ZGplLmg+CkBAIC00NCw2ICs0NCw5IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBQYXNz UmVmUHRyPFNjcm9sbGJhcj4gU2Nyb2xsYmFyOjpjcmVhdGVOYXRpdmVTY3JvbGxiYXIoU2Nyb2xs YWJsZUFyZWEqIHNjcm9sbGFibGVBcmVhLCBTY3JvbGxiYXJPcmllbnRhdGlvbiBvcmllbnRhdGlv biwgU2Nyb2xsYmFyQ29udHJvbFNpemUgc2l6ZSkKIHsKKyAgICBpZiAoU2V0dGluZ3M6Om1vY2tT Y3JvbGxiYXJzRW5hYmxlZCgpKQorICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNjcm9sbGJh cihzY3JvbGxhYmxlQXJlYSwgb3JpZW50YXRpb24sIHNpemUpKTsKKwogICAgIHJldHVybiBhZG9w dFJlZihuZXcgU2Nyb2xsYmFyRWZsKHNjcm9sbGFibGVBcmVhLCBvcmllbnRhdGlvbiwgc2l6ZSkp OwogfQogCg==