81305 2012-03-15 20:55:32 -0700 The commit-queue should fast-track patches that have already passed the testing EWS bots 2012-03-15 21:20:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric ojan webkit.review.bot oldest_to_newest 580085 0 abarth 2012-03-15 20:55:32 -0700 The commit-queue should fast-track patches that have already passed the testing EWS bots 580087 1 132188 abarth 2012-03-15 20:58:12 -0700 Created attachment 132188 Patch 580101 2 132188 eric 2012-03-15 21:17:05 -0700 Comment on attachment 132188 Patch LGTM. 580106 3 abarth 2012-03-15 21:20:13 -0700 Committed r110944: <http://trac.webkit.org/changeset/110944> 132188 2012-03-15 20:58:12 -0700 2012-03-15 21:17:05 -0700 Patch bug-81305-20120315205811.patch text/plain 6637 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMDkzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMwIEBACisyMDEyLTAzLTE1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgVGhlIGNvbW1pdC1xdWV1ZSBzaG91bGQgZmFzdC10cmFjayBwYXRjaGVzIHRoYXQg aGF2ZSBhbHJlYWR5IHBhc3NlZCB0aGUgdGVzdGluZyBFV1MgYm90cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEzMDUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBhIHBhdGNoIGhhcyBhbHJlYWR5IHBh c3NlZCB0aGUgdGVzdGluZyBFV1MgYm90cyAoY3VycmVudGx5IG9ubHkgdGhlCisgICAgICAgIGNo cm9taXVtLWV3cyBib3QpLCB3ZSBzaG91bGQgYmUgYWJsZSB0byBsYW5kIHRoZSBwYXRjaCB3aXRo b3V0IHJ1bm5pbmcKKyAgICAgICAgdGhlIHRlc3RzIGFnYWluLiAgVGhpcyBwYXRjaCBpcyBzb21l d2hhdCByaXNreSBpbiB0aGF0IHRoZSB0ZXN0cyBtaWdodAorICAgICAgICBoYXZlIGJlZW4gYnJv a2VuIGJldHdlZW4gd2hlbiB0aGUgRVdTIGJvdHMgcmFuIGFuZCB3aGVuIHRoZQorICAgICAgICBj b21taXQtcXVldWUgaXMgcHJvY2Vzc2luZyB0aGUgcGF0Y2guICBJZiB0aGF0IHR1cm5zIG91dCB0 byBiZSBhCisgICAgICAgIHByb2JsZW0gaW4gcHJhY3RpY2UsIHdlJ2xsIHRpZ2h0ZW4gdXAgdGhp cyBmYXN0LXRyYWNrIGluIHNvbWUgd2F5LAorICAgICAgICBsaWtlbHkgYnkgbWFraW5nIHN1cmUg dGhhdCB0aGUgcGFzcyBzdGF0dXMgaXMgcmVjZW50LgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHk6CisgICAgICAgIChDb21taXRRdWV1ZVRh c2tEZWxlZ2F0ZS5kaWRfcGFzc190ZXN0aW5nX2V3cyk6CisgICAgICAgIChDb21taXRRdWV1ZVRh c2suX2RpZF9wYXNzX3Rlc3RzX3JlY2VudGx5KToKKyAgICAgICAgKENvbW1pdFF1ZXVlVGFzay5y dW4pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNr X3VuaXR0ZXN0LnB5OgorICAgICAgICAoTW9ja0NvbW1pdFF1ZXVlLmRpZF9wYXNzX3Rlc3Rpbmdf ZXdzKToKKyAgICAgICAgKHRlc3RfZmFzdF9zdWNjZXNzX2Nhc2UpOgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHk6CisgICAgICAgIChDb21taXRRdWV1 ZS5kaWRfcGFzc190ZXN0aW5nX2V3cyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weToKKyAgICAgICAgKHRlc3RfZGlkX3Bhc3NfdGVz dGluZ19ld3MpOgorCiAyMDEyLTAzLTE1ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbUGVyZm9ybWFuY2VUZXN0c10gcnVuLXBlcmYtdGVzdHMgc2hvdWxk IG91dHB1dCBjb3JyZWN0IHVuaXRzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv Ym90L2NvbW1pdHF1ZXVldGFzay5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvYm90L2NvbW1pdHF1ZXVldGFzay5weQkocmV2aXNpb24gMTEwOTI1KQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2sucHkJKHdvcmtpbmcg Y29weSkKQEAgLTMzLDYgKzMzLDkgQEAgY2xhc3MgQ29tbWl0UXVldWVUYXNrRGVsZWdhdGUoUGF0 Y2hBbmFseQogICAgIGRlZiBwYXJlbnRfY29tbWFuZChzZWxmKToKICAgICAgICAgcmV0dXJuICJj b21taXQtcXVldWUiCiAKKyAgICBkZWYgZGlkX3Bhc3NfdGVzdGluZ19ld3Moc2VsZiwgcGF0Y2gp OgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2VzIG11c3QgaW1w bGVtZW50IikKKwogCiBjbGFzcyBDb21taXRRdWV1ZVRhc2soUGF0Y2hBbmFseXNpc1Rhc2spOgog ICAgIGRlZiB2YWxpZGF0ZShzZWxmKToKQEAgLTU4LDYgKzYxLDExIEBAIGNsYXNzIENvbW1pdFF1 ZXVlVGFzayhQYXRjaEFuYWx5c2lzVGFzaykKICAgICAgICAgIkNoYW5nZUxvZyB2YWxpZGF0ZWQi LAogICAgICAgICAiQ2hhbmdlTG9nIGRpZCBub3QgcGFzcyB2YWxpZGF0aW9uIikKIAorICAgIGRl ZiBfZGlkX3Bhc3NfdGVzdHNfcmVjZW50bHkoc2VsZik6CisgICAgICAgIGlmIHNlbGYuX2RlbGVn YXRlLmRpZF9wYXNzX3Rlc3RpbmdfZXdzKHNlbGYuX3BhdGNoKToKKyAgICAgICAgICAgIHJldHVy biBUcnVlCisgICAgICAgIHJldHVybiBzZWxmLl90ZXN0X3BhdGNoKCkKKwogICAgIGRlZiBydW4o c2VsZik6CiAgICAgICAgIGlmIG5vdCBzZWxmLnZhbGlkYXRlKCk6CiAgICAgICAgICAgICByZXR1 cm4gRmFsc2UKQEAgLTc0LDcgKzgyLDcgQEAgY2xhc3MgQ29tbWl0UXVldWVUYXNrKFBhdGNoQW5h bHlzaXNUYXNrKQogICAgICAgICAgICAgICAgIGlmIG5vdCBzZWxmLl9idWlsZF93aXRob3V0X3Bh dGNoKCk6CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICAgICAgICAg IHJldHVybiBzZWxmLnJlcG9ydF9mYWlsdXJlKCkKLSAgICAgICAgICAgIGlmIG5vdCBzZWxmLl90 ZXN0X3BhdGNoKCk6CisgICAgICAgICAgICBpZiBub3Qgc2VsZi5fZGlkX3Bhc3NfdGVzdHNfcmVj ZW50bHkoKToKICAgICAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgIyBNYWtlIHN1 cmUgdGhlIHBhdGNoIGlzIHN0aWxsIHZhbGlkIGJlZm9yZSBsYW5kaW5nIChlLmcuLCBtYWtlIHN1 cmUKICAgICAgICAgIyBubyBvbmUgaGFzIHNldCBjb21taXQtcXVldWUtIHNpbmNlIHdlIHN0YXJ0 ZWQgd29ya2luZyBvbiB0aGUgcGF0Y2guKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkJKHJl dmlzaW9uIDExMDkyNSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvY29tbWl0 cXVldWV0YXNrX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC04NCw2ICs4NCw5IEBAIGNs YXNzIE1vY2tDb21taXRRdWV1ZShDb21taXRRdWV1ZVRhc2tEZWwKICAgICBkZWYgYnVpbGRfc3R5 bGUoc2VsZik6CiAgICAgICAgIHJldHVybiAiYm90aCIKIAorICAgIGRlZiBkaWRfcGFzc190ZXN0 aW5nX2V3cyhzZWxmLCBwYXRjaCk6CisgICAgICAgIHJldHVybiBGYWxzZQorCiAKIGNsYXNzIEZh aWxpbmdUZXN0Q29tbWl0UXVldWUoTW9ja0NvbW1pdFF1ZXVlKToKICAgICBkZWYgX19pbml0X18o c2VsZiwgZXJyb3JfcGxhbiwgdGVzdF9mYWlsdXJlX3BsYW4pOgpAQCAtMTQ0LDYgKzE0NywyNCBA QCBjb21tYW5kX3Bhc3NlZDogc3VjY2Vzc19tZXNzYWdlPSdMYW5kZWQgCiAiIiIKICAgICAgICAg c2VsZi5fcnVuX3Rocm91Z2hfdGFzayhjb21taXRfcXVldWUsIGV4cGVjdGVkX3N0ZGVycikKIAor ICAgIGRlZiB0ZXN0X2Zhc3Rfc3VjY2Vzc19jYXNlKHNlbGYpOgorICAgICAgICBjb21taXRfcXVl dWUgPSBNb2NrQ29tbWl0UXVldWUoW10pCisgICAgICAgIGNvbW1pdF9xdWV1ZS5kaWRfcGFzc190 ZXN0aW5nX2V3cyA9IGxhbWJkYSBwYXRjaDogVHJ1ZQorICAgICAgICBleHBlY3RlZF9zdGRlcnIg PSAiIiJydW5fd2Via2l0X3BhdGNoOiBbJ2NsZWFuJ10KK2NvbW1hbmRfcGFzc2VkOiBzdWNjZXNz X21lc3NhZ2U9J0NsZWFuZWQgd29ya2luZyBkaXJlY3RvcnknIHBhdGNoPScxMDAwMCcKK3J1bl93 ZWJraXRfcGF0Y2g6IFsndXBkYXRlJ10KK2NvbW1hbmRfcGFzc2VkOiBzdWNjZXNzX21lc3NhZ2U9 J1VwZGF0ZWQgd29ya2luZyBkaXJlY3RvcnknIHBhdGNoPScxMDAwMCcKK3J1bl93ZWJraXRfcGF0 Y2g6IFsnYXBwbHktYXR0YWNobWVudCcsICctLW5vLXVwZGF0ZScsICctLW5vbi1pbnRlcmFjdGl2 ZScsIDEwMDAwXQorY29tbWFuZF9wYXNzZWQ6IHN1Y2Nlc3NfbWVzc2FnZT0nQXBwbGllZCBwYXRj aCcgcGF0Y2g9JzEwMDAwJworcnVuX3dlYmtpdF9wYXRjaDogWyd2YWxpZGF0ZS1jaGFuZ2Vsb2cn LCAnLS1ub24taW50ZXJhY3RpdmUnLCAxMDAwMF0KK2NvbW1hbmRfcGFzc2VkOiBzdWNjZXNzX21l c3NhZ2U9J0NoYW5nZUxvZyB2YWxpZGF0ZWQnIHBhdGNoPScxMDAwMCcKK3J1bl93ZWJraXRfcGF0 Y2g6IFsnYnVpbGQnLCAnLS1uby1jbGVhbicsICctLW5vLXVwZGF0ZScsICctLWJ1aWxkLXN0eWxl PWJvdGgnXQorY29tbWFuZF9wYXNzZWQ6IHN1Y2Nlc3NfbWVzc2FnZT0nQnVpbHQgcGF0Y2gnIHBh dGNoPScxMDAwMCcKK3J1bl93ZWJraXRfcGF0Y2g6IFsnbGFuZC1hdHRhY2htZW50JywgJy0tZm9y Y2UtY2xlYW4nLCAnLS1ub24taW50ZXJhY3RpdmUnLCAnLS1wYXJlbnQtY29tbWFuZD1jb21taXQt cXVldWUnLCAxMDAwMF0KK2NvbW1hbmRfcGFzc2VkOiBzdWNjZXNzX21lc3NhZ2U9J0xhbmRlZCBw YXRjaCcgcGF0Y2g9JzEwMDAwJworIiIiCisgICAgICAgIHNlbGYuX3J1bl90aHJvdWdoX3Rhc2so Y29tbWl0X3F1ZXVlLCBleHBlY3RlZF9zdGRlcnIpCisKICAgICBkZWYgdGVzdF9jbGVhbl9mYWls dXJlKHNlbGYpOgogICAgICAgICBjb21taXRfcXVldWUgPSBNb2NrQ29tbWl0UXVldWUoWwogICAg ICAgICAgICAgU2NyaXB0RXJyb3IoIk1PQ0sgY2xlYW4gZmFpbHVyZSIpLApJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CShyZXZpc2lvbiAx MTA5MjUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5 CSh3b3JraW5nIGNvcHkpCkBAIC0zMzMsNiArMzMzLDEyIEBAIGNsYXNzIENvbW1pdFF1ZXVlKEFi c3RyYWN0UGF0Y2hRdWV1ZSwgU3QKICAgICAgICAgcmVwb3J0ZXIgPSBGbGFreVRlc3RSZXBvcnRl cihzZWxmLl90b29sLCBzZWxmLm5hbWUpCiAgICAgICAgIHJlcG9ydGVyLnJlcG9ydF9mbGFreV90 ZXN0cyhwYXRjaCwgZmxha3lfdGVzdF9yZXN1bHRzLCByZXN1bHRzX2FyY2hpdmUpCiAKKyAgICBk ZWYgZGlkX3Bhc3NfdGVzdGluZ19ld3Moc2VsZiwgcGF0Y2gpOgorICAgICAgICAjIEN1cnJlbnRs eSwgY2hyb21pdW0tZXdzIGlzIHRoZSBvbmx5IHRlc3RpbmcgRVdTLiBPbmNlIHRoZXJlIGFyZSBt b3JlLAorICAgICAgICAjIHNob3VsZCBtYWtlIHN1cmUgdGhleSBhbGwgcGFzcy4KKyAgICAgICAg c3RhdHVzID0gc2VsZi5fdG9vbC5zdGF0dXNfc2VydmVyLnBhdGNoX3N0YXR1cygiY2hyb21pdW0t ZXdzIiwgcGF0Y2guaWQoKSkKKyAgICAgICAgcmV0dXJuIHN0YXR1cyA9PSBzZWxmLl9wYXNzX3N0 YXR1cworCiAgICAgIyBTdGVwU2VxdWVuY2VFcnJvckhhbmRsZXIgbWV0aG9kcwogCiAgICAgZGVm IGhhbmRsZV9zY3JpcHRfZXJyb3IoY2xzLCB0b29sLCBzdGF0ZSwgc2NyaXB0X2Vycm9yKToKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3Qu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1 ZXVlc191bml0dGVzdC5weQkocmV2aXNpb24gMTEwOTI1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAt NDM2LDYgKzQzNiwxMiBAQCBUaGUgY29tbWl0LXF1ZXVlIGlzIGNvbnRpbnVpbmcgdG8gcHJvY2Vz CiAKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHF1ZXVlLnJl cG9ydF9mbGFreV90ZXN0cywgW1F1ZXVlc1Rlc3QubW9ja193b3JrX2l0ZW0sIHRlc3RfcmVzdWx0 cywgTW9ja1ppcEZpbGUoKV0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAKKyAg ICBkZWYgdGVzdF9kaWRfcGFzc190ZXN0aW5nX2V3cyhzZWxmKToKKyAgICAgICAgdG9vbCA9IE1v Y2tUb29sKCkKKyAgICAgICAgcGF0Y2ggPSB0b29sLmJ1Z3MuZmV0Y2hfYXR0YWNobWVudCgxMDAw MCkKKyAgICAgICAgcXVldWUgPSBUZXN0Q29tbWl0UXVldWUodG9vbCkKKyAgICAgICAgc2VsZi5h c3NlcnRGYWxzZShxdWV1ZS5kaWRfcGFzc190ZXN0aW5nX2V3cyhwYXRjaCkpCisKIAogY2xhc3Mg U3R5bGVRdWV1ZVRlc3QoUXVldWVzVGVzdCk6CiAgICAgZGVmIHRlc3Rfc3R5bGVfcXVldWVfd2l0 aF9zdHlsZV9leGNlcHRpb24oc2VsZik6Cg==