81293 2012-03-15 17:34:44 -0700 REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work 2012-03-15 17:53:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent abarth ojan webkit.review.bot oldest_to_newest 579952 0 tkent 2012-03-15 17:34:44 -0700 http://trac.webkit.org/changeset/110595 _split_contributor_names() doesn't handle && as a separator. Traceback (most recent call last): File "./Tools/Scripts/webkit-patch", line 69, in <module> main() File "./Tools/Scripts/webkit-patch", line 64, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py", line 59, in execute reviewers = tool.checkout().suggested_reviewers(options.git_commit) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 139, in suggested_reviewers commit_infos = self.recent_commit_infos_for_files(changed_files) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 135, in recent_commit_infos_for_files return set(map(self.commit_info_for_revision, revisions)) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/memoized.py", line 45, in __call__ result = self._function(*args) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 102, in co changelog_data = self._changelog_data_for_revision(revision) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 82, in _changelog_data_for_revision changelog_entries = self.changelog_entries_for_revision(revision, changed_files=changed_files) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 75, in changelog_entries_for_revision changelog_entries.append(self._latest_entry_for_changelog_at_revision(path, revision)) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 61, in _latest_entry_for_changelog_at_revision return ChangeLog.parse_latest_entry_from_file(changelog_file) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 266, in parse_latest_entry_from_file return ChangeLogEntry(''.join(entry_lines[:-1])) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 118, in __init__ self._parse_entry() File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 183, in _parse_entry self._authors = ChangeLogEntry._parse_author_text(self._author_text) File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 174, in _parse_author_text return [ChangeLogEntry._parse_author_name_and_email(author) for author in authors] File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 164, in _parse_author_name_and_email return {'name': match.group("name"), 'email': match.group("email")} AttributeError: 'NoneType' object has no attribute 'group' 579960 1 132162 tkent 2012-03-15 17:43:03 -0700 Created attachment 132162 Patch 579969 2 tkent 2012-03-15 17:53:46 -0700 Committed r110922: <http://trac.webkit.org/changeset/110922> 132162 2012-03-15 17:43:03 -0700 2012-03-15 17:50:01 -0700 Patch bug-81293-20120316094302.patch text/plain 2837 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwOTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA5OTE5NTBhZmI3YzY0ZmRhMzgzM2I1MmMwNTA1Yzc1 ZDVkMTNiMi4uYWM3YjgzYjc3NjM1Y2FhNWExM2YyOWZiMmVlZTQ5OTBkZjE2NTdiMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTAzLTE1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAg ICAgICBSRUdSRVNTSU9OKHIxMTA1OTUpOiB3ZWJraXQtcGF0Y2ggc3VnZ2VzdC1yZXZpZXdlcnMg ZG9lc24ndCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MTI5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIHIxMTA1OTUgaW50cm9kdWNlZCBuZXcgZm9ybWF0IG9mIHRoZSBhdXRob3IgZmllbGQgb2Yg Q2hhbmdlTG9nIGVudHJ5OgorICAgICAgICAiQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PiAmJiBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPiIKKyAgICAgICAgVXBk dGUgY2hhbmVsb2cucHkgdG8gc3VwcG9ydCBpdC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZy5weToKKyAgICAgICAgKENoYW5nZUxvZ0VudHJ5 Ll9zcGxpdF9jb250cmlidXRvcl9uYW1lcyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5OgorICAgICAgICAodGVzdF9wYXJz ZV9hdXRob3JzKToKKwogMjAxMi0wMy0xNSAgTHlubiBOZWlyICA8bHlubi5uZWlyQHNreXBlLm5l dD4KIAogICAgICAgICBJbXBsZW1lbnQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZhbHVlRm9y VXNlciBvbiBXaW5kb3dzIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NTgzNApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQv Y2hhbmdlbG9nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hh bmdlbG9nLnB5CmluZGV4IDU1YjA1OTgyYjllMTdkNWQyYzc5YmU0YTBhMmQ1Mzc0MmI1NTFkYzYu LmQ3NWZhYzUzNjJkNTg4ZWY3ZTNmMjI4Nzg5NGQyMWEwYjRjYTlmZjggMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZy5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2cucHkKQEAgLTE0 Nyw3ICsxNDcsNyBAQCBjbGFzcyBDaGFuZ2VMb2dFbnRyeShvYmplY3QpOgogCiAgICAgQHN0YXRp Y21ldGhvZAogICAgIGRlZiBfc3BsaXRfY29udHJpYnV0b3JfbmFtZXModGV4dCk6Ci0gICAgICAg IHJldHVybiByZS5zcGxpdChyJ1xzKig/OiwoPzpccythbmRccyt8Jik/fCg/Ol58XHMrKWFuZFxz K3xbLysmXSlccyonLCB0ZXh0KQorICAgICAgICByZXR1cm4gcmUuc3BsaXQocidccyooPzosKD86 XHMrYW5kXHMrfCYpP3woPzpefFxzKylhbmRccyt8JiZ8Wy8rJl0pXHMqJywgdGV4dCkKIAogICAg IGRlZiBfZnV6el9tYXRjaF9yZXZpZXdlcnMoc2VsZiwgcmV2aWV3ZXJzX3RleHRfbGlzdCk6CiAg ICAgICAgIGlmIG5vdCByZXZpZXdlcnNfdGV4dF9saXN0OgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5 CmluZGV4IDQzMWM4NjcwMWZiOTQyYjMzZWQ3M2ExMmNjMzg4MWIwYzIxMzMxOTkuLjUyMjY4NDIz ZDczY2NiMDBkYTAxMjVkYThmYmM4ZWRjNjFiMDZhY2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191bml0dGVzdC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2dfdW5pdHRlc3Qu cHkKQEAgLTQyNSw2ICs0MjUsOCBAQCBjbGFzcyBDaGFuZ2VMb2dUZXN0KHVuaXR0ZXN0LlRlc3RD YXNlKToKICAgICAgICAgICAgIFsoJ1phbiBEb2JlcnNlaycsICd6YW5kb2JlcnNla0BnbWFpbC5j b20nKSwgKCdQaGlsaXBwZSBOb3JtYW5kJywgJ3Bub3JtYW5kQGlnYWxpYS5jb20nKV0pCiAgICAg ICAgIHNlbGYuX2Fzc2VydF9wYXJzZV9hdXRob3JzKCdOZXcgQ29udHJpYnV0b3IgIDxuZXdAd2Vi a2l0Lm9yZz4gYW5kIE5vb2IgIDxub29iQHdlYmtpdC5vcmc+JywKICAgICAgICAgICAgIFsoJ05l dyBDb250cmlidXRvcicsICduZXdAd2Via2l0Lm9yZycpLCAoJ05vb2InLCAnbm9vYkB3ZWJraXQu b3JnJyldKQorICAgICAgICBzZWxmLl9hc3NlcnRfcGFyc2VfYXV0aG9ycygnQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPiAmJiBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUu Y29tPicsCisgICAgICAgICAgICBbKCdBZGFtIEJhcnRoJywgJ2FiYXJ0aEB3ZWJraXQub3JnJyks ICgnQmVuamFtaW4gUG91bGFpbicsICdicG91bGFpbkBhcHBsZS5jb20nKV0pCiAKICAgICBkZWYg X2Fzc2VydF9oYXNfdmFsaWRfcmV2aWV3ZXIoc2VsZiwgcmV2aWV3ZXJfbGluZSwgZXhwZWN0ZWQp OgogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuX2VudHJ5X3dpdGhfcmV2aWV3ZXIocmV2 aWV3ZXJfbGluZSkuaGFzX3ZhbGlkX3Jldmlld2VyKCksIGV4cGVjdGVkKQo=